GNU bug report logs - #37774
27.0.50; new :extend attribute broke visuals of all themes and other packages

Previous Next

Full log

Message #428 received at 37774 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Ergus <spacibba <at> aol.com>, jonas <at> bernoul.li, Eli Zaretskii <eliz <at> gnu.org>,
 37774 <at> debbugs.gnu.org
Subject: Re: bug#37774: 27.0.50; new :extend attribute broke visuals of all
 themes and other packages
Date: Thu, 05 Dec 2019 17:48:22 +0100

[Message part 1 (text/plain, inline)]

martin rudalics <rudalics <at> gmx.at> writes:

>> Please push it for me.
>
> Pushed now.  Please have a look.

(For context: this was commit 8232325337 "Handle case where a face's
:extend attribute is unspecified (Bug#37774)".)

I think there might have been a regression since this commit: in-between
1c29ba0340 (2019-11-17) and 21790e5473 (2019-12-05), something caused
the backgrounds to no longer extend for faces with unspecified :extend
inheriting faces with :extend t.

The attached theme sets :extend t for diff-{added,removed}, and sets
:inherit (diff-…) for ediff-fine-diff-{A,B}.

[extend-inherit-theme.el (application/emacs-lisp, attachment)]

[Message part 3 (text/plain, inline)]

From emacs -Q, running the following code:

    (add-to-list 'custom-theme-load-path default-directory)
    (load-theme 'extend-inherit t)
    (ediff-files "/usr/share/common-licenses/LGPL-2" "/usr/share/common-licenses/LGPL-2.1")

… gives the following results with commit 1c29ba0340:

[bug-37774-inherit-1c29ba0340.png (image/png, attachment)]

[Message part 5 (text/plain, inline)]

… and the following results with commit 21790e5473:

[bug-37774-inherit-21790e5473.png (image/png, attachment)]

[Message part 7 (text/plain, inline)]

Is this deliberate?  I don't think I read anything in this thread
suggesting it; apologies if I missed something.

If it's a bug, maybe this is due to recent changes in xfaces.c?

    git log --oneline 1c29ba0340..21790e5473 -- src/xfaces.c 
    d4515f3cab Support ':extend' in faces defined by list of key/value pairs
    19aecd340b Fix face merging when some have :extend non-nil and some are inherited

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.