GNU bug report logs - #37758
27.0.50; Support multibyte characters in function 'auth-source--pad'an; with patch

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: mgcyung <mgcyung <at> gmail.com>
Cc: 37758 <at> debbugs.gnu.org
Subject: bug#37758: 27.0.50; Support multibyte characters in function 'auth-source--pad'an; with patch
Date: Tue, 15 Oct 2019 08:43:58 +0200

mgcyung <mgcyung <at> gmail.com> writes:

> 'auth-source--pad' use 'length' to get byte length of a
> string. However, 'length' return the number of characters which is not
> the byte length with multibyte characters such as Chinese
> character. This may causes an error "GnuTLS cipher
> AES-256-CBC/encrypt input block length xxxx is not a multiple of the
> required 16".
>
> According to the doc of 'length'. 'length' can be replaced by
> 'string-bytes'. And a patch is attached.

Thanks for the patch, but I don't think it's a quite safe change.
Instead the string should be made into a sequence of bytes before
padding (and converted back again afterwards) to ensure that it survives
the encryption, I think.

I've now made this change on the trunk.  Could you check that it works
for you?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.