GNU bug report logs - #37756
[PATCH] Wrong initialization of fringe bitmap

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37756: closed ([PATCH] Wrong initialization of fringe bitmap)
Date: Sat, 26 Oct 2019 10:22:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 26 Oct 2019 13:21:25 +0300
with message-id <83lft7vmca.fsf <at> gnu.org>
and subject line Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap
has caused the debbugs.gnu.org bug report #37756,
regarding [PATCH] Wrong initialization of fringe bitmap
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37756: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37756
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Carlos Pita <carlosjosepita <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Wrong initialization of fringe bitmap
Date: Mon, 14 Oct 2019 23:39:19 -0300

[Message part 3 (text/plain, inline)]

In fringe.c:1606 you have:

  xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW);
  fb.bits = b = ((unsigned short *)
ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW));
  xfb = ptr_bounds_clip (xfb, sizeof *xfb);
  memset (b, 0, fb.height);

I might be wrong but it seems to me that the last line should be:

  memset (b, 0, fb.height * BYTES_PER_BITMAP_ROW);

instead.

I've attached a patch that does exactly that.

Best regards
--
Carlos

[0001-Fix-zero-initialization-of-fringe-bitmap.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Carlos Pita <carlosjosepita <at> gmail.com>
Cc: 37756-done <at> debbugs.gnu.org
Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap
Date: Sat, 26 Oct 2019 13:21:25 +0300

> From: Carlos Pita <carlosjosepita <at> gmail.com>
> Date: Wed, 16 Oct 2019 17:01:11 -0300
> Cc: 37756 <at> debbugs.gnu.org
> 
> I'm having some issues doing that because I'm using magit to amend /
> reword previously committed changes, so the instructions there don't
> quite match my situation. Will try harder later, for now I just
> modified the message after some examples in your git log. Hope it's ok
> now.

Thanks, pushed.  Closing the bug.

> From: memeplex <carlosjosepita <at> gmail.com>
        ^^^^^^^^
Is this really how you want your name to appear in the Git log?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.