From unknown Fri Jun 20 07:25:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37756 <37756@debbugs.gnu.org> To: bug#37756 <37756@debbugs.gnu.org> Subject: Status: [PATCH] Wrong initialization of fringe bitmap Reply-To: bug#37756 <37756@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:25:12 +0000 retitle 37756 [PATCH] Wrong initialization of fringe bitmap reassign 37756 emacs submitter 37756 Carlos Pita severity 37756 normal tag 37756 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 22:39:35 2019 Received: (at submit) by debbugs.gnu.org; 15 Oct 2019 02:39:35 +0000 Received: from localhost ([127.0.0.1]:42514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKCkJ-0004ez-D2 for submit@debbugs.gnu.org; Mon, 14 Oct 2019 22:39:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:55667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKCkI-0004et-Nf for submit@debbugs.gnu.org; Mon, 14 Oct 2019 22:39:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKCkH-0005Hp-KH for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:39:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKCkF-0001Ch-Jn for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:39:33 -0400 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]:41196) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKCkF-0001CF-Ek for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:39:31 -0400 Received: by mail-yb1-xb34.google.com with SMTP id 206so6076696ybc.8 for ; Mon, 14 Oct 2019 19:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=vULXWLade1shVMSzrVEq6Foyp46FICeJbQ85hrHv4Lw=; b=gg+TirQgD2pCWt1IAIStGPSAL/h5x/iTWnLXvhjodANXHEvR7A5g2eXsb1KpGctnRV u/Vhhi5WKN3y86e6xKISHk5aQHm85Ria10+6Ba5Nzh/nsfPBDzxgiLNlTTzHwOvcwGHa HFmfEW4KLYYgWzlQDg4C84RRs8LcYSXu9Fj2wj+XFkYHyZEIEe2lvPjdgdCvFI1ff4vQ LtYDc09EXecXdu8uesmQRRBOGcYIjpnwbYXGY0OAL+NEfjpntaliXreJBe/hZaGneTh3 B4iBs/juLYWs2NAEH6tb/04w/DtPHYCepGASbK+2iN+WtoScbu3WJzlGqIDRNHFIa843 BWpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=vULXWLade1shVMSzrVEq6Foyp46FICeJbQ85hrHv4Lw=; b=NrNncolw8rWkpi8qEGku5PaI1MeQMEAypLtlMC6aI4h9SknAVPbIYuGPg/H/yZLheJ 6zgXI1Q+E/cGnx1Olsg8OFuQhN31Z35oPH5/fWkQ0eDxzhtc3n+NqaG49ZkLsTxqzuk3 Ul4nts940LGWceI/40Gn/ZCodtliNwKRDUZvAMme+cIzBThP4GLCN3SgEwL4rTYBBMwg nSK6CdrE7oyvyVSK8bSiYEZ7XX8s1hIsZcWweruPbS1hoVHLwfqsuyA0uR9ZROMX2XxV NQFozE2o1ds5wU0Muq3C5zyZeQsAPmPdwBUb4WUU/mj9ieGVAUsS1IOGJsWwYIn97ctr oepw== X-Gm-Message-State: APjAAAUANL+I3ca9IewBquySDlLsZw34iNnRXNvzt9jaCFT9FOPTIOA+ Ow4LrJj2AX6eLiXXyoRsQ7WNSzLp4aUcxpUORi7kdjLJE5Q= X-Google-Smtp-Source: APXvYqy9ds++saI7I3FMCB3iMhtDmbDvLIsilvurp09YJJhxrGA0VeMw+FejUvZAEtCL4CIN5A/2Kl5zPqFa7K1tBHg= X-Received: by 2002:a25:4d87:: with SMTP id a129mr21661863ybb.82.1571107170516; Mon, 14 Oct 2019 19:39:30 -0700 (PDT) MIME-Version: 1.0 From: Carlos Pita Date: Mon, 14 Oct 2019 23:39:19 -0300 Message-ID: Subject: [PATCH] Wrong initialization of fringe bitmap To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000cdaa610594e9e46a" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::b34 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000cdaa610594e9e46a Content-Type: text/plain; charset="UTF-8" In fringe.c:1606 you have: xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW); fb.bits = b = ((unsigned short *) ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW)); xfb = ptr_bounds_clip (xfb, sizeof *xfb); memset (b, 0, fb.height); I might be wrong but it seems to me that the last line should be: memset (b, 0, fb.height * BYTES_PER_BITMAP_ROW); instead. I've attached a patch that does exactly that. Best regards -- Carlos --000000000000cdaa610594e9e46a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-zero-initialization-of-fringe-bitmap.patch" Content-Disposition: attachment; filename="0001-Fix-zero-initialization-of-fringe-bitmap.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1r8mcp00 RnJvbSBmZTNmMDQwZDY2MTRlZTRiOTkwZjNmNDI1MmM4OWQ5YTE3YzUyODQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBNb24sIDE0IE9jdCAyMDE5IDIzOjMzOjM3IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IHplcm8gaW5pdGlhbGl6YXRpb24gb2YgZnJpbmdlIGJpdG1hcAoKKiBzcmMvZnJpbmdlLmM6IHRo ZSBzaXplIGluIGJ5dGVzIG9mIGZiLmJpdHMgaXMKICAgIGZiLmhlaWdodCAqIEJZVEVTX1BFUl9C SVRNQVBfUk9XCiAgYW5kIG5vdCBzaW1wbHkgdGhlIG51bWJlciBvZiByb3dzIGZiLmhlaWdodC4K LS0tCiBzcmMvZnJpbmdlLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvZnJpbmdlLmMgYi9zcmMvZnJpbmdlLmMK aW5kZXggMjJmM2JkYy4uZGI5MTIwOSAxMDA2NDQKLS0tIGEvc3JjL2ZyaW5nZS5jCisrKyBiL3Ny Yy9mcmluZ2UuYwpAQCAtMTYwNyw3ICsxNjA3LDcgQEAgbGlzdCAoQUxJR04gUEVSSU9ESUMpIHdo ZXJlIFBFUklPRElDIG5vbi1uaWwgc3BlY2lmaWVzIHRoYXQgdGhlIGJpdG1hcAogICBmYi5iaXRz ID0gYiA9ICgodW5zaWduZWQgc2hvcnQgKikKIAkJIHB0cl9ib3VuZHNfY2xpcCAoeGZiICsgMSwg ZmIuaGVpZ2h0ICogQllURVNfUEVSX0JJVE1BUF9ST1cpKTsKICAgeGZiID0gcHRyX2JvdW5kc19j bGlwICh4ZmIsIHNpemVvZiAqeGZiKTsKLSAgbWVtc2V0IChiLCAwLCBmYi5oZWlnaHQpOworICBt ZW1zZXQgKGIsIDAsIGZiLmhlaWdodCAqIEJZVEVTX1BFUl9CSVRNQVBfUk9XKTsKIAogICBqID0g MDsKICAgd2hpbGUgKGogPCBmYi5oZWlnaHQpCi0tIAoyLjIwLjEKCg== --000000000000cdaa610594e9e46a-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 05:47:51 2019 Received: (at 37756) by debbugs.gnu.org; 15 Oct 2019 09:47:51 +0000 Received: from localhost ([127.0.0.1]:42762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJQk-0002Uo-Rc for submit@debbugs.gnu.org; Tue, 15 Oct 2019 05:47:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJQj-0002UZ-SX for 37756@debbugs.gnu.org; Tue, 15 Oct 2019 05:47:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKJQd-0002Zm-Bm; Tue, 15 Oct 2019 05:47:43 -0400 Received: from [176.228.60.248] (port=2177 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKJQa-0003NL-OD; Tue, 15 Oct 2019 05:47:43 -0400 Date: Tue, 15 Oct 2019 12:47:26 +0300 Message-Id: <838spmgx1t.fsf@gnu.org> From: Eli Zaretskii To: Carlos Pita In-reply-to: (message from Carlos Pita on Mon, 14 Oct 2019 23:39:19 -0300) Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37756 Cc: 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Carlos Pita > Date: Mon, 14 Oct 2019 23:39:19 -0300 > > In fringe.c:1606 you have: > > xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW); > fb.bits = b = ((unsigned short *) > ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW)); > xfb = ptr_bounds_clip (xfb, sizeof *xfb); > memset (b, 0, fb.height); > > I might be wrong but it seems to me that the last line should be: > > memset (b, 0, fb.height * BYTES_PER_BITMAP_ROW); > > instead. Can you explain your reasoning? The loop after that does initialize the structure as needed, doesn't it? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 06:14:46 2019 Received: (at 37756) by debbugs.gnu.org; 15 Oct 2019 10:14:46 +0000 Received: from localhost ([127.0.0.1]:42773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJqo-000389-Gp for submit@debbugs.gnu.org; Tue, 15 Oct 2019 06:14:46 -0400 Received: from mail-yw1-f44.google.com ([209.85.161.44]:37774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJqk-00037t-9T for 37756@debbugs.gnu.org; Tue, 15 Oct 2019 06:14:44 -0400 Received: by mail-yw1-f44.google.com with SMTP id m7so7139899ywe.4 for <37756@debbugs.gnu.org>; Tue, 15 Oct 2019 03:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kuXCPFpuxyRcCzxlKIjGF1iZnom7zyVY/DjvEwsdckw=; b=UoLjVe/r4TyFBpkZ4CKGihSsf494KBJQk2YL3ukbXbIdcpnImT4pcsGTgP3L3C6gNT b4Wyzphv82PpO46W8sw74esdDEn8nvAQFlRZ82GtLGl3ITmUTEBi98ysPFcQPGWsaaKj 4bsBBmENUgOyHxw2yr7dY32zc6GXHjX/3l9z21HPYyGWKxi+OvN/mD6Sx4pObWZuKOan ntJ8z9/HMChNxAZDeyRmX4FjGj2TgbGu5gyEsUQAPvF6OqVTRzgikMIAHmmqoKeOP9wd IO0AF8MTsITEnIpm3Lx4dgmkaw2Yl8sdOK3rk3P9l19Nj6OiQqOuS8qge6LHzxrqg8u8 CrUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kuXCPFpuxyRcCzxlKIjGF1iZnom7zyVY/DjvEwsdckw=; b=mwJQpdvFvz/qVIp0XErROubZ0zz0pZGuUmhLjHNXMpicS5lJjvg3/YSmCFNkG5oNVX Ayd2jHXnwM8XpXqloAYJo8hQKnc4CHZ+rmTe/YFsBZFcQO5VbGmbzF7fVLLphw0nDNXi 3wyl6NyXc5Id7gncUwntnraCqElgp+B6Mz/Ab1nAn8f4GkS1W7tYiwczDjqf2FRiVHCl 9+bA/hOZBsrhClnv7eSM/w9Gd45SmX/xT8jEKR8bGBgV24sLwgTPvdtpO8nJqYWIu0dG Xdo86pilSIkNetRlVy236xD1s8eQqTtyiiGaYFemd3+bSyCZha6/+5bsoJbSfw9fgp9n zkIA== X-Gm-Message-State: APjAAAXIHFBVOepl3VWziBqNnr++gxVdSauWi1FvyFAmdqY6kF620ZaZ ksil38pKC45rxGlIRd7AwBW5YzxTa4LlBtl4WE8= X-Google-Smtp-Source: APXvYqxrkq6RoFOMs80LLLMTQdP44OITtkyw6AbCLh0k65b3Q4nOsND2VSdbljQivVfi87E7TFww/ckmMVhVI2BgC7A= X-Received: by 2002:a81:ab42:: with SMTP id d2mr15665979ywk.64.1571134476502; Tue, 15 Oct 2019 03:14:36 -0700 (PDT) MIME-Version: 1.0 References: <838spmgx1t.fsf@gnu.org> In-Reply-To: <838spmgx1t.fsf@gnu.org> From: Carlos Pita Date: Tue, 15 Oct 2019 07:14:25 -0300 Message-ID: Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37756 Cc: 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Can you explain your reasoning? The loop after that does initialize Ok, TBH I hadn't looked at the loop. But anyway: > > xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW); This allocates fb.height * BYTES_PER_BITMAP_ROW for bits = b. > > memset (b, 0, fb.height); This only initializes fb.height bytes to zero. And then the loop indeed initializes all fb.height * BYTES_PER_BITMAP_ROW bytes (b being an unsigned short pointer): j = 0; while (j < fb.height) { ... b[j++] = something; ... } So instead of memset (b, 0, fb.height) being incomplete I would now say that it is redundant and misleading. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 13:28:49 2019 Received: (at 37756) by debbugs.gnu.org; 16 Oct 2019 17:28:49 +0000 Received: from localhost ([127.0.0.1]:46476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKn6P-0006Da-9a for submit@debbugs.gnu.org; Wed, 16 Oct 2019 13:28:49 -0400 Received: from mail-yb1-f196.google.com ([209.85.219.196]:39727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKn6M-0006DL-Si for 37756@debbugs.gnu.org; Wed, 16 Oct 2019 13:28:48 -0400 Received: by mail-yb1-f196.google.com with SMTP id z2so5032366ybn.6 for <37756@debbugs.gnu.org>; Wed, 16 Oct 2019 10:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jPWQh+wJkcCUIHs7G9qSgeVrRfDkaoA1LgFnIlKfXaY=; b=m6uNjOf6OWFJzK9z8yhIQSc7wLqdQNlzztl/mzyghFZLMvVIDbcWdQShH2+sxN42p1 Y+DXzisTWe899HgW3Ma9Q6iR9+qSicVF7nJs/lasgQYwdxcLvZLaaCpkzmdGvt2B42cq Nqh+UocRbODeYds8PKTE3s8ly6UxG/IcODP0+NijlHgmpWc/EydYJ6I+fBJ1H3/EsJPO iwwBCf1Fdl3jlutvMNAeuGX+uIxtw6kQmEznvLSuPkaymvH5nDbZ4FISKkG9ZPKPPfGe sNyfJQ2Y1TG2S8GoRD8avVdAJIJY7eL4fmIkmtKZ8ULy4o4GGtjfbW08GpkDlySe2bra g9GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jPWQh+wJkcCUIHs7G9qSgeVrRfDkaoA1LgFnIlKfXaY=; b=Njc/S2FW08dKtqSwBspM59VSPD346pucZ0ChUXr0jPFPDhhi9Cek6+tp3PH3DRVs4b VUU2cukEQqqIglR2MRo831bmobZvfA4mgaOCLcSpwPwBg3u3GcS2Gb9gf1VSwXwHLNWG A08QWo6LreFD5j4HCMgVpxPGwPMWz2lKyT/sWQ4+TqakqsJzfCk5ndTBOn6mplN9X6cb tZLmb+/2khyyk19W8ebwhtXc0YbTYMkaA1oee/NuV0rk668pwy+WdCDs2cW6OSYgxS/k BappJIqvObW1oZrrn2ej4PbViE5OF0L/Kegm75/9x4VQPkVcJL1mKuupfrcrQGbD6aD4 tpRA== X-Gm-Message-State: APjAAAV2Vkcm08cOSObtVni1m6/JCZVg5cz3E1mJsE7WZICiodG4Z9gv o+ZGMAfu0ZxVfUykB0Xm9g1ucOtimXF2P7azLavE98x6 X-Google-Smtp-Source: APXvYqxHP/iUeyxFWwo6tWWI4nZON2QCk/X8zgJ5oMGVOQtcuqBaYMkGrH4L+4aG3e3Kyg7GJf6DzIdy8k8kNA9+6f0= X-Received: by 2002:a25:9947:: with SMTP id n7mr28216945ybo.263.1571246921181; Wed, 16 Oct 2019 10:28:41 -0700 (PDT) MIME-Version: 1.0 References: <838spmgx1t.fsf@gnu.org> In-Reply-To: From: Carlos Pita Date: Wed, 16 Oct 2019 14:28:29 -0300 Message-ID: Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000978b1b05950a6e5a" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37756 Cc: 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000978b1b05950a6e5a Content-Type: text/plain; charset="UTF-8" Here is a patch that removes the superfluous line with a detailed explanation in the commit message. I've tested it in combination (also in combination with my "hidpi fringe" patches) and got no segv yet ;) --000000000000978b1b05950a6e5a Content-Type: application/x-patch; name="0001-Remove-redundant-and-incomplete-initialization-of-fr.patch" Content-Disposition: attachment; filename="0001-Remove-redundant-and-incomplete-initialization-of-fr.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1tihqba0 RnJvbSAxZWE5MTk1MmM0YTNhNzVlYThjOWMyMmNlNTA0OTU2YzMxZjk5NDFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBXZWQsIDE2IE9jdCAyMDE5IDEzOjQ0OjAwIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gUmVt b3ZlIHJlZHVuZGFudCBhbmQgaW5jb21wbGV0ZSBpbml0aWFsaXphdGlvbiBvZiBmcmluZ2UKIGJp dG1hcAoKKiBzcmMvZnJpbmdlLmM6IHRoZSByZW1vdmVkIG1lbXNldCB3YXMgc2V0dGluZyBmYi5o ZWlnaHQgYnl0ZXMgdG8gemVybwpidXQgdGhlIHNpemUgb2YgdGhlIGJpdG1hcCBpcyBmYi5oZWln aHQqQllURVNfUEVSX0JJVE1BUF9ST1cgaW5zdGVhZCwKd2l0aCBCWVRFU19QRVJfQklUTUFQX1JP VyA9PSAyLiBOZXZlcnRoZWxlc3MsIHRoZSBsb29wIGltbWVkaWF0ZWx5CmJlbG93IGlzIGFscmVh ZHkgaW5pdGlhbGl6aW5nIGFsbCBmYi5oZWlnaHQqQllURVNfUEVSX0JJVE1BUF9ST1cgc28KdGhl cmUgaXMgbm8gbmVlZCB0byBrZWVwIHRoYXQgbWVtc2V0LiBTZWUgYnVnIzM3NzU2LgotLS0KIHNy Yy9mcmluZ2UuYyB8IDEgLQogMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9zcmMvZnJpbmdlLmMgYi9zcmMvZnJpbmdlLmMKaW5kZXggMjJmM2JkYy4uMDhiZjI3MSAx MDA2NDQKLS0tIGEvc3JjL2ZyaW5nZS5jCisrKyBiL3NyYy9mcmluZ2UuYwpAQCAtMTYwNyw3ICsx NjA3LDYgQEAgbGlzdCAoQUxJR04gUEVSSU9ESUMpIHdoZXJlIFBFUklPRElDIG5vbi1uaWwgc3Bl Y2lmaWVzIHRoYXQgdGhlIGJpdG1hcAogICBmYi5iaXRzID0gYiA9ICgodW5zaWduZWQgc2hvcnQg KikKIAkJIHB0cl9ib3VuZHNfY2xpcCAoeGZiICsgMSwgZmIuaGVpZ2h0ICogQllURVNfUEVSX0JJ VE1BUF9ST1cpKTsKICAgeGZiID0gcHRyX2JvdW5kc19jbGlwICh4ZmIsIHNpemVvZiAqeGZiKTsK LSAgbWVtc2V0IChiLCAwLCBmYi5oZWlnaHQpOwogCiAgIGogPSAwOwogICB3aGlsZSAoaiA8IGZi LmhlaWdodCkKLS0gCjIuMjAuMQoK --000000000000978b1b05950a6e5a-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 14:35:30 2019 Received: (at 37756) by debbugs.gnu.org; 16 Oct 2019 18:35:30 +0000 Received: from localhost ([127.0.0.1]:46528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKo8v-0007wc-Vd for submit@debbugs.gnu.org; Wed, 16 Oct 2019 14:35:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKo8u-0007wR-SJ for 37756@debbugs.gnu.org; Wed, 16 Oct 2019 14:35:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKo8p-0000TZ-CZ; Wed, 16 Oct 2019 14:35:23 -0400 Received: from [176.228.60.248] (port=3308 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKo8o-00046U-Mv; Wed, 16 Oct 2019 14:35:23 -0400 Date: Wed, 16 Oct 2019 21:35:03 +0300 Message-Id: <83zhi0cze0.fsf@gnu.org> From: Eli Zaretskii To: Carlos Pita In-reply-to: (message from Carlos Pita on Wed, 16 Oct 2019 14:28:29 -0300) Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap References: <838spmgx1t.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37756 Cc: 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Carlos Pita > Date: Wed, 16 Oct 2019 14:28:29 -0300 > Cc: 37756@debbugs.gnu.org > > Here is a patch that removes the superfluous line with a detailed > explanation in the commit message. Thanks, but please format the log message according to CONTRIBUTE: it should name the function in which the change is being made, start with a capital letter, and keep 2 spaces between sentences. Also, there's no need to describe in such detail what the code does, when the code speaks for itself. You could just say "Remove redundant zeroing of fb.bits". From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 14:54:21 2019 Received: (at 37756) by debbugs.gnu.org; 16 Oct 2019 18:54:21 +0000 Received: from localhost ([127.0.0.1]:46541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKoRB-0008OP-Ek for submit@debbugs.gnu.org; Wed, 16 Oct 2019 14:54:21 -0400 Received: from mail-yw1-f46.google.com ([209.85.161.46]:39864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKoR8-0008O8-Ik for 37756@debbugs.gnu.org; Wed, 16 Oct 2019 14:54:20 -0400 Received: by mail-yw1-f46.google.com with SMTP id n11so9027500ywn.6 for <37756@debbugs.gnu.org>; Wed, 16 Oct 2019 11:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v+EwoF3EvwZRgDW5fe5qRnJdSvjm9fGW0BCqfsS3hm0=; b=cw7z/hv1Qqps6LRp2jVXhtvsW9O9ja485E2olVmiNXx5xkOuoFIHHzVAbL8KOkdVCg jU08zLfpP3dVmkHkClf/xjRmZZ3xBqigGmYSevaZan77IJKZgnfIHQ+HR6NE3riZ6Eah gAdiwwc1huJc6Q1zhb/TcilMiqLEiaYl661n8nQrp/mvDGfR4ObstAY0hWXMIQGgfEll 9hoAB9m/Mj/gY36+uOUUajJgICEjzpLd7OBWWT1SDK7GCNcpENmBw7XF6EPDsDMsFlCQ EuvwiF/3uY2WMKdqz1c5yVpR14Fl0wXhWHnUoXb8zrBzPGOzAdOQzPWBPrV/VPUuk2JM 3b6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v+EwoF3EvwZRgDW5fe5qRnJdSvjm9fGW0BCqfsS3hm0=; b=UTQB/mmKAlKbyG4hZ4GlcIVgOudXjZsvb4qpDjoV6gjLH/jWK2yzrH9bLbPsiW0txt 99Mw1SqErdgVVGk89LS+V4cXKUHbF46n6UYFcqBWhd4tJUx2LNAdLf+EyWrOYLR8fayS TyX4WxlW6EfDZbGxfu+6LIvy4ICKikZLJS/57foEu4otHO5QgzEeMpM+QH+AvYZCIi7w yQpkeF0qC1A2gt9qN80+/uLy+9+451VQoplUzRL4NAzxndx3JcQ0iWby2W1MfvTOUjjU WMGWVYC7QpkqudetSnItDrSPkwGvBXYs92QWLYVKAaR9uBYjiuwVpA31ZZQzxmhbl7J+ nzBw== X-Gm-Message-State: APjAAAU6GPoW/cVmXXU2TRUGK6cBz+SchLQs7wauWPO7s2QNvi+KiKde vEPtK8yuP81+XNVSQrEVdiR+LXK4RwrxIMsFBRI= X-Google-Smtp-Source: APXvYqzP5iAfU2gH2eLVaVYoqWp1wpZCEsYCsuRTKTJXuSv1tqRg+lMWeuW6Q+2UASKz6wfSr6dHbkBlXkbFm5pixi4= X-Received: by 2002:a81:996:: with SMTP id 144mr22969411ywj.57.1571252052631; Wed, 16 Oct 2019 11:54:12 -0700 (PDT) MIME-Version: 1.0 References: <838spmgx1t.fsf@gnu.org> <83zhi0cze0.fsf@gnu.org> In-Reply-To: <83zhi0cze0.fsf@gnu.org> From: Carlos Pita Date: Wed, 16 Oct 2019 15:54:01 -0300 Message-ID: Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap To: Eli Zaretskii Content-Type: multipart/mixed; boundary="00000000000074cd1605950ba051" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37756 Cc: 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000074cd1605950ba051 Content-Type: text/plain; charset="UTF-8" I've done as you asked, Eli. Sorry but I'm still trying to catch up with many of your conventions. I'm not sure about how to designate the modified function in the changelog, since it's a DEFUN. --00000000000074cd1605950ba051 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Remove-redundant-and-incomplete-initialization-of-fr.patch" Content-Disposition: attachment; filename="0001-Remove-redundant-and-incomplete-initialization-of-fr.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1tmt90o0 RnJvbSBkZDY5ODMzYzVhMWFhNmE4OWNhYzRjYzNiOTQxOWMxZGFiYmU1MGVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBXZWQsIDE2IE9jdCAyMDE5IDEzOjQ0OjAwIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gUmVt b3ZlIHJlZHVuZGFudCBhbmQgaW5jb21wbGV0ZSBpbml0aWFsaXphdGlvbiBvZiBmcmluZ2UKIGJp dG1hcAoKKiBzcmMvZnJpbmdlLmMgKGRlZmluZS1mcmluZ2UtYml0bWFwKTogUmVtb3ZlIHJlZHVu ZGFudCB6ZXJvaW5nCm9mIGZiLmJpdHMgdGhhdCBvbmx5IHplcm9lZCBoYWxmIG9mIHRoZSBhcnJh eSBhbnl3YXkuIEJ1ZyMzNzc1Ni4KLS0tCiBzcmMvZnJpbmdlLmMgfCAxIC0KIDEgZmlsZSBjaGFu Z2VkLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2ZyaW5nZS5jIGIvc3JjL2ZyaW5n ZS5jCmluZGV4IDIyZjNiZGMuLjA4YmYyNzEgMTAwNjQ0Ci0tLSBhL3NyYy9mcmluZ2UuYworKysg Yi9zcmMvZnJpbmdlLmMKQEAgLTE2MDcsNyArMTYwNyw2IEBAIGxpc3QgKEFMSUdOIFBFUklPRElD KSB3aGVyZSBQRVJJT0RJQyBub24tbmlsIHNwZWNpZmllcyB0aGF0IHRoZSBiaXRtYXAKICAgZmIu Yml0cyA9IGIgPSAoKHVuc2lnbmVkIHNob3J0ICopCiAJCSBwdHJfYm91bmRzX2NsaXAgKHhmYiAr IDEsIGZiLmhlaWdodCAqIEJZVEVTX1BFUl9CSVRNQVBfUk9XKSk7CiAgIHhmYiA9IHB0cl9ib3Vu ZHNfY2xpcCAoeGZiLCBzaXplb2YgKnhmYik7Ci0gIG1lbXNldCAoYiwgMCwgZmIuaGVpZ2h0KTsK IAogICBqID0gMDsKICAgd2hpbGUgKGogPCBmYi5oZWlnaHQpCi0tIAoyLjIwLjEKCg== --00000000000074cd1605950ba051-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 15:06:26 2019 Received: (at 37756) by debbugs.gnu.org; 16 Oct 2019 19:06:27 +0000 Received: from localhost ([127.0.0.1]:46559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKocs-0000Fn-KN for submit@debbugs.gnu.org; Wed, 16 Oct 2019 15:06:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKocq-0000Fa-Tk for 37756@debbugs.gnu.org; Wed, 16 Oct 2019 15:06:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKocl-0001Sp-R3; Wed, 16 Oct 2019 15:06:19 -0400 Received: from [176.228.60.248] (port=1358 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKocg-0006ET-3X; Wed, 16 Oct 2019 15:06:19 -0400 Date: Wed, 16 Oct 2019 22:05:57 +0300 Message-Id: <83sgnscxyi.fsf@gnu.org> From: Eli Zaretskii To: Carlos Pita In-reply-to: (message from Carlos Pita on Wed, 16 Oct 2019 15:54:01 -0300) Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap References: <838spmgx1t.fsf@gnu.org> <83zhi0cze0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37756 Cc: 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Carlos Pita > Date: Wed, 16 Oct 2019 15:54:01 -0300 > Cc: 37756@debbugs.gnu.org > > I've done as you asked, Eli. Sorry but I'm still trying to catch up > with many of your conventions. Thanks for persevering. > I'm not sure about how to designate the modified function in the > changelog, since it's a DEFUN. Use one of the related Emacs commands, and Emacs will do that for you. Those commands are described in CONTRIBUTE under "Generating ChangeLog entries". From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 16:01:31 2019 Received: (at 37756) by debbugs.gnu.org; 16 Oct 2019 20:01:31 +0000 Received: from localhost ([127.0.0.1]:46610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKpUB-0001aP-K0 for submit@debbugs.gnu.org; Wed, 16 Oct 2019 16:01:31 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:39424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKpU9-0001aA-3Y for 37756@debbugs.gnu.org; Wed, 16 Oct 2019 16:01:29 -0400 Received: by mail-yb1-f182.google.com with SMTP id z2so5195107ybn.6 for <37756@debbugs.gnu.org>; Wed, 16 Oct 2019 13:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oAFmZ2CvU3cE57Lup+xcOoKh7n2lT5KscGStcZtCR3c=; b=N0o1ng8bCTd8XCbkS88jUOyU+DLyFaq5jxARdImtQX/uFxSijcX8sbOyLNfV7OSt4u npslpIpxt5ohtRCj7tpVxhT4ijQD6IVrYB6gX7smGJU7AgWtYUJhu5/BI6ys2ua7pvw6 lt0VtwQZgkR8LSdvFiWctwkuqPEZ7pkMLKERhUB8aaoQClQ3rqNAWJgl5fl9R5bJzJQT 0ZHIsbTEgZFcbGIoyqXDAYhNCA2nW4d6PUdCZGfK5z5/sfqzYjLZ5D7w2673JTgh1ErE BT0Gj8QPXTArpa9tmm5fMfoy0CTycPck2OfwynHgTG13znObb9cT2K+LqOWEIO63MgSj H0lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oAFmZ2CvU3cE57Lup+xcOoKh7n2lT5KscGStcZtCR3c=; b=bjtDU600K/XVk6fumYg3djRI4N8Gpq1GuHupnkbcIocMHqO33vbqZvoD3kZLr2pPkD /yUPBzXf9wX9h7tOZl7TLlZyEdD8tbmwBKUywHIjGBLaj3wmzuovxzMkfpJMCp6gJsLN RIXIUmiauz/PIhbxxEiLYGE7J1Wdqad1YRUVwJXP4CdO7xsphV1ZiF0qZMzSNlXC607M gAdmwjWyMcSGyrHccBXmoZfhIRrlWydQztmNxljizxSiYcmowXtem8upEAdTp6OJTMfP sFc4WXC8L9PYZtuH4orrFoaKq1IsojX5H63hbZHL+c9lbsAm2InLH+FEFPrHY0TEZ84n VI2A== X-Gm-Message-State: APjAAAWEpOkqINBToOdzKjY02USnf/dxGAKZ/wax0H7XDrOz63+P0HIJ umxHPD6lyayuMQto8r8D2fAO5mcDbpA4HUChPCyTpkDz X-Google-Smtp-Source: APXvYqzPAe/xAp88a4Gtg5k5d8p54L6DWQ55/XlABGJBKileskHo4cIPzc0w3VJtIrRX0pXeFqNAMahwvevxyVbaU9I= X-Received: by 2002:a25:e7cf:: with SMTP id e198mr268048ybh.334.1571256083107; Wed, 16 Oct 2019 13:01:23 -0700 (PDT) MIME-Version: 1.0 References: <838spmgx1t.fsf@gnu.org> <83zhi0cze0.fsf@gnu.org> <83sgnscxyi.fsf@gnu.org> In-Reply-To: <83sgnscxyi.fsf@gnu.org> From: Carlos Pita Date: Wed, 16 Oct 2019 17:01:11 -0300 Message-ID: Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000af6b9705950c9020" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37756 Cc: 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000af6b9705950c9020 Content-Type: text/plain; charset="UTF-8" > Use one of the related Emacs commands, and Emacs will do that for you. > Those commands are described in CONTRIBUTE under "Generating ChangeLog > entries". I'm having some issues doing that because I'm using magit to amend / reword previously committed changes, so the instructions there don't quite match my situation. Will try harder later, for now I just modified the message after some examples in your git log. Hope it's ok now. --000000000000af6b9705950c9020 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Remove-redundant-initialization-of-fringe-bitmap-Bug.patch" Content-Disposition: attachment; filename="0001-Remove-redundant-initialization-of-fringe-bitmap-Bug.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1tpajy50 RnJvbSBkY2I0N2Q3Y2ZiODNmYjRiNWEyOGM3ZjkwOWFlYThlNWFhYjExODkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBXZWQsIDE2IE9jdCAyMDE5IDEzOjQ0OjAwIC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gUmVt b3ZlIHJlZHVuZGFudCBpbml0aWFsaXphdGlvbiBvZiBmcmluZ2UgYml0bWFwIChCdWcjMzc3NTYp CgoqIHNyYy9mcmluZ2UuYyAoRmRlZmluZS1mcmluZ2UtYml0bWFwKTogUmVtb3ZlIHJlZHVuZGFu dCB6ZXJvaW5nCm9mIGZiLmJpdHMgdGhhdCBvbmx5IHplcm9lZCBoYWxmIG9mIHRoZSBhcnJheSBh bnl3YXkuCi0tLQogc3JjL2ZyaW5nZS5jIHwgMSAtCiAxIGZpbGUgY2hhbmdlZCwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL3NyYy9mcmluZ2UuYyBiL3NyYy9mcmluZ2UuYwppbmRleCAyMmYz YmRjLi4wOGJmMjcxIDEwMDY0NAotLS0gYS9zcmMvZnJpbmdlLmMKKysrIGIvc3JjL2ZyaW5nZS5j CkBAIC0xNjA3LDcgKzE2MDcsNiBAQCBsaXN0IChBTElHTiBQRVJJT0RJQykgd2hlcmUgUEVSSU9E SUMgbm9uLW5pbCBzcGVjaWZpZXMgdGhhdCB0aGUgYml0bWFwCiAgIGZiLmJpdHMgPSBiID0gKCh1 bnNpZ25lZCBzaG9ydCAqKQogCQkgcHRyX2JvdW5kc19jbGlwICh4ZmIgKyAxLCBmYi5oZWlnaHQg KiBCWVRFU19QRVJfQklUTUFQX1JPVykpOwogICB4ZmIgPSBwdHJfYm91bmRzX2NsaXAgKHhmYiwg c2l6ZW9mICp4ZmIpOwotICBtZW1zZXQgKGIsIDAsIGZiLmhlaWdodCk7CiAKICAgaiA9IDA7CiAg IHdoaWxlIChqIDwgZmIuaGVpZ2h0KQotLSAKMi4yMC4xCgo= --000000000000af6b9705950c9020-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 07:54:02 2019 Received: (at 37756) by debbugs.gnu.org; 17 Oct 2019 11:54:02 +0000 Received: from localhost ([127.0.0.1]:47272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL4Ly-00022a-L0 for submit@debbugs.gnu.org; Thu, 17 Oct 2019 07:54:02 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL4Lw-000225-Vj for 37756@debbugs.gnu.org; Thu, 17 Oct 2019 07:54:01 -0400 Received: by mail-wm1-f68.google.com with SMTP id r19so2257416wmh.2 for <37756@debbugs.gnu.org>; Thu, 17 Oct 2019 04:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=5ezQQXnmzAo9vY34oRdq3pPbeitETTyGhgQCi8C/2vM=; b=YONpX7VzIOvMYy8EgG2d5kuJgK1cWS+ZN0WSZSHYjwvndCjMV5HQ2kA00s2ouLOAdl pWk16bSEdCRMBqLJ1YqqmRU6J4wpCGE+1VTISWX6rXMfIa/pYFJ4iJ85mT03o+sPLYzr VcO3dliocM/O648FZyM5lbGW7wCzJowOsCHvhJ2SjauE0Y7HIsPICg16rQpX/v70DpQh bOiWtwvkkp0Q4hhtFwxG+QNxjwQj1bzBVEskv7hycDK2cUDWnajH82fto1DNP2DhSerI wQYBoxnKxb78D6AyIF+wM82UQ6Z2Y9J6i9S32bMIq8VWf895zCGEONjnwvijuQ7SH8Pt DuCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=5ezQQXnmzAo9vY34oRdq3pPbeitETTyGhgQCi8C/2vM=; b=ujDg8S3m/EccE9fojCg+RmS53779C2oejZ7g0Yz4yGYOafqaNn1WDXTdYpzsSk5nAl 3GwIRd4py3U8Vk4ahwzINXhRK5TWlduaRFRLkPJllSviksRqR7QzqEMux8f1Pdc/6+6l Y3cl0/Oafr/Rx1unpqA3TzVEdrLgEquWOCTk4ZlpF3xfOhWW/QntD8MkLSRe4RwoTLRe oo90NIGHO8FzOcGSdO12x8JaT6CVHhyckpBOqmcbacXKPG2OnEkDoiBLeeP0DCEgXoHY 2Z+icRZbF+/n+uO1JJ8r4x/K8P0GDm3cHB6IjGtpGSfInY2bFOxIqf/4qqp7Zsp38yhT vjHA== X-Gm-Message-State: APjAAAXjrBBO6WcZrEwXGfabH5aGKjJIwHaFtnuKOQYEjWMgcCUJ8w+2 oBui8zxDjOpzkspbfHyggTs= X-Google-Smtp-Source: APXvYqzShspovyQjNN9ic3sl37eAA2VEQSwcsI/8M8AtAgTUIu8ppZJlfTno/ICIWX9K5Oc+VQdazw== X-Received: by 2002:a1c:a385:: with SMTP id m127mr2720080wme.50.1571313234873; Thu, 17 Oct 2019 04:53:54 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-7415-ea7a-be7a-b72e.holly.idiocy.org. [2001:8b0:3f8:8129:7415:ea7a:be7a:b72e]) by smtp.gmail.com with ESMTPSA id 13sm2187977wmj.29.2019.10.17.04.53.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Oct 2019 04:53:53 -0700 (PDT) Date: Thu, 17 Oct 2019 12:53:51 +0100 From: Alan Third To: Carlos Pita Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap Message-ID: <20191017115351.GB11160@breton.holly.idiocy.org> References: <838spmgx1t.fsf@gnu.org> <83zhi0cze0.fsf@gnu.org> <83sgnscxyi.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 37756 Cc: Eli Zaretskii , 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Oct 16, 2019 at 05:01:11PM -0300, Carlos Pita wrote: > > Use one of the related Emacs commands, and Emacs will do that for you. > > Those commands are described in CONTRIBUTE under "Generating ChangeLog > > entries". > > I'm having some issues doing that because I'm using magit to amend / > reword previously committed changes, so the instructions there don't > quite match my situation. Will try harder later, for now I just > modified the message after some examples in your git log. Hope it's ok > now. In the Magit diff view that is displayed when comitting you should be able to just hit ‘C’ with point in the code you want to add to the commit message. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 11:02:11 2019 Received: (at 37756) by debbugs.gnu.org; 17 Oct 2019 15:02:11 +0000 Received: from localhost ([127.0.0.1]:48684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL7I3-0007Hy-4q for submit@debbugs.gnu.org; Thu, 17 Oct 2019 11:02:11 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL7I0-0007Hj-NW for 37756@debbugs.gnu.org; Thu, 17 Oct 2019 11:02:09 -0400 Received: by mail-wr1-f65.google.com with SMTP id o18so2713101wrv.13 for <37756@debbugs.gnu.org>; Thu, 17 Oct 2019 08:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=SX3afXQsDw+37E6Ufj8mmtFP4XoJS7b2DEkUFb2IdiY=; b=DVGe1psIDXi/i8UNzyKddVF6ADJl6vb3RLfkR3doCNjb1RbwgVmTd90MsVmcpOXaAO 9ym5GdIxcL6Dq4fx4la0ojCk2MOqJAGP69lsALDMUzo2cfKrxcgKteZhazzV9Nnj61Td S1x6lmmnBKugbdI8wRSq46icJ+QDGk4QM8nVKyqGGxzJhzKoRmEOqDb1gk0cCsThJ3Tm 8udosHhE8O5tp8ocP6eBFHmnov/IOeP5UYVL8o+1aRDwTxKyn74AgpbL69jhsyPAAuLu ckcXoD2waxYt186xqM6x5ew3SPxfs+F1nzVa/zELcDafwwcaA2BM5m7OYJVN0LqpXG7t 8rFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=SX3afXQsDw+37E6Ufj8mmtFP4XoJS7b2DEkUFb2IdiY=; b=nXovMzZwa0z1Tmfz6aqRPhnHmQQiHXvXsWeyDYck1AjTikc3TctYyItxwOAWVQ+LaY qvH1R6Cd4rLATDKlJH8G6iflZ/i70Q7YL9uJ89c0ZlfqjJ9UrlDUPnNfEl2NboXp7Q7D Ha4y0T/odxvrJGfMT7L4a/ttFzG1NYDU8Axbxokoigmf3waYSVOA+sjIQ3/Wcsbw0T6J WAaCTo4iSuXnBT/IkgLwsSKe7qcNJbFMFIlq5XApA+EeJo0Dvn+PsenxKdSBf3iVxsZm wNYHiOwk9YLECORFmu9zdQCgXc3MI1+52hUIO27hSHYhCwxJWYV5RFPJd5qDeVX4iGQr LF1Q== X-Gm-Message-State: APjAAAUsHVAOT/Va7Vtr/giOW3fIbXC+lGlSOymnc67EeaPbi/+B7fOS FB5K6HUuVz3FPNNpVsOEXRISP4+N8Ik= X-Google-Smtp-Source: APXvYqw2NX34EurdvA41MdfCAcZCpMJR7F/W8U+zIYevGoum2+gDOah9RCuptukT5G1PFt3jxS+gTw== X-Received: by 2002:adf:a506:: with SMTP id i6mr3386568wrb.159.1571324520335; Thu, 17 Oct 2019 08:02:00 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id g4sm2575657wrw.9.2019.10.17.08.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 08:01:55 -0700 (PDT) From: Robert Pluim To: Alan Third Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap References: <838spmgx1t.fsf@gnu.org> <83zhi0cze0.fsf@gnu.org> <83sgnscxyi.fsf@gnu.org> <20191017115351.GB11160@breton.holly.idiocy.org> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 17 Oct 2019 17:01:54 +0200 In-Reply-To: <20191017115351.GB11160@breton.holly.idiocy.org> (Alan Third's message of "Thu, 17 Oct 2019 12:53:51 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37756 Cc: Carlos Pita , 37756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 17 Oct 2019 12:53:51 +0100, Alan Third said: Alan> On Wed, Oct 16, 2019 at 05:01:11PM -0300, Carlos Pita wrote: >> > Use one of the related Emacs commands, and Emacs will do that for = you. >> > Those commands are described in CONTRIBUTE under "Generating Chang= eLog >> > entries". >>=20 >> I'm having some issues doing that because I'm using magit to amend / >> reword previously committed changes, so the instructions there don't >> quite match my situation. Will try harder later, for now I just >> modified the message after some examples in your git log. Hope it's = ok >> now. Alan> In the Magit diff view that is displayed when comitting you shoul= d be Alan> able to just hit =E2=80=98C=E2=80=99 with point in the code you w= ant to add to the Alan> commit message. That doesn=CA=BCt auto-snarf the function names the way C-x 4 A or C-c C-w do in vc. Robert From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 06:21:43 2019 Received: (at 37756-done) by debbugs.gnu.org; 26 Oct 2019 10:21:43 +0000 Received: from localhost ([127.0.0.1]:39713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOJCZ-0007Jc-KC for submit@debbugs.gnu.org; Sat, 26 Oct 2019 06:21:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOJCY-0007JR-ME for 37756-done@debbugs.gnu.org; Sat, 26 Oct 2019 06:21:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iOJCT-00014n-Ho; Sat, 26 Oct 2019 06:21:37 -0400 Received: from [176.228.60.248] (port=3998 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iOJCS-0000fI-DS; Sat, 26 Oct 2019 06:21:36 -0400 Date: Sat, 26 Oct 2019 13:21:25 +0300 Message-Id: <83lft7vmca.fsf@gnu.org> From: Eli Zaretskii To: Carlos Pita In-reply-to: (message from Carlos Pita on Wed, 16 Oct 2019 17:01:11 -0300) Subject: Re: bug#37756: [PATCH] Wrong initialization of fringe bitmap References: <838spmgx1t.fsf@gnu.org> <83zhi0cze0.fsf@gnu.org> <83sgnscxyi.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37756-done Cc: 37756-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Carlos Pita > Date: Wed, 16 Oct 2019 17:01:11 -0300 > Cc: 37756@debbugs.gnu.org > > I'm having some issues doing that because I'm using magit to amend / > reword previously committed changes, so the instructions there don't > quite match my situation. Will try harder later, for now I just > modified the message after some examples in your git log. Hope it's ok > now. Thanks, pushed. Closing the bug. > From: memeplex ^^^^^^^^ Is this really how you want your name to appear in the Git log? From unknown Fri Jun 20 07:25:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 23 Nov 2019 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator