GNU bug report logs - #37755
Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Carlos Pita <carlosjosepita <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37755: closed (Logic in init_fringe_bitmap should be moved to
 backends (maybe rif->define_fringe_bitmap))
Date: Sat, 26 Oct 2019 16:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 26 Oct 2019 13:11:09 -0300
with message-id <CAELgYhft-4CLC8d=R8AQS5bgDFJXM-29R=+T5vQgvhZnLWkYPg <at> mail.gmail.com>
and subject line Re: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap)
has caused the debbugs.gnu.org bug report #37755,
regarding Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37755: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37755
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Carlos Pita <carlosjosepita <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Logic in init_fringe_bitmap should be moved to backends (maybe
 rif->define_fringe_bitmap)
Date: Mon, 14 Oct 2019 23:30:08 -0300

In fringe.c you have init_fringe_bitmap with this structure:

```
#if defined (HAVE_X_WINDOWS)
...
#ifdef USE_CAIRO
...
#endif
...
#endif
#ifdef HAVE_NTGUI
...
#endif
  if (!once_p)
    {
    ....
    rif->define_fringe_bitmap (...)
    ....
    }
```

Now, this is backend specific code that should be moved behind the
redisplay_interface. It seems to me that the obvious candidate to host
that code is define_fringe_bitmap. The once_p clause is related to
pdumper which I ignore all about.

Best regards
--
Carlos

[Message part 3 (message/rfc822, inline)]

From: Carlos Pita <carlosjosepita <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 37755-close <at> debbugs.gnu.org
Subject: Re: bug#37755: Logic in init_fringe_bitmap should be moved to
 backends (maybe rif->define_fringe_bitmap)
Date: Sat, 26 Oct 2019 13:11:09 -0300

[Message part 4 (text/plain, inline)]

> I don't think you can do that with a RIF, for the reason already
> mentioned: Emacs is dumped in batch mode, where we have a frame type
> that doesn't support fringes, and doesn't implement the RIF interfaces
> you will need.
>

Ok, I'm not eager to rework this, so if you think that avoiding repeating
that bit shuffling at the beginning is worth the additional coupling and
complexity I trust in your criterion and close this issue. Thanks.

>

[Message part 5 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.