From unknown Sun Jun 15 08:52:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37752: Scaling factor inconsistencies between X with and without GTK Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 00:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 37752@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157109893228832 (code B ref -1); Tue, 15 Oct 2019 00:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Oct 2019 00:22:12 +0000 Received: from localhost ([127.0.0.1]:42437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAbL-0007Ux-5v for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:22:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:50809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAbK-0007Up-3Y for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:22:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKAbJ-0005Dm-1A for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKAbH-0008VC-0j for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:07 -0400 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:33563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKAbG-0008Uh-T3 for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:06 -0400 Received: by mail-yb1-xb2a.google.com with SMTP id h7so3900360ybp.0 for ; Mon, 14 Oct 2019 17:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3s6t3snYn70pgJL/OVJmjoL+yE/T0MKa6pdILNnGces=; b=cFfuqsBIK4LRr3TDBesi66HH6kVUulughYHIWgzj9bhEKz1UnoCec4Ru4lK7XfdTIu lIYfagYeii7JVZWvjGbkARONNtHxMCLmS0OaC/7TUVb3UK27f+Xz5O1QQC6edg1TaVRH Jmx/dI9LmQnJCafvRLCuKgQeTfi+tQ5DC9FHubwmHDe3lsjc83qsHSXWcRXm5/1Fguq1 8infrcFjvdToy+nF/ZryT4mshUCPJJ9f5K75kDXuXfjIQE5pTYDvIF97SaNdgRk0qd3k 7ViLLxvr6yjcwyKyctt7iMmTnTxlps831tSebMtqd2OXyeq0tr/o2WHoLfgsn+2tzjWd XuGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3s6t3snYn70pgJL/OVJmjoL+yE/T0MKa6pdILNnGces=; b=Xa/ed6iQclI09ITlVQ8EeEdcVeJeBdWQML8U3Zsa8rL0zoCSK6frNgnQemNJezpL/c Gwh6rPKPA0fBB+/WER9BxfW9aerf4Sfq/eq1B/SXBC1+ZImwb6e9hcZZeBFUoh3Z2jBG QUNQNWEb10pO/R70L2AO6yin6NcTrpwMxMpUazWTPfzsdhFUyhRUGVvwusMhzVv+/6oO Niyb9LZ1BUrGU7r1ASOzs+015Gj8Y6noRG0huqvHMpt1/Rtk0i6gFfko5BL6a0bASS1b EQFa26ogIFiEyE3S07fCGLQ9yt8K1GXuQ8PaA+iOAbmxWAj03c8ishyM8kkm2DxcvZAJ 3nRw== X-Gm-Message-State: APjAAAUHv/kfJhsPdHGmAdvlocs/66wxi9xU89flqfcFx9Kr+paS6zdg pV4R62TcdEIO+4PMeh2wG/PNJoWxQzE4orAAGOPOXiahjV8= X-Google-Smtp-Source: APXvYqxBvhhiliisf/OQZvR/HvbaXviuKj1jKAf4aGRqVw8xIaSDz90JEv0B6sKEkfqj3HIECF+0qet9GURugSw0jlo= X-Received: by 2002:a25:9947:: with SMTP id n7mr21595169ybo.263.1571098925814; Mon, 14 Oct 2019 17:22:05 -0700 (PDT) MIME-Version: 1.0 From: Carlos Pita Date: Mon, 14 Oct 2019 21:21:54 -0300 Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::b2a X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) In many places in xterm.c you have code like: #ifdef USE_GTK scale = xg_get_scale (f); #endif Sometimes scale is only used in GTK specific code and that's ok. But sometimes it's used in code that's not particular to GTK, for example: int scale = 1; #ifdef USE_GTK scale = xg_get_scale (f); #endif FRAME_CR_SURFACE (f) = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, scale * FRAME_PIXEL_WIDTH (f), scale * FRAME_PIXEL_HEIGHT (f)); Besides, there is x_get_scale_factor, also defined in xterm.c, which computes the scaling factor in a GTK-independent way, and also discriminates between x and y scaling factors. It's only used by x_draw_underwave. I would like to abstract both cases inside x_get_scale_factor, that would then use xg_get_scale if in GTK or compute just one scaling factor (for x or for y) otherwise. Notice that given that the scaling factor is the ratio of the effective resolution to a base resolution of 96 dpi *truncated down* to the nearest integer, AFAICS it's almost impossible to get different scaling factors for x and for y. What do you think? Best regards -- Carlos From unknown Sun Jun 15 08:52:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37752: Scaling factor inconsistencies between X with and without GTK Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 07:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Carlos Pita Cc: 37752@debbugs.gnu.org Received: via spool by 37752-submit@debbugs.gnu.org id=B37752.157112621731649 (code B ref 37752); Tue, 15 Oct 2019 07:57:02 +0000 Received: (at 37752) by debbugs.gnu.org; 15 Oct 2019 07:56:57 +0000 Received: from localhost ([127.0.0.1]:42660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKHhQ-0008EP-SM for submit@debbugs.gnu.org; Tue, 15 Oct 2019 03:56:57 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:35645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKHhP-0008EB-2S for 37752@debbugs.gnu.org; Tue, 15 Oct 2019 03:56:55 -0400 Received: by mail-wm1-f43.google.com with SMTP id y21so19159080wmi.0 for <37752@debbugs.gnu.org>; Tue, 15 Oct 2019 00:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=gY4J6ctpeSnztV9n2IjqDQgHjUGYpBG80amT5QmnX5I=; b=bQKZud5HLKy/VUa0FlVxhGhloNqenOaG9IXA71FD+IyThovKNpjljUsoE9HMbjIkcn 22KrnwX5/7ph6puc80PKLopTrx7ErEpDn3+HOuO5lTXacniEfgXJfNvw0fCqMkrVseKG feK5+CvWVRHKY/K395lP1HA2dW8ueG0Kmt0eShap1ztfS8jPBv0oLdsdClgVDeb6+F1f ZP9NobwkhnVseODiuFrDarWVbdCG/rgcwGTfh/6tIJ7Ggs6IhHxw5wVEsC0DnsBYs7wI YiafzITjuGByIF8BR55POnirW/COi9+Y1WZ8SbR+qRJcyzgg5o+EMXbW6962XAmpDzSt Oe/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=gY4J6ctpeSnztV9n2IjqDQgHjUGYpBG80amT5QmnX5I=; b=U3EPWO3Q7cUgg731wgZkAzfUpE9ncuZboBT9EXUtC80txPJJD/AgQ1F2IlHK1LAliV VZeCTrLkIXTuxlmX04K3Pvre40p4DQi2NlIGUWXRXEx55DNtuNyvsn82WLkULLVECMyx /hrQ9s3e6ybWmw2ENTQ3KkKqvB5votzz5mKJcOyjM/ybgAKfl1tSBhpBHSWu14QLH68D BpwLkl1EaH+5X+3hb3TvMfITicW7d+NWLKFTdGxQOLgAM9D64wjbsN3ErLxmzSaGDbpB T8vNw+9dPIAOdL7tCbNlnJK4Aj9KhKo7Xme/tAR+LiB56pxWq+U0pzo5VTkpvbTIzv/j r7jQ== X-Gm-Message-State: APjAAAXie0Lz8f3LN1CMlFMdy3G/Rl5r0hGJNGS6n0cQIyfZ8hF8RbG2 luiteIwbmGlVskbhngc9S0eLiZclggk= X-Google-Smtp-Source: APXvYqxQQVU+ZZWSUoUAN+d9hbELzyJ+Es0gnrgFHCSi2WsqLxjsb+IMfIGp3dO3fcEOkgYtsOqqhA== X-Received: by 2002:a1c:6a0b:: with SMTP id f11mr19392974wmc.78.1571126208468; Tue, 15 Oct 2019 00:56:48 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id p85sm28517246wme.23.2019.10.15.00.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 00:56:47 -0700 (PDT) From: Robert Pluim References: Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 15 Oct 2019 09:56:46 +0200 In-Reply-To: (Carlos Pita's message of "Mon, 14 Oct 2019 21:21:54 -0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 14 Oct 2019 21:21:54 -0300, Carlos Pita said: Carlos> In many places in xterm.c you have code like: Carlos> #ifdef USE_GTK Carlos> scale =3D xg_get_scale (f); Carlos> #endif Carlos> Sometimes scale is only used in GTK specific code and that's ok. Carlos> But sometimes it's used in code that's not particular to GTK, f= or example: Carlos> int scale =3D 1; Carlos> #ifdef USE_GTK Carlos> scale =3D xg_get_scale (f); Carlos> #endif Carlos> FRAME_CR_SURFACE (f) =3D Carlos> cairo_image_surface_create (CAIRO_FORMAT_ARGB32, Carlos> scale * FRAME_PIXEL_WIDTH (f), Carlos> scale * FRAME_PIXEL_HEIGHT (f)); I can=CA=BCt find that code in master. Carlos> Besides, there is x_get_scale_factor, also defined in xterm.c, = which Carlos> computes the scaling factor in a GTK-independent way, and also Carlos> discriminates between x and y scaling factors. It's only used by Carlos> x_draw_underwave. Carlos> I would like to abstract both cases inside x_get_scale_factor, = that Carlos> would then use xg_get_scale if in GTK or compute just one scali= ng Carlos> factor (for x or for y) otherwise. Notice that given that the s= caling Carlos> factor is the ratio of the effective resolution to a base resol= ution Carlos> of 96 dpi *truncated down* to the nearest integer, AFAICS it's = almost Carlos> impossible to get different scaling factors for x and for y. Sure, that makes sense. Do you have a test case showing a display difference, or is this just code cleanup? Robert From unknown Sun Jun 15 08:52:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37752: Scaling factor inconsistencies between X with and without GTK Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 08:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 37752@debbugs.gnu.org Received: via spool by 37752-submit@debbugs.gnu.org id=B37752.1571126963384 (code B ref 37752); Tue, 15 Oct 2019 08:10:01 +0000 Received: (at 37752) by debbugs.gnu.org; 15 Oct 2019 08:09:23 +0000 Received: from localhost ([127.0.0.1]:42672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKHtT-000068-0U for submit@debbugs.gnu.org; Tue, 15 Oct 2019 04:09:23 -0400 Received: from mail-yw1-f50.google.com ([209.85.161.50]:40907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKHtR-00005k-FF for 37752@debbugs.gnu.org; Tue, 15 Oct 2019 04:09:21 -0400 Received: by mail-yw1-f50.google.com with SMTP id e205so7032632ywc.7 for <37752@debbugs.gnu.org>; Tue, 15 Oct 2019 01:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kWKfeQiQMde57aBgSalU8acZwCB37VTroEiyYHQsKPw=; b=AJQ6rITm97Sabvja1FS+lbVXgdsnjQ44U+8LYdMH8tc3lDz/GaqFP8XFDRQtQjRBjV 90Bo1C/5gwADVivWhltvmqOXgC80eu4++F4DaYOWCa+rONUwIOt2XvZON5yWrqP/R64k MFg8Q5k28LY7684uKXAk+EijZ9WIxk8DfDxw0BeWoBmpppEWBKGIhsI/BzDnJTLh9mk/ OsYh8V8qZQ//aj70KfNkAEYPx9NrbVnDmfAwwbiGn8PObr4rPZffJyEvoHhWKjaZI9jK aNXhMfjjYHRCHK8bQMVjqvX8ORluJVf7SL/vukdr71zOqyo/I/6XuTYrsXtQfjv8q4I/ jyzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kWKfeQiQMde57aBgSalU8acZwCB37VTroEiyYHQsKPw=; b=X9EsZhLr41mrcNvEPd/VheQSyPaE98dDGL6go40JO3PHsVJMOuZfhDetc3wdLw4+0Z Mnkoo+rmaJ5UQFa3XYw5YO4DpYK6wZTJw0w3h9N0xkjCUuPPBgjw66QajE3sBoVX1usG swTpOYSavGNmJQ7QMigt7jPxgTWnvqGXRMgKn2uzDKWFfXsrS+9kv71b44tlWX+LQCay Qyp166NlXWqUeIFeJYlWjYUm9GsJ4qVvlbIuqDel2asikRJUuys0VyLS0uChNeYG61Ti XOKYVj85HMFSRRpRNpx06tGRAOmJTOLGo+2XDVuIMplfwEpgyzrWLijGQy769wqBLgC1 Kp5A== X-Gm-Message-State: APjAAAV+wBXyrOil48ucNSO2VlcZ4qaOWr+gTnoQ2cH0xGApHZUp2fei sQbxO9e8E1oylJsDMfz5WWTt3USfK/KmWnrIUb8= X-Google-Smtp-Source: APXvYqzP4PNIppS6LwFDMIbIvGsFlRIPWfm19YYzrYIPt8KHYeESVXWaFUJkjXNNKpC+4BHSXf62jxfsJVA8gggwnGY= X-Received: by 2002:a81:254e:: with SMTP id l75mr15014158ywl.90.1571126955601; Tue, 15 Oct 2019 01:09:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carlos Pita Date: Tue, 15 Oct 2019 05:09:04 -0300 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Carlos> int scale =3D 1; > Carlos> #ifdef USE_GTK > Carlos> scale =3D xg_get_scale (f); > Carlos> #endif > Carlos> FRAME_CR_SURFACE (f) =3D > Carlos> cairo_image_surface_create (CAIRO_FORMAT_ARGB32, > Carlos> scale * FRAME_PIXEL_WIDTH (f), > Carlos> scale * FRAME_PIXEL_HEIGHT (f)); > > I can=CA=BCt find that code in master. You're right, this and other xg_get_scale usages were removed wrt emacs-26. Just one of them remains. > Sure, that makes sense. Do you have a test case showing a display > difference, or is this just code cleanup? It's just code cleanup. Best regards -- Carlos From unknown Sun Jun 15 08:52:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37752: Scaling factor inconsistencies between X with and without GTK Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 09:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Carlos Pita Cc: 37752@debbugs.gnu.org Received: via spool by 37752-submit@debbugs.gnu.org id=B37752.15711322328665 (code B ref 37752); Tue, 15 Oct 2019 09:38:02 +0000 Received: (at 37752) by debbugs.gnu.org; 15 Oct 2019 09:37:12 +0000 Received: from localhost ([127.0.0.1]:42758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJGR-0002Fg-Q4 for submit@debbugs.gnu.org; Tue, 15 Oct 2019 05:37:12 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:52729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJGQ-0002FV-ST for 37752@debbugs.gnu.org; Tue, 15 Oct 2019 05:37:11 -0400 Received: by mail-wm1-f46.google.com with SMTP id r19so20062525wmh.2 for <37752@debbugs.gnu.org>; Tue, 15 Oct 2019 02:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=anlNGBOovUX1+VxjJ1ja2OenmZfhbXu7xnhkjNyOduM=; b=svCglfWUlKJHdNCmcCwqNCBbixF30loCBFn+XH1mlo80N/hH4hiaMF3JNZuVrkvGe7 /SFv7F8sAmmBMZb9fu4bpMyzbVrysgoEs3jzVcC+H6iBtHsB5TEBAL3LzvncXZLcdnBu 4N/eMRLLlwrfiqQhPbJx+B4mLdWGTkTQG16F4ByDBatSAmcVvGKsrrZD5kb+fPoNIwNe e1X+0iHQDRCq/t/ibOc7GberIoAhbzdfn36Q76TPmQIz2AE4xRsXssTq9OLAPKOOpNYD 4eyKRyX8ch9b0COPXhiveUkm3pBimkF47wo9VAHsToHBtDrC2h/b8uK8A5zAmef3Af2k GjSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=anlNGBOovUX1+VxjJ1ja2OenmZfhbXu7xnhkjNyOduM=; b=EMgui80NjSyyMwrOQTBs3ai+CT6BhO95lpeTtyNeJ0YXH99NDR6x3IRT+qKVOalkeY tX64A7mU98ukFSyZVgsVbK8Y5XJg6yIsN8rsR6IksEQNB2MP/avyloJ6eY4EhXckRcDE 91dReD5QyU756njd/Soss5nhm+WagCa4iWdVZNTgdQkpXbdG0TPbtxRn9SnYtAhc8d5N Wkj5xDfjDdI7m6JlzYyZ19jWQgTRTDBMwPU1MM8vrjSy1GMXL336py1V4Xda/sZxdoln IS+hm/vgqlk8b9qxzlWgliOFDgxkIKImsF+1vt4XxhzIazFkOsv89VKPuAnNMX99aIgM bugA== X-Gm-Message-State: APjAAAVZTlLjAE0GIPcRM2gQk/r6EqNei9RqYf3oZoiR3Mkn8+9p0FWQ R3h6XexB4e4fHrPm+08T7sOOzlfk X-Google-Smtp-Source: APXvYqwVyDN2qmZ6XMZfbvSmaS2HrQOyFpNGOBPetepIkcFx/EG8hFAyJYCki2CFwuiM9Hcm6fuy9g== X-Received: by 2002:a1c:1dc9:: with SMTP id d192mr19565467wmd.51.1571132224551; Tue, 15 Oct 2019 02:37:04 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id 143sm25618611wmb.33.2019.10.15.02.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 02:37:03 -0700 (PDT) From: Robert Pluim References: Date: Tue, 15 Oct 2019 11:37:02 +0200 In-Reply-To: (Carlos Pita's message of "Tue, 15 Oct 2019 05:09:04 -0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 15 Oct 2019 05:09:04 -0300, Carlos Pita said: Carlos> int scale =3D 1; Carlos> #ifdef USE_GTK Carlos> scale =3D xg_get_scale (f); Carlos> #endif Carlos> FRAME_CR_SURFACE (f) =3D Carlos> cairo_image_surface_create (CAIRO_FORMAT_ARGB32, Carlos> scale * FRAME_PIXEL_WIDTH (f), Carlos> scale * FRAME_PIXEL_HEIGHT (f)); >>=20 >> I can=CA=BCt find that code in master. Carlos> You're right, this and other xg_get_scale usages were removed w= rt Carlos> emacs-26. Just one of them remains. If that=CA=BCs in code that=CA=BCs independent of GTK3 usage, then by all m= eans fix it. Robert From unknown Sun Jun 15 08:52:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Carlos Pita Subject: bug#37752: closed (Re: bug#37752: Scaling factor inconsistencies between X with and without GTK) Message-ID: References: X-Gnu-PR-Message: they-closed 37752 X-Gnu-PR-Package: emacs Reply-To: 37752@debbugs.gnu.org Date: Tue, 15 Oct 2019 22:41:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1571179261-21258-1" This is a multi-part message in MIME format... ------------=_1571179261-21258-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #37752: Scaling factor inconsistencies between X with and without GTK which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 37752@debbugs.gnu.org. --=20 37752: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37752 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1571179261-21258-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 37752-close) by debbugs.gnu.org; 15 Oct 2019 22:40:22 +0000 Received: from localhost ([127.0.0.1]:44986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKVUL-0005Vl-1O for submit@debbugs.gnu.org; Tue, 15 Oct 2019 18:40:21 -0400 Received: from mail-yb1-f174.google.com ([209.85.219.174]:33044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKVUJ-0005VU-5O for 37752-close@debbugs.gnu.org; Tue, 15 Oct 2019 18:40:19 -0400 Received: by mail-yb1-f174.google.com with SMTP id h7so5056145ybp.0 for <37752-close@debbugs.gnu.org>; Tue, 15 Oct 2019 15:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TqhxYwrD/ZztM4/RMnu+EjUAr/Q9+cDBh8ELt2IuQhQ=; b=XajexZvQeIgq06QnpidM0470OAOjphTW8yqNoXxsR1uQL8HiqApKe1coxGMLQS5wEM /Y6DqVMj5cuOR50Pg1EbCsOKYjkNEDUyA+/ix4BNQT1mXoGHKwCroTlMLBPTEYUm/Hnc nt4N/lX1yy+KPdYevSu0PPJvTFrKqQ0g2GMOIJPjSyK2DeGmS/cgGTf1ls9bl32Q2qzh VBE9mM/s8aGnmCjXDWg8BB/nFRmdcpz2VLfYlrq6bZXnwd2/35DDlUG+QzX4Xd+nsSIY BIilSLFLr599pJ06zyPjOHHdfyMzFZLyb3necS4fO1tosFZsseXdLvyBSIJ/0d4+62V7 ZYqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TqhxYwrD/ZztM4/RMnu+EjUAr/Q9+cDBh8ELt2IuQhQ=; b=O6C1w1Yf7O7YQ6TEdr5utsOFcMyAP3/fx7aQ9t/8RlsgqlbwIRnCsYJtFGI/f1lnBF JJYG4XUlk0Lu8Jm3cVlExGk35vfRxLffimPhsA4W8ndu2G96QGQ12OgR96sJfTWmCcfY u/7KC3Yv3F6ptMqPN454ToK65N3Mjo18W++vp6L3fMv9dA52NwI1ShL1RPC5dB9qwMnq LXmNAc2WfbngUtf/XkUtMD+HwW2zHHkKYwwlg9QDdDoDOLqDDgY15aoDYohnXRN7qBqJ FvTmTe5s/3QIROLYnMznJr6X59mVo+BP7qDCYgfZRq6Z5SSdB4fpzKi6dpMJ4l7hXIv4 RyPg== X-Gm-Message-State: APjAAAWl2+yRxunRPgn1PhrZIIsc+myFwl+k2kGg4naEV6AakPtqu1SZ +DCwBJkPpchWNushRZcstoZkNiyJq/ziUFRkZ44= X-Google-Smtp-Source: APXvYqzryEG3UIzOb5lcj1BBlnBFKHoH8Sy/GBJomdpbaSBf9foOD4+sgoeXUV0K6R9N8y+SttaifyLlkAMesi5q118= X-Received: by 2002:a25:9cc5:: with SMTP id z5mr2798530ybo.82.1571179213399; Tue, 15 Oct 2019 15:40:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carlos Pita Date: Tue, 15 Oct 2019 19:40:02 -0300 Message-ID: Subject: Re: bug#37752: Scaling factor inconsistencies between X with and without GTK To: Robert Pluim Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37752-close Cc: 37752-close@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Robert, I'm closing this in favor of #37770 [PATCH] Expose scale factor through the redisplay interface https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37770 Please take a look at it if you're so kind. Best regards -- Carlos ------------=_1571179261-21258-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Oct 2019 00:22:12 +0000 Received: from localhost ([127.0.0.1]:42437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAbL-0007Ux-5v for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:22:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:50809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAbK-0007Up-3Y for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:22:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKAbJ-0005Dm-1A for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKAbH-0008VC-0j for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:07 -0400 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:33563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKAbG-0008Uh-T3 for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:06 -0400 Received: by mail-yb1-xb2a.google.com with SMTP id h7so3900360ybp.0 for ; Mon, 14 Oct 2019 17:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3s6t3snYn70pgJL/OVJmjoL+yE/T0MKa6pdILNnGces=; b=cFfuqsBIK4LRr3TDBesi66HH6kVUulughYHIWgzj9bhEKz1UnoCec4Ru4lK7XfdTIu lIYfagYeii7JVZWvjGbkARONNtHxMCLmS0OaC/7TUVb3UK27f+Xz5O1QQC6edg1TaVRH Jmx/dI9LmQnJCafvRLCuKgQeTfi+tQ5DC9FHubwmHDe3lsjc83qsHSXWcRXm5/1Fguq1 8infrcFjvdToy+nF/ZryT4mshUCPJJ9f5K75kDXuXfjIQE5pTYDvIF97SaNdgRk0qd3k 7ViLLxvr6yjcwyKyctt7iMmTnTxlps831tSebMtqd2OXyeq0tr/o2WHoLfgsn+2tzjWd XuGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3s6t3snYn70pgJL/OVJmjoL+yE/T0MKa6pdILNnGces=; b=Xa/ed6iQclI09ITlVQ8EeEdcVeJeBdWQML8U3Zsa8rL0zoCSK6frNgnQemNJezpL/c Gwh6rPKPA0fBB+/WER9BxfW9aerf4Sfq/eq1B/SXBC1+ZImwb6e9hcZZeBFUoh3Z2jBG QUNQNWEb10pO/R70L2AO6yin6NcTrpwMxMpUazWTPfzsdhFUyhRUGVvwusMhzVv+/6oO Niyb9LZ1BUrGU7r1ASOzs+015Gj8Y6noRG0huqvHMpt1/Rtk0i6gFfko5BL6a0bASS1b EQFa26ogIFiEyE3S07fCGLQ9yt8K1GXuQ8PaA+iOAbmxWAj03c8ishyM8kkm2DxcvZAJ 3nRw== X-Gm-Message-State: APjAAAUHv/kfJhsPdHGmAdvlocs/66wxi9xU89flqfcFx9Kr+paS6zdg pV4R62TcdEIO+4PMeh2wG/PNJoWxQzE4orAAGOPOXiahjV8= X-Google-Smtp-Source: APXvYqxBvhhiliisf/OQZvR/HvbaXviuKj1jKAf4aGRqVw8xIaSDz90JEv0B6sKEkfqj3HIECF+0qet9GURugSw0jlo= X-Received: by 2002:a25:9947:: with SMTP id n7mr21595169ybo.263.1571098925814; Mon, 14 Oct 2019 17:22:05 -0700 (PDT) MIME-Version: 1.0 From: Carlos Pita Date: Mon, 14 Oct 2019 21:21:54 -0300 Message-ID: Subject: Scaling factor inconsistencies between X with and without GTK To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::b2a X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) In many places in xterm.c you have code like: #ifdef USE_GTK scale = xg_get_scale (f); #endif Sometimes scale is only used in GTK specific code and that's ok. But sometimes it's used in code that's not particular to GTK, for example: int scale = 1; #ifdef USE_GTK scale = xg_get_scale (f); #endif FRAME_CR_SURFACE (f) = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, scale * FRAME_PIXEL_WIDTH (f), scale * FRAME_PIXEL_HEIGHT (f)); Besides, there is x_get_scale_factor, also defined in xterm.c, which computes the scaling factor in a GTK-independent way, and also discriminates between x and y scaling factors. It's only used by x_draw_underwave. I would like to abstract both cases inside x_get_scale_factor, that would then use xg_get_scale if in GTK or compute just one scaling factor (for x or for y) otherwise. Notice that given that the scaling factor is the ratio of the effective resolution to a base resolution of 96 dpi *truncated down* to the nearest integer, AFAICS it's almost impossible to get different scaling factors for x and for y. What do you think? Best regards -- Carlos ------------=_1571179261-21258-1--