From unknown Sat Jun 21 12:28:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#37750] inputattach: Add baud rate option Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Oct 2019 17:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37750 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 37750@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157107424113285 (code B ref -1); Mon, 14 Oct 2019 17:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Oct 2019 17:30:41 +0000 Received: from localhost ([127.0.0.1]:41637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK4B6-0003SD-SI for submit@debbugs.gnu.org; Mon, 14 Oct 2019 13:30:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:36025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK4B2-0003S1-1f for submit@debbugs.gnu.org; Mon, 14 Oct 2019 13:30:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48942) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iK4Ax-0005G2-UW for guix-patches@gnu.org; Mon, 14 Oct 2019 13:30:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iK4Aw-0001ps-Mp for guix-patches@gnu.org; Mon, 14 Oct 2019 13:30:31 -0400 Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:41082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iK4Aw-0001oL-AE for guix-patches@gnu.org; Mon, 14 Oct 2019 13:30:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1571074227; bh=4KRBj3owTALJwbu/i9GXLgpm036QBLI9CcTFpLGL6rU=; h=From:To:Subject:Date:From:Subject; b=Pq51aqZi37UZhZN8jIgkivGdNla0cF4OTJlNYPkg1M8L+X5DJ5SF2H4FWhx1SoDqQbwXojpLFr5bbrG08wPKQVpQWU3ttW3zIjRQWIydZu8ukAUhHX5mT+0LTtLl6CHe0MXgVpIdnFxUMp0zMbvwtU9h5JBGyXF9STJiAbJ6cLownvM4qP6gAYgpaC2NCPU7Zd75FGcUSR1pPaLL2vuaXOJ3GU1lNoYnqsEXZ0AnxAqRaK0n9k/VEZ85U8PDTOhgkZRNBrg2AA3NHUT2cx9XAx4NL+xSFroKaRsdqmUS1No3fHSKR9/OgmEGU0N+9P+3kLfC+ybwMaXK5Ovx9iqRiA== X-YMail-OSG: Vl4t3jcVM1n3cz9QnTtACcuCErpxoXHzok.PoT40lVGJFlXLGnL2b0vVtze3.tG ZQMQRIdBgeFqDkfs2DrJSi09noOIH8btcLBdrUhvJK0zib_0iTt.70fBwDalY0Q9vkluJhkUX_QF fg4_W5KgjLgnD63ugw8BIUp8iCM9qMnyK8nJ_dUINPr7Q5phwGoMGJbmbF2RIxADAT_MUozb5SFA Ehd.qSaJa1J4NzRiodQzQW4tHapMXl1ZYSXx1HtAF44R74jUbZyOuPPFwXSAB6W.rHEwfJS8fZsd r0.oQ38grH3P9ADAa3MU51GedT1aHs1sGoUYW3ZlscGhDKyBAmu6N13ZKEHgeFXF0LUF83kH24aN IFcdtbansPp_EocbPv95fkYK8bCA48slrug6vp_F1RU6hEv3llmQrlWLV5KdAKXy.fqlbbuy62Vh _5zTyI1lBO0GJrH_PdZeqNt26iYBDT_y0dk2XjR7HHdXDL1e3ANRDn6KqGkWEcMTW34IgW1ejLX_ dCKRQW0Tbjfh4WVH3eKwdeWit1bAqbbsQAVq2f.v1wsIhCMbVXi1Fh8rDUmpBc4CevvK9X9O8yCK _3r3zVWoR4Xqu8QXB7ap9.mSHJn8xXO9dfYKvVGnrIc656FbOCfZod62bg4xH7R709oP_5lE_GUz R4yqyS463LJgGwQ1rEUNW6c8uZTWccVC5u2iUV7BeISIVm57kXY6Qys3VVLoowVtYrV2PN_7SJy. jjhUWgfuZIAgE_HWz.6zjWd7OPXDUqscZqroe7hGUcyck6jvQaZq6.voc5BolKs7rwR5xksMjxa1 W_JaZugP9Glv9CuJfI5ZH69KwkjIn.mL1Hn6sDgq4vx7l3ZR8Lh0r5xtbTdBKkGFdzqkzV3cfrXK hKsKnGH_3Ze33Q01AZods8JvSZHQev2fVEzpwFfMot6eARSjFe.eX0DpZMYxtjb12NI_SSbTXRIR YK9C4yS.CAXSv0Tn1XTxyVYWUhJ5upqa_bcpMYNS_yHyQP06sa8HmXfeezdzhM_YoxxqmwWE7PJ7 m7PZ9TA7Go277DJoz6HrC3O76t3TG0qF33qi4TKPhHMiT50TKCpr2UGREh95NhrNH9g_3sBGqBXT A6RwqtzCgOmacoyjt0RpxCjm_PPX8lFyHolYzxEi0Hiyc.IlkYhFjfgKZ8jhBFplqojRO4nuRbRb aHbtq8.MyMbrYXWbFv6V0BDNTIMJp_lFRIpEc98V3ErGtvFst00zL14BS8lIVneAnU4LIKQC7j23 _.V7M7c1lHeN0LNVhQGPfmN5EQK_gndgbo4_.rrJqxAveFcZPbaeQvBI- Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Mon, 14 Oct 2019 17:30:27 +0000 Received: by smtp416.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 419398f357d79d643817649e4361e83f; Mon, 14 Oct 2019 17:30:23 +0000 (UTC) User-agent: mu4e 1.2.0; emacs 26.3 From: Tim Gesthuizen Date: Mon, 14 Oct 2019 19:30:22 +0200 Message-ID: <87d0ezb5g1.fsf@yahoo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 87.248.110.84 X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Hi Guix, The attached patch adds a baud-rate option to the inputattach-service which is needed for some devices. It would be nice if someone could review and commit if the patch is fine. Tim. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-baud-rate-parameter-to-inputattach-service.patch >From 29bf34ead05c47a1d045dd60185c803dd6af204a Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Thu, 10 Oct 2019 18:38:36 +0200 Subject: [PATCH] gnu: Add baud-rate parameter to inputattach-service * gnu/services/desktop.scm (inputattach-configuration): Add baud-rate field. (inputattach-shepherd-service): Add baud-rate to parameters when specified. --- gnu/services/desktop.scm | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index a32756e040..35320bdde2 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -1021,23 +1021,31 @@ as expected."))) (default "wacom")) (device inputattach-configuration-device (default "/dev/ttyS0")) + (baud-rate inputattach-configuration-baud-rate + (default #f)) (log-file inputattach-configuration-log-file (default #f))) (define inputattach-shepherd-service (match-lambda - (($ type device log-file) - (list (shepherd-service - (provision '(inputattach)) - (requirement '(udev)) - (documentation "inputattach daemon") - (start #~(make-forkexec-constructor - (list (string-append #$inputattach - "/bin/inputattach") - (string-append "--" #$type) - #$device) - #:log-file #$log-file)) - (stop #~(make-kill-destructor))))))) + (($ type device baud-rate log-file) + (let ((args (append (if baud-rate + (if (number? baud-rate) + (list "--baud-rate" (number->string baud-rate)) + (error "Expected baud-rate to be a number or #f" baud-rate)) + '()) + (list (string-append "--" type) + device)))) + (list (shepherd-service + (provision '(inputattach)) + (requirement '(udev)) + (documentation "inputattach daemon") + (start #~(make-forkexec-constructor + (cons (string-append #$inputattach + "/bin/inputattach") + (quote #$args)) + #:log-file #$log-file)) + (stop #~(make-kill-destructor)))))))) (define inputattach-service-type (service-type -- 2.23.0 --=-=-=-- From unknown Sat Jun 21 12:28:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#37750] Fixup: Documentation References: <87d0ezb5g1.fsf@yahoo.de> In-Reply-To: <87d0ezb5g1.fsf@yahoo.de> Resent-From: Tim Gesthuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Oct 2019 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37750 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 37750@debbugs.gnu.org Received: via spool by 37750-submit@debbugs.gnu.org id=B37750.157107586816079 (code B ref 37750); Mon, 14 Oct 2019 17:58:01 +0000 Received: (at 37750) by debbugs.gnu.org; 14 Oct 2019 17:57:48 +0000 Received: from localhost ([127.0.0.1]:41661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK4bL-0004BE-Sb for submit@debbugs.gnu.org; Mon, 14 Oct 2019 13:57:48 -0400 Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:37922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK4bH-0004Ar-68 for 37750@debbugs.gnu.org; Mon, 14 Oct 2019 13:57:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1571075855; bh=Nv8czOM5qr6hUofnNwwMUNO6Yc9o98qellc4a9Jom0A=; h=From:To:Subject:Date:From:Subject; b=jZ68d9iss90oBW1GU41ShvU/4jV3q1Z/ynxRKa25AzElzR/um7HROV17ZS56PEDjqh083eVUwJ1Cvemd/I9Wtgz48d3SUyUGvxqHdZBA6olb6lEkiRfPg9CiwiTvrRuaZEZXS2YgLP7dFladqrPYSVUL1k6N2E4/wedgrzCHwGDr12hwDVCZD610LLiWOGuJjTc4CQlK/xEt2kPdVw+v+iz+f83a3w30l1Cz2k1mYdFvygQfg2aSPkIyM7AIlw6+QaJ4QMcXdBxuPOSiEquCmGuPk6TrfDQGE2+v+cVcHuro/OOdRn7hpnQZqd/mmEmaun9cmy/Fw2sTY4TCbwivBw== X-YMail-OSG: fX6fRtYVM1lCrBw3CTMSywGSG2OYSif98DNBhZlryO3xAXWlGCsNcLb7BlFoTap fdJFW42rNg7lm8VLNRYkJviovsrGcAEmkiOi3HPp6CrN4P_yCGj1QCPRrgfXCmDrwxv6BfX72MAW RzfkjunN3oYjgaD11KWylcdst0Q0z8L1sZodFZ59kuCznkoKc2wGMIXf5r9E9d4F47XN_G8NO87H 1nWIrSSEjz3eYSh_QCen4wxDHjAcRXwphnftkOZVP9MP.LG8N4Kv_6M5RPfWBiYYLXNiwhHw_nup bv7iu2KXHdKyA5hh0gMwOMOU8dx3.QMHL515Wt0EMEMV95CkuJwslsRUxDqCEigPm3baKe7Zma2P 4AYf6Hk6j.k.uNgDPK9txCDERbwRZ_hBTC7zZs9PoNcgFX2phNl7bkK2nBQiqHXEnpwJMpEWKDI4 SeNsZSDMpN7Gw8H0mEbNTK_olEZFfYshOWGttpHOzbz7eJKYZdqdZxHSBZ66kOdLa_XhNs1ZRHQ7 0.GZlRYhEpls8Sck3m1Lw1FmQM..kO5noBeDmxzOhTn7uNrFLc5ZycWFSmuz5eUtSPsOp.BsFrcH a.VIIbfM6JndrnCwRLNFVZjShNAvcxRKrDKFoO3McfhAsHPlBZ3HX8OxFqx08Jmr6omXYC_Smu0n SawOVaPUbWDmVKroLUxufAMr5ugZymVWo0TC8xgPIrJT6jIMxicyB8Ef2UnHneBnA_lQ2218iPQS ktBqv2KUMJq2zaeQ0naZ0gBkcnxEpGQ8c9dIw6vZKtb0GQTvCCjR5luY.EALOZvFy4r4wdlF2nH9 W5Jj5eFWd0qvy9M_az0tDOtZ8.hqWWC.3aRgmXBVEg7rxMv24vsGYjg_poTVmFIOYhkHQyTMY8L4 c9ZYzMnrvurYh3k9P2xVw7izvIjof2szCheeIRqNlHvTekEdll34aYSH6HTWNlRK.VHDZw0yS.Ft plbAXMR3wnSQicib51igFlcTPfLzEmp6hAPGGdRjUJJAVS1RqRfFK6c9l4xBBQvDR0jgZacslJUc RHxcZcnF0tvCN4WkUVobnzu6y3m5eVZ2fIYOjjksxETBetxQAfhnw3entW5hZaeeUdno1MeMqekF 1_h9fRA6sKdVfg5IKcYMtB.1PLMqUxiRUeNrTQsKysTsFyTu_Ldj6LxV_qpVwZxvTJqrzUH.aayk T.vPaIMVM8dx5zCCj.g6YaH4I2L9eJUBDxJZSl..TqDgleHaBmVBs6MmRmnf.8eHC58cbySFprYm 6KG5m90YyEQI38S8tTycC637DgNB.O4GzbBhozWwJbbpa0E26alwCYHo- Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Mon, 14 Oct 2019 17:57:35 +0000 Received: by smtp412.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID c79c9e08e4aedc257d80304138496653; Mon, 14 Oct 2019 17:57:30 +0000 (UTC) User-agent: mu4e 1.2.0; emacs 26.3 From: Tim Gesthuizen Date: Mon, 14 Oct 2019 19:57:29 +0200 Message-ID: <87blujb46u.fsf@yahoo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Of course there is also documentation for the new parameter which I missed to send. You find an updated patch attached. Sorry for the hassle, Tim. From 544ae60c79134be980d6ee0430deb6abe4cad8ca Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Thu, 10 Oct 2019 18:38:36 +0200 Subject: [PATCH] gnu: Add baud-rate parameter to inputattach-service Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: yahoo.de] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [87.248.110.84 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [87.248.110.84 listed in list.dnswl.org] 0.0 T_SPF_TEMPERROR SPF: test of record failed (temperror) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tim.gesthuizen[at]yahoo.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 SPOOFED_FREEMAIL No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Of course there is also documentation for the new parameter which I missed to send. You find an updated patch attached. Sorry for the hassle, Tim. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-baud-rate-parameter-to-inputattach-service.patch >From 544ae60c79134be980d6ee0430deb6abe4cad8ca Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Thu, 10 Oct 2019 18:38:36 +0200 Subject: [PATCH] gnu: Add baud-rate parameter to inputattach-service * gnu/services/desktop.scm (inputattach-configuration): Add baud-rate field. (inputattach-shepherd-service): Add baud-rate to parameters when specified. * doc/guix.texi (Miscellaneous Services): [inputattach Service] Document baud-rate parameter. --- doc/guix.texi | 4 ++++ gnu/services/desktop.scm | 32 ++++++++++++++++++++------------ 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 6703c2756c..e53a708df2 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -24549,6 +24549,10 @@ The type of device to connect to. Run @command{inputattach --help}, from the @item @code{device} (default: @code{"/dev/ttyS0"}) The device file to connect to the device. +@item @code{baud-rate} (default: @code{#f}) +Baud rate to use for the serial connection. +Should be a number or @code{#f}. + @item @code{log-file} (default: @code{#f}) If true, this must be the name of a file to log messages to. @end table diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index a32756e040..35320bdde2 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -1021,23 +1021,31 @@ as expected."))) (default "wacom")) (device inputattach-configuration-device (default "/dev/ttyS0")) + (baud-rate inputattach-configuration-baud-rate + (default #f)) (log-file inputattach-configuration-log-file (default #f))) (define inputattach-shepherd-service (match-lambda - (($ type device log-file) - (list (shepherd-service - (provision '(inputattach)) - (requirement '(udev)) - (documentation "inputattach daemon") - (start #~(make-forkexec-constructor - (list (string-append #$inputattach - "/bin/inputattach") - (string-append "--" #$type) - #$device) - #:log-file #$log-file)) - (stop #~(make-kill-destructor))))))) + (($ type device baud-rate log-file) + (let ((args (append (if baud-rate + (if (number? baud-rate) + (list "--baud-rate" (number->string baud-rate)) + (error "Expected baud-rate to be a number or #f" baud-rate)) + '()) + (list (string-append "--" type) + device)))) + (list (shepherd-service + (provision '(inputattach)) + (requirement '(udev)) + (documentation "inputattach daemon") + (start #~(make-forkexec-constructor + (cons (string-append #$inputattach + "/bin/inputattach") + (quote #$args)) + #:log-file #$log-file)) + (stop #~(make-kill-destructor)))))))) (define inputattach-service-type (service-type -- 2.23.0 --=-=-=-- From unknown Sat Jun 21 12:28:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tim Gesthuizen Subject: bug#37750: closed (Re: [bug#37750] Fixup: Documentation) Message-ID: References: <875zkhzu5o.fsf@gnu.org> <87d0ezb5g1.fsf@yahoo.de> X-Gnu-PR-Message: they-closed 37750 X-Gnu-PR-Package: guix-patches Reply-To: 37750@debbugs.gnu.org Date: Mon, 21 Oct 2019 21:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1571691962-20341-1" This is a multi-part message in MIME format... ------------=_1571691962-20341-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #37750: inputattach: Add baud rate option which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 37750@debbugs.gnu.org. --=20 37750: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37750 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1571691962-20341-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 37750-done) by debbugs.gnu.org; 21 Oct 2019 21:05:34 +0000 Received: from localhost ([127.0.0.1]:57975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMeru-0005H9-G9 for submit@debbugs.gnu.org; Mon, 21 Oct 2019 17:05:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMers-0005Gq-7l for 37750-done@debbugs.gnu.org; Mon, 21 Oct 2019 17:05:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMerm-0001gX-C6; Mon, 21 Oct 2019 17:05:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52898 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMerl-0000IS-Mp; Mon, 21 Oct 2019 17:05:26 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tim Gesthuizen Subject: Re: [bug#37750] Fixup: Documentation References: <87d0ezb5g1.fsf@yahoo.de> <87blujb46u.fsf@yahoo.de> Date: Mon, 21 Oct 2019 23:05:23 +0200 In-Reply-To: <87blujb46u.fsf@yahoo.de> (Tim Gesthuizen's message of "Mon, 14 Oct 2019 19:57:29 +0200") Message-ID: <875zkhzu5o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37750-done Cc: 37750-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Tim, Tim Gesthuizen skribis: >>>From 544ae60c79134be980d6ee0430deb6abe4cad8ca Mon Sep 17 00:00:00 2001 > From: Tim Gesthuizen > Date: Thu, 10 Oct 2019 18:38:36 +0200 > Subject: [PATCH] gnu: Add baud-rate parameter to inputattach-service > > * gnu/services/desktop.scm (inputattach-configuration): Add baud-rate fie= ld. > (inputattach-shepherd-service): Add baud-rate to parameters when specif= ied. > * doc/guix.texi (Miscellaneous Services): [inputattach Service] Document > baud-rate parameter. Neat. I took the liberty to apply it with the minor change below (we don=E2=80=99t usually call =E2=80=98error=E2=80=99; eventually I think we s= hould use contracts =C3=A0 la Racket in such situations.) Thanks! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index 20e89c0dea..08acb79ed6 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -1037,9 +1037,7 @@ as expected."))) (match-lambda (($ type device baud-rate log-file) (let ((args (append (if baud-rate - (if (number? baud-rate) - (list "--baud-rate" (number->string baud-rate)) - (error "Expected baud-rate to be a number or #f" baud-rate)) + (list "--baud-rate" (number->string baud-rate)) '()) (list (string-append "--" type) device)))) --=-=-=-- ------------=_1571691962-20341-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Oct 2019 17:30:41 +0000 Received: from localhost ([127.0.0.1]:41637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK4B6-0003SD-SI for submit@debbugs.gnu.org; Mon, 14 Oct 2019 13:30:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:36025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK4B2-0003S1-1f for submit@debbugs.gnu.org; Mon, 14 Oct 2019 13:30:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48942) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iK4Ax-0005G2-UW for guix-patches@gnu.org; Mon, 14 Oct 2019 13:30:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iK4Aw-0001ps-Mp for guix-patches@gnu.org; Mon, 14 Oct 2019 13:30:31 -0400 Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:41082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iK4Aw-0001oL-AE for guix-patches@gnu.org; Mon, 14 Oct 2019 13:30:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1571074227; bh=4KRBj3owTALJwbu/i9GXLgpm036QBLI9CcTFpLGL6rU=; h=From:To:Subject:Date:From:Subject; b=Pq51aqZi37UZhZN8jIgkivGdNla0cF4OTJlNYPkg1M8L+X5DJ5SF2H4FWhx1SoDqQbwXojpLFr5bbrG08wPKQVpQWU3ttW3zIjRQWIydZu8ukAUhHX5mT+0LTtLl6CHe0MXgVpIdnFxUMp0zMbvwtU9h5JBGyXF9STJiAbJ6cLownvM4qP6gAYgpaC2NCPU7Zd75FGcUSR1pPaLL2vuaXOJ3GU1lNoYnqsEXZ0AnxAqRaK0n9k/VEZ85U8PDTOhgkZRNBrg2AA3NHUT2cx9XAx4NL+xSFroKaRsdqmUS1No3fHSKR9/OgmEGU0N+9P+3kLfC+ybwMaXK5Ovx9iqRiA== X-YMail-OSG: Vl4t3jcVM1n3cz9QnTtACcuCErpxoXHzok.PoT40lVGJFlXLGnL2b0vVtze3.tG ZQMQRIdBgeFqDkfs2DrJSi09noOIH8btcLBdrUhvJK0zib_0iTt.70fBwDalY0Q9vkluJhkUX_QF fg4_W5KgjLgnD63ugw8BIUp8iCM9qMnyK8nJ_dUINPr7Q5phwGoMGJbmbF2RIxADAT_MUozb5SFA Ehd.qSaJa1J4NzRiodQzQW4tHapMXl1ZYSXx1HtAF44R74jUbZyOuPPFwXSAB6W.rHEwfJS8fZsd r0.oQ38grH3P9ADAa3MU51GedT1aHs1sGoUYW3ZlscGhDKyBAmu6N13ZKEHgeFXF0LUF83kH24aN IFcdtbansPp_EocbPv95fkYK8bCA48slrug6vp_F1RU6hEv3llmQrlWLV5KdAKXy.fqlbbuy62Vh _5zTyI1lBO0GJrH_PdZeqNt26iYBDT_y0dk2XjR7HHdXDL1e3ANRDn6KqGkWEcMTW34IgW1ejLX_ dCKRQW0Tbjfh4WVH3eKwdeWit1bAqbbsQAVq2f.v1wsIhCMbVXi1Fh8rDUmpBc4CevvK9X9O8yCK _3r3zVWoR4Xqu8QXB7ap9.mSHJn8xXO9dfYKvVGnrIc656FbOCfZod62bg4xH7R709oP_5lE_GUz R4yqyS463LJgGwQ1rEUNW6c8uZTWccVC5u2iUV7BeISIVm57kXY6Qys3VVLoowVtYrV2PN_7SJy. jjhUWgfuZIAgE_HWz.6zjWd7OPXDUqscZqroe7hGUcyck6jvQaZq6.voc5BolKs7rwR5xksMjxa1 W_JaZugP9Glv9CuJfI5ZH69KwkjIn.mL1Hn6sDgq4vx7l3ZR8Lh0r5xtbTdBKkGFdzqkzV3cfrXK hKsKnGH_3Ze33Q01AZods8JvSZHQev2fVEzpwFfMot6eARSjFe.eX0DpZMYxtjb12NI_SSbTXRIR YK9C4yS.CAXSv0Tn1XTxyVYWUhJ5upqa_bcpMYNS_yHyQP06sa8HmXfeezdzhM_YoxxqmwWE7PJ7 m7PZ9TA7Go277DJoz6HrC3O76t3TG0qF33qi4TKPhHMiT50TKCpr2UGREh95NhrNH9g_3sBGqBXT A6RwqtzCgOmacoyjt0RpxCjm_PPX8lFyHolYzxEi0Hiyc.IlkYhFjfgKZ8jhBFplqojRO4nuRbRb aHbtq8.MyMbrYXWbFv6V0BDNTIMJp_lFRIpEc98V3ErGtvFst00zL14BS8lIVneAnU4LIKQC7j23 _.V7M7c1lHeN0LNVhQGPfmN5EQK_gndgbo4_.rrJqxAveFcZPbaeQvBI- Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Mon, 14 Oct 2019 17:30:27 +0000 Received: by smtp416.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 419398f357d79d643817649e4361e83f; Mon, 14 Oct 2019 17:30:23 +0000 (UTC) User-agent: mu4e 1.2.0; emacs 26.3 From: Tim Gesthuizen To: guix-patches@gnu.org Subject: inputattach: Add baud rate option Date: Mon, 14 Oct 2019 19:30:22 +0200 Message-ID: <87d0ezb5g1.fsf@yahoo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 87.248.110.84 X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Hi Guix, The attached patch adds a baud-rate option to the inputattach-service which is needed for some devices. It would be nice if someone could review and commit if the patch is fine. Tim. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-baud-rate-parameter-to-inputattach-service.patch >From 29bf34ead05c47a1d045dd60185c803dd6af204a Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Thu, 10 Oct 2019 18:38:36 +0200 Subject: [PATCH] gnu: Add baud-rate parameter to inputattach-service * gnu/services/desktop.scm (inputattach-configuration): Add baud-rate field. (inputattach-shepherd-service): Add baud-rate to parameters when specified. --- gnu/services/desktop.scm | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index a32756e040..35320bdde2 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -1021,23 +1021,31 @@ as expected."))) (default "wacom")) (device inputattach-configuration-device (default "/dev/ttyS0")) + (baud-rate inputattach-configuration-baud-rate + (default #f)) (log-file inputattach-configuration-log-file (default #f))) (define inputattach-shepherd-service (match-lambda - (($ type device log-file) - (list (shepherd-service - (provision '(inputattach)) - (requirement '(udev)) - (documentation "inputattach daemon") - (start #~(make-forkexec-constructor - (list (string-append #$inputattach - "/bin/inputattach") - (string-append "--" #$type) - #$device) - #:log-file #$log-file)) - (stop #~(make-kill-destructor))))))) + (($ type device baud-rate log-file) + (let ((args (append (if baud-rate + (if (number? baud-rate) + (list "--baud-rate" (number->string baud-rate)) + (error "Expected baud-rate to be a number or #f" baud-rate)) + '()) + (list (string-append "--" type) + device)))) + (list (shepherd-service + (provision '(inputattach)) + (requirement '(udev)) + (documentation "inputattach daemon") + (start #~(make-forkexec-constructor + (cons (string-append #$inputattach + "/bin/inputattach") + (quote #$args)) + #:log-file #$log-file)) + (stop #~(make-kill-destructor)))))))) (define inputattach-service-type (service-type -- 2.23.0 --=-=-=-- ------------=_1571691962-20341-1--