GNU bug report logs - #37745
(save-window-excursion (shell) (buffer-name (current-buffer)))

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37745 in the body.
You can then email your comments to 37745 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eduardo Ochs <eduardoochs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: (save-window-excursion (shell) (buffer-name (current-buffer)))
Date: Mon, 14 Oct 2019 04:55:53 -0300

[Message part 1 (text/plain, inline)]

In many versions of Emacs the sexp below

  (save-window-excursion (shell) (buffer-name (current-buffer)))

returns "*shell*", but in some recent versions it returns the name of
the current buffer instead.

Let me be more precise. I ran the sexp below in the versions of Emacs
that I have in my machine,

  (list emacs-version
    (save-window-excursion (shell) (buffer-name (current-buffer)))
    )

and collected the outputs, and got:

  ("24.5.1" "*shell*")
  ("25.1.1" "*shell*")
  ("26.3" "*shell*")
  ("27.0.50" "TODO")

Here's the exact version of my "27.0.50". The output of

  PAGER=cat git log -1 --format=format:"%H%n%cd%n"

was:

  01ea96b5548a80e6aabc69428439113ce0a8c17e
  Mon Oct 14 08:47:02 2019 +0200

I don't know (yet) how to bisect versions to find exactly when the
behavior changed, sorry... btw, this is a Debian box (on amd64).

  Cheers,
    Eduardo Ochs
    http://angg.twu.net/#eev

[Message part 2 (text/html, inline)]

Message #8 received at 37745 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eduardo Ochs <eduardoochs <at> gmail.com>
Cc: 37745 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#37745: (save-window-excursion (shell) (buffer-name
 (current-buffer)))
Date: Thu, 17 Oct 2019 05:03:25 +0200

Eduardo Ochs <eduardoochs <at> gmail.com> writes:

> In many versions of Emacs the sexp below
>
>   (save-window-excursion (shell) (buffer-name (current-buffer)))
>
> returns "*shell*", but in some recent versions it returns the name of
> the current buffer instead.

This seems to be introduced by 

commit 59191cd0cbe8463f9095a71cb4048bb138d6e446
Author: Michael Albinus <michael.albinus <at> gmx.de>
Date:   Sun Apr 2 11:02:54 2017 +0200

    Apply connecion-local variables for shells
    
if I read the log right.

It wraps the `pop-to-buffer' in a `(with-current-buffer buffer', so
current-buffer doesn't change like it used to.

Michael?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 37745 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Eduardo Ochs <eduardoochs <at> gmail.com>
Cc: 37745 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#37745: (save-window-excursion (shell) (buffer-name
 (current-buffer)))
Date: Thu, 17 Oct 2019 10:26:42 +0200

>> In many versions of Emacs the sexp below
>>
>>    (save-window-excursion (shell) (buffer-name (current-buffer)))
>>
>> returns "*shell*", but in some recent versions it returns the name of
>> the current buffer instead.
>
> This seems to be introduced by
>
> commit 59191cd0cbe8463f9095a71cb4048bb138d6e446
> Author: Michael Albinus <michael.albinus <at> gmx.de>
> Date:   Sun Apr 2 11:02:54 2017 +0200
>
>      Apply connecion-local variables for shells
>
> if I read the log right.
>
> It wraps the `pop-to-buffer' in a `(with-current-buffer buffer', so
> current-buffer doesn't change like it used to.

Why can't you simply use (buffer-name (shell)) instead?

martin

Message #14 received at 37745 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 37745 <at> debbugs.gnu.org,
 Eduardo Ochs <eduardoochs <at> gmail.com>
Subject: Re: bug#37745: (save-window-excursion (shell) (buffer-name
 (current-buffer)))
Date: Thu, 17 Oct 2019 18:50:00 +0200

martin rudalics <rudalics <at> gmx.at> writes:

>>> In many versions of Emacs the sexp below
>>>
>>>    (save-window-excursion (shell) (buffer-name (current-buffer)))
>>>
>>> returns "*shell*", but in some recent versions it returns the name of
>>> the current buffer instead.
>>
>> This seems to be introduced by
>>
>> commit 59191cd0cbe8463f9095a71cb4048bb138d6e446
>> Author: Michael Albinus <michael.albinus <at> gmx.de>
>> Date:   Sun Apr 2 11:02:54 2017 +0200
>>
>>      Apply connecion-local variables for shells
>>
>> if I read the log right.
>>
>> It wraps the `pop-to-buffer' in a `(with-current-buffer buffer', so
>> current-buffer doesn't change like it used to.
>
> Why can't you simply use (buffer-name (shell)) instead?

That's possible, of course.

However, `shell' has always made the shell buffer current. It was an
oversight by me to change this.

I've added this behavior to the docstring of `shell', and fixed
this. Committed to master.

> martin

Best regards, Michael.

Message #17 received at 37745 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 37745 <at> debbugs.gnu.org,
 Eduardo Ochs <eduardoochs <at> gmail.com>
Subject: Re: bug#37745: (save-window-excursion (shell) (buffer-name
 (current-buffer)))
Date: Sun, 27 Oct 2019 09:42:18 +0100

Version: 27.1

Michael Albinus <michael.albinus <at> gmx.de> writes:

> I've added this behavior to the docstring of `shell', and fixed
> this. Committed to master.

No further complaints, so I'm closing this bug.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.