GNU bug report logs - #37730
[PATCH] Topologically sort recursively-imported packages

Previous Next

Full log

View this message in rfc822 format

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Brian Leung <bkleung89 <at> gmail.com>, 37730-done <at> debbugs.gnu.org
Subject: [bug#37730] [PATCH] Topologically sort recursively-imported packages
Date: Thu, 12 Dec 2019 16:15:01 +0100

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Brian,
>
> Brian Leung <bkleung89 <at> gmail.com> skribis:
>
>>> If that’s fine with you, I’d be willing to apply this patch, and then
>>> apply other bits of your patch (the tests and stream removal) on top of
>>> it.  How does that sound?
>>
>> Sure, your patch seems clearer to me.
>
> I pushed patches that combine mine and yours:
>
>   4982de4c32 import: crate: Add recursive import test.
>   70a8e13277 import: utils: 'recursive-import' returns a list rather than a stream.
>   ddd5915900 import: utils: 'recursive-import' returns packages in topological order.

Thank you!

> Let me know if you notice anything wrong!

I believe the docstring of RECURSIVE-IMPORT in (guix import utils) needs
to be adjusted.  It still refers to streams.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.