GNU bug report logs - #37730
[PATCH] Topologically sort recursively-imported packages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brian Leung <bkleung89 <at> gmail.com>
Subject: bug#37730: closed (Re: [bug#37730] [PATCH] Topologically sort
 recursively-imported packages)
Date: Wed, 11 Dec 2019 13:02:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#37730: [PATCH] Topologically sort recursively-imported packages

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 37730 <at> debbugs.gnu.org.

-- 
37730: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37730
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 37730-done <at> debbugs.gnu.org
Subject: Re: [bug#37730] [PATCH] Topologically sort recursively-imported
 packages
Date: Wed, 11 Dec 2019 12:26:12 +0100

Hi Brian,

Brian Leung <bkleung89 <at> gmail.com> skribis:

>> If that’s fine with you, I’d be willing to apply this patch, and then
>> apply other bits of your patch (the tests and stream removal) on top of
>> it.  How does that sound?
>
> Sure, your patch seems clearer to me.

I pushed patches that combine mine and yours:

  4982de4c32 import: crate: Add recursive import test.
  70a8e13277 import: utils: 'recursive-import' returns a list rather than a stream.
  ddd5915900 import: utils: 'recursive-import' returns packages in topological order.

Let me know if you notice anything wrong!

Thank you,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Brian Leung <bkleung89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Topologically sort recursively-imported packages
Date: Sun, 13 Oct 2019 00:37:59 -0700

[Message part 4 (text/plain, inline)]

Hi Guix,

Attached is a patch modifying the recursive importer in utils.scm.

Thanks,
Brian

[Message part 5 (text/html, inline)]

[0001-guix-utils-Topologically-sort-recursively-imported-r.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.