GNU bug report logs - #37730
[PATCH] Topologically sort recursively-imported packages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37730: closed ([PATCH] Topologically sort recursively-imported
 packages)
Date: Wed, 11 Dec 2019 13:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 11 Dec 2019 12:26:12 +0100
with message-id <87pngvje7f.fsf <at> gnu.org>
and subject line Re: [bug#37730] [PATCH] Topologically sort recursively-imported packages
has caused the debbugs.gnu.org bug report #37730,
regarding [PATCH] Topologically sort recursively-imported packages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37730: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37730
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brian Leung <bkleung89 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Topologically sort recursively-imported packages
Date: Sun, 13 Oct 2019 00:37:59 -0700

[Message part 3 (text/plain, inline)]

Hi Guix,

Attached is a patch modifying the recursive importer in utils.scm.

Thanks,
Brian

[Message part 4 (text/html, inline)]

[0001-guix-utils-Topologically-sort-recursively-imported-r.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brian Leung <bkleung89 <at> gmail.com>
Cc: 37730-done <at> debbugs.gnu.org
Subject: Re: [bug#37730] [PATCH] Topologically sort recursively-imported
 packages
Date: Wed, 11 Dec 2019 12:26:12 +0100

Hi Brian,

Brian Leung <bkleung89 <at> gmail.com> skribis:

>> If that’s fine with you, I’d be willing to apply this patch, and then
>> apply other bits of your patch (the tests and stream removal) on top of
>> it.  How does that sound?
>
> Sure, your patch seems clearer to me.

I pushed patches that combine mine and yours:

  4982de4c32 import: crate: Add recursive import test.
  70a8e13277 import: utils: 'recursive-import' returns a list rather than a stream.
  ddd5915900 import: utils: 'recursive-import' returns packages in topological order.

Let me know if you notice anything wrong!

Thank you,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.