GNU bug report logs - #37720
[PATCH 0/2] gnu: easytag: Fix mp3 support.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37720: closed ([PATCH 0/2] gnu: easytag: Fix mp3 support.)
Date: Sun, 13 Oct 2019 12:10:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 13 Oct 2019 14:09:24 +0200
with message-id <20191013140924.0e966e3f <at> scratchpost.org>
and subject line Re: [bug#37720] [PATCH 0/2] gnu: easytag: Fix mp3 support.
has caused the debbugs.gnu.org bug report #37720,
regarding [PATCH 0/2] gnu: easytag: Fix mp3 support.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37720: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37720
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: guix-patches <at> gnu.org
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>
Subject: [PATCH 0/2] gnu: easytag: Fix mp3 support.
Date: Sat, 12 Oct 2019 22:25:31 +0100

Hello Guix!

EasyTag hasn't been working for mp3 files and I couldn't work out why for a
long time. I've finally got around to looking into it properly and it turns
the hack with the temporary .pc file I added back then didn't work because
it's missing some fields.

With that fixed though, EasyTag warns you with a popup that id3lib is buggy
and needs patching. It's something about UTF16 being broken:
https://sourceforge.net/p/id3lib/patches/64/, I checked, ArchLinux also
applies the same patch.

WDYT?

Pierre Langlois (2):
  gnu: id3lib: Apply patch for UTF16 writing bug.
  gnu: easytag: Fix mp3 support.

 gnu/local.mk                                  |  1 +
 gnu/packages/mp3.scm                          |  5 ++-
 gnu/packages/music.scm                        | 12 ++++--
 .../patches/id3lib-UTF16-writing-bug.patch    | 39 +++++++++++++++++++
 4 files changed, 52 insertions(+), 5 deletions(-)
 create mode 100644 gnu/packages/patches/id3lib-UTF16-writing-bug.patch

--
2.23.0

[Message part 3 (message/rfc822, inline)]

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 37720-done <at> debbugs.gnu.org
Subject: Re: [bug#37720] [PATCH 0/2] gnu: easytag: Fix mp3 support.
Date: Sun, 13 Oct 2019 14:09:24 +0200

[Message part 4 (text/plain, inline)]

Hi Pierre,

On Sat, 12 Oct 2019 22:25:31 +0100
Pierre Langlois <pierre.langlois <at> gmx.com> wrote:

> WDYT?

Looks good to me, so I pushed the patchset to guix master.

(It's unfortunately that char signedness is unspecified in the C standard.
That maybe made sense in 1980--not today.  Sigh)

[Message part 5 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.