From unknown Tue Aug 19 09:35:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37720 <37720@debbugs.gnu.org> To: bug#37720 <37720@debbugs.gnu.org> Subject: Status: [PATCH 0/2] gnu: easytag: Fix mp3 support. Reply-To: bug#37720 <37720@debbugs.gnu.org> Date: Tue, 19 Aug 2025 16:35:02 +0000 retitle 37720 [PATCH 0/2] gnu: easytag: Fix mp3 support. reassign 37720 guix-patches submitter 37720 Pierre Langlois severity 37720 normal tag 37720 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 17:25:52 2019 Received: (at submit) by debbugs.gnu.org; 12 Oct 2019 21:25:52 +0000 Received: from localhost ([127.0.0.1]:34361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJOta-0004nt-7H for submit@debbugs.gnu.org; Sat, 12 Oct 2019 17:25:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:50120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJOtW-0004nj-4r for submit@debbugs.gnu.org; Sat, 12 Oct 2019 17:25:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33896) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJOtU-0001p4-Qz for guix-patches@gnu.org; Sat, 12 Oct 2019 17:25:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_05,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJOtR-000331-1r for guix-patches@gnu.org; Sat, 12 Oct 2019 17:25:44 -0400 Received: from mout.gmx.net ([212.227.17.20]:45161) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJOtP-0002zd-VM for guix-patches@gnu.org; Sat, 12 Oct 2019 17:25:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570915533; bh=cb/kEPX16T8dsMzYEywV4dDHuYia6AukbgdDHsr6ZAQ=; h=X-UI-Sender-Class:From:To:Subject:CC:Date; b=On/7b/ZV6Lq5h/QuKmJCf2vebzEMlGhVNei4E2oYzYZoDPOXbk26fvlYqBgYsb0ao BRxktSCtYFQ5PgfCO5h8MTXsXRT9EHrbq8ulpUhxG9F4DDgKRz8PjZckEksQBFTcha 7MAD5D/lw/GItApesWQZKkIsZhjjDVBw92uRIMQQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([2.99.192.73]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MQe5u-1iftYh0ypC-00NeeF; Sat, 12 Oct 2019 23:25:33 +0200 User-agent: mu4e 1.2.0; emacs 26.3 From: Pierre Langlois To: guix-patches@gnu.org Subject: [PATCH 0/2] gnu: easytag: Fix mp3 support. Date: Sat, 12 Oct 2019 22:25:31 +0100 Message-ID: <87tv8dy7uc.fsf@gmx.com> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:z+OkpGwGX1bgQQASaVxBqjwhpNX4RCpf4ltLUXjUkXUpCb3y3rk HN9svobZW6FYuRmclrMUf2ZEX2DEmLZCcedVxQ8NUmsq17MSOZl24iIg1lU8axlGHsccmav /daNcDzvSBUm74W/VyhOWnqVN0caWiw/lMJB4MDjjwgqS4SN/xman67qCL1m2wrfnXzfcHv z7R24GbcaGvTHA0xQFe6g== X-UI-Out-Filterresults: notjunk:1;V03:K0:LLl4db8FzzQ=:L9ffR/C7V/5vwJWeYv88XH lSYhK5KN03+s9FXA8fi3EMufYWYRy5XKfhd6VZUnxAv2HApc7GkJQz8R9WIomsehZBeLogNUM QLTs+WNcoRPextLd19B8ZgVxSsLtFgjY8gh4HPZGVlE6I/Rm8Ft5AqVkOfJ4wcvgQLr3w01LI HRXQotUBSBWFNhPEg3xBKRmVJbUX63UaBpDXjlqMZswsSEWd32WD9clnDAQrxkLii3LRFUY60 I9UE/VKbmOQRSO3yeUfZskvDmZhitPbl3Ze2X3NfJcfEm7iDHz9TgL4O4KiO8olZaDz94MJ9s Y2Z5CbFcngrIASwyZoiDsdNNDLN1VALfs5XhfaHXJa/P6kH0ezQso/y2GO8ugfRvyE96dc5DQ ZEBLitB/djEcXcK+JZ5vv5WU6DHCike8NtBEMvGDoB9jmTbsaSQUJJzNlMuyaK4LNgw1Poulh qEHdOkB3JM1yu3++nDn2FTnKe/JRM5vK1ysENGEAvy13DZvZ6+N2/oMPnOQb5ppA8H20XDuuG JLD6DNxYkTwtXdU0Lm6lmdH+O+OF3Nm8Fp4bQmDrX9kG/ArDUBgXzSge5bP8zDj8ooUIAtBg0 UCj35tIA/zWavUARRDhVkDfotekodVWnUJ42FyNxxSWCB5sB/MzXqzZCmFSU+GtuAxWVu7iqv joyuxNKtnm5PzIzNVIRJGEY1nzA1xh83Xn2wpn43CdG+G9VGrPpnBTAJJtp+swDJ8vEzxzcsx GylFCLQmjhY5YGKWwefCaRxhnBNgqHeV3Y1C5gWz6KZJZMiBvFbfJ6F3z8tk/tV4XA5azqPZV Xi7wsbOpL8IkZ8BGIxTNYurNVfyMNXECbsL0W94fMozeCc6+t58fEctQXMo5Oq2yflYMcppMu Sqwl4zuKx3AOTOX0sAe0n0BmfLXrA8t/HwbDubXQ1B5MZx/xNXcc6bIVp5mNy1p5xUvX4al+3 oNW7hvjiXD8auN1XceqXcTC7D1iWA7zdKP1HCtZ7HhPUeCDPPEGoA/c4hLIAsxj1IimhwJt0C UbF58xh/Z+20uGKcLhQq5eBPNeSK/ic2/TnlQE0QugdYczMZlHT3JZJvAla3/b1EysTtZZwMg JO/eX3FrkQcMiLhfpfpxGehZ2XaTIpUVpoEQzAyio2/K0a3LSqDg7KUsN6izwOAPHNj1uzxZx mc/oEeVF5Nu6bbvk9xmZc7lyjJnKxzDqUWfj6l4bJ7zgy5t663nCTP8nm/RHkPUnOeMD1IJZA kwuvrAC49B0bGaJvKorOjDcoy8emGX9ARsYgGbVpYgGFAFV5M4/kXsSaBKN8= Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.20 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit Cc: Pierre Langlois X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello Guix! EasyTag hasn't been working for mp3 files and I couldn't work out why for = a long time. I've finally got around to looking into it properly and it turn= s the hack with the temporary .pc file I added back then didn't work because it's missing some fields. With that fixed though, EasyTag warns you with a popup that id3lib is bugg= y and needs patching. It's something about UTF16 being broken: https://sourceforge.net/p/id3lib/patches/64/, I checked, ArchLinux also applies the same patch. WDYT? Pierre Langlois (2): gnu: id3lib: Apply patch for UTF16 writing bug. gnu: easytag: Fix mp3 support. gnu/local.mk | 1 + gnu/packages/mp3.scm | 5 ++- gnu/packages/music.scm | 12 ++++-- .../patches/id3lib-UTF16-writing-bug.patch | 39 +++++++++++++++++++ 4 files changed, 52 insertions(+), 5 deletions(-) create mode 100644 gnu/packages/patches/id3lib-UTF16-writing-bug.patch =2D- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 17:29:45 2019 Received: (at 37720) by debbugs.gnu.org; 12 Oct 2019 21:29:45 +0000 Received: from localhost ([127.0.0.1]:34376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJOxH-0004vI-Dy for submit@debbugs.gnu.org; Sat, 12 Oct 2019 17:29:45 -0400 Received: from mout.gmx.net ([212.227.17.20]:48939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJOxD-0004v0-O8 for 37720@debbugs.gnu.org; Sat, 12 Oct 2019 17:29:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570915767; bh=DvGAmaEgphPhRJmixlW6VcdcYzVCPmpqTT3fMTCaW04=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=QcftKHj0+D3bTbbdwJH+vTbPYJxOXbIUmjWFzjYuG19xrllRGSqtb5Q4OBjjqztGp YcvJqNyt3SzO7jekJlGp5+wKYhfv0Au4cDG6p3H20IHIgspUHiS7yGrWwMGozZgK92 akVabJabiDZp0arND5efMh3tZhm4MRpAKx03gImk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere.lan ([2.99.192.73]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MIMfc-1iG9HW22HU-00EL97; Sat, 12 Oct 2019 23:29:27 +0200 From: Pierre Langlois To: 37720@debbugs.gnu.org Subject: [PATCH 1/2] gnu: id3lib: Apply patch for UTF16 writing bug. Date: Sat, 12 Oct 2019 22:29:18 +0100 Message-Id: <20191012212918.23515-1-pierre.langlois@gmx.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <87tv8dy7uc.fsf@gmx.com> References: <87tv8dy7uc.fsf@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:GmqFIXPsWwP/Jp0PMH22l0xAGB3LEhymvrCoJKocyVFxip5peaE ndBSgkihfCjdGRWVOYuri7q7D4RWC3n3vaVb3VuIWPokbe0IcvkkbrlOwLXTWvGwZZ1Nomc 1ZHBI75rdWjZIiWVSvc1snWwkOSKISv/T3zSyTOTUtm/uTbcOK5TrynAxUi/n/Ty4xTcxAH aT5ve1uKc7h2DoWHWxyfA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:5Y7UdDkxG/A=:TQH98+3Q7oDsXKPJcQAMBW 1neTvBPBDhIrRuNUXnNsFkzTTeHrWsDjKwtMRMWg1K2IF7VyK88NVm+XkkT+7cUW2AUkRIaUr P6qI54YpHSKsd/nx7+7hAr48oUyet8v5ccE9U3pFyBGfZih1+TYqF1Yln9MONoLXKv7ESVR69 GDO/uRerbkVrU0QH2i4zebUOzI8l5wMI8LdbpN1jbBiASr1ex7EpW6e86w0DMAGbFwzwp3ELC Mq7hfFWhKLPtOfTtEyTFVgYIGQISIl0faZHUX5WvsSr212bZzK+XqslduPCcdIWpkS4+mLHq5 pBjMdDQ6Z4IhahR4BE/bAw/VHUgrW8tVLqWWDczvnn8AXQCMHPyBi6IGv9+LOWHsW46L95PVh b1CBvRC1I/dO5K2pQ48dOgOparUD0F7MU6H2nnthjpn5UMk0KnTH7r6wvKoxGkfnaryYOw5NC nyX91y81dMOeLtP1vni+nxugQjpPImGHTAG//IDk+K4CqkvO5MdBvU8kJDGy3ijPFl7KJIEMm 0U1j9qCT/6DNizCRA9c0OpERRnaEPzCCaxo2PX1okRu/sX1k475TS7UuujZtlweWaRDNNlXEe alX5oaTOHzuHSsff8lfprM6FjBbFfNh+jxnKQ32Eyaletg5ZcJBm2VZ4y5bu7P3S/L4cVXQ9H 67BLS4NV9qmqsnqacQecHc1w1PsrOyJNVTW83bRacZTiIzWcn3338MFR9aLWePUajqlszOpCv NOQRr2abmfrbckmBd87M9x6ZCgayloqWxk/xWrt1FM7GWFlxMwKD0YGXHtCkkSnhBVWSt1/Qc I5cfRuYOxQ+W7Xf14Fvi4ejTsOBLtziUfOhkkPezSdmArCTInCwtvm35VZksw5WXNzBp9A1rG ILi2OB1Xg4ZTaodtMaYyvVMA6xYoEx4mLxwq8ldsxbJGuNYce2Qv77bnCyBySSOY5n8dKgwdU TvbPrGgPUhe1IE1Tx2qQxTMJr5iBZ9t5lzUNj+RsFb+DtV6mjpM80FzKZdpqmZCurHS9UUc0Q +AakER5PJqYOyufxqR5+laWDt4omdzyiDxlYRYxIxIoetk9Sa5eAJAo7o/Wgudb0MjW6y02kx wIu/kBM33ZTNxYMaUbuTpr6mdnbpPAVdfHFxM0eSEgseciCggYF4bP6E2lFCgcYsN5X+Wx118 u40A/+OpLIQmx8BLG4JftGqVNOkldZtbC0KadtcSXZauTqRVCHYSn77ZjVJwzFKRxZEnPLpxr cOYOZmP7G7chze4ipjQxsPXt//hfCho8vJkzrW8Tbm8glrdEBpUjfgnJOxII= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37720 Cc: Pierre Langlois X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/mp3.scm (id3lib)[patches]: Add "id3lib-UTF16-writing-bug.patch". * gnu/packages/patches/id3lib-UTF16-writing-bug.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. =2D-- gnu/local.mk | 1 + gnu/packages/mp3.scm | 5 ++- .../patches/id3lib-UTF16-writing-bug.patch | 39 +++++++++++++++++++ 3 files changed, 43 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/id3lib-UTF16-writing-bug.patch diff --git a/gnu/local.mk b/gnu/local.mk index 0a4ee7c986..f99711e1ac 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -975,6 +975,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/icedtea-6-hotspot-gcc-segfault-workaround.patch \ %D%/packages/patches/icedtea-7-hotspot-gcc-segfault-workaround.patch \ %D%/packages/patches/id3lib-CVE-2007-4460.patch \ + %D%/packages/patches/id3lib-UTF16-writing-bug.patch \ %D%/packages/patches/ilmbase-fix-tests.patch \ %D%/packages/patches/ilmbase-openexr-pkg-config.patch \ %D%/packages/patches/inkscape-poppler-0.76.patch \ diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index a218071edb..9a1cf60c2e 100644 =2D-- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -4,7 +4,7 @@ ;;; Copyright =C2=A9 2015 Mark H Weaver ;;; Copyright =C2=A9 2016 Efraim Flashner ;;; Copyright =C2=A9 2017 Thomas Danckaert -;;; Copyright =C2=A9 2017 Pierre Langlois +;;; Copyright =C2=A9 2017, 2019 Pierre Langlois ;;; Copyright =C2=A9 2018, 2019 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. @@ -123,7 +123,8 @@ versions of ID3v2.") (modules '((guix build utils))) ;; Don't use bundled zlib (snippet '(begin (delete-file-recursively "zlib") #t)) - (patches (search-patches "id3lib-CVE-2007-4460.patch")))) + (patches (search-patches "id3lib-CVE-2007-4460.patch" + "id3lib-UTF16-writing-bug.patch")))) (build-system gnu-build-system) (inputs `(("zlib" ,zlib))) (arguments diff --git a/gnu/packages/patches/id3lib-UTF16-writing-bug.patch b/gnu/pac= kages/patches/id3lib-UTF16-writing-bug.patch new file mode 100644 index 0000000000..b05d2cf298 =2D-- /dev/null +++ b/gnu/packages/patches/id3lib-UTF16-writing-bug.patch @@ -0,0 +1,39 @@ +diff -ruN id3lib-3.8.3.orig/ChangeLog id3lib-3.8.3/ChangeLog +--- id3lib-3.8.3.orig/ChangeLog 2003-03-02 01:23:00.000000000 +0100 ++++ id3lib-3.8.3/ChangeLog 2006-02-22 00:33:59.946214472 +0100 +@@ -1,3 +1,8 @@ ++2006-02-17 Jerome Couderc ++ ++ * Patch from Spoon to fix UTF-16 writing bug ++ http://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D10162= 90&group_id=3D979&atid=3D300979 ++ + 2003-03-02 Sunday 17:38 Thijmen Klok + + * THANKS (1.20): added more people +diff -ruN id3lib-3.8.3.orig/src/io_helpers.cpp id3lib-3.8.3/src/io_helper= s.cpp +--- id3lib-3.8.3.orig/src/io_helpers.cpp 2003-03-02 01:23:00.000000000 +0= 100 ++++ id3lib-3.8.3/src/io_helpers.cpp 2006-02-22 00:35:02.926639992 +0100 +@@ -363,11 +363,22 @@ + // Write the BOM: 0xFEFF + unicode_t BOM =3D 0xFEFF; + writer.writeChars((const unsigned char*) &BOM, 2); ++ // Patch from Spoon : 2004-08-25 14:17 ++ // http://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D10= 16290&group_id=3D979&atid=3D300979 ++ // Wrong code ++ //for (size_t i =3D 0; i < size; i +=3D 2) ++ //{ ++ // unicode_t ch =3D (data[i] << 8) | data[i+1]; ++ // writer.writeChars((const unsigned char*) &ch, 2); ++ //} ++ // Right code ++ unsigned char *pdata =3D (unsigned char *) data.c_str(); + for (size_t i =3D 0; i < size; i +=3D 2) + { +- unicode_t ch =3D (data[i] << 8) | data[i+1]; ++ unicode_t ch =3D (pdata[i] << 8) | pdata[i+1]; + writer.writeChars((const unsigned char*) &ch, 2); + } ++ // End patch + } + return writer.getCur() - beg; + } =2D- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 17:30:26 2019 Received: (at 37720) by debbugs.gnu.org; 12 Oct 2019 21:30:26 +0000 Received: from localhost ([127.0.0.1]:34380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJOxu-0005Cf-Ty for submit@debbugs.gnu.org; Sat, 12 Oct 2019 17:30:26 -0400 Received: from mout.gmx.net ([212.227.17.20]:49277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJOxs-00053g-5V for 37720@debbugs.gnu.org; Sat, 12 Oct 2019 17:30:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570915810; bh=t2d3DRjzgWty50d7uhLBDWM9z6nWAnnfd7xJHFMwigQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=WHQ6CKfKm5eJEeklT2MO84OSXiL8Osj9cYNfll0j3AfqKpDPLUzdFmbJaNm7qUiuP //z4qUBuGWtTO2yb3ccELfwwyK0JnDD0lDoC4h8dl2ED0vyMygaO9kjz1vUEpUFj83 5pZV+ICdTk+6QIzmOnXtCf7sfpO2Cm9RFXsENyB0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere.lan ([2.99.192.73]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MXGvG-1iZL7E0RXK-00Ylb5; Sat, 12 Oct 2019 23:30:10 +0200 From: Pierre Langlois To: 37720@debbugs.gnu.org Subject: [PATCH 2/2] gnu: easytag: Fix mp3 support. Date: Sat, 12 Oct 2019 22:30:08 +0100 Message-Id: <20191012213008.23574-1-pierre.langlois@gmx.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <87tv8dy7uc.fsf@gmx.com> References: <87tv8dy7uc.fsf@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:jQzs+zgXnYceNBbsNtPwZMXpmt9K1oeI/EzMMNt8KyKwWuDNAa1 8VqvG2x9+oSIhTHdhdgVsYd2yNvHs15jabras8yUe+oDhMGAtrwH7KCKF29QYupi10MT1/1 hBo66Il2mavfp9HCqu8e0CRgGBBCG5GXuq/aVUb3dSnDB3K6uXd0FiIggKuLeGf4LpEIu9d h3FlgoNN1p4tvDzgFNbuA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:qI0iNWX35sc=:eTKpPknCZq5gQtEt2LAPh0 S7JIhMtUZhrF0TB6mw9R+FIIUzTXbqdL9wnxeWSLKu8GzdnCf6lHYdOVEoGCl+HPLHtZ539Db FnOgYj1J5dC6CCxbptG2TBPh/WmaYrowPoVBoT2JcRzdCibScuF4Q1Vo1EFzdsW1aNBwJ/82D HaLVrpfatFNqgu+z+0AXPit7DJYul+riRx2q2htQjNX/BXRlAsUU5HigY3wiZLxTXwhgoJd90 5J2MG9netloEPAVfVRzski9N4yuN4oX+WEHuOsXoIgV0HzgMEuMiWWwv7ubwlfEJCuVLo+QDe ZvKY8328EWFep9Qo23ARZRvb3VHNEbtnEaI5XesJemeE2wEhFr1w+5a/BYlND4hHJJKazrakY Ie0q9gD0Xx85KOFgS7/MpwApWiyPCl7uyUbzqocwoRwt93xnY9Nlqa+IcxshpzvHagVZzjhhZ yLECLFEeU+x2O+TnE1zoYcgbOdGEUyrFzfPXQCV65wSM/RSPFbi8B42brenqhcAIMxy7atzjW rRe9NGv8BErIO+XFcr+KuwTdIHm9iT7Uvb7hEoavE2YYs6GRymjnZn+5rTzqxb+1VrBopwfzg dPlUIa+Y0zJPgsTzcDU7gSk8fbARcCOAG4fLri0r92lZyJkQf348zpEqYpycE1l9rGtczVJzp gy8XzTQhiYknBUefLvA5RA26ePW9BPaZk8EdeYxIYL/kCQcss/lPR62dvMrKnx6CM+N4pKfiO tnz0s0EYo19lB//wj03Ih/MpE+TV/uJCHCbmCJ0fEJcalfrEIntQPMilDgr92+VPR/bhOYkOD IFKdIXnugrt2hrp4Yn/2kIUg/JvcWxs37ijoa8qGr1P4BHkdXAYH8Cx3B6ZpnpvoyfzIHHF/t j8MnLXTS8Uksp34ta7FWg8uobd2UC4U2cT2Hw5GlCHjLhCFCWx+C1LGo0XkIma7Ytia7Pgf70 REGKpAsi0OQa8XQ8L2nZ4rIoic1h5+3M5xRH668o5aK+oPgfp3itRud8tzBP3kjoR4xajdY3H 1ipSMPxneQFA884tlWZ4K+cQE762GatZii2r5vJKNYzy0BMnYGvuzW0M8FbxHUATJXTivAYax WBAs98N8Fy/LrMIEQ7lKEZe2DEd0qGSEV0GUtBQzLGwOZfIfDZ+8OlkAfK5wmirE41n7oG3d8 UCUO/uKqa+bNBLw4yKeKbncWcChSaBDbDRRwz+wJUVUuH7aiF/TP7DPpXIez89AOCCV4+PN6m NFd6MtJxUuyaT+EOPmoOzliobqHkb5VDw3vixovh1rPCx/NW5HxUBL+h0Tuw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37720 Cc: Pierre Langlois X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/music.scm (easytag)[arguments]: Add 'Name', 'Description' a= nd 'Version' entries to temporary id3tag.pc pkg-config file. Terminate phases with #t. =2D-- gnu/packages/music.scm | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index ac4333168c..4c74ae5ffa 100644 =2D-- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -11,7 +11,7 @@ ;;; Copyright =C2=A9 2017 ng0 ;;; Copyright =C2=A9 2017 Rodger Fox ;;; Copyright =C2=A9 2017, 2018, 2019 Nicolas Goaziou -;;; Copyright =C2=A9 2017, 2018 Pierre Langlois +;;; Copyright =C2=A9 2017, 2018, 2019 Pierre Langlois ;;; Copyright =C2=A9 2017 Arun Isaac ;;; Copyright =C2=A9 2017, 2018, 2019 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2018 nee @@ -593,12 +593,17 @@ enable professional yet simple and intuitive pattern= -based drum programming.") "prefix=3D~@*~a~@ libdir=3D${prefix}/lib~@ includedir=3D${prefix}/include~@ + + Name: libid3tag~@ + Description:~@ + Version:~@ Libs: -L${libdir} -lid3tag -lz~@ Cflags: -I${includedir}~%" libid3tag))) (setenv "PKG_CONFIG_PATH" (string-append (getenv "PKG_CONFIG_PATH") - ":" (getcwd) "/pkgconfig"))))) + ":" (getcwd) "/pkgconfig")) + #t))) (add-after 'unpack 'patch-makefile (lambda _ (substitute* "Makefile.in" @@ -606,7 +611,8 @@ enable professional yet simple and intuitive pattern-b= ased drum programming.") ;; script with /bin/sh hard-coded. (("/bin/sh") (which "sh")) ;; Don't create 'icon-theme.cache'. - (("gtk-update-icon-cache") "true"))))))) + (("gtk-update-icon-cache") "true")) + #t))))) (home-page "https://wiki.gnome.org/Apps/EasyTAG") (synopsis "Simple application for viewing and editing tags in audio f= iles") (description =2D- 2.23.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 13 08:09:34 2019 Received: (at 37720-done) by debbugs.gnu.org; 13 Oct 2019 12:09:34 +0000 Received: from localhost ([127.0.0.1]:35297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJcgo-0003VY-I2 for submit@debbugs.gnu.org; Sun, 13 Oct 2019 08:09:34 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:60612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJcgm-0003VO-9x for 37720-done@debbugs.gnu.org; Sun, 13 Oct 2019 08:09:33 -0400 Received: from localhost (77.117.187.31.wireless.dyn.drei.com [77.117.187.31]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 493793365576; Sun, 13 Oct 2019 14:09:30 +0200 (CEST) Date: Sun, 13 Oct 2019 14:09:24 +0200 From: Danny Milosavljevic To: Pierre Langlois Subject: Re: [bug#37720] [PATCH 0/2] gnu: easytag: Fix mp3 support. Message-ID: <20191013140924.0e966e3f@scratchpost.org> In-Reply-To: <87tv8dy7uc.fsf@gmx.com> References: <87tv8dy7uc.fsf@gmx.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/VkKnOtPZ..KpbBxjaQLfPsA"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37720-done Cc: 37720-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/VkKnOtPZ..KpbBxjaQLfPsA Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Pierre, On Sat, 12 Oct 2019 22:25:31 +0100 Pierre Langlois wrote: > WDYT? Looks good to me, so I pushed the patchset to guix master. (It's unfortunately that char signedness is unspecified in the C standard. That maybe made sense in 1980--not today. Sigh) --Sig_/VkKnOtPZ..KpbBxjaQLfPsA Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl2jE/QACgkQ5xo1VCww uqXx5wf9HQhEy0VLeSUT9raEQwvzMDi0jV3pS2hIdr6lADiRnMp4kpSgns08Lxry xF3YkKQ7N/RTjNTCgp6iMpLmNT5FQyTxGf3Lepamxee2biYeRL864ddmeRpJnLtK 4w6qQmns8mCGZqkB16ARHlokQUo2tOcaEdWzt3HPzG4koePAZLft7vcWb+gfcwVj b7IfnXGnsQCNnSTAg5wwI1Q3pavKoMWnlyhXAKX2Afwzm59tBbLCOcq96zn6GUnp 1ga/vpRAsRexTzgVmAvcPtP3WTGMYq67coo4tr0cgsNaP7TvQ+5O3n0aaeRJxit/ n0YWZtuuBRHBsYzn29WZKzPMjzj+Jw== =W0pZ -----END PGP SIGNATURE----- --Sig_/VkKnOtPZ..KpbBxjaQLfPsA-- From unknown Tue Aug 19 09:35:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Nov 2019 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator