GNU bug report logs - #37700
27.0.50; undo mouse-drag-and-drop-region ineffective

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 37700 <at> debbugs.gnu.org, tkk <at> misasa.okayama-u.ac.jp, homeros.misasa <at> gmail.com, monnier <at> iro.umontreal.ca
Subject: bug#37700: 27.0.50; undo mouse-drag-and-drop-region ineffective
Date: Thu, 31 Oct 2019 16:45:40 +0200

> From: Mattias Engdegård <mattiase <at> acm.org>
> Date: Thu, 31 Oct 2019 12:00:08 +0100
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 37700 <at> debbugs.gnu.org,
>         tkk <at> misasa.okayama-u.ac.jp, homeros.misasa <at> gmail.com
> 
> > But now that I think about it, maybe a better option would be to check
> > 
> >    (when (symbolp last-command)
> >      (get last-command 'undo-inhibit-region))
> > 
> > and then put the `undo-inhibit-region` property on
> > `mouse-drag-and-drop-region`.
> 
> Thank you, this looks like the best idea so far. A very simple change, yet effective in practice. Not perfect --- last-command is not buffer-local, and even switching to a different frame and back will change it --- but good enough.
> 
> Patch attached.

Fine with me (I proposed something like this during the original
discussion), but please document this property in the ELisp manual.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.