GNU bug report logs - #3770
archive-mode: recognize ZIP files with non-standard "PK00" header

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Peter Jolly <peter <at> jollys.org>
Subject: bug#3770 closed by Chong Yidong <cyd <at> stupidchicken.com> (Re:
 archive-mode: recognize ZIP files with non-standard "PK00" header)
Date: Sun, 12 Jul 2009 19:05:09 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#3770: archive-mode: recognize ZIP files with non-standard "PK00" header

It has been closed by Chong Yidong <cyd <at> stupidchicken.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <cyd <at> stupidchicken.com> by
replying to this email.


-- 
3770: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3770
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Peter Jolly <peter <at> jollys.org>
Cc: 3770-done <at> debbugs.gnu.org
Subject: Re: archive-mode: recognize ZIP files with non-standard "PK00" header
Date: Sun, 12 Jul 2009 14:56:27 -0400

> Some ZIP files have the string "PK00" before the first PK^C^D header.
> Apparently this is added by certain archivers when writing to removable
> media.

Thanks.  I've checked in your patch into CVS trunk.

[Message part 3 (message/rfc822, inline)]

From: Peter Jolly <peter <at> jollys.org>
To: bug-gnu-emacs <at> gnu.org
Subject: archive-mode: recognize ZIP files with non-standard "PK00" header
Date: Mon, 06 Jul 2009 23:28:37 +0100

Some ZIP files have the string "PK00" before the first PK^C^D header.
Apparently this is added by certain archivers when writing to removable
media.

archive-find-type does not currently recognize such files.  The rest of
archive-mode handles them correctly, so I believe they can be supported
with a trivial change: something like

diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el
index cc59d6e..174d205 100644
--- a/lisp/arc-mode.el
+++ b/lisp/arc-mode.el
@@ -716,7 +716,7 @@ archive.
   ;; The funny [] here make it unlikely that the .elc file will be treated
   ;; as an archive by other software.
   (let (case-fold-search)
-    (cond ((looking-at "[P]K\003\004") 'zip)
+    (cond ((looking-at "\\(PK00\\)?[P]K\003\004") 'zip)
 	  ((looking-at "..-l[hz][0-9ds]-") 'lzh)
 	  ((looking-at "....................[\334]\247\304\375") 'zoo)
 	  ((and (looking-at "\C-z")	; signature too simple, IMHO

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.