From unknown Sun Jun 22 11:44:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37679: Local git configuration interferes with testsuite Resent-From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 09 Oct 2019 10:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37679 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 37679@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157061737721274 (code B ref -1); Wed, 09 Oct 2019 10:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Oct 2019 10:36:17 +0000 Received: from localhost ([127.0.0.1]:52192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI9KL-0005X4-1x for submit@debbugs.gnu.org; Wed, 09 Oct 2019 06:36:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:55668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI9KJ-0005Ws-BK for submit@debbugs.gnu.org; Wed, 09 Oct 2019 06:36:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57286) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI9KH-0002wB-Rf for bug-guix@gnu.org; Wed, 09 Oct 2019 06:36:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI9KG-0004HE-DH for bug-guix@gnu.org; Wed, 09 Oct 2019 06:36:13 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:33710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI9KG-0004Gw-69 for bug-guix@gnu.org; Wed, 09 Oct 2019 06:36:12 -0400 Received: by mail-ed1-x52b.google.com with SMTP id c4so1577637edl.0 for ; Wed, 09 Oct 2019 03:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=FVUBeYQJp/XYdL/lURnwotmnBSP4YZe4qmV1mtXZfAk=; b=uk5QX81RiJVjk6M6zZcqWdUCTp3Ocr/QsQc6uXHQGMsaOqjbZDA5XRXqZQSD5MSfPl SqkQnkW/hyU4gCFjCw2h96k2YGqin4NQbCPN45aZE2UlpyhTA+o3tV/syZRbtpWnm4AT YVDgTRceNh9ACSCmCcAaor494NjhtnXJXzjET4vmFfiQDXS4CRR8dNFVIxDIMnh25PH4 fIlpC5kZW/D8n9WGCmKE8KNnsKL5nzsj0gcdx5fCEwq62N6gUrD+FF9U7sevYpmcZRhP v/hiMkI680ccEeEm0VcIoN1b/PvT4MUe4ItZ3d3k1MUgogBLqhLS8VpKvkQDcog7tUQN LfxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=FVUBeYQJp/XYdL/lURnwotmnBSP4YZe4qmV1mtXZfAk=; b=AgEzZsQndT+vmA7ihC/ZQ+ygoLF1T3bB7GUPUXHc2l20pQHU82gX1nt8VQxuxdzeOf w6eajWTccymwFHVg5EARaMBZ55N10639bxk5Myt1TJet8rMRqF9YxBksCSVlbN0NnVAJ Ue2isAlXEIwmmMZg5EjIvfRuSjy1ciKUzsj1heP3YYKeihXtADbTLP1b8rsAH48LN/q/ JGm7PQSK05rHwjZYY3/veUuG8MDxjpZnMN3k1pPfqdtf5soUFEI7HyYZbaaR8An97/Zc sTH9YQX/Htccp0I6g9/K+nT+q6kFt0FON/5Ig1f3yv/wUPzAmUzJYL7HzvHqqW7VCNJm sBOg== X-Gm-Message-State: APjAAAVeoXGD5hbDz7sdDUhCpoytE0ADkqocVaE1Ny2Ul8OO3GmlYbDY PbktjMMTOdBkeb5aaY15eT3ZTvvZ05WlTCO5uerD X-Google-Smtp-Source: APXvYqxzFzVfu3TDBPIQU4sPtB69HgSbnzfpf6bXWJARHFv+umPVZdfzjcidX3GuxuZTCTJmx4DdAQ/clTsv8oMUMQc= X-Received: by 2002:a17:906:1655:: with SMTP id n21mr2084062ejd.110.1570617369901; Wed, 09 Oct 2019 03:36:09 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Wed, 9 Oct 2019 12:35:58 +0200 Message-ID: Content-Type: multipart/mixed; boundary="00000000000069574a059477da30" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52b X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000069574a059477da30 Content-Type: multipart/alternative; boundary="000000000000695748059477da2e" --000000000000695748059477da2e Content-Type: text/plain; charset="UTF-8" I noticed that the local git configuration interferes with the guix test suite. After discussion on IRC with nckx I came up with the attached patch. Comments are welcome! Best regards, g_bor -- OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21 --000000000000695748059477da2e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I noticed that the local git configuration interferes= with the guix test suite.

After discussion on IRC= with nckx I came up with the attached patch. Comments are welcome!

Best regards,
g_bor
--
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:25= 06:A96C:CF63:0B21
--000000000000695748059477da2e-- --00000000000069574a059477da30 Content-Type: text/x-patch; charset="UTF-8"; name="0001-tests-Isolate-git-from-external-configuration.patch" Content-Disposition: attachment; filename="0001-tests-Isolate-git-from-external-configuration.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1j50e420 RnJvbSBhYmYyMDQ3N2VhMTM5YmZhZjFmMmUyMWYwOWMyNDIwZmU2MThjOWNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Rz1DMz1BMWJvcj0yMEJvc2tvdml0cz89IDxi b3Nrb3ZpdHNAZ21haWwuY29tPgpEYXRlOiBUdWUsIDggT2N0IDIwMTkgMjI6NDE6MjAgKzAyMDAK U3ViamVjdDogW1BBVENIXSB0ZXN0czogSXNvbGF0ZSBnaXQgZnJvbSBleHRlcm5hbCBjb25maWd1 cmF0aW9uLgoKKiBNYWtlZmlsZS5hbShBTV9URVNUU19FTlZJUk9OTUVOVCk6IEFkZCBlbnZpcm9u bWVudCB2YXJpYWJsZXMgdG8KbWFrZSBnaXQgaWdub3JlIHRoZSB1c2VyIGFuZCBzeXN0ZW0gY29u ZmlndXJhdGlvbiBmaWxlcy4KKiB0ZXN0cy9mYWtlLWhvbWUvLmdpdGNvbmZpZzogTmV3IGZpbGUu IFByb3ZpZGUgbWluaW1hbCBnaXQKY29uZmlndXJhdGlvbiBmb3IgdGVzdHMuCi0tLQogTWFrZWZp bGUuYW0gICAgICAgICAgICAgICAgfCAgOSArKysrKysrKy0KIHRlc3RzL2Zha2UtaG9tZS8uZ2l0 Y29uZmlnIHwgMjEgKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI5IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0cy9mYWtl LWhvbWUvLmdpdGNvbmZpZwoKZGlmZiAtLWdpdCBhL01ha2VmaWxlLmFtIGIvTWFrZWZpbGUuYW0K aW5kZXggMzY3NjdjMmY0Ny4uZTdiZjgxOWE2YiAxMDA2NDQKLS0tIGEvTWFrZWZpbGUuYW0KKysr IGIvTWFrZWZpbGUuYW0KQEAgLTE0LDYgKzE0LDcgQEAKICMgQ29weXJpZ2h0IMKpIDIwMTggT2xl ZyBQeWtoYWxvdiA8Z28ud2lndXN0QGdtYWlsLmNvbT4KICMgQ29weXJpZ2h0IMKpIDIwMTggQWxl eCBWb25nIDxhbGV4dm9uZzE5OTVAZ21haWwuY29tPgogIyBDb3B5cmlnaHQgwqkgMjAxOSBFZnJh aW0gRmxhc2huZXIgPGVmcmFpbUBmbGFzaG5lci5jby5pbD4KKyMgQ29weXJpZ2h0IMKpIDIwMTkg R8OhYm9yIEJvc2tvdml0cyA8Ym9za292aXRzQGdtYWlsLmNvbT4KICMKICMgVGhpcyBmaWxlIGlz IHBhcnQgb2YgR05VIEd1aXguCiAjCkBAIC00NzIsNyArNDczLDEzIEBAIFNIX1RFU1RTID0JCQkJ CVwKIAogVEVTVFMgPSAkKFNDTV9URVNUUykgJChTSF9URVNUUykKIAotQU1fVEVTVFNfRU5WSVJP Tk1FTlQgPSBhYnNfdG9wX3NyY2Rpcj0iJChhYnNfdG9wX3NyY2RpcikiIEdVSUxFX0FVVE9fQ09N UElMRT0wCitBTV9URVNUU19FTlZJUk9OTUVOVCA9IAkJCQlcCisgIGFic190b3Bfc3JjZGlyPSIk KGFic190b3Bfc3JjZGlyKSIgCQlcCisgIEdVSUxFX0FVVE9fQ09NUElMRT0wCQkJCVwKKyAgR0lU X0NPTkZJR19OT1NZU1RFTT0xCQkJCVwKKyAgR0lUX0FUVFJfTk9TWVNURU09MQkJCQlcCisgIEhP TUU9IiQoYWJzX3RvcF9zcmNkaXIpL3Rlc3RzL2Zha2UtaG9tZSIJXAorICBYREdfQ09ORklHX0hP TUU9IiQoYWJzX3RvcF9zcmNkaXIpL3Rlc3RzL2Zha2UteGdkLWNvbmZpZy1ob21lIgogCiBTQ01f TE9HX0RSSVZFUiA9CQkJCVwKICAgJCh0b3BfYnVpbGRkaXIpL3Rlc3QtZW52IC0tcXVpZXQtc3Rk ZXJyCVwKZGlmZiAtLWdpdCBhL3Rlc3RzL2Zha2UtaG9tZS8uZ2l0Y29uZmlnIGIvdGVzdHMvZmFr ZS1ob21lLy5naXRjb25maWcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4u MDc5Y2JkMGQzMAotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3RzL2Zha2UtaG9tZS8uZ2l0Y29uZmln CkBAIC0wLDAgKzEsMjEgQEAKKyMgR05VIEd1aXggLS0tIEZ1bmN0aW9uYWwgcGFja2FnZSBtYW5h Z2VtZW50IGZvciBHTlUKKyMgQ29weXJpZ2h0IMKpIDIwMTkgR8OhYm9yIEJvc2tvdml0cyA8Ym9z a292aXRzQGdtYWlsLmNvbT4KKyMKKyMgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCisj CisjIEdOVSBHdWl4IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFu ZC9vciBtb2RpZnkgaXQKKyMgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv bjsgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3IgKGF0CisjIHlvdXIgb3B0aW9u KSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyMKKyMgR05VIEd1aXggaXMgZGlzdHJpYnV0ZWQgaW4gdGhl IGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwgYnV0CisjIFdJVEhPVVQgQU5ZIFdBUlJBTlRZ OyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyMgTUVSQ0hBTlRBQklMSVRZ IG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorIyBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorIworIyBZb3Ugc2hvdWxkIGhh dmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBh bG9uZyB3aXRoIEdOVSBHdWl4LiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LgorCitbdXNlcl0KKyAgZW1haWwgPSBlbWFpbEBleGFtcGxlLmNvbQorICBuYW1lID0g VXNtYW4KLS0gCjIuMjMuMAoK --00000000000069574a059477da30-- From unknown Sun Jun 22 11:44:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37679: Local git configuration interferes with testsuite Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 07 Jan 2020 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37679 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: 37679@debbugs.gnu.org Received: via spool by 37679-submit@debbugs.gnu.org id=B37679.157838830517051 (code B ref 37679); Tue, 07 Jan 2020 09:12:02 +0000 Received: (at 37679) by debbugs.gnu.org; 7 Jan 2020 09:11:45 +0000 Received: from localhost ([127.0.0.1]:47249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioktt-0004Qw-AP for submit@debbugs.gnu.org; Tue, 07 Jan 2020 04:11:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioktr-0004Qe-6e for 37679@debbugs.gnu.org; Tue, 07 Jan 2020 04:11:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ioktm-0006wF-3t; Tue, 07 Jan 2020 04:11:38 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=48576 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ioktk-0002uw-F0; Tue, 07 Jan 2020 04:11:36 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Tue, 07 Jan 2020 10:11:32 +0100 In-Reply-To: ("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Wed, 9 Oct 2019 12:35:58 +0200") Message-ID: <87eewbljgb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! G=C3=A1bor Boskovits skribis: > From abf20477ea139bfaf1f2e21f09c2420fe618c9ca Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?G=3DC3=3DA1bor=3D20Boskovits?=3D > Date: Tue, 8 Oct 2019 22:41:20 +0200 > Subject: [PATCH] tests: Isolate git from external configuration. > > * Makefile.am(AM_TESTS_ENVIRONMENT): Add environment variables to > make git ignore the user and system configuration files. > * tests/fake-home/.gitconfig: New file. Provide minimal git > configuration for tests. > --- > Makefile.am | 9 ++++++++- > tests/fake-home/.gitconfig | 21 +++++++++++++++++++++ > 2 files changed, 29 insertions(+), 1 deletion(-) > create mode 100644 tests/fake-home/.gitconfig > > diff --git a/Makefile.am b/Makefile.am > index 36767c2f47..e7bf819a6b 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -14,6 +14,7 @@ > # Copyright =C2=A9 2018 Oleg Pykhalov > # Copyright =C2=A9 2018 Alex Vong > # Copyright =C2=A9 2019 Efraim Flashner > +# Copyright =C2=A9 2019 G=C3=A1bor Boskovits > # > # This file is part of GNU Guix. > # > @@ -472,7 +473,13 @@ SH_TESTS =3D \ >=20=20 > TESTS =3D $(SCM_TESTS) $(SH_TESTS) >=20=20 > -AM_TESTS_ENVIRONMENT =3D abs_top_srcdir=3D"$(abs_top_srcdir)" GUILE_AUTO= _COMPILE=3D0 > +AM_TESTS_ENVIRONMENT =3D \ > + abs_top_srcdir=3D"$(abs_top_srcdir)" \ > + GUILE_AUTO_COMPILE=3D0 \ > + GIT_CONFIG_NOSYSTEM=3D1 \ > + GIT_ATTR_NOSYSTEM=3D1 \ > + HOME=3D"$(abs_top_srcdir)/tests/fake-home" \ > + XDG_CONFIG_HOME=3D"$(abs_top_srcdir)/tests/fake-xgd-config-home" Ooh, good catch. This change fixes issues with =E2=80=98tests/git.scm=E2= =80=99, is that correct? The =E2=80=98GIT_=E2=80=99 environment variables are honored by Git itself,= not by libgit2/Guile-Git, right? Can we avoid setting HOME and XDG_CONFIG_HOME? Perhaps these variables should all be set in =E2=80=98test-env=E2=80=99 alo= ng with their friends, for consistency? Last, if we end up keeping =E2=80=98tests/fake-home=E2=80=99, make sure to = also add it to =E2=80=98EXTRA_DIST=E2=80=99 in =E2=80=98Makefile.am=E2=80=99. Could you send an updated patch? Thanks for addressing it, and sorry for the loooong delay! Ludo=E2=80=99. From unknown Sun Jun 22 11:44:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37679: [PATCH 0/2] Local git configuration interferes with testsuite References: In-Reply-To: Resent-From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 30 Mar 2020 02:36:27 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37679 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 37679@debbugs.gnu.org Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits Received: via spool by 37679-submit@debbugs.gnu.org id=B37679.158553573717480 (code B ref 37679); Mon, 30 Mar 2020 02:36:27 +0000 Received: (at 37679) by debbugs.gnu.org; 30 Mar 2020 02:35:37 +0000 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIXpT-0001O6-N4 for 37679@debbugs.gnu.org; Sun, 29 Mar 2020 09:18:20 -0400 Received: by mail-wm1-f68.google.com with SMTP id d1so18107968wmb.2 for <37679@debbugs.gnu.org>; Sun, 29 Mar 2020 06:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n+KljeddNaNM0aRbr9G3iH/WkR1UHRuvFbeA6o27AXc=; b=Rs8UCUTQzFFynVG3Qc39kwZhmkP2MjwPUAyzG8DWmiMG/RRkxXzhc2thyB7DOx2Cqw c2kubeo3eRu6/ZYEAXS/tNhRMYuTkv2g3o9KMubft0jcaP7Ny+ES/pKEgiFNLKrzEoCu gMHhnjPbTGAU1XTppLJy/FKtwu26cVtp3Hcc6b3fOgpaacBHAAv5tFpswxP0nmj3cbGR dedOT/FPzGHAKkR18Gmt2W0PChE7yYIClQ6WwNAk/HfiyYrcdQX8KMCBslK5R9FXw50W Wdy0v5PXP9RwKVzyMMm2vjedBLq/2He6LCYvPhrKwPTtuN0rXNEVzH8n81kxxnwlU9Qo FfHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n+KljeddNaNM0aRbr9G3iH/WkR1UHRuvFbeA6o27AXc=; b=oRet0t0xdZOhZhp1x5HlaVHBwchLIDZy4+e3tr/8dKzzUP9xRb/FJxLfoIAbMGcOaJ g9hOqC+g/kfhPMAYMvYrOpQYn7+uUOPwqIXkWUYGzdm8m34PCUx2EDxph4ORB6lS2TZL KpWnFPRAr+QPhW1WlLCr1BdJKbDujg0HNsZowXCsBFy5YRnRhz7b2n6QCtB1YKHsqonc s28QemT0ob+aKmO1PLA/L19MD0mjyXJdGflG8RdH20QiHLtHQGtPpLyXTh2kt8fQRHKQ e8k4ju+b+cr2U7ed7dGu0OQy8oAHggmElqfRXnSaWaRn4JJXtARw0nhGf1lMGFXIW6Wz sL9w== X-Gm-Message-State: ANhLgQ0loFTLSjRdlZJWnS/Eod+j2gvZ4qNFwGT6laelnpUMih+jtCDh TsjJuwu0LDQ4tXDdE4tcj1Pyl+P5NQ== X-Google-Smtp-Source: ADFU+vtBTds4Oc7e33lv6UhHNTQFwAntaSdvlAKNwlZjME2EHb0K1zxTfUcumJnlLjgayZx2iRf5Tw== X-Received: by 2002:a1c:e914:: with SMTP id q20mr8217438wmc.105.1585487893727; Sun, 29 Mar 2020 06:18:13 -0700 (PDT) Received: from localhost.localdomain (catv-176-63-20-200.catv.broadband.hu. [176.63.20.200]) by smtp.gmail.com with ESMTPSA id b67sm16622328wmh.29.2020.03.29.06.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2020 06:18:13 -0700 (PDT) From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Sun, 29 Mar 2020 15:18:08 +0200 Message-Id: <20200329131810.23562-1-boskovits@gmail.com> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 13:18:20 -0000 Create a fake home in tests with a gitconfig so that the user configuration does not get picked up. I investigated how to solve this best, but git only respects HOME for the commands we are using. Also note that this does not affect libraries, only the git cli, as libraries do not use the environment variables. Gábor Boskovits (2): tests: Isolate git from user configuration. tests: Ignore files created by the testsuite. .gitignore | 4 +++- Makefile.am | 2 ++ build-aux/test-env.in | 4 ++++ tests/fake-home/.gitconfig | 21 +++++++++++++++++++++ 4 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 tests/fake-home/.gitconfig -- 2.25.0 From unknown Sun Jun 22 11:44:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37679: [PATCH 1/2] tests: Isolate git from user configuration. Resent-From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 30 Mar 2020 02:36:27 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37679 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 37679@debbugs.gnu.org Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits Received: via spool by 37679-submit@debbugs.gnu.org id=B37679.158553573717482 (code B ref 37679); Mon, 30 Mar 2020 02:36:27 +0000 Received: (at 37679) by debbugs.gnu.org; 30 Mar 2020 02:35:37 +0000 Received: from mail-wm1-f54.google.com ([209.85.128.54]:53608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIXpY-0001OG-VI for 37679@debbugs.gnu.org; Sun, 29 Mar 2020 09:18:25 -0400 Received: by mail-wm1-f54.google.com with SMTP id b12so16756476wmj.3 for <37679@debbugs.gnu.org>; Sun, 29 Mar 2020 06:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dyUEmRq/HnOQsswZ1/aMDEL8X9RzCmyjPkt4ijiuePY=; b=JuZiJ2FlnohtPfFwnwuKlh41NR9c82ApDqiBpSKGe2TPZtvyISVndspqatHAl1P/PT gor4NgDLXTzdtU5bwBxZixIk1ogzaOFyIEuQN9PM2Beh//K1An2SxjPCenQ7SeQwAhTH oegY9s5poeNZtVh42+LPQ18Kx+bjhipQ2R23XPbO37b0p8N6BNV0xUxugovIgwVlwm8C qSTFzvDuiyqBQyQnJDmsXbd91AppYBaCI1uyokDlCvXaWABCxXVT15NNKkM9TQJybYHs 3gcHophfKxeY8IXhduzl0eKhqr/OPU1pa0zSyI/m7uYxLRZTNpqMiJ8Psw5rW48E4Zmd /HBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dyUEmRq/HnOQsswZ1/aMDEL8X9RzCmyjPkt4ijiuePY=; b=cq9jP1uktaaBfvL+IK6g4fUjot3rbbeO8OOnPVDf78a10e0YXfvnbYXN+W7kAsoqb6 HhKybr+lQngQGvkaMmF0/kt8xBOOHCLgn+nvjR46hbSFeJMBn0+ivGjJzgFYZ62yfzrA VWcDN0mj/wQMumBgch7hdy+GX7GKcPngOJ7zTnJcdcQZEYFuUvXMr4B7GKZcOq4eRjoe 1tyVXIq8PkCHrGv1AuVRgOdmqjtxKRaHEBzCtCfs/N9RwRrkOcn/A4A6yhr4FTaTat9U vrVRl3jLV2ii20u1IkjfU3lMZuMzCsiuWo+D64SdnVJcwz3FovCDunx56lR0t/GL8qCJ Bh5w== X-Gm-Message-State: ANhLgQ34/qegRu5vDnCr2zgaHsNmwa6LjDYbhc97I3fjSQoJjHQGmEhl Bbx+ox04D+OG9ZyXpo6MZNwNbww4nA== X-Google-Smtp-Source: ADFU+vsRNTp2LPhmu/jigdBaFNnU5ZWUYlQvnQIDHMXBFU8yUx0+KD/z+aRBoygyX+RURYvNLKoMTg== X-Received: by 2002:a1c:63c4:: with SMTP id x187mr8406055wmb.124.1585487899168; Sun, 29 Mar 2020 06:18:19 -0700 (PDT) Received: from localhost.localdomain (catv-176-63-20-200.catv.broadband.hu. [176.63.20.200]) by smtp.gmail.com with ESMTPSA id b67sm16622328wmh.29.2020.03.29.06.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2020 06:18:18 -0700 (PDT) From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Sun, 29 Mar 2020 15:18:09 +0200 Message-Id: <20200329131810.23562-2-boskovits@gmail.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200329131810.23562-1-boskovits@gmail.com> References: <20200329131810.23562-1-boskovits@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 13:18:25 -0000 * tests/fake-home/.gitconfig: New file. Provide minimal git configuration for tests. * build-aux/test-env.in: Set HOME to the fake home. * Makefile.am(EXTRA_DIST): Add fake-home/.gitconfig. --- Makefile.am | 2 ++ build-aux/test-env.in | 4 ++++ tests/fake-home/.gitconfig | 21 +++++++++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 tests/fake-home/.gitconfig diff --git a/Makefile.am b/Makefile.am index 344ecdbc42..5eb918d599 100644 --- a/Makefile.am +++ b/Makefile.am @@ -14,6 +14,7 @@ # Copyright © 2018 Oleg Pykhalov # Copyright © 2018 Alex Vong # Copyright © 2019 Efraim Flashner +# Copyright © 2020 Gábor Boskovits # # This file is part of GNU Guix. # @@ -560,6 +561,7 @@ EXTRA_DIST += \ build-aux/update-NEWS.scm \ d3.v3.js \ graph.js \ + tests/fake-home/.gitconfig \ tests/test.drv \ tests/signing-key.pub \ tests/signing-key.sec \ diff --git a/build-aux/test-env.in b/build-aux/test-env.in index 59ab58cc94..1121570fbc 100644 --- a/build-aux/test-env.in +++ b/build-aux/test-env.in @@ -2,6 +2,7 @@ # GNU Guix --- Functional package management for GNU # Copyright © 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès +# Copyright © 2020 Gábor Boskovits # # This file is part of GNU Guix. # @@ -151,6 +152,9 @@ export GUIX_BUILD_OPTIONS # Ignore user settings. unset GUIX_PACKAGE_PATH +# Provide fake home for tests using git +HOME="@abs_top_srcdir@/tests/fake-home" + storedir="@storedir@" prefix="@prefix@" datarootdir="@datarootdir@" diff --git a/tests/fake-home/.gitconfig b/tests/fake-home/.gitconfig new file mode 100644 index 0000000000..c32de560e7 --- /dev/null +++ b/tests/fake-home/.gitconfig @@ -0,0 +1,21 @@ +# GNU Guix --- Functional package management for GNU +# Copyright © 2020 Gábor Boskovits +# +# This file is part of GNU Guix. +# +# GNU Guix is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or (at +# your option) any later version. +# +# GNU Guix is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with GNU Guix. If not, see . + +[user] + email = alice@example.com + name = Alice -- 2.25.0 From unknown Sun Jun 22 11:44:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37679: [PATCH 2/2] tests: Ignore files created by the testsuite. Resent-From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 30 Mar 2020 02:36:28 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37679 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 37679@debbugs.gnu.org Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits Received: via spool by 37679-submit@debbugs.gnu.org id=B37679.158553573717485 (code B ref 37679); Mon, 30 Mar 2020 02:36:28 +0000 Received: (at 37679) by debbugs.gnu.org; 30 Mar 2020 02:35:37 +0000 Received: from mail-wr1-f42.google.com ([209.85.221.42]:37489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIXpb-0001OT-4Z for 37679@debbugs.gnu.org; Sun, 29 Mar 2020 09:18:27 -0400 Received: by mail-wr1-f42.google.com with SMTP id w10so17716275wrm.4 for <37679@debbugs.gnu.org>; Sun, 29 Mar 2020 06:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9GLpasZrv1LuErd9D7d5XWPRn/0G3hWQEOhFRGasz5E=; b=TIAIm3sSQXHL6M+tdYhhGaIi8I600fNMQ4Oy0HRL4heaxCcVvSs4M5BdJmiPLhO6fO h43tMkDnh20h6p2+ufdhPsmqjagBIk5dbunq79wngAyTUIHym2AlKJaaEjqVOVYMaVvM +7MlLbAdvMnuc5Y74l8H8heY6ow4fR6EJl8ZQxXuSE7LBNs+bZBOIFT06LIlBvfLn3L5 DyJ3aecPnOLQTEc3ga0sZEUqn1XomoWOTeZFp93tI8P1SKEn9/3ztiOT+L/Eq1/+G7CC Y6V+5GBZOuHTRmAH8Kgq9N2/3qblY2ouvVYPg6em2EKOAZgcdOq9UZfP+aX42BuASYy3 ckuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9GLpasZrv1LuErd9D7d5XWPRn/0G3hWQEOhFRGasz5E=; b=mLaaCmvmvO1cyfZwAH8C2bMPHvMvWoM5IsqYpG3puPcFwAZDrICGtsF87UH3V9oUbD ZqsqQOZe8Lw2sHCpTsxBrgAqY6xlMjiQhKp2WGQwGljtWilNjQm+BlNgAZa2AFqGFi2l ozT7J486f+7l2qGh6VfgD0e5Cmprv7UYqs7O/hG6oMihM8H6d853bJsJNXKZzJ6kGQxh YKkOUsLcZx3151deU1LLDf0obYDTwdTVv1/EPeYB3Lsy744v0zJn/tgdo9FpFQTlZSdE KGzDqAUwoEhHFzaXtn98HAmqtoGCVGHC0vQvp5UxF2sB+2XAE0dDgqca+X9MLS0gs6vk 43HQ== X-Gm-Message-State: ANhLgQ3s6UOcH4WrQ+e/BNAiCc4IXw0s9bUqbDa7UqnnZoKKLr+X8pzb AzYbdo4HY9ev6YZr1sapWss7CYIvvA== X-Google-Smtp-Source: ADFU+vsilRQZdTv7xVpS6CTVGBuah9rLMJPs1GD2bstwT42rDHVyQWfchXtMzneVKmK3lpR0cJw+NA== X-Received: by 2002:a05:6000:1212:: with SMTP id e18mr10514245wrx.0.1585487901339; Sun, 29 Mar 2020 06:18:21 -0700 (PDT) Received: from localhost.localdomain (catv-176-63-20-200.catv.broadband.hu. [176.63.20.200]) by smtp.gmail.com with ESMTPSA id b67sm16622328wmh.29.2020.03.29.06.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2020 06:18:21 -0700 (PDT) From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Sun, 29 Mar 2020 15:18:10 +0200 Message-Id: <20200329131810.23562-3-boskovits@gmail.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200329131810.23562-1-boskovits@gmail.com> References: <20200329131810.23562-1-boskovits@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 13:18:27 -0000 * .gitignore: Add /tests/fake-home/.guix-profile. Ignore test result files in tests subdirectories. Ignore top level files staring with t-. --- .gitignore | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index de058dda5e..19aae6c5ae 100644 --- a/.gitignore +++ b/.gitignore @@ -137,7 +137,8 @@ /scripts/guix /test-env /test-tmp -/tests/*.trs +/tests/**/*.trs +/tests/fake-home/.guix-profile GPATH GRTAGS GTAGS @@ -152,3 +153,4 @@ tmp /.version /doc/stamp-[0-9] /gnu/packages/bootstrap +/t-* \ No newline at end of file -- 2.25.0 From unknown Sun Jun 22 11:44:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37679: Local git configuration interferes with testsuite Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 17 Apr 2020 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37679 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: 37679@debbugs.gnu.org Received: via spool by 37679-submit@debbugs.gnu.org id=B37679.158711317929634 (code B ref 37679); Fri, 17 Apr 2020 08:47:02 +0000 Received: (at 37679) by debbugs.gnu.org; 17 Apr 2020 08:46:19 +0000 Received: from localhost ([127.0.0.1]:39921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPMde-0007ht-PY for submit@debbugs.gnu.org; Fri, 17 Apr 2020 04:46:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPMdZ-0007hc-5L for 37679@debbugs.gnu.org; Fri, 17 Apr 2020 04:46:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jPMdT-0002tJ-U8; Fri, 17 Apr 2020 04:46:08 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43790 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jPMdS-0003Hw-WB; Fri, 17 Apr 2020 04:46:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Fri, 17 Apr 2020 10:46:04 +0200 In-Reply-To: ("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Wed, 9 Oct 2019 12:35:58 +0200") Message-ID: <87pnc6biur.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi G=C3=A1bor, G=C3=A1bor Boskovits skribis: > +AM_TESTS_ENVIRONMENT =3D \ > + abs_top_srcdir=3D"$(abs_top_srcdir)" \ > + GUILE_AUTO_COMPILE=3D0 \ > + GIT_CONFIG_NOSYSTEM=3D1 \ > + GIT_ATTR_NOSYSTEM=3D1 \ > + HOME=3D"$(abs_top_srcdir)/tests/fake-home" \ > + XDG_CONFIG_HOME=3D"$(abs_top_srcdir)/tests/fake-xgd-config-home" As discussed on IRC yesterday (?), we can arrange to move these variables directly in (guix tests git), which is the only place where =E2=80=98git=E2=80=99 is invoked. That way, it can=E2=80=99t possibly inte= rfere with other uses of HOME, etc. WDYT of something like the patch below? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/guix/tests/git.scm b/guix/tests/git.scm index 21573ac14e..54d306fbba 100644 --- a/guix/tests/git.scm +++ b/guix/tests/git.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright =C2=A9 2019 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2019, 2020 Ludovic Court=C3=A8s ;;; ;;; This file is part of GNU Guix. ;;; @@ -30,6 +30,23 @@ (define git-command (make-parameter "git")) =20 +(define (call-with-environment-variables variables thunk) + (let ((environment (environ))) + (dynamic-wind + (lambda () + (for-each (match-lambda + ((variable value) + (setenv variable value))) + variables)) + thunk + (lambda () + (environ environment))))) + +(define-syntax-rule (with-environment-variables variables exp ...) + "Evaluate EXP with the given environment VARIABLES set." + (call-with-environment-variables variables + (lambda () exp ...))) + (define (populate-git-repository directory directives) "Initialize a new Git checkout and repository in DIRECTORY and apply DIRECTIVES. Each element of DIRECTIVES is an sexp like: @@ -41,8 +58,21 @@ Return DIRECTORY on success." ;; Note: As of version 0.2.0, Guile-Git lacks the necessary bindings to = do ;; all this, so resort to the "git" command. (define (git command . args) - (apply invoke (git-command) "-C" directory - command args)) + ;; Make sure Git doesn't rely on the user's config. + (call-with-temporary-directory + (lambda (home) + (call-with-output-file (string-append home "/.gitconfig") + (lambda (port) + (display "[user] + email =3D charlie@example.org\n name =3D Charlie Guix\n" + port))) + + (with-environment-variables + `(("GIT_CONFIG_NOSYSTEM" "1") + ("GIT_ATTR_NOSYSTEM" "1") + ("HOME" ,home)) + (apply invoke (git-command) "-C" directory + command args))))) =20 (mkdir-p directory) (git "init") @@ -59,7 +89,7 @@ Return DIRECTORY on success." (display (if (string? contents) contents (with-repository directory repository - (contents repository))) + (contents repository))) port))) (git "add" file) (loop rest))) --=-=-=-- From unknown Sun Jun 22 11:44:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Subject: bug#37679: closed (Re: bug#37679: Local git configuration interferes with testsuite) Message-ID: References: <87eesj3eak.fsf@gnu.org> X-Gnu-PR-Message: they-closed 37679 X-Gnu-PR-Package: guix Reply-To: 37679@debbugs.gnu.org Date: Sun, 19 Apr 2020 11:29:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1587295744-5245-1" This is a multi-part message in MIME format... ------------=_1587295744-5245-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #37679: Local git configuration interferes with testsuite which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 37679@debbugs.gnu.org. --=20 37679: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37679 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1587295744-5245-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 37679-done) by debbugs.gnu.org; 19 Apr 2020 11:28:50 +0000 Received: from localhost ([127.0.0.1]:44178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jQ882-0001MD-3d for submit@debbugs.gnu.org; Sun, 19 Apr 2020 07:28:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jQ87z-0001Lx-7p for 37679-done@debbugs.gnu.org; Sun, 19 Apr 2020 07:28:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50358) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQ87t-0003Al-Vr; Sun, 19 Apr 2020 07:28:42 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57858 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jQ87o-000562-DW; Sun, 19 Apr 2020 07:28:36 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?G=C3=A1bor?= Boskovits Subject: Re: bug#37679: Local git configuration interferes with testsuite References: <87pnc6biur.fsf@gnu.org> Date: Sun, 19 Apr 2020 13:28:35 +0200 In-Reply-To: <87pnc6biur.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 17 Apr 2020 10:46:04 +0200") Message-ID: <87eesj3eak.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37679-done Cc: 37679-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi G=C3=A1bor, Ludovic Court=C3=A8s skribis: > As discussed on IRC yesterday (?), we can arrange to move these > variables directly in (guix tests git), which is the only place where > =E2=80=98git=E2=80=99 is invoked. That way, it can=E2=80=99t possibly in= terfere with other uses > of HOME, etc. > > WDYT of something like the patch below? I pushed it as 3c91f003416c9fb79af2dc8766a7f449aa03f839. Ludo=E2=80=99. ------------=_1587295744-5245-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Oct 2019 10:36:17 +0000 Received: from localhost ([127.0.0.1]:52192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI9KL-0005X4-1x for submit@debbugs.gnu.org; Wed, 09 Oct 2019 06:36:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:55668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI9KJ-0005Ws-BK for submit@debbugs.gnu.org; Wed, 09 Oct 2019 06:36:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57286) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI9KH-0002wB-Rf for bug-guix@gnu.org; Wed, 09 Oct 2019 06:36:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI9KG-0004HE-DH for bug-guix@gnu.org; Wed, 09 Oct 2019 06:36:13 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:33710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI9KG-0004Gw-69 for bug-guix@gnu.org; Wed, 09 Oct 2019 06:36:12 -0400 Received: by mail-ed1-x52b.google.com with SMTP id c4so1577637edl.0 for ; Wed, 09 Oct 2019 03:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=FVUBeYQJp/XYdL/lURnwotmnBSP4YZe4qmV1mtXZfAk=; b=uk5QX81RiJVjk6M6zZcqWdUCTp3Ocr/QsQc6uXHQGMsaOqjbZDA5XRXqZQSD5MSfPl SqkQnkW/hyU4gCFjCw2h96k2YGqin4NQbCPN45aZE2UlpyhTA+o3tV/syZRbtpWnm4AT YVDgTRceNh9ACSCmCcAaor494NjhtnXJXzjET4vmFfiQDXS4CRR8dNFVIxDIMnh25PH4 fIlpC5kZW/D8n9WGCmKE8KNnsKL5nzsj0gcdx5fCEwq62N6gUrD+FF9U7sevYpmcZRhP v/hiMkI680ccEeEm0VcIoN1b/PvT4MUe4ItZ3d3k1MUgogBLqhLS8VpKvkQDcog7tUQN LfxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=FVUBeYQJp/XYdL/lURnwotmnBSP4YZe4qmV1mtXZfAk=; b=AgEzZsQndT+vmA7ihC/ZQ+ygoLF1T3bB7GUPUXHc2l20pQHU82gX1nt8VQxuxdzeOf w6eajWTccymwFHVg5EARaMBZ55N10639bxk5Myt1TJet8rMRqF9YxBksCSVlbN0NnVAJ Ue2isAlXEIwmmMZg5EjIvfRuSjy1ciKUzsj1heP3YYKeihXtADbTLP1b8rsAH48LN/q/ JGm7PQSK05rHwjZYY3/veUuG8MDxjpZnMN3k1pPfqdtf5soUFEI7HyYZbaaR8An97/Zc sTH9YQX/Htccp0I6g9/K+nT+q6kFt0FON/5Ig1f3yv/wUPzAmUzJYL7HzvHqqW7VCNJm sBOg== X-Gm-Message-State: APjAAAVeoXGD5hbDz7sdDUhCpoytE0ADkqocVaE1Ny2Ul8OO3GmlYbDY PbktjMMTOdBkeb5aaY15eT3ZTvvZ05WlTCO5uerD X-Google-Smtp-Source: APXvYqxzFzVfu3TDBPIQU4sPtB69HgSbnzfpf6bXWJARHFv+umPVZdfzjcidX3GuxuZTCTJmx4DdAQ/clTsv8oMUMQc= X-Received: by 2002:a17:906:1655:: with SMTP id n21mr2084062ejd.110.1570617369901; Wed, 09 Oct 2019 03:36:09 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Wed, 9 Oct 2019 12:35:58 +0200 Message-ID: Subject: Local git configuration interferes with testsuite To: bug-guix@gnu.org Content-Type: multipart/mixed; boundary="00000000000069574a059477da30" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52b X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000069574a059477da30 Content-Type: multipart/alternative; boundary="000000000000695748059477da2e" --000000000000695748059477da2e Content-Type: text/plain; charset="UTF-8" I noticed that the local git configuration interferes with the guix test suite. After discussion on IRC with nckx I came up with the attached patch. Comments are welcome! Best regards, g_bor -- OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21 --000000000000695748059477da2e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I noticed that the local git configuration interferes= with the guix test suite.

After discussion on IRC= with nckx I came up with the attached patch. Comments are welcome!

Best regards,
g_bor
--
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:25= 06:A96C:CF63:0B21
--000000000000695748059477da2e-- --00000000000069574a059477da30 Content-Type: text/x-patch; charset="UTF-8"; name="0001-tests-Isolate-git-from-external-configuration.patch" Content-Disposition: attachment; filename="0001-tests-Isolate-git-from-external-configuration.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1j50e420 RnJvbSBhYmYyMDQ3N2VhMTM5YmZhZjFmMmUyMWYwOWMyNDIwZmU2MThjOWNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Rz1DMz1BMWJvcj0yMEJvc2tvdml0cz89IDxi b3Nrb3ZpdHNAZ21haWwuY29tPgpEYXRlOiBUdWUsIDggT2N0IDIwMTkgMjI6NDE6MjAgKzAyMDAK U3ViamVjdDogW1BBVENIXSB0ZXN0czogSXNvbGF0ZSBnaXQgZnJvbSBleHRlcm5hbCBjb25maWd1 cmF0aW9uLgoKKiBNYWtlZmlsZS5hbShBTV9URVNUU19FTlZJUk9OTUVOVCk6IEFkZCBlbnZpcm9u bWVudCB2YXJpYWJsZXMgdG8KbWFrZSBnaXQgaWdub3JlIHRoZSB1c2VyIGFuZCBzeXN0ZW0gY29u ZmlndXJhdGlvbiBmaWxlcy4KKiB0ZXN0cy9mYWtlLWhvbWUvLmdpdGNvbmZpZzogTmV3IGZpbGUu IFByb3ZpZGUgbWluaW1hbCBnaXQKY29uZmlndXJhdGlvbiBmb3IgdGVzdHMuCi0tLQogTWFrZWZp bGUuYW0gICAgICAgICAgICAgICAgfCAgOSArKysrKysrKy0KIHRlc3RzL2Zha2UtaG9tZS8uZ2l0 Y29uZmlnIHwgMjEgKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI5IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0cy9mYWtl LWhvbWUvLmdpdGNvbmZpZwoKZGlmZiAtLWdpdCBhL01ha2VmaWxlLmFtIGIvTWFrZWZpbGUuYW0K aW5kZXggMzY3NjdjMmY0Ny4uZTdiZjgxOWE2YiAxMDA2NDQKLS0tIGEvTWFrZWZpbGUuYW0KKysr IGIvTWFrZWZpbGUuYW0KQEAgLTE0LDYgKzE0LDcgQEAKICMgQ29weXJpZ2h0IMKpIDIwMTggT2xl ZyBQeWtoYWxvdiA8Z28ud2lndXN0QGdtYWlsLmNvbT4KICMgQ29weXJpZ2h0IMKpIDIwMTggQWxl eCBWb25nIDxhbGV4dm9uZzE5OTVAZ21haWwuY29tPgogIyBDb3B5cmlnaHQgwqkgMjAxOSBFZnJh aW0gRmxhc2huZXIgPGVmcmFpbUBmbGFzaG5lci5jby5pbD4KKyMgQ29weXJpZ2h0IMKpIDIwMTkg R8OhYm9yIEJvc2tvdml0cyA8Ym9za292aXRzQGdtYWlsLmNvbT4KICMKICMgVGhpcyBmaWxlIGlz IHBhcnQgb2YgR05VIEd1aXguCiAjCkBAIC00NzIsNyArNDczLDEzIEBAIFNIX1RFU1RTID0JCQkJ CVwKIAogVEVTVFMgPSAkKFNDTV9URVNUUykgJChTSF9URVNUUykKIAotQU1fVEVTVFNfRU5WSVJP Tk1FTlQgPSBhYnNfdG9wX3NyY2Rpcj0iJChhYnNfdG9wX3NyY2RpcikiIEdVSUxFX0FVVE9fQ09N UElMRT0wCitBTV9URVNUU19FTlZJUk9OTUVOVCA9IAkJCQlcCisgIGFic190b3Bfc3JjZGlyPSIk KGFic190b3Bfc3JjZGlyKSIgCQlcCisgIEdVSUxFX0FVVE9fQ09NUElMRT0wCQkJCVwKKyAgR0lU X0NPTkZJR19OT1NZU1RFTT0xCQkJCVwKKyAgR0lUX0FUVFJfTk9TWVNURU09MQkJCQlcCisgIEhP TUU9IiQoYWJzX3RvcF9zcmNkaXIpL3Rlc3RzL2Zha2UtaG9tZSIJXAorICBYREdfQ09ORklHX0hP TUU9IiQoYWJzX3RvcF9zcmNkaXIpL3Rlc3RzL2Zha2UteGdkLWNvbmZpZy1ob21lIgogCiBTQ01f TE9HX0RSSVZFUiA9CQkJCVwKICAgJCh0b3BfYnVpbGRkaXIpL3Rlc3QtZW52IC0tcXVpZXQtc3Rk ZXJyCVwKZGlmZiAtLWdpdCBhL3Rlc3RzL2Zha2UtaG9tZS8uZ2l0Y29uZmlnIGIvdGVzdHMvZmFr ZS1ob21lLy5naXRjb25maWcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4u MDc5Y2JkMGQzMAotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3RzL2Zha2UtaG9tZS8uZ2l0Y29uZmln CkBAIC0wLDAgKzEsMjEgQEAKKyMgR05VIEd1aXggLS0tIEZ1bmN0aW9uYWwgcGFja2FnZSBtYW5h Z2VtZW50IGZvciBHTlUKKyMgQ29weXJpZ2h0IMKpIDIwMTkgR8OhYm9yIEJvc2tvdml0cyA8Ym9z a292aXRzQGdtYWlsLmNvbT4KKyMKKyMgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCisj CisjIEdOVSBHdWl4IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFu ZC9vciBtb2RpZnkgaXQKKyMgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKyMgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv bjsgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3IgKGF0CisjIHlvdXIgb3B0aW9u KSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyMKKyMgR05VIEd1aXggaXMgZGlzdHJpYnV0ZWQgaW4gdGhl IGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwgYnV0CisjIFdJVEhPVVQgQU5ZIFdBUlJBTlRZ OyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyMgTUVSQ0hBTlRBQklMSVRZ IG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorIyBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorIworIyBZb3Ugc2hvdWxkIGhh dmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBh bG9uZyB3aXRoIEdOVSBHdWl4LiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LgorCitbdXNlcl0KKyAgZW1haWwgPSBlbWFpbEBleGFtcGxlLmNvbQorICBuYW1lID0g VXNtYW4KLS0gCjIuMjMuMAoK --00000000000069574a059477da30-- ------------=_1587295744-5245-1--