GNU bug report logs - #37673
[PATCH] Simplify the search of the default tags file in, `visit-tags-table'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Hong Xu <hong <at> topbug.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37673: closed ([PATCH] Simplify the search of the default
 tags file in, `visit-tags-table')
Date: Sat, 12 Oct 2019 18:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 12 Oct 2019 11:55:29 -0700
with message-id <b0adf89f-7f8d-b045-7c1a-a877f439f344 <at> topbug.net>
and subject line Re: [PATCH] Simplify the search of the default tags file in, `visit-tags-table'
has caused the debbugs.gnu.org bug report #37673,
regarding [PATCH] Simplify the search of the default tags file in, `visit-tags-table'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37673: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37673
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Hong Xu <hong <at> topbug.net>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Cc: Phil Sainty <psainty <at> orcon.net.nz>, Lars Ingebrigtsen <larsi <at> gnus.org>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: [PATCH] Simplify the search of the default tags file in,
 `visit-tags-table'
Date: Tue, 8 Oct 2019 21:59:40 -0700

* lisp/progmodes/etags.el (visit-tags-table): Reimplement
`tags--find-default-tags-dir-recursively' using the much simpler
`locate-dominating-file'. Following up bug#37518.
---
 lisp/progmodes/etags.el | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
index 906ab37c6b9f..6784894ba87e 100644
--- a/lisp/progmodes/etags.el
+++ b/lisp/progmodes/etags.el
@@ -274,19 +274,6 @@ tags-table-mode
   (setq buffer-undo-list t)
   (initialize-new-tags-table))

-(defun tags--find-default-tags-dir-recursively (current-dir)
-  "Find the directory in which the default TAGS file lives.
-It is the first directory that contains a file named TAGS
-encountered when recursively searching upward from CURRENT-DIR."
-  (let ((tag-filename (expand-file-name "TAGS" current-dir)))
-    (if (file-exists-p tag-filename)
-        current-dir
-      (let ((parent-dir
-             (file-name-directory (directory-file-name current-dir))))
-        (if (string= parent-dir current-dir)  ;; root dir is reached
-            nil
-          (tags--find-default-tags-dir-recursively parent-dir))))))
-
 ;;;###autoload
 (defun visit-tags-table (file &optional local)
   "Tell tags commands to use tags table file FILE.
@@ -301,7 +288,7 @@ visit-tags-table
 file the tag was in."
   (interactive
    (let ((default-tag-dir
-           (or (tags--find-default-tags-dir-recursively default-directory)
+           (or (locate-dominating-file default-directory "TAGS")
                default-directory)))
      (list (read-file-name
             "Visit tags table (default TAGS): "
--
2.20.1

[Message part 3 (message/rfc822, inline)]

From: Hong Xu <hong <at> topbug.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Phil Sainty <psainty <at> orcon.net.nz>, Eli Zaretskii <eliz <at> gnu.org>,
 37673-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Simplify the search of the default tags file in,
 `visit-tags-table'
Date: Sat, 12 Oct 2019 11:55:29 -0700

On 10/8/19 10:04 PM, Lars Ingebrigtsen wrote:
> Looks good to me; applied to Emacs 27 now.
> 

Shall we close this one?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.