GNU bug report logs - #37654
[PATCH] gnu-build-system: Don't try executing directories in bootstrap phase.

Previous Next

Full log

Message #8 received at 37654 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Brendan Tildesley <mail <at> brendan.scot>, 37654 <at> debbugs.gnu.org
Subject: Re: [bug#37654] [PATCH] gnu-build-system: Don't try executing
 directories in bootstrap phase.
Date: Thu, 30 Jan 2020 13:41:50 +0100

[Message part 1 (text/plain, inline)]

Hello Brendan, sorry for the sloooow response.

Brendan Tildesley <mail <at> brendan.scot> writes:

> I just made this after discovering a source repo with a bootstrap
> directory. Naturally it results in just about everything being rebuilt,
> so it would a long time to fully test it, and I'm no experienced schemer
> so I can't be sure this is the right way to add in this change. Feel
> free to rewrite it a better way.

Were you able to verify that it DTRT?

> From 3a602cccbd8711f40f6b981e5616289a5fdd0b56 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail <at> brendan.scot>
> Date: Tue, 8 Oct 2019 02:55:03 +1100
> Subject: [PATCH] gnu-build-system: Don't try executing directories in
>  bootstrap phase.
>
> * guix/build/gnu-build-system.scm: (bootstrap): Change the file-exists?
> procedure to one that excludes directories, so that we do not mistake it for a
> script. For example if the source includes a bootstrap/ directory.

The patch LGTM.

Will push it in a few days unless anyone protests!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.