From unknown Sat Sep 06 02:33:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37654 <37654@debbugs.gnu.org> To: bug#37654 <37654@debbugs.gnu.org> Subject: Status: [PATCH] gnu-build-system: Don't try executing directories in bootstrap phase. Reply-To: bug#37654 <37654@debbugs.gnu.org> Date: Sat, 06 Sep 2025 09:33:08 +0000 retitle 37654 [PATCH] gnu-build-system: Don't try executing directories in = bootstrap phase. reassign 37654 guix-patches submitter 37654 Brendan Tildesley severity 37654 normal tag 37654 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 23:39:25 2019 Received: (at submit) by debbugs.gnu.org; 8 Oct 2019 03:39:26 +0000 Received: from localhost ([127.0.0.1]:49328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHgLN-0002b6-JZ for submit@debbugs.gnu.org; Mon, 07 Oct 2019 23:39:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:38842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHgLL-0002ax-8T for submit@debbugs.gnu.org; Mon, 07 Oct 2019 23:39:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57249) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHgLJ-0003ug-TL for guix-patches@gnu.org; Mon, 07 Oct 2019 23:39:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHgLI-0000Ox-5s for guix-patches@gnu.org; Mon, 07 Oct 2019 23:39:21 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:63778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHgLH-0000Ly-KU for guix-patches@gnu.org; Mon, 07 Oct 2019 23:39:20 -0400 Received: from smtp2.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 7BE45A25EC for ; Tue, 8 Oct 2019 05:39:14 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1570505952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=egPKbU9ae9YutN8PVxXptovExje4g7R7qtgWz47ql9U=; b=tGY/SnHwUWj+rSQGwgJ9G50aI12r/PbwiC4y2p5ZM3qoGKICkIvYjQg/jCN9sQpLTJl0IH t1P7DXV8juyUYCb0tTsKLR6s9iItM5b6a7dVQpC/89LwHrdbrpYOahQXgX4m85pr11YIm5 nanPYMn4eU3/vns2l1EDv2YtMddi+leou7ts/WwkyarjUZ5eWC9ZQndhCgpLGmK6CqV01d UMy/bDkiqtw2lHUAI7Sr+K5riao9XBs6ZLjjf+3QdQbpxKVahSC3o/ZVHvCu2LIzz5hCn3 ZB403ZVfOGgVCfXJchRhDUcvtcOV8FW5FrOS8HTlyIDtmTSuD1aQJ5SOTqIN5w== Received: from smtp2.mailbox.org ([80.241.60.240]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id CzBxTXI7LX75 for ; Tue, 8 Oct 2019 05:39:11 +0200 (CEST) To: guix-patches@gnu.org From: Brendan Tildesley Subject: [PATCH] gnu-build-system: Don't try executing directories in bootstrap phase. Message-ID: <4ed4493a-5d41-9bad-d81d-6082e3b1f151@brendan.scot> Date: Tue, 8 Oct 2019 14:39:05 +1100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E2A22CF87F90B47E9E3CD128" Content-Language: en-AU X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.241.60.215 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------E2A22CF87F90B47E9E3CD128 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit I just made this after discovering a source repo with a bootstrap directory. Naturally it results in just about everything being rebuilt, so it would a long time to fully test it, and I'm no experienced schemer so I can't be sure this is the right way to add in this change. Feel free to rewrite it a better way. --------------E2A22CF87F90B47E9E3CD128 Content-Type: text/x-patch; name="0001-gnu-build-system-Don-t-try-executing-directories-in-.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-gnu-build-system-Don-t-try-executing-directories-in-.pa"; filename*1="tch" >From 3a602cccbd8711f40f6b981e5616289a5fdd0b56 Mon Sep 17 00:00:00 2001 From: Brendan Tildesley Date: Tue, 8 Oct 2019 02:55:03 +1100 Subject: [PATCH] gnu-build-system: Don't try executing directories in bootstrap phase. * guix/build/gnu-build-system.scm: (bootstrap): Change the file-exists? procedure to one that excludes directories, so that we do not mistake it for a script. For example if the source includes a bootstrap/ directory. --- guix/build/gnu-build-system.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm index e5f3197b0a..6b4e74721b 100644 --- a/guix/build/gnu-build-system.scm +++ b/guix/build/gnu-build-system.scm @@ -177,12 +177,16 @@ working directory." \"autoreconf\". Otherwise do nothing." ;; Note: Run that right after 'unpack' so that the generated files are ;; visible when the 'patch-source-shebangs' phase runs. - (if (not (file-exists? "configure")) + (define (script-exists? file) + (and (file-exists? file) + (not (file-is-directory? file)))) + + (if (not (script-exists? "configure")) ;; First try one of the BOOTSTRAP-SCRIPTS. If none exists, and it's ;; clearly an Autoconf-based project, run 'autoreconf'. Otherwise, do ;; nothing (perhaps the user removed or overrode the 'configure' phase.) - (let ((script (find file-exists? bootstrap-scripts))) + (let ((script (find script-exists? bootstrap-scripts))) ;; GNU packages often invoke the 'git-version-gen' script from ;; 'configure.ac' so make sure it has a valid shebang. (false-if-file-not-found -- 2.23.0 --------------E2A22CF87F90B47E9E3CD128-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 30 07:42:01 2020 Received: (at 37654) by debbugs.gnu.org; 30 Jan 2020 12:42:01 +0000 Received: from localhost ([127.0.0.1]:35034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix98z-00039T-AT for submit@debbugs.gnu.org; Thu, 30 Jan 2020 07:42:01 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:59361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix98x-00039G-Ct for 37654@debbugs.gnu.org; Thu, 30 Jan 2020 07:42:00 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 7F74F359; Thu, 30 Jan 2020 07:41:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 30 Jan 2020 07:41:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=9ddSSCwMlxB+w6kcuIhx9owHIR 42/LF2l8ioXBB9DOI=; b=Tb9CQ109olO36XvXVlrpV15dwGdGqhR/fYM7R/9Oa1 LsFiehfbL4DyKTEySaF+PoR0HcUhTZUTjse5E16goQgfat277s50MH6QJr9udM2m 63FVGZEMM7ZrTr4MgOJfVma0tOBR1pBDEiRMO4Rl7xopjGiwlDoztxyPWMhtdU0h VzMMyMg8aXLU/jDo8CgHOm7J5XrRXV5igrXjt4nfSCDJgNvt55krviJJwUBVVEXy VNQ39acWa8Tvt6KOAQfvCJpxp2jTce3aLDN/Dwq7m3t61faeAOqbyKc+Ct5UnLCX rHV+gKHhtYYqxeGKBEejPEkTagZLGffvZJ3GYSrBU9iQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9ddSSC wMlxB+w6kcuIhx9owHIR42/LF2l8ioXBB9DOI=; b=YV0KbphQAPZDrzn9tQEDJ2 IoI+RtquPCOEmoj+3vwYK/ZxNIyV1pUIDeZSwyhlu1kRVPXWccVu0eWMDZq/hcV3 2vZsPRg0Nc2viRR2M4utOcEe0GvgJHWV3QlfCXlUYfO6yKamVTv41qLPSYWRMp/k 9HXG5+rPsPejheGlgdijeRCdHk+UwSl7XWHKPedZz2PUxcq+T3KyYdMZs36gtxiA eVWTYbwft9dEFEmlSUUkUQo1zCu8Fc75JSASVfda78tAGxxPVQkSX8G7ZHrLERgS 8uX0wt9/UWWin6tJ+pUZ8i9f4Rcm33nkYoXa+0iKbUSpQtLHKkC2PC1yTkDZ6EqA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeekgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucfkphepkeegrddvtddvrdeiledrvdehfeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-3035.bb.online.no [84.202.69.253]) by mail.messagingengine.com (Postfix) with ESMTPA id 884283280065; Thu, 30 Jan 2020 07:41:52 -0500 (EST) From: Marius Bakke To: Brendan Tildesley , 37654@debbugs.gnu.org Subject: Re: [bug#37654] [PATCH] gnu-build-system: Don't try executing directories in bootstrap phase. In-Reply-To: <4ed4493a-5d41-9bad-d81d-6082e3b1f151@brendan.scot> References: <4ed4493a-5d41-9bad-d81d-6082e3b1f151@brendan.scot> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Thu, 30 Jan 2020 13:41:50 +0100 Message-ID: <87r1zhnmk1.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37654 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello Brendan, sorry for the sloooow response. Brendan Tildesley writes: > I just made this after discovering a source repo with a bootstrap > directory. Naturally it results in just about everything being rebuilt, > so it would a long time to fully test it, and I'm no experienced schemer > so I can't be sure this is the right way to add in this change. Feel > free to rewrite it a better way. Were you able to verify that it DTRT? > From 3a602cccbd8711f40f6b981e5616289a5fdd0b56 Mon Sep 17 00:00:00 2001 > From: Brendan Tildesley > Date: Tue, 8 Oct 2019 02:55:03 +1100 > Subject: [PATCH] gnu-build-system: Don't try executing directories in > bootstrap phase. > > * guix/build/gnu-build-system.scm: (bootstrap): Change the file-exists? > procedure to one that excludes directories, so that we do not mistake it for a > script. For example if the source includes a bootstrap/ directory. The patch LGTM. Will push it in a few days unless anyone protests! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4yzw4ACgkQoqBt8qM6 VPrxYAf8Ci5dwhyGjJmPv818dHK1fQU2szna306sGLvt2/PjRsyw7BxiiXImanzT Oy0TJG+m8gQY6N1yTMtdsA7DCFLsRx9b+8Cnd5KupGBHkJYZWSFLxbzeHcnSitFy HnAelWtPJ7eJJ46zB1MLUim9dRZOECtGWiYE/MPpIcw5vx2YkXEAlVb1UJcLDxxH jDhv1Z2B0fijw0eI/mehiFiXWc8pj4k+NgjyvNILo4SeD7N0lOs8G4aQONrTEm94 vgFu8KsKEiB3qAgL/ORIi61V/YgnWgrYa37hsBVkatg5CxmdHrhy3XhN3TyYmA7h A2/2koI2q/Z6KM7Bheb6gFJQkOtLcw== =JAYq -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 16 10:47:21 2020 Received: (at 37654-done) by debbugs.gnu.org; 16 Feb 2020 15:47:21 +0000 Received: from localhost ([127.0.0.1]:37590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3M8f-00006M-BT for submit@debbugs.gnu.org; Sun, 16 Feb 2020 10:47:21 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:57997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3M8d-00006A-Mx for 37654-done@debbugs.gnu.org; Sun, 16 Feb 2020 10:47:20 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DF3D9661; Sun, 16 Feb 2020 10:47:13 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 16 Feb 2020 10:47:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=AG7BfkGXLUNeJgfYu08vfHIA4c rRTneG6iaH1FqWfc0=; b=PtWt9Uj6Wo1BtLSQJNl/30R2HyjM9I/1VBK2Cd/Hfw Hi3xkOv5Ma6ep5dZumRTg27E3DZbLY1pAOQ6R5P4unwDcI5gnqlAZgWZEEcHAOA4 jUwJuedY4NLDV3j9voLtrDkBS/PG7bkvZsJpuSN6Af4AVsZqh0gecsYUmF1+mJXe Vrt53pE8eKmnVFIkpOKKVxmiYMF0Ka2rhv+cT7RRe9Kn0hCefoHwzOUNcOap6Ycz mhaIy1V5NTZfYAG15zTGVmBhdb3oSBmwePXWW9KIhQuv33aOkyZVRP20j+vuPfy0 EfjwbW4QY7712gw+U8f+8RabnetG7fB8bDnzFgudviHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=AG7Bfk GXLUNeJgfYu08vfHIA4crRTneG6iaH1FqWfc0=; b=Ozo1T4MWOByBNNA450CAra q1NqaV4f/dPXBsQ38Gpk//mJzLsc4oOI+6tchbxJJ4XHRYrJENvnONq+FL4ag+2G MjuGyFuXStF74DdbMjCcZeh7VfeAnKiw2PcCiCkGAZamrkOLGaqcpUXVzvv3R9ec US6N5FH6XnkyyuzoW0ZTRTJwxXV++3l9SddR5XKZLKIGtGPSgfn2zjRVpubi5YSf IaWFt8P3tyHZ8R/6q1yq3lE+Zflr/gVnfmKk4mry8BaV35QgUwm861PSsZE2gbeW 1CQfJxFuCs8lWZS+fNspYUMY5yGFO+1gixyxKNo99OI18VUQWZBuXnd8UHIkPeLA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeggdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucfkphepkeegrddvtddvrdeikedrjeehnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhm rghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id EC8053280060; Sun, 16 Feb 2020 10:47:12 -0500 (EST) From: Marius Bakke To: Brendan Tildesley , 37654-done@debbugs.gnu.org Subject: Re: [bug#37654] [PATCH] gnu-build-system: Don't try executing directories in bootstrap phase. In-Reply-To: <4ed4493a-5d41-9bad-d81d-6082e3b1f151@brendan.scot> References: <4ed4493a-5d41-9bad-d81d-6082e3b1f151@brendan.scot> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sun, 16 Feb 2020 16:47:11 +0100 Message-ID: <87v9o65ybk.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37654-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Brendan Tildesley writes: > Subject: [PATCH] gnu-build-system: Don't try executing directories in > bootstrap phase. > > * guix/build/gnu-build-system.scm: (bootstrap): Change the file-exists? > procedure to one that excludes directories, so that we do not mistake it for a > script. For example if the source includes a bootstrap/ directory. Finally pushed in a21bd6d5c208111fbf96e9b402cc5ca872f95109, thanks! I also added a copyright line for you, hope that was okay. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl5JY/8ACgkQoqBt8qM6 VPrm9wf/feMulre4zlgOHF4yNYbRErFr3vZWrOfxjlcdr64W3Yyw1X17lExNs6GQ kZhPlscJR1d24+A0BKVGSXNM/+xKjjpy1czGFEolrF3ErXeuww/6aohvMXmPg0+a nW/LlaM93rTJ+1bW20il9Y8Q4BEW7SB9oopFj0C4lTRz8P6aKuxgTMjwszkZltOW iFYwaGG3PU07hxg7KKlqYhK/2b9MRUQE0WLujAxvBjYsudVh3XakdQNQxwvKX2D2 poOw1RfzHL9CSujsZY2BKEDUoA5KOr+UWAs+vkzh6dMstARbRXA6kIl38GU6vq0R hg0Ubc68Uc3AGSZvfwvwbQAIZwQP+A== =xhET -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 02:33:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Mar 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator