GNU bug report logs - #37630
27.0.50; image-mode-fit-frame doesn't

Previous Next

Full log

Message #79 received at 37630 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 37630 <at> debbugs.gnu.org
Subject: Re: bug#37630: 27.0.50; image-mode-fit-frame doesn't
Date: Wed, 23 Mar 2022 18:30:55 +0100

martin rudalics <rudalics <at> gmx.at> writes:

> A silly one.  For historical reason, 'set-frame-height' expects a "text
> height" as argument.  'frame-pixel-height' OTOH returns the "native
> height" of the frame.  How these relate is explained in sections 30.3.1
> and 30.3.4 of the Elisp Manual.  The idempotent operation you have in
> mind is probably
>
> (set-frame-height nil (frame-text-height) nil t)
>
> although with a GTK build you usually won't notice the difference.

Ah, right.

I've poked at the image-mode-fit-frame code some more to see whether we
could use frame-text-height directly without any further changes, but
that makes the frame too short.  So there's something not adding up in
the computations it does, but it's not clear what, exactly.

Perhaps somebody else should take a peek at it...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.