GNU bug report logs - #37630
27.0.50; image-mode-fit-frame doesn't

Previous Next

Package: emacs;

Reported by: Eli Zaretskii <eliz <at> gnu.org>

Date: Sat, 5 Oct 2019 09:11:01 UTC

Severity: normal

Found in version 27.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 37630 <at> debbugs.gnu.org
Subject: bug#37630: 27.0.50; image-mode-fit-frame doesn't
Date: Wed, 23 Mar 2022 18:07:48 +0100
>>>> (set-frame-height nil (frame-pixel-height) nil t)
>>>
>>> Yes, it does here: the resulting frame is 2 lines taller.
>>
>> So it does here (with a non-toolkit build); I didn't notice.  (It does
>> nothing in a Gtk build.)
>>
>> I guess that's a bug in `set-frame-height'?
>
> It could also be a feature.  Martin?

A silly one.  For historical reason, 'set-frame-height' expects a "text
height" as argument.  'frame-pixel-height' OTOH returns the "native
height" of the frame.  How these relate is explained in sections 30.3.1
and 30.3.4 of the Elisp Manual.  The idempotent operation you have in
mind is probably

(set-frame-height nil (frame-text-height) nil t)

although with a GTK build you usually won't notice the difference.

martin




This bug report was last modified 3 years and 119 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.