GNU bug report logs - #37592
Using tabs in EWW

Previous Next

Full log

Message #11 received at 37592 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 37592 <at> debbugs.gnu.org
Subject: Re: bug#37592: Using tabs in EWW
Date: Thu, 03 Oct 2019 05:44:27 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Date: Wed, 02 Oct 2019 23:31:17 +0300
> 
> Like <C-mouse-1> in web browsers opens links in a new tab,
> the attached patch does the same for EWW.
> 
> The change that implements support for tabs in EWW is just 3 lines:
> 
>     (when eww-browse-url-new-window-is-tab
>       (let ((tab-bar-new-tab-choice t))
>         (tab-new)))
> 
> Everything else is replicating the existing code:
> 
> 1. A new defcustom eww-browse-url-new-window-is-tab is a copy
>    of existing browse-url-firefox-new-window-is-tab
> 
> 2. The docstring for eww-browse-url is copied from browse-url-firefox
> 
> 3. The code for shr-browse-url is copied from browse-url-at-point

Instead of adding another defcustom, how about doing this by default
if tab-bar-mode is enabled?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.