From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 16:33:50 2019 Received: (at submit) by debbugs.gnu.org; 2 Oct 2019 20:33:50 +0000 Received: from localhost ([127.0.0.1]:38412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFlJm-0008Ot-1y for submit@debbugs.gnu.org; Wed, 02 Oct 2019 16:33:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:58714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFlJh-0008Oj-P4 for submit@debbugs.gnu.org; Wed, 02 Oct 2019 16:33:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32838) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFlJe-0007na-9j for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 16:33:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFlJb-0006Ik-MY for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 16:33:41 -0400 Received: from anteater.elm.relay.mailchannels.net ([23.83.212.3]:56362) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFlJb-0006Gj-83 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2019 16:33:39 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 3FFDA8C1274 for ; Wed, 2 Oct 2019 20:33:36 +0000 (UTC) Received: from pdx1-sub0-mail-a65.g.dreamhost.com (100-96-91-70.trex.outbound.svc.cluster.local [100.96.91.70]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9568F8C2EC5 for ; Wed, 2 Oct 2019 20:33:35 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a65.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Wed, 02 Oct 2019 20:33:36 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Industry-Shrill: 2b4df85b202786a9_1570048415848_260023891 X-MC-Loop-Signature: 1570048415848:2313092419 X-MC-Ingress-Time: 1570048415847 Received: from pdx1-sub0-mail-a65.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a65.g.dreamhost.com (Postfix) with ESMTP id 28C198584B for ; Wed, 2 Oct 2019 13:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=6uUf6wrmj6iwIXTnAwh4xNNG+WE=; b=q2giUMCXgW2+c5s6W WD87ruuv3VlxovmbjBzYWTf/D+sfWLdWorhjtbM7dlfjSv9efjtgeJjG8sUJGQY4 UoihShUcMmR6rN6GU+AaR9fwz/I/+JekD/vEowge0TCIypr3iON4Gspvz3gsEDjU Eo7xN6fkWijwBRj15gOZlhUHes= Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a65.g.dreamhost.com (Postfix) with ESMTPSA id 4B2DB8583D for ; Wed, 2 Oct 2019 13:33:28 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a65 From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Using tabs in EWW Organization: LINKOV.NET Date: Wed, 02 Oct 2019 23:31:17 +0300 Message-ID: <87r23uga96.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrgeeigdduhedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohffkfgfgggtsehmtderredtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleelrdelleenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdelledrleelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.212.3 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Severity: wishlist Tags: patch Like in web browsers opens links in a new tab, the attached patch does the same for EWW. The change that implements support for tabs in EWW is just 3 lines: (when eww-browse-url-new-window-is-tab (let ((tab-bar-new-tab-choice t)) (tab-new))) Everything else is replicating the existing code: 1. A new defcustom eww-browse-url-new-window-is-tab is a copy of existing browse-url-firefox-new-window-is-tab 2. The docstring for eww-browse-url is copied from browse-url-firefox 3. The code for shr-browse-url is copied from browse-url-at-point --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=eww-tabs.patch diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fb495a9858..a39f8b87cc 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -876,9 +876,32 @@ eww-mode (buffer-disable-undo) (setq buffer-read-only t)) +(defcustom eww-browse-url-new-window-is-tab nil + "Whether to open up new windows in a tab or a new buffer. +If non-nil, then open the URL in a new tab rather than a new buffer if +`eww-browse-url' is asked to open it in a new window." + :version "27.1" + :group 'eww + :type 'boolean) + ;;;###autoload (defun eww-browse-url (url &optional new-window) + "Ask the EWW browser to load URL. + +Interactively, if the variable `browse-url-new-window-flag' is non-nil, +loads the document in a new buffer tab on the window tab-line. A non-nil +prefix argument reverses the effect of `browse-url-new-window-flag'. + +If `eww-browse-url-new-window-is-tab' is non-nil, then +whenever a document would otherwise be loaded in a new buffer, it +is loaded in a new tab in the tab-bar on an existing frame. + +Non-interactively, this uses the optional second argument NEW-WINDOW +instead of `browse-url-new-window-flag'." (when new-window + (when eww-browse-url-new-window-is-tab + (let ((tab-bar-new-tab-choice t)) + (tab-new))) (pop-to-buffer-same-window (generate-new-buffer (format "*eww-%s*" (url-host (url-generic-parse-url diff --git a/lisp/net/shr.el b/lisp/net/shr.el index ef236bf7c4..390be4deff 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -201,6 +201,7 @@ shr-map (define-key map [?\M-\t] 'shr-previous-link) (define-key map [follow-link] 'mouse-face) (define-key map [mouse-2] 'shr-browse-url) + (define-key map [C-down-mouse-1] 'shr-mouse-browse-url-new-window) (define-key map "I" 'shr-insert-image) (define-key map "w" 'shr-maybe-probe-and-copy-url) (define-key map "u" 'shr-maybe-probe-and-copy-url) @@ -967,7 +968,13 @@ shr-mouse-browse-url (mouse-set-point ev) (shr-browse-url)) -(defun shr-browse-url (&optional external mouse-event) +(defun shr-mouse-browse-url-new-window (ev) + "Browse the URL under the mouse cursor in a new window." + (interactive "e") + (mouse-set-point ev) + (shr-browse-url nil nil t)) + +(defun shr-browse-url (&optional external mouse-event new-window) "Browse the URL at point using `browse-url'. If EXTERNAL is non-nil (interactively, the prefix argument), browse the URL using `browse-url-secondary-browser-function'. @@ -987,7 +994,9 @@ shr-browse-url (progn (funcall browse-url-secondary-browser-function url) (shr--blink-link)) - (browse-url url)))))) + (browse-url url (if new-window + (not browse-url-new-window-flag) + browse-url-new-window-flag))))))) (defun shr-save-contents (directory) "Save the contents from URL in a file." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 18:31:49 2019 Received: (at 37592) by debbugs.gnu.org; 2 Oct 2019 22:31:49 +0000 Received: from localhost ([127.0.0.1]:38484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFn9w-0004Jo-Pa for submit@debbugs.gnu.org; Wed, 02 Oct 2019 18:31:49 -0400 Received: from egyptian.birch.relay.mailchannels.net ([23.83.209.56]:33933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFn9u-0004H9-Gy for 37592@debbugs.gnu.org; Wed, 02 Oct 2019 18:31:47 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1962D8C1AAB for <37592@debbugs.gnu.org>; Wed, 2 Oct 2019 22:31:45 +0000 (UTC) Received: from pdx1-sub0-mail-a65.g.dreamhost.com (100-96-86-26.trex.outbound.svc.cluster.local [100.96.86.26]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 940398C18C8 for <37592@debbugs.gnu.org>; Wed, 2 Oct 2019 22:31:44 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a65.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Wed, 02 Oct 2019 22:31:44 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Glossy-Towering: 24a0accb5e611aa2_1570055504843_544976318 X-MC-Loop-Signature: 1570055504843:2462752568 X-MC-Ingress-Time: 1570055504842 Received: from pdx1-sub0-mail-a65.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a65.g.dreamhost.com (Postfix) with ESMTP id 563AC85866 for <37592@debbugs.gnu.org>; Wed, 2 Oct 2019 15:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=HSUmujjPfkhlrrGxeJ3lLSVxPYQ=; b= oMDSIQC8Yn8HJqSSO5w2S5UUq57WCjClRYrOaLZyu5Z7wawGmURmbWJq72SxMY3T pU2uU4XirCD+rV14dxyuW8L3nCqhkYUz7lvKLe1zKJcOMf60Y/FU4HKMAUhu1cwp Gp64I/qZEsWjzamsX1JQB0qXeQcWgaUvpblckvJ2Q1g= Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a65.g.dreamhost.com (Postfix) with ESMTPSA id 142E385851 for <37592@debbugs.gnu.org>; Wed, 2 Oct 2019 15:31:37 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a65 From: Juri Linkov To: 37592@debbugs.gnu.org Subject: Re: bug#37592: Using tabs in EWW Organization: LINKOV.NET References: <87r23uga96.fsf@mail.linkov.net> Date: Thu, 03 Oct 2019 00:20:24 +0300 In-Reply-To: <87r23uga96.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 02 Oct 2019 23:31:17 +0300") Message-ID: <87pnjeesav.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrgeejgddtlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrleelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleelrdelledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopeefjeehledvseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37592 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Addendum: diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fb495a9858..88a351adb1 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -369,6 +369,9 @@ eww-open-in-new-buffer (interactive) (let ((url (eww-suggested-uris))) (if (null url) (user-error "No link at point") + (when eww-browse-url-new-window-is-tab + (let ((tab-bar-new-tab-choice t)) + (tab-new))) ;; clone useful to keep history, but ;; should not clone from non-eww buffer (with-current-buffer From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 22:44:51 2019 Received: (at 37592) by debbugs.gnu.org; 3 Oct 2019 02:44:51 +0000 Received: from localhost ([127.0.0.1]:38658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFr6o-0006U9-Pu for submit@debbugs.gnu.org; Wed, 02 Oct 2019 22:44:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFr6n-0006Tw-9g for 37592@debbugs.gnu.org; Wed, 02 Oct 2019 22:44:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iFr6h-0001PP-H8; Wed, 02 Oct 2019 22:44:43 -0400 Received: from [176.228.60.248] (port=1135 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iFr6g-0005SB-MG; Wed, 02 Oct 2019 22:44:43 -0400 Date: Thu, 03 Oct 2019 05:44:27 +0300 Message-Id: <83zhii7dkk.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87r23uga96.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 02 Oct 2019 23:31:17 +0300) Subject: Re: bug#37592: Using tabs in EWW References: <87r23uga96.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37592 Cc: 37592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Wed, 02 Oct 2019 23:31:17 +0300 > > Like in web browsers opens links in a new tab, > the attached patch does the same for EWW. > > The change that implements support for tabs in EWW is just 3 lines: > > (when eww-browse-url-new-window-is-tab > (let ((tab-bar-new-tab-choice t)) > (tab-new))) > > Everything else is replicating the existing code: > > 1. A new defcustom eww-browse-url-new-window-is-tab is a copy > of existing browse-url-firefox-new-window-is-tab > > 2. The docstring for eww-browse-url is copied from browse-url-firefox > > 3. The code for shr-browse-url is copied from browse-url-at-point Instead of adding another defcustom, how about doing this by default if tab-bar-mode is enabled? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 10:20:47 2019 Received: (at 37592) by debbugs.gnu.org; 3 Oct 2019 14:20:48 +0000 Received: from localhost ([127.0.0.1]:40708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG1yJ-0005ky-G2 for submit@debbugs.gnu.org; Thu, 03 Oct 2019 10:20:47 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG1yH-0005ko-Es for 37592@debbugs.gnu.org; Thu, 03 Oct 2019 10:20:45 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG1yC-0008Kr-Ov; Thu, 03 Oct 2019 16:20:43 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#37592: Using tabs in EWW References: <87r23uga96.fsf@mail.linkov.net> Date: Thu, 03 Oct 2019 16:20:40 +0200 In-Reply-To: <87r23uga96.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 02 Oct 2019 23:31:17 +0300") Message-ID: <87v9t5uczr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Like in web browsers opens links in a new tab, > the attached patch does the same for EWW. Sounds good -- in addition to adding this command and key binding, the rest of the code deals with whether "new window" means "new buffer" (as it does today) or whether it should mean "new tab"? As El [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37592 Cc: 37592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Like in web browsers opens links in a new tab, > the attached patch does the same for EWW. Sounds good -- in addition to adding this command and key binding, the rest of the code deals with whether "new window" means "new buffer" (as it does today) or whether it should mean "new tab"? As Eli pointed out, perhaps that should be determined by whether tab-bar-mode is on or off? Otherwise, it looks fine to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 19:19:32 2019 Received: (at 37592) by debbugs.gnu.org; 3 Oct 2019 23:19:32 +0000 Received: from localhost ([127.0.0.1]:41446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGANf-0006Y5-NB for submit@debbugs.gnu.org; Thu, 03 Oct 2019 19:19:31 -0400 Received: from buffalo.birch.relay.mailchannels.net ([23.83.209.24]:32799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGANd-0006Xr-TE for 37592@debbugs.gnu.org; Thu, 03 Oct 2019 19:19:30 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BAABD500D40; Thu, 3 Oct 2019 23:19:27 +0000 (UTC) Received: from pdx1-sub0-mail-a97.g.dreamhost.com (100-96-14-189.trex.outbound.svc.cluster.local [100.96.14.189]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0FF15500F50; Thu, 3 Oct 2019 23:19:27 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a97.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Thu, 03 Oct 2019 23:19:27 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thoughtful-Name: 3b6555e60c6a3f7e_1570144767271_4200664881 X-MC-Loop-Signature: 1570144767271:2504952015 X-MC-Ingress-Time: 1570144767271 Received: from pdx1-sub0-mail-a97.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a97.g.dreamhost.com (Postfix) with ESMTP id 938627F688; Thu, 3 Oct 2019 16:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=1SnHwPqBE9XmHihrgAkJdBWug8A=; b= y7RsRJ62xP4/SEAZLtJxAzDfp14fbANYDiFmn02PZ1KnTCDzK2pLIJ6SW/NTWWp9 pBdPXZPjWYjZF0pxDByfYCQrAYsDuvzT6VFWL0Nv4CupODWyXibUVnlUX2vDSY8n WVy/VOx41ae9yQQg5Vu4rDEPfpWHboArrDICbOXi5Mk= Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a97.g.dreamhost.com (Postfix) with ESMTPSA id CD1C97F682; Thu, 3 Oct 2019 16:19:17 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a97 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#37592: Using tabs in EWW Organization: LINKOV.NET References: <87r23uga96.fsf@mail.linkov.net> <83zhii7dkk.fsf@gnu.org> Date: Fri, 04 Oct 2019 01:39:42 +0300 In-Reply-To: <83zhii7dkk.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 Oct 2019 05:44:27 +0300") Message-ID: <87pnjdh1up.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrgeelgddvudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleelrdelleenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdelledrleelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepvghlihiisehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 37592 Cc: 37592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Like in web browsers opens links in a new tab, >> the attached patch does the same for EWW. >> >> The change that implements support for tabs in EWW is just 3 lines: >> >> (when eww-browse-url-new-window-is-tab >> (let ((tab-bar-new-tab-choice t)) >> (tab-new))) >> >> Everything else is replicating the existing code: >> >> 1. A new defcustom eww-browse-url-new-window-is-tab is a copy >> of existing browse-url-firefox-new-window-is-tab >> >> 2. The docstring for eww-browse-url is copied from browse-url-firefox >> >> 3. The code for shr-browse-url is copied from browse-url-at-point > > Instead of adding another defcustom, how about doing this by default > if tab-bar-mode is enabled? I guess the users still need to decide whether they want to open new tabs in the tab-bar (when eww-browse-url-new-window-is-tab is non-nil), or new tabs in the tab-line (when eww-browse-url-new-window-is-tab is nil) that just creates a new buffer displayed in the window-local tab-line - this is the current behavior. Another use case is that when tab-bar-mode is not yet enabled, users migth prefer that clicking on a link with a Ctrl key could enable the tab-bar and open a new tab in automatically enabled tab-bar. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 03:34:55 2019 Received: (at 37592) by debbugs.gnu.org; 4 Oct 2019 07:34:55 +0000 Received: from localhost ([127.0.0.1]:41651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGI75-0001nv-CF for submit@debbugs.gnu.org; Fri, 04 Oct 2019 03:34:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGI73-0001nh-71 for 37592@debbugs.gnu.org; Fri, 04 Oct 2019 03:34:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iGI6x-00069s-Ug; Fri, 04 Oct 2019 03:34:47 -0400 Received: from [176.228.60.248] (port=3545 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iGI6w-0007v4-Q6; Fri, 04 Oct 2019 03:34:47 -0400 Date: Fri, 04 Oct 2019 10:34:32 +0300 Message-Id: <83zhih55h3.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87pnjdh1up.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 04 Oct 2019 01:39:42 +0300) Subject: Re: bug#37592: Using tabs in EWW References: <87r23uga96.fsf@mail.linkov.net> <83zhii7dkk.fsf@gnu.org> <87pnjdh1up.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37592 Cc: 37592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 37592@debbugs.gnu.org > Date: Fri, 04 Oct 2019 01:39:42 +0300 > > > Instead of adding another defcustom, how about doing this by default > > if tab-bar-mode is enabled? > > I guess the users still need to decide whether they want to open > new tabs in the tab-bar (when eww-browse-url-new-window-is-tab is non-nil), > or new tabs in the tab-line (when eww-browse-url-new-window-is-tab is nil) > that just creates a new buffer displayed in the window-local tab-line - > this is the current behavior. > > Another use case is that when tab-bar-mode is not yet enabled, > users migth prefer that clicking on a link with a Ctrl key > could enable the tab-bar and open a new tab in automatically > enabled tab-bar. It seems to me that there are sensible defaults in each of these situations, and we could use those defaults unconditionally until users complained. Adding too many user options has a downside as well, you know. Just one opinion. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 18:37:15 2019 Received: (at 37592) by debbugs.gnu.org; 5 Oct 2019 22:37:15 +0000 Received: from localhost ([127.0.0.1]:45329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGsfq-0004xC-WE for submit@debbugs.gnu.org; Sat, 05 Oct 2019 18:37:15 -0400 Received: from beige.elm.relay.mailchannels.net ([23.83.212.16]:42266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGsfo-0004wy-8U for 37592@debbugs.gnu.org; Sat, 05 Oct 2019 18:37:13 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 00ECA5E131D; Sat, 5 Oct 2019 22:37:11 +0000 (UTC) Received: from pdx1-sub0-mail-a36.g.dreamhost.com (100-96-87-199.trex.outbound.svc.cluster.local [100.96.87.199]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 883985E180D; Sat, 5 Oct 2019 22:37:10 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a36.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.3); Sat, 05 Oct 2019 22:37:10 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Ski-Exultant: 7c579c8306936f9d_1570315030766_2216901645 X-MC-Loop-Signature: 1570315030766:277998764 X-MC-Ingress-Time: 1570315030766 Received: from pdx1-sub0-mail-a36.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTP id 706E381820; Sat, 5 Oct 2019 15:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=afSOZ6/uLwRbnKNnzeIl7pbY5qk=; b= hkriqOOi+9yrLeSJJV6qGmHNMMuXhU3U5payACX+eCDE0+7Hn4LvLJCT+Zi8/Q5A DyLY6XcEZIbtzD9DdukuIm4Bn6g7OD9dh4M+ujPF/2yPvJD91Z2C4K6cVMVd9fZA kai+95BfVbV8TfjoIZAFU5HyI/ggbwRItIMWIm2yOt0= Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTPSA id F3ACA8181E; Sat, 5 Oct 2019 15:37:03 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a36 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#37592: Using tabs in EWW Organization: LINKOV.NET References: <87r23uga96.fsf@mail.linkov.net> <83zhii7dkk.fsf@gnu.org> <87pnjdh1up.fsf@mail.linkov.net> <83zhih55h3.fsf@gnu.org> Date: Sun, 06 Oct 2019 01:35:40 +0300 In-Reply-To: <83zhih55h3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Oct 2019 10:34:32 +0300") Message-ID: <87zhieu8g3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrheefgddujeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrleelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleelrdelledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 37592 Cc: 37592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain >> > Instead of adding another defcustom, how about doing this by default >> > if tab-bar-mode is enabled? >> >> I guess the users still need to decide whether they want to open >> new tabs in the tab-bar (when eww-browse-url-new-window-is-tab is non-nil), >> or new tabs in the tab-line (when eww-browse-url-new-window-is-tab is nil) >> that just creates a new buffer displayed in the window-local tab-line - >> this is the current behavior. >> >> Another use case is that when tab-bar-mode is not yet enabled, >> users migth prefer that clicking on a link with a Ctrl key >> could enable the tab-bar and open a new tab in automatically >> enabled tab-bar. > > It seems to me that there are sensible defaults in each of these > situations, and we could use those defaults unconditionally until > users complained. > > Adding too many user options has a downside as well, you know. > > Just one opinion. I agree, let's try this heuristics to open new tabs when tab-bar-mode is enabled: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=eww-tabs.2.patch diff --git a/doc/misc/eww.texi b/doc/misc/eww.texi index b8821cbc29..d0a4c9a790 100644 --- a/doc/misc/eww.texi +++ b/doc/misc/eww.texi @@ -105,7 +105,10 @@ Basics @kindex M-RET The @kbd{M-@key{RET}} command (@code{eww-open-in-new-buffer}) opens the URL at point in a new EWW buffer, akin to opening a link in a new -``tab'' in other browsers. +``tab'' in other browsers. When @code{global-tab-line-mode} is +enabled, this buffer is displayed in the tab on the window tab line. +When @code{tab-bar-mode} is enabled, a new tab is created on the frame +tab bar. @findex eww-readable @kindex R diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fb495a9858..0756c6088b 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -369,6 +369,9 @@ eww-open-in-new-buffer (interactive) (let ((url (eww-suggested-uris))) (if (null url) (user-error "No link at point") + (when tab-bar-mode + (let ((tab-bar-new-tab-choice t)) + (tab-new))) ;; clone useful to keep history, but ;; should not clone from non-eww buffer (with-current-buffer @@ -878,7 +881,22 @@ eww-mode ;;;###autoload (defun eww-browse-url (url &optional new-window) + "Ask the EWW browser to load URL. + +Interactively, if the variable `browse-url-new-window-flag' is non-nil, +loads the document in a new buffer tab on the window tab-line. A non-nil +prefix argument reverses the effect of `browse-url-new-window-flag'. + +If `tab-bar-mode' is enabled, then whenever a document would +otherwise be loaded in a new buffer, it is loaded in a new tab +in the tab-bar on an existing frame. + +Non-interactively, this uses the optional second argument NEW-WINDOW +instead of `browse-url-new-window-flag'." (when new-window + (when tab-bar-mode + (let ((tab-bar-new-tab-choice t)) + (tab-new))) (pop-to-buffer-same-window (generate-new-buffer (format "*eww-%s*" (url-host (url-generic-parse-url diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 628cc17a5b..f3d5de9fb6 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -201,6 +201,7 @@ shr-map (define-key map [?\M-\t] 'shr-previous-link) (define-key map [follow-link] 'mouse-face) (define-key map [mouse-2] 'shr-browse-url) + (define-key map [C-down-mouse-1] 'shr-mouse-browse-url-new-window) (define-key map "I" 'shr-insert-image) (define-key map "w" 'shr-maybe-probe-and-copy-url) (define-key map "u" 'shr-maybe-probe-and-copy-url) @@ -967,7 +968,13 @@ shr-mouse-browse-url (mouse-set-point ev) (shr-browse-url)) -(defun shr-browse-url (&optional external mouse-event) +(defun shr-mouse-browse-url-new-window (ev) + "Browse the URL under the mouse cursor in a new window." + (interactive "e") + (mouse-set-point ev) + (shr-browse-url nil nil t)) + +(defun shr-browse-url (&optional external mouse-event new-window) "Browse the URL at point using `browse-url'. If EXTERNAL is non-nil (interactively, the prefix argument), browse the URL using `browse-url-secondary-browser-function'. @@ -987,7 +994,9 @@ shr-browse-url (progn (funcall browse-url-secondary-browser-function url) (shr--blink-link)) - (browse-url url)))))) + (browse-url url (if new-window + (not browse-url-new-window-flag) + browse-url-new-window-flag))))))) (defun shr-save-contents (directory) "Save the contents from URL in a file." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 13:23:13 2019 Received: (at 37592) by debbugs.gnu.org; 6 Oct 2019 17:23:13 +0000 Received: from localhost ([127.0.0.1]:46770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHAFV-0007ok-8M for submit@debbugs.gnu.org; Sun, 06 Oct 2019 13:23:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHAFT-0007oW-Fu for 37592@debbugs.gnu.org; Sun, 06 Oct 2019 13:23:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iHAFO-0003tm-4z; Sun, 06 Oct 2019 13:23:06 -0400 Received: from [176.228.60.248] (port=1166 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iHAFN-0004Bu-41; Sun, 06 Oct 2019 13:23:05 -0400 Date: Sun, 06 Oct 2019 20:22:57 +0300 Message-Id: <83d0f93i1a.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87zhieu8g3.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 06 Oct 2019 01:35:40 +0300) Subject: Re: bug#37592: Using tabs in EWW References: <87r23uga96.fsf@mail.linkov.net> <83zhii7dkk.fsf@gnu.org> <87pnjdh1up.fsf@mail.linkov.net> <83zhih55h3.fsf@gnu.org> <87zhieu8g3.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37592 Cc: 37592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 37592@debbugs.gnu.org > Date: Sun, 06 Oct 2019 01:35:40 +0300 > > > It seems to me that there are sensible defaults in each of these > > situations, and we could use those defaults unconditionally until > > users complained. > > > > Adding too many user options has a downside as well, you know. > > > > Just one opinion. > > I agree, let's try this heuristics to open new tabs > when tab-bar-mode is enabled: LGTM, thanks. It is probably a NEWS-worthy change. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 16:06:36 2019 Received: (at 37592) by debbugs.gnu.org; 6 Oct 2019 20:06:36 +0000 Received: from localhost ([127.0.0.1]:46930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHCnc-0003y4-Ax for submit@debbugs.gnu.org; Sun, 06 Oct 2019 16:06:36 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHCnZ-0003xv-QJ for 37592@debbugs.gnu.org; Sun, 06 Oct 2019 16:06:34 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHCnV-0000Nk-6Y; Sun, 06 Oct 2019 22:06:31 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#37592: Using tabs in EWW References: <87r23uga96.fsf@mail.linkov.net> <83zhii7dkk.fsf@gnu.org> <87pnjdh1up.fsf@mail.linkov.net> <83zhih55h3.fsf@gnu.org> <87zhieu8g3.fsf@mail.linkov.net> Date: Sun, 06 Oct 2019 22:06:28 +0200 In-Reply-To: <87zhieu8g3.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 06 Oct 2019 01:35:40 +0300") Message-ID: <87o8ytej0b.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > I agree, let's try this heuristics to open new tabs > when tab-bar-mode is enabled: Looks good to me, too. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37592 Cc: 37592@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > I agree, let's try this heuristics to open new tabs > when tab-bar-mode is enabled: Looks good to me, too. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 17:11:18 2019 Received: (at 37592-done) by debbugs.gnu.org; 6 Oct 2019 21:11:18 +0000 Received: from localhost ([127.0.0.1]:46945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHDoE-0005kx-0r for submit@debbugs.gnu.org; Sun, 06 Oct 2019 17:11:18 -0400 Received: from blue.elm.relay.mailchannels.net ([23.83.212.20]:58908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHDoB-0005kn-JR for 37592-done@debbugs.gnu.org; Sun, 06 Oct 2019 17:11:16 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 709E050039B; Sun, 6 Oct 2019 21:11:14 +0000 (UTC) Received: from pdx1-sub0-mail-a93.g.dreamhost.com (100-96-14-192.trex.outbound.svc.cluster.local [100.96.14.192]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0484350113A; Sun, 6 Oct 2019 21:11:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a93.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.3); Sun, 06 Oct 2019 21:11:14 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Keen-Thread: 7d3952ef59017c68_1570396274256_3066594343 X-MC-Loop-Signature: 1570396274256:1539115899 X-MC-Ingress-Time: 1570396274256 Received: from pdx1-sub0-mail-a93.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a93.g.dreamhost.com (Postfix) with ESMTP id 5622D80F73; Sun, 6 Oct 2019 14:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=UAVniGNcYZsr2NwbkkFY+s+5z58=; b= kdC9gwESqH9Y99IUza6qkjYRwilSJnaNLbk6J6ImRhZlZp7BeXUwqW5V+NFXks7V gON3DGLd3EYG2ZrVqZ//kiCuQxabfZbCVKz5nYm7qt89Vnfp0IT5Q7QKMLDYsFcf pXFKcK+lSl/waeVrmHT+q5uh0lxc9zQmYTtO+MMz6PA= Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a93.g.dreamhost.com (Postfix) with ESMTPSA id 2A02880F54; Sun, 6 Oct 2019 14:11:06 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a93 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#37592: Using tabs in EWW Organization: LINKOV.NET References: <87r23uga96.fsf@mail.linkov.net> <83zhii7dkk.fsf@gnu.org> <87pnjdh1up.fsf@mail.linkov.net> <83zhih55h3.fsf@gnu.org> <87zhieu8g3.fsf@mail.linkov.net> <87o8ytej0b.fsf@gnus.org> Date: Mon, 07 Oct 2019 00:08:33 +0300 In-Reply-To: <87o8ytej0b.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 06 Oct 2019 22:06:28 +0200") Message-ID: <87o8ytfupa.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrheehgdduiedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdelledrleelnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleelrdelledprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehlrghrshhisehgnhhushdrohhrghenucevlhhushhtvghrufhiiigvpedu X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37592-done Cc: Eli Zaretskii , 37592-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> I agree, let's try this heuristics to open new tabs >> when tab-bar-mode is enabled: > > Looks good to me, too. I also updated the Info documentation on opening tabs by 'C-u RET'. but can't find a suitable place to describe using tabs on clicking with the Ctrl key, because currently the EWW documentation has no mentions of mouse commands. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 19 18:42:02 2019 Received: (at 37592) by debbugs.gnu.org; 19 Oct 2019 22:42:02 +0000 Received: from localhost ([127.0.0.1]:53636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLxQ9-0005kJ-R6 for submit@debbugs.gnu.org; Sat, 19 Oct 2019 18:42:02 -0400 Received: from bird.elm.relay.mailchannels.net ([23.83.212.17]:43696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLxQ7-0005k9-QL for 37592@debbugs.gnu.org; Sat, 19 Oct 2019 18:42:01 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8B5271A0A04; Sat, 19 Oct 2019 22:41:58 +0000 (UTC) Received: from pdx1-sub0-mail-a10.g.dreamhost.com (100-96-6-135.trex.outbound.svc.cluster.local [100.96.6.135]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 28B161A09CA; Sat, 19 Oct 2019 22:41:58 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a10.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 19 Oct 2019 22:41:58 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Whimsical-Gusty: 51cc979f72639d61_1571524918367_3310640187 X-MC-Loop-Signature: 1571524918367:2652524804 X-MC-Ingress-Time: 1571524918367 Received: from pdx1-sub0-mail-a10.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a10.g.dreamhost.com (Postfix) with ESMTP id B5FDD83909; Sat, 19 Oct 2019 15:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=NP+X6tiq2HDvaE7iesyiQSU5+kI=; b= ozeu4B1JwtMLmmVOv3Gc+h9EJm5zNIAZPpeDqccxaFk4UJ5uHTOX+p4JmzcKjI4x uYKxa/GQOBjHZHLnM8pPh6x8CikTkgcAjAY6kcK667anDWmBho1yb0VtTfAMBy0z vZgHQlDQEKYN3tafUD7qX5Qzbh9vSAdtsyfkx9WXJn8= Received: from mail.jurta.org (m91-129-98-153.cust.tele2.ee [91.129.98.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a10.g.dreamhost.com (Postfix) with ESMTPSA id 533C583906; Sat, 19 Oct 2019 15:41:53 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a10 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#37592: Using tabs in EWW References: <87r23uga96.fsf@mail.linkov.net> <83zhii7dkk.fsf@gnu.org> <87pnjdh1up.fsf@mail.linkov.net> <83zhih55h3.fsf@gnu.org> Date: Sun, 20 Oct 2019 01:40:55 +0300 In-Reply-To: <83zhih55h3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Oct 2019 10:34:32 +0300") Message-ID: <87mudwtl3c.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37592 Cc: 37592@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > Instead of adding another defcustom, how about doing this by default >> > if tab-bar-mode is enabled? >> >> I guess the users still need to decide whether they want to open >> new tabs in the tab-bar (when eww-browse-url-new-window-is-tab is non-nil), >> or new tabs in the tab-line (when eww-browse-url-new-window-is-tab is nil) >> that just creates a new buffer displayed in the window-local tab-line - >> this is the current behavior. >> >> Another use case is that when tab-bar-mode is not yet enabled, >> users migth prefer that clicking on a link with a Ctrl key >> could enable the tab-bar and open a new tab in automatically >> enabled tab-bar. > > It seems to me that there are sensible defaults in each of these > situations, and we could use those defaults unconditionally until > users complained. Users complained, so I added that defcustom. From unknown Wed Jun 18 00:25:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 17 Nov 2019 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator