Subject: bug#37567: closed (Re: [bug#37567] [PATCH] gnu: pulseaudio: Add optional X11 inputs.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 13 Oct 2019 21:10:03 +0000

Your bug report

#37567: [PATCH] gnu: pulseaudio: Add optional X11 inputs.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
37567: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37567
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#37567] [PATCH] gnu: pulseaudio: Add optional X11 inputs.
From: Marius Bakke <[email-masked]>
To: Diego Nicola Barbato <[email-masked]>, [email-masked]
Date: Sun, 13 Oct 2019 23:09:45 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Diego Nicola Barbato <[email-masked]> writes:

> Hello Guix,
>
> Pulseaudio is currently built without the optional X11 modules (e.g
> module-x11-bell, which makes it possible to customize the x11-bell
> sound).  This patch adds those X11 libraries to Pulseaudios's inputs,
> which are necessary for the modules to be built.

This patch increases the size of pulseaudio from 187.2 MiB to 189.4 MiB,
which is OK IMO.

Pushed to 'staging' with a minor cosmetic change in 531b63eba7.

Thank you!

Subject: [PATCH] gnu: pulseaudio: Add optional X11 inputs.
From: Diego Nicola Barbato <[email-masked]>
To: [email-masked]
Date: Tue, 01 Oct 2019 12:42:06 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Guix,

Pulseaudio is currently built without the optional X11 modules (e.g
module-x11-bell, which makes it possible to customize the x11-bell
sound).  This patch adds those X11 libraries to Pulseaudios's inputs,
which are necessary for the modules to be built.

Regards,

Diego

>From 3bcfda0a26a572b6789a469ea6da4d384db4be47 Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <[email-masked]>
Date: Tue, 1 Oct 2019 11:31:42 +0200
Subject: [PATCH] gnu: pulseaudio: Add optional X11 inputs.

* gnu/packages/pulseaudio.scm (pulseaudio)[inputs]: Add libxcb, libice, libsm,
  and libxtst.
---
 gnu/packages/pulseaudio.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index fa48d8a7a6..f0f8574078 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -50,7 +50,8 @@
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages python-web)
   #:use-module (gnu packages pkg-config)
-  #:use-module (gnu packages xiph))
+  #:use-module (gnu packages xiph)
+  #:use-module (gnu packages xorg))
 
 (define-public libsndfile
   (package
@@ -187,6 +188,10 @@ rates.")
        ("libltdl" ,libltdl)
        ("fftwf" ,fftwf)
        ("avahi" ,avahi)
+       ("libxcb" ,libxcb)   ; For enabling X11.
+       ("libice" ,libice)   ; For enabling X11.
+       ("libsm" ,libsm)     ; For enabling X11.
+       ("libxtst" ,libxtst) ; For enabling X11.
        ("eudev" ,eudev)))         ;for the detection of hardware audio devices
     (native-inputs
      `(("check" ,check)
-- 
2.23.0