GNU bug report logs - #37564
[PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 37564 <at> debbugs.gnu.org, stefan <at> marxist.se, matthew <at> mattleach.net
Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications
Date: Sat, 15 Aug 2020 14:37:26 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> PS for an example of the effect, one can use some of the programs in
>> the ncurses-examples from
>> https://invisible-island.net/ncurses/ncurses-examples.html
>> 
>> eg "worm".
>
> I understand that applications based on ncurses are affected, but what
> about those which aren't based on ncurses?

I think the rough consensus here was that adding LINES/COLUMNS is
usually the wrong thing to do, but Eli worries that this might break
something.  So I've applied Matthew's patch, but also added a defcustom
to control this.

I've defaulted the variable to "don't add the variables", but if this
leads to problems during the Emacs 28.1 cycle, we can flip it to "on"
later.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.