GNU bug report logs - #37563
27.0.50; fit-frame-to-buffer does not account for line-spacing

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Ingo Lohmar <ingo.lohmar <at> posteo.net>
Cc: 37563 <at> debbugs.gnu.org
Subject: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing
Date: Wed, 2 Oct 2019 10:54:03 +0200

> I surely find the complexity of all this code jarring, so I have to
> restrict myself to looking at a single issue; and here, it's clearly
> fixing a bug, using the char height is simply wrong, IMO.

Agreed.  But if I change 'fit-frame-to-buffer', then, for consistency,
I have to at least change 'fit-window-to-buffer' too.

> +          (setq height (* (/ (+ height line-height -1) line-height)
> +                          line-height)))
[...]
> And then char-height can be dropped.

Right.

Thanks, martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.