From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 15:33:08 2019 Received: (at submit) by debbugs.gnu.org; 30 Sep 2019 19:33:08 +0000 Received: from localhost ([127.0.0.1]:60521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iF1Pu-0003tK-UA for submit@debbugs.gnu.org; Mon, 30 Sep 2019 15:33:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:57179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iF0bm-0002ZC-Dq for submit@debbugs.gnu.org; Mon, 30 Sep 2019 14:41:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32867) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iF0bj-0004KU-Qj for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 14:41:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iF0bh-000351-Bp for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 14:41:15 -0400 Received: from mout02.posteo.de ([185.67.36.66]:56057) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iF0bg-000319-Hf for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 14:41:13 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id D58002400FB for ; Mon, 30 Sep 2019 20:41:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1569868869; bh=pcWhqbrGAStVQScc3U/Gp+pZ4XoD5R/9IqRzLl9ZAIg=; h=From:To:Subject:Date:From; b=aPGAmG/fqWmNWyY2mmt/pGhXQ79QYeJKreqOHEdAIzqPk72+4F4KgaaHjPUeO5qnL aglG/JmV3JOM4LN5imvCEbuEb6RB/jWUTRyRjav13W8ebzRVuN5uYAHCbWxgFgxN+F 0tA5jCC2eCALNyaJskC83LdgZOTQTcVpvIYEU0cFwCmQBLvvc1rmcxbHgkU0zCtqOt REo6pIWwCh9yo6U8QhJtXr+QCwBEnYnBMauL2jBVRVFJQGsS8rTmJYLBFU16pW36sn UZwvMZK8CVDs5ISBp9BBE7nP+Z70wQePh5wA92EkiV2pL/NKy3QhfrF9QmasflXuQ1 OeTcIn3yvZzlA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46hrnw3qztz9rxG for ; Mon, 30 Sep 2019 20:41:08 +0200 (CEST) From: Ingo Lohmar To: bug-gnu-emacs@gnu.org Subject: 27.0.50; fit-frame-to-buffer does not account for line-spacing Date: Mon, 30 Sep 2019 20:41:08 +0200 Message-ID: <87tv8tsk3f.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.67.36.66 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 30 Sep 2019 15:33:05 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I noticed the behavior due to company-posframe, which uses the posframe package to show a completion popup frame. The frame size is set using window.el's `fit-frame-to-buffer'. Some time ago, the call was changed to provide the explicit frame max-height in terms of lines, which exposed the following behavior: If (default-value line-spacing) is the usual 0, the height of the popup frame is correct, ie, all lines are fully shown. If, however, (default-value line-spacing) is 1 or larger (as in my setup), the bottom of the popup frame cuts off parts of the lowest line. I do not understand all the details, but it here's what my debugging shows: 1) When max-height is provided, the actual frame height is calculated in ll 8736ff of window.el (as of commit 5746202c182a9c69c732beb29b8507a6e6364799), and that just multiplies by the char-height, which excludes the line-spacing. This is the buggy case. 2) When max-height is NOT provided, the above lines set max-height to the total (parent frame) height, and the popup frame size is calculated only when reaching l 8767. This yields a larger height, correctly accounting for the line-spacing. Hope this helps and can be easily fixed. Thanks! Ingo In GNU Emacs 27.0.50 (build 24, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-02-16 built on kenko Repository revision: aff0c585060b7cc92d52a32978c6aa64cf7e2a5e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux bullseye/sid Recent messages: 1 Evaluating... Showing all blocks ... done nil [3 times] Evaluating... Showing all blocks ... done nil [2 times] t Saving file /home/il/Documents/emacs/emacs.org... Wrote /home/il/Documents/emacs/emacs.org Configured using: 'configure --with-imagemagick --without-gsettings --without-gconf --with-x-toolkit=lucid --with-modules' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS PDUMPER GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Org Minor modes in effect: semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode) S))) TeX-PDF-mode: t TeX-source-correlate-mode: t magit-todos-mode: t global-magit-file-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t server-mode: t buffer-face-mode: t org-indent-mode: t shell-dirtrack-mode: t diff-auto-refine-mode: t global-flycheck-mode: t dired-async-mode: t mimuma-global-mode: t global-hl-todo-mode: t pollen-global-mode: t counsel-mode: t ivy-mode: t amx-mode: t minibuffer-depth-indicate-mode: t savehist-mode: t enchive-mode: t xterm-mouse-mode: t ws-butler-global-mode: t ws-butler-mode: t global-auto-revert-mode: t my/window-number-mode: t desktop-save-mode: t company-posframe-mode: t company-statistics-mode: t global-company-mode: t company-mode: t show-paren-mode: t electric-pair-mode: t beginend-global-mode: t beginend-org-mode: t beginend-outline-mode: t global-undo-tree-mode: t undo-tree-mode: t delete-selection-mode: t guide-key-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t global-prettify-symbols-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t auto-fill-function: org-auto-fill-function transient-mark-mode: t Load-path shadows: [... elided ...] Features: (shadow sort emacsbug sendmail mail-extr edebug timezone dired-x mule-diag ox-org ox-odt ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox my-grep cl-print ielm quail systemd preview prv-emacs reftex-dcr reftex-auc reftex-toc-patch reftex-toc reftex-config reftex reftex-loaddefs reftex-vars tex-buf font-latex latex-config my-fill latex-addons latex-mode-expansions latex latex-flymake tex-ispell tex-style tex-config tex tex-mode hippie-expand-config my-mode-groups hippie-expand-addons my-flex-search hippie-exp pkg-info epl network-stream cider cider-debug cider-inspector cider-browse-ns cider-repl-history two-column iso-transl org-attach ess-r-mode ess-r-flymake ess-r-xref ess-trns ess-r-package ess-r-completion ess-roxy ess-r-syntax ess-rd ess-s-lang ess-help ess-mode ess-inf ess-tracebug ess ess-utils ess-custom magit-bookmark bookmark org-capture cal-move cs-mode cc-langs sql-config sql-addons sql rng-xsd xsd-regexp rng-cmpct nxml-addons nxml-mode-expansions rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-enc xmltok solar cal-dst holidays hol-loaddefs cal-iso org-addons window-addons my-window-funs pulse misearch multi-isearch shell-addons my-completion magit-extras magit-addons magit-config magit-bundle magit-todos pcre2el rxt re-builder f wgrep-patch wgrep grep-config grep forge-config forge-list forge-commands forge-semi forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab forge-github ghub-graphql treepy gsexp ghub let-alist gnutls forge-notify forge-revnote forge-pullreq forge-issue forge-topic bug-reference forge-post forge-repo forge forge-core forge-db closql emacsql-sqlite emacsql emacsql-compiler url-http url-auth url-gw nsm magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos-addons tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-config smerge-mode magit-core magit-autorevert magit-margin magit-transient magit-process magit-mode transient git-commit magit-git magit-section magit-utils log-edit pcvs-util add-log with-editor async-bytecomp hi-lock eieio-opt speedbar sb-image ezimage dframe em-unix em-term term ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias windmove tabify server time notmuch-config notmuch-addons notmuch-patch notmuch hl-line notmuch-hello notmuch-tree notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj notmuch-query icalendar diary-lib diary-loaddefs notmuch-tag crm notmuch-lib notmuch-version notmuch-compat cl message rmc rfc822 mml mailabbrev gmm-utils mailheader mm-view mml-smime mml-sec epa epg smime dig mm-decode mm-bodies mm-encode mail-parse rfc2231 wconf racket-mode racket-bug-report racket-collection racket-stepper racket-logger racket-profile racket-imenu racket-edit racket-complete racket-repl ido racket-common racket-parens racket-indent racket-font-lock racket-util racket-ppss racket-keywords-and-builtins racket-custom vimrc-mode ngo make-mode gitconfig-mode macrostep-c cmacexp my/publish-blog fish-mode mhtml-mode skewer-html sh-flymake-backends sh-script executable skewer-css company-skewer skewer-addons skewer-repl skewer-mode cache-table js2-mode-expansions js2-mode js-config js-patch js-mode-expansions js cc-mode-expansions cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs simple-httpd css-mode-expansions css-mode smie html-mode-expansions sgml-mode eww mm-url gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils cus-edit cus-start cus-load wid-edit url-queue shr text-property-search puny svg dom conf-mode markdown-mode edit-indirect pyvenv-config pyvenv esh-var esh-cmd esh-opt esh-io esh-ext esh-proc esh-arg esh-groups eshell-config eshell esh-module esh-mode esh-util python-config python-el-fgallina-expansions python tramp-sh geiser-config geiser-mode geiser-xref geiser-compile geiser-debug geiser-patch geiser-gambit geiser-chibi geiser-mit geiser-chez geiser-chicken geiser-racket geiser-guile info-look geiser-repl geiser-image geiser-company geiser-doc geiser-menu geiser-edit geiser-completion geiser-autodoc geiser-eval geiser-connection tq geiser-syntax geiser-log geiser-popup view scheme cider-mode cider-completion cider-profile cider-eval cider-repl cider-resolve cider-eldoc cider-test cider-stacktrace cider-doc cider-browse-spec cider-clojuredocs cider-popup cider-overlays cider-client cider-common cider-util cider-connection sesman-browser nrepl-client tramp tramp-loaddefs trampver tramp-compat ucs-normalize parse-time queue nrepl-dict cider-compat spinner parseedn parseclj-parser parseclj-lex a clojure-mode-expansions sesman clojure-mode lisp-mnt align org-duration slime-config slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-addons slime-repl slime-parse slime arc-mode archive-mode hyperspec browse-url imenu go-config go-guru go-flymake-backends my-flymake-addons go-mode derived url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf mailcap find-file ffap face-remap org-indent image-file org-table disp-table vc-hg vc-src vc-svn my-misc-funs elisp-addons subword-patch subword-mode-expansions cap-words superword subword goto-addr idle-highlight-mode rainbow-delimiters hideshow outshine outshine-org-cmds outorg org-capture-config org-config my-org-contacts org-protocol org-irc org-info org-id org-docview doc-view jka-compr image-mode org-bibtex org-element avl-tree bibtex-config bibtex-clean-addons bibtex ob-scheme geiser-impl help-fns radix-tree geiser-custom geiser-base geiser ob-dot ob-js ob-sql ob-latex ob-python ob-shell shell-config shell org-clock org-agenda the-org-mode-expansions org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint ob-keys org-pcomplete pcomplete org-list org-faces org-entities time-date org-version ob-emacs-lisp ob-core ob-eval org-compat org-macs org-loaddefs format-spec calendar-config cal-menu calendar cal-loaddefs noutline outline vc-git diff-mode flycheck-config flycheck faces-config ui-config comint-config dired-guess dired-subtree dired-hacks-utils dired-async async dired-aux dired-config modeline-config dired-patch ls-lisp-config ls-lisp-patch ls-lisp mini-multi-major xref-addons my-eval-result-overlays my-solarized-colors hl-todo flymake-config help-at-pt eglot-config eglot-patch eglot jsonrpc array ert pp ewoc debug backtrace subr-x flymake-proc flymake warnings url-util pollen compile-config compile-addons locals-patch my-project vc vc-dispatcher counsel-addons counsel xdg dired dired-loaddefs compile comint ansi-color swiper-addons swiper ivy-config ivy-hydra ivy flx colir color ivy-overlay amx mb-depth savehist secrets dbus xml enchive-mode xt-mouse ws-butler autorevert filenotify my-file-funs desktop-config my-window-numbers display-actions desktop frameset company-posframe posframe company-statistics company-keywords company-dabbrev-code company-dabbrev etags-addons company-etags etags fileloop generator xref project company-gtags company-template company-capf company-elisp find-func company-config company sexp-addons pcase paren elec-pair occur-config my-aux-funs easy-mmode beginend ace-link avy multiple-cursors mc-hide-unmatched-lines-mode mc-separate-operations rectangular-region-mode mc-mark-pop mc-mark-more mc-cycle-cursors mc-edit-lines multiple-cursors-core rect expand-region text-mode-expansions er-basic-expansions thingatpt expand-region-core expand-region-custom undo-tree-patch undo-tree diff delsel indent-config indent-addons mm-util mail-prsvr diminish guide-key advice s popwin dash my-loaddefs edmacro kmacro cl-extra help-mode hydra ring lv my-setup-funs mule-util info tex-site slime-autoloads rx package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 5731969 544737) (symbols 48 74465 205) (strings 32 351286 127943) (string-bytes 1 10253755) (vectors 16 264560) (vector-slots 8 5833430 221798) (floats 8 1203 4037) (intervals 56 781876 5606) (buffers 992 301)) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 01 03:32:18 2019 Received: (at 37563) by debbugs.gnu.org; 1 Oct 2019 07:32:18 +0000 Received: from localhost ([127.0.0.1]:60802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFCdu-0005E3-I9 for submit@debbugs.gnu.org; Tue, 01 Oct 2019 03:32:18 -0400 Received: from mout.gmx.net ([212.227.15.15]:44895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFCds-0005Dq-Vz for 37563@debbugs.gnu.org; Tue, 01 Oct 2019 03:32:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1569915128; bh=fc48re5Np4KN+pKzjDAq0cpQAVwRWtPBkiVznL5E9KY=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=GLvuV4ZLyr9HX+CNGihiTnp7SmMPqNJyqVbmc61m7OazbOv59KTfyb4dUHG48zN8H 7ekK5QgfqGrPXRQxdIYMLNyMp+8BP437+18euOWLP+vKqaJFs8n5fvXOS5HtsTdmAG /xh27Wv/rBBN7e05I49mQF5weGFYxxw5Ik8vQgzk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.139]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MZTqW-1ibsTu0rJ8-00WWbD; Tue, 01 Oct 2019 09:32:08 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing To: Ingo Lohmar , 37563@debbugs.gnu.org References: <87tv8tsk3f.fsf@kenko.localhost.com> From: martin rudalics Message-ID: Date: Tue, 1 Oct 2019 09:32:08 +0200 MIME-Version: 1.0 In-Reply-To: <87tv8tsk3f.fsf@kenko.localhost.com> Content-Type: multipart/mixed; boundary="------------BDE0F6A92FDBF15CD1C3688D" Content-Language: de-AT X-Provags-ID: V03:K1:jWWzjs0Oe6VSAsGSJYIhztBB7+Jlr7VYTt4coln8sWcI3cCtNZG J17MjYsZuSC70UPoeouKTdAxYlz+4fH9aNd7MTnANCQx60xTxIB7NV0W0VmHTW8P/+EJmDm Us8XLP+9/o/Jjw1TMVfaKr4cpWjYgDQXGcv4yc44kHPb8q50L0MwBiPG65LhwoRq/cjRkgz QntADB33ne0sPVq7m7bOQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:5MPm/r6mNrM=:dGV8foyBgUP9kD/Qzq5e7h 74w0cDVb0q/gfS/UfjNLqxWHLNBC8w2hwSY6leAJo4J7LOZs43xyEX712sH3F6looug2eNOBb I+QKOYkPpDdvidmAeOHqoSMMN4Vc4EBeapDPaenQwN8LqsyoC3UyHllKBQuOc/zWUEe66A4G8 /KPAaM5joXU1HwmAix6WkFKu0Fc//aYyuu7EQYmGuQsWBe9axCNYeNloSANiZH3mJtcrevDp5 dvfRRAwN8emLUtTfzRXxgunh6uTk10NxLH7yVSBDIj37M6xopvjdGzBGXGA0QMnl0FSngCLTK NkXFj3G0sy5lDzJdr85l/EIFpaWXfUFX4pKhj0w9wCSijpFgoHCapkRiIiJAiSaDwg03oTioR dbhe9B38ggP7ySUh4nxIJDKaAM9F9wgVbqSB0pTSafBoMxOtRgOeitcl3wROHVWFeWMA4jmIl J7SAvAuxpWCxTpYvNrOGrFap5oqcD9F65KqNY98RZtDWW6mN9lwU/zISTcHI0RdQ942wOJ3v/ slm2f3YVT+omVoHM5N4VL/VsAAsnmy+vKubFm3FV8sI+mvA22wEU1KhyfwSj64oborU8quxqr Qd8WA5jlBEnKD03h3FNzoC+qVCCfwVlQ2biM4KiH5N124bAc8qdrF39IADqabmmkAOJAPZ44w erYzds0NivpHS4IaOFdwziXmPX2KcSyOQ1fULZREPz5hBrQl9/kzvgqmYeY9hb9lpfRyQ1nHE N+/GPaFVN3b3NYUULwq/Qe6y9/t5MolQmRW6rXFgd7Y2gJqjOx4Q9Tyu3dz2HDUgg3ipG7Q1s geXVkKKKcDcIHJ6fiAXkDy8HL9+gc5NIi5JlypaLWYqX/dS8pg6vr4OEYMOoi+joeTXArmJlv vzqf5L1jkXG8FCFNbmtQ3F8BioXHSBcmAVu+CDNhNiP0rXYa6ikyURWX8Z7RfSJB6+b7VSqDF rIZMmOepUMP0QFfWamUPWuO3b1D0RJh+OvenN/1yX63eFcrY44KxcG5jtxxvOF9gmgMUlAMYr AApDzjk9Mupyh8kDElRZPkkYwfby6zjQPToSM/EdZzxGO+xArJU+AVOEBvEXYJMVikvx7NYV3 4b40JqlASjFKf2IDvd7aFdl5WzLXzLSA5iNAwXVcBjHMwAsAe0utAURFNWzbKT202OKweY65N rrIgDpE9up/xY11xu7b666AAel5uJ1SAvfuIw7Zg/l/qaMyHejcFG66DSwsGoXEm3sUxMyTds jGxw9LaluYo2X2CDDHVHGTPxf1qPKQFEpI6YfqA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37563 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------BDE0F6A92FDBF15CD1C3688D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > 1) When max-height is provided, the actual frame height is calculated in > ll 8736ff of window.el (as of commit > 5746202c182a9c69c732beb29b8507a6e6364799), and that just multiplies by > the char-height, which excludes the line-spacing. This is the buggy > case. I attached a fix. Please try it. Many thanks for the report, martin --------------BDE0F6A92FDBF15CD1C3688D Content-Type: text/plain; charset=UTF-8; name="fit-frame-to-buffer.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fit-frame-to-buffer.diff" ZGlmZiAtLWdpdCBhL2xpc3Avd2luZG93LmVsIGIvbGlzcC93aW5kb3cuZWwKaW5kZXggY2Y3 MzMxNTNiOC4uM2RmNDYzNTMzYyAxMDA2NDQKLS0tIGEvbGlzcC93aW5kb3cuZWwKKysrIGIv bGlzcC93aW5kb3cuZWwKQEAgLTg0OTQsNiArODQ5NCw0MCBAQCB3aW5kb3ctYnVmZmVyLWhl aWdodAogCQkJICAgICAoZW9icCkKIAkJCSAgICAgd2luZG93KSkpKQogCisoZGVmdW4gd2lu ZG93LWNoYXItaGVpZ2h0ICgmb3B0aW9uYWwgd2luZG93KQorICAiUmV0dXJuIG51bWJlciBv ZiBwaXhlbHMgb2YgdGhlIGhlaWdodCBvZiBhIGNoYXJhY3RlciBpbiBXSU5ET1cuCitXSU5E T1cgbXVzdCBiZSBhIGxpdmUgd2luZG93IGFuZCBkZWZhdWx0cyB0byB0aGUgc2VsZWN0ZWQg b25lLgorVGhlIHJldHVybiB2YWx1ZSBhY2NvdW50cyBmb3IgYW55IHJlbWFwcGluZyBvZiB0 aGUgZGVmYXVsdCBmYWNlCitvZiBXSU5ET1cncyBmcmFtZS4iCisgIDs7IENvZGUgbW9zdGx5 IHN0b2xlbiBmcm9tIHNpbXBsZS5lbCdzIGBkZWZhdWx0LWZvbnQtaGVpZ2h0Jy4KKyAgKGxl dCogKCh3aW5kb3cgKHdpbmRvdy1ub3JtYWxpemUtd2luZG93IHdpbmRvdyB0KSkKKwkgKGZy YW1lICh3aW5kb3ctZnJhbWUgd2luZG93KSkKKwkgKGRlZmF1bHQtZm9udCAoZmFjZS1mb250 ICdkZWZhdWx0IGZyYW1lKSkpCisgICAgKGNvbmQKKyAgICAgKChhbmQgKGRpc3BsYXktbXVs dGktZm9udC1wIChmcmFtZS1wYXJhbWV0ZXIgZnJhbWUgJ2Rpc3BsYXkpKQorCSAgIChub3Qg KHN0cmluZy1lcXVhbCAoZnJhbWUtcGFyYW1ldGVyIGZyYW1lICdmb250KSBkZWZhdWx0LWZv bnQpKSkKKyAgICAgIChhcmVmIChmb250LWluZm8gZGVmYXVsdC1mb250IGZyYW1lKSAzKSkK KyAgICAgKHQgKGZyYW1lLWNoYXItaGVpZ2h0IGZyYW1lKSkpKSkKKworKGRlZnVuIHdpbmRv dy1saW5lLWhlaWdodCAoJm9wdGlvbmFsIHdpbmRvdykKKyAgIlJldHVybiBudW1iZXIgb2Yg cGl4ZWxzIG9mIGEgdGV4dCBsaW5lIGluIFdJTkRPVy4KK1dJTkRPVyBtdXN0IGJlIGEgbGl2 ZSB3aW5kb3cgYW5kIGRlZmF1bHRzIHRvIHRoZSBzZWxlY3RlZCBvbmUuCitUaGUgcmV0dXJu IHZhbHVlIGluY2x1ZGVzIGFueSBsaW5lIHNwYWNpbmcgZGVmaW5lZCBmb3IgV0lORE9XJ3MK K2J1ZmZlciBvciBmcmFtZS4iCisgIDs7IENvZGUgbW9zdGx5IHN0b2xlbiBmcm9tIHNpbXBs ZS5lbCdzIGBkZWZhdWx0LWxpbmUtaGVpZ2h0Jy4KKyAgKGxldCogKCh3aW5kb3cgKHdpbmRv dy1ub3JtYWxpemUtd2luZG93IHdpbmRvdyB0KSkKKwkgKGNoYXItaGVpZ2h0ICh3aW5kb3ct Y2hhci1oZWlnaHQgd2luZG93KSkKKwkgKGJ1ZmZlciAod2luZG93LWJ1ZmZlciB3aW5kb3cp KQorCSAoZnJhbWUgKHdpbmRvdy1mcmFtZSB3aW5kb3cpKQorCSAoc3BhY2UtaGVpZ2h0CisJ ICAob3IgKGFuZCAoZGlzcGxheS1ncmFwaGljLXApCisJCSAgIChvciAoYnVmZmVyLWxvY2Fs LXZhbHVlICdsaW5lLXNwYWNpbmcgYnVmZmVyKQorCQkgICAgICAgKGZyYW1lLXBhcmFtZXRl ciBmcmFtZSAnbGluZS1zcGFjaW5nKSkpCisJICAgICAgMCkpKQorICAgICh3aGVuIChmbG9h dHAgc3BhY2UtaGVpZ2h0KQorICAgICAgKHNldHEgc3BhY2UtaGVpZ2h0ICh0cnVuY2F0ZSAo KiBjaGFyLWhlaWdodCBzcGFjZS1oZWlnaHQpKSkpCisgICAgKCsgY2hhci1oZWlnaHQgc3Bh Y2UtaGVpZ2h0KSkpCisKIDs7OyBSZXNpemluZyB3aW5kb3dzIGFuZCBmcmFtZXMgdG8gZml0 IHRoZWlyIGNvbnRlbnRzIGV4YWN0bHkuCiAoZGVmY3VzdG9tIGZpdC13aW5kb3ctdG8tYnVm ZmVyLWhvcml6b250YWxseSBuaWwKICAgIk5vbi1uaWwgbWVhbnMgYGZpdC13aW5kb3ctdG8t YnVmZmVyJyBjYW4gcmVzaXplIHdpbmRvd3MgaG9yaXpvbnRhbGx5LgpAQCAtODYzNiw2ICs4 NjcwLDcgQEAgZml0LWZyYW1lLXRvLWJ1ZmZlcgogICAgICAgICAgICAoY2hhci1oZWlnaHQg KGZyYW1lLWNoYXItaGVpZ2h0IGZyYW1lKSkKICAgICAgICAgICAgOzsgV0lORE9XIGlzIEZS QU1FJ3Mgcm9vdCB3aW5kb3cuCiAgICAgICAgICAgICh3aW5kb3cgKGZyYW1lLXJvb3Qtd2lu ZG93IGZyYW1lKSkKKyAgICAgICAgICAgKGxpbmUtaGVpZ2h0ICh3aW5kb3ctbGluZS1oZWln aHQgd2luZG93KSkKICAgICAgICAgICAgKHBhcmVudCAoZnJhbWUtcGFyZW50IGZyYW1lKSkK ICAgICAgICAgICAgKG1vbml0b3ItYXR0cmlidXRlcwogICAgICAgICAgICAgKHVubGVzcyBw YXJlbnQKQEAgLTg3MzIsMTYgKzg3NjcsMTYgQEAgZml0LWZyYW1lLXRvLWJ1ZmZlcgogICAg ICAgICAgICAobWF4LWhlaWdodAogICAgICAgICAgICAgKG1pbgogICAgICAgICAgICAgIChj b25kCi0gICAgICAgICAgICAgICgobnVtYmVycCBtYXgtaGVpZ2h0KSAoKiBtYXgtaGVpZ2h0 IGNoYXItaGVpZ2h0KSkKLSAgICAgICAgICAgICAgKChudW1iZXJwIChudGggMCBzaXplcykp ICgqIChudGggMCBzaXplcykgY2hhci1oZWlnaHQpKQorICAgICAgICAgICAgICAoKG51bWJl cnAgbWF4LWhlaWdodCkgKCogbWF4LWhlaWdodCBsaW5lLWhlaWdodCkpCisgICAgICAgICAg ICAgICgobnVtYmVycCAobnRoIDAgc2l6ZXMpKSAoKiAobnRoIDAgc2l6ZXMpIGxpbmUtaGVp Z2h0KSkKICAgICAgICAgICAgICAgKHQgcGFyZW50LW9yLWRpc3BsYXktaGVpZ2h0KSkKICAg ICAgICAgICAgICA7OyBUaGUgZm9sbG93aW5nIGlzIHRoZSBtYXhpbXVtIGhlaWdodCB0aGF0 IGZpdHMgaW50byB0aGUKICAgICAgICAgICAgICA7OyB0b3AgYW5kIGJvdHRvbSBtYXJnaW5z LgogICAgICAgICAgICAgIChtYXggKC0gYm90dG9tLW1hcmdpbiB0b3AtbWFyZ2luIG91dGVy LW1pbnVzLWJvZHktaGVpZ2h0KSkpKQogICAgICAgICAgICAobWluLWhlaWdodAogICAgICAg ICAgICAgKGNvbmQKLSAgICAgICAgICAgICAoKG51bWJlcnAgbWluLWhlaWdodCkgKCogbWlu LWhlaWdodCBjaGFyLWhlaWdodCkpCi0gICAgICAgICAgICAgKChudW1iZXJwIChudGggMSBz aXplcykpICgqIChudGggMSBzaXplcykgY2hhci1oZWlnaHQpKQorICAgICAgICAgICAgICgo bnVtYmVycCBtaW4taGVpZ2h0KSAoKiBtaW4taGVpZ2h0IGxpbmUtaGVpZ2h0KSkKKyAgICAg ICAgICAgICAoKG51bWJlcnAgKG50aCAxIHNpemVzKSkgKCogKG50aCAxIHNpemVzKSBsaW5l LWhlaWdodCkpCiAgICAgICAgICAgICAgKHQgKHdpbmRvdy1taW4tc2l6ZSB3aW5kb3cgbmls IG5pbCB0KSkpKQogICAgICAgICAgICAobWF4LXdpZHRoCiAgICAgICAgICAgICAobWluCgo= --------------BDE0F6A92FDBF15CD1C3688D-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 01 04:10:56 2019 Received: (at 37563) by debbugs.gnu.org; 1 Oct 2019 08:10:56 +0000 Received: from localhost ([127.0.0.1]:60821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFDFI-0006MZ-AC for submit@debbugs.gnu.org; Tue, 01 Oct 2019 04:10:56 -0400 Received: from mout.gmx.net ([212.227.15.15]:46929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFDFF-0006MM-Fy for 37563@debbugs.gnu.org; Tue, 01 Oct 2019 04:10:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1569917444; bh=zk4JGuA/tWXvv21MpulorjUJegFdr1Zgm+qH+LUTwSk=; h=X-UI-Sender-Class:Subject:To:References:Cc:From:Date:In-Reply-To; b=GfkD/eb/CWL0nLr+X3Zq49J7SwfuwvQoz+LG8vNcX0gpmSUZIfs+mePxu4uaow+VC TRuXkYRm4jcnWRICV0YxIKLkFJXIUro9OrQKrFshfOyW9bETVTQHAcdYFfOMryWtm4 CVWoVTZfkkxHCVwcpJ1W97OrrltdaoYipg1PGErM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.139]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N17Ye-1i8IHe2fko-012Zfi; Tue, 01 Oct 2019 10:10:44 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> From: martin rudalics Message-ID: <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> Date: Tue, 1 Oct 2019 10:10:44 +0200 MIME-Version: 1.0 In-Reply-To: <87lfu4aook.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:T7/VNHusTAlHS48cr16cd152Px7iHQJtYSEUVg6pK4AERc8LNre pRrrWkYGBnc/uDyECa61FfacOBQ/FAtyLkjpyzpRvmgs99JkMAgxUKDEna5iqNCoU5dw1Hn Ry+e48pjVZuaLcnxd4iCvqkrBMA1IYi+S7J1ZnEFMUe66401BNBwGnv5jS8lBBo255QvD5c aUykG1r/nMu9qYyp2DTfg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nSs03OJ51UQ=:TV3lWCcza/0n1rmXtdECZP VmyoNwlyrnnI+OUFtDXEtu0tiqiUxVuAW9joVknhiJd9HPqg0fKfk/We2/A8Nh493qX6wI4JH QOEPsRd4fKt7/44MxznkCdIhkk+FI5ojs+0y2YvYBAdqduNkmr7e0qd6+9v4ahou7P/X0q2pF DLzH/qLEJSaHLpdreum8ZuS3+5wLSWPwwhn1zMd4lU5z4zlIxFief2/aIMRJ4uqHa2WwJFrwY hEjPW797gQd5MJLP1XUnIUwuKbFzq9AsAVaYj1uIAD0vxF+c/KOtzIiC9UW0PH63hVAatMTt5 GoZvtmGNwtk/RRi3wUn1nQ8p7GDzZf1Ljna2MjiZT+3hdSbqFKGhhGPPDmkqS30Co2AUx9HNp Yep/DuzVP/OfzTC9EGlFJEVxSeYGseU49FYlYGewvfWIpEtyuBG1u/FecB0J1Y7OSMGGmHH1f IP8bbMuPqPGPqpEE5f75rBepF21AxnfYBn7LtnJp+RHcosHMDOuSE8xLHAWS6Y7jLTCuiMFMT sjQZVwYU+TplY1MfX/gJM4bz3Ohqyn9NI9klF8zWNNog9uYNP4tlA/wbk7ggrZIck7HhkjnNX 9844+oLTEk08m412msE8bO7UsWOSKjPQKBfBa/GDOcAXQTIYCe42wQKdrcgvAtXf5D0rfHJsl L3v6KG7g/3tsdnVZUbUfrxsYbH46B68Ll2aIhKjf8L1GHyspfxCTtqGVdLeyOKGNWdnJ+Dl07 8a/+Htu7COqDgOW1dIMfJFgpg6Oc69j4ctr4qSVxjZNfztOIfcdVgKOIP2LkEyE0s/V4oJ3Ie LR2Lbdtl5l+U9G6qXmCUVdc7uy1RqGlibGwQnX/aMGHrsMX8FxzH140sVIPQE7sl/4AxePp/D 1GQ+CrNUTiNSQ8MkmJjZpKUE3oZxoA+fGnhJDOVwTaOyZnX0wtjfu9e1anP5j9j++qHbkgNNu PkqQ95+/BxDrR0Wq1oTVgJ5s6EX2TC9RYFqOOTHf+f/rTtA9qdzPesfd1sgG4WXJBwzrY+6Oe EAW0PpcI2dOB+Ds+96F7OWZRCuubi3+x1YbYJvVZdGdthq9o3VFxjizlfNypVJeBZ2lL0KDdk V96xXumXTWs7gTxYJthxsEtcold0DhgzDnIIgE2KxfvJ65fQx3LkzhEz8wrPgK91egYh5l86T Xq84SHtOC9sBjMOXUPjqP7HlXe+2pafBA68HSD5nOMRNUkHFdKR8ctvvRXKAkKIZfHrdgubGU bqF4pqG6oihship+7y1Bz7Nb+KxtJjqINqWjZ2zk/gkuQM70j9DugfjhMCS8= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > thanks for the quick reply! The fix is working for me. The separate > window-*-height functions are much better than what I sent a few > minutes ago, I missed all kinds of scenarios, of course. For consistency, I would use these functions in 'fit-window-to-buffer' as well. But I haven't looked into all consequences yet. There's also Bug#14825 still sitting around the corner, awaiting a proper solution. It's somehow troubling that all these substitute canonical character height with real line height fixes are inherently backward incompatible. What if someone did mean to use the canonical character height there? > There's one thing from my patch, however, that I think is missing in > yours: I think you're right but I need to see your patch first. It's not here yet. > In ll 8831ff, the height is rounded if frame-resize-pixelwise is > nil. That also uses char-height, and I think it should be line-height > there as well. In that case, char-height is no longer used in the > function. Which certainly would be an asset. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 01 10:31:42 2019 Received: (at 37563) by debbugs.gnu.org; 1 Oct 2019 14:31:42 +0000 Received: from localhost ([127.0.0.1]:34255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFJBl-0000bk-QE for submit@debbugs.gnu.org; Tue, 01 Oct 2019 10:31:42 -0400 Received: from mout02.posteo.de ([185.67.36.66]:59349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFCkr-0005OP-CC for 37563@debbugs.gnu.org; Tue, 01 Oct 2019 03:39:30 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C6DFC2400FC for <37563@debbugs.gnu.org>; Tue, 1 Oct 2019 09:39:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1569915562; bh=H5gAhapfT/sznivC3EGvL2HYwfUbe8VSoeoR1wxQqTs=; h=From:To:Subject:Date:From; b=V5Y0zTAjaDuZU7bXTEdUfdJ4xN8WUkia9RBGcYT5ENgMmrXupbMzNJfyrveOk8kyZ WABS/oBegDU7qEC7g+p9jpMBjBiV3BO68uXX4acV4n+un1MwYO1Tt3urZJych7gZqa le04gD1Cy5Y1tmqAxBJMWtasgATLqUzLXBGMsakDntwRdduEcaaJhrsJ4MFC6DfdBT WyMZoJniut6tZD/vOrfWgl6MPkbqLPMG2xnBtfLino4GHYjXUrlVI38rXhURr1FmkM j2/u2DHUydxGeI1zDVhcY4z8dm6n7OZ6DNKqfH/M+WscYuiRHC9u0zgkGzoUltCnbL vQ9rfe8MXt1YA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46jB3s3vYyz9rxK for <37563@debbugs.gnu.org>; Tue, 1 Oct 2019 09:39:21 +0200 (CEST) From: Ingo Lohmar To: 37563@debbugs.gnu.org Subject: [PATCH] please review Date: Tue, 01 Oct 2019 09:39:20 +0200 Message-ID: <87o8z0ap93.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 X-Mailman-Approved-At: Tue, 01 Oct 2019 10:31:40 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain This has an obvious fix after sleeping on it: Just increase the char-height by the line-spacing. The local var `char-height' is used once again in the function, but also with the correct meaning. Actually it should be renamed to `line-height', should I do that? Other than that, waiting for some kind of review before I commit.. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-frame-height-calculation-from-max-height.patch >From 5b9ee5b913b031fca6f424170d9b61addb090294 Mon Sep 17 00:00:00 2001 From: Ingo Lohmar Date: Tue, 1 Oct 2019 09:27:55 +0200 Subject: [PATCH] Fix frame height calculation from max-height When `fit-frame-to-buffer' is given a non-nil `max-height' argument, we need to work not with the char-height, but with the line-height including `line-spacing' (Bug#37563). * lisp/window.el (fit-frame-to-buffer): Account for line-spacing in height. --- lisp/window.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/window.el b/lisp/window.el index 620eacdd29..21b58495fa 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -8637,7 +8637,10 @@ fit-frame-to-buffer (setq frame (window-normalize-frame frame)) (when (window-live-p (frame-root-window frame)) (let* ((char-width (frame-char-width frame)) - (char-height (frame-char-height frame)) + (char-height (+ (frame-char-height frame) + ;; Add line-spacing in the selected window's buffer. + (buffer-local-value 'line-spacing + (window-buffer (car (window-list)))))) ;; WINDOW is FRAME's root window. (window (frame-root-window frame)) (parent (frame-parent frame)) -- 2.23.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 01 10:31:42 2019 Received: (at 37563) by debbugs.gnu.org; 1 Oct 2019 14:31:42 +0000 Received: from localhost ([127.0.0.1]:34257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFJBm-0000bm-K4 for submit@debbugs.gnu.org; Tue, 01 Oct 2019 10:31:42 -0400 Received: from mout02.posteo.de ([185.67.36.66]:43443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFDWC-0006mW-Nu for 37563@debbugs.gnu.org; Tue, 01 Oct 2019 04:28:25 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 56A9B2400FB for <37563@debbugs.gnu.org>; Tue, 1 Oct 2019 10:28:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1569918498; bh=BAFh1aXSfh7Qpy6TNjATxWP1sM4UdwAyREncB1oT+NE=; h=From:To:Cc:Subject:Date:From; b=rPsNwKZss3YtLqRHkngJIxox9oU33KtnOnpK5BG+AsblfgeqlDkSUPG4DaxVQgASH yQUJng2TRVyPBqj0hYzwF19bhxI7BrblH13ABo7JpvPpC1Pj4Zpe/eGmygVCEiU4+o 9ZwXlC8pkiXh6TZ42zuOjclBy9pI2z79J90ciey85VP/BUtrb1s3ASaCPV2xmpqt5H SQnQbsVJ72YvgsETKX859rPK0pBhBjP4fTyildrKnp4Laet6RBq74YeA6ktveOy4EB 2WVC84dkQmyhuWEJ9Cxw1Zg/3XIAyPS5x4OpTI6q+ymiKGRDOCUn7DAN8QxzQDmnWP 2rG3qmL4wtE2A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46jC8J5VYKz9rxB; Tue, 1 Oct 2019 10:28:16 +0200 (CEST) From: Ingo Lohmar To: martin rudalics Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing In-Reply-To: <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> Date: Tue, 01 Oct 2019 10:28:16 +0200 Message-ID: <87d0fgamzj.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 X-Mailman-Approved-At: Tue, 01 Oct 2019 10:31:40 -0400 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Tue, Oct 01 2019 10:10 (+0200), martin rudalics wrote: > > thanks for the quick reply! The fix is working for me. The separate > > window-*-height functions are much better than what I sent a few > > minutes ago, I missed all kinds of scenarios, of course. > > For consistency, I would use these functions in 'fit-window-to-buffer' > as well. But I haven't looked into all consequences yet. There's > also Bug#14825 still sitting around the corner, awaiting a proper > solution. It's somehow troubling that all these substitute canonical > character height with real line height fixes are inherently backward > incompatible. What if someone did mean to use the canonical character > height there? I surely find the complexity of all this code jarring, so I have to restrict myself to looking at a single issue; and here, it's clearly fixing a bug, using the char height is simply wrong, IMO. > > > There's one thing from my patch, however, that I think is missing in > > yours: > > I think you're right but I need to see your patch first. It's not > here yet. Debbugs and the mailing list interaction is another thing I do not really understand ;) In any case, the patch would simply be confusing now, here's the change on top of yours: @@ -8794,8 +8828,8 @@ fit-frame-to-buffer ;; Fit height to constraints. (when height (unless frame-resize-pixelwise - (setq height (* (/ (+ height char-height -1) char-height) - char-height))) + (setq height (* (/ (+ height line-height -1) line-height) + line-height))) ;; The new outer height. (setq outer-height (+ height outer-minus-body-height)) ;; Preserve margins. And then char-height can be dropped. Best, Ingo From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 04:53:58 2019 Received: (at 37563) by debbugs.gnu.org; 2 Oct 2019 08:53:58 +0000 Received: from localhost ([127.0.0.1]:35326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFaOT-0007FR-Rm for submit@debbugs.gnu.org; Wed, 02 Oct 2019 04:53:58 -0400 Received: from mout.gmx.net ([212.227.17.21]:56259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFaOR-0007FD-Em for 37563@debbugs.gnu.org; Wed, 02 Oct 2019 04:53:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570006426; bh=C8znK7nppjcM/NXPrYjOVqfPCgoDgY3Ztfo+halFsik=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=j+WYXt3wWHBJ8ZCqDkHarhIqvCYOkaIESxeKKP9a2BZc0d5h5tyfwoHTXMRB4bzQD 2pYZ6i0IsbyKjRw1LSWbwPGAKRLzgddUw/LSqoYLiiJ15c95ct0kz1ruRRly4OqPuQ IwGc811l+SvQ9lNH3kZS+XCCa2Xkw5nRKzqvvypo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.203]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJE27-1ia9PV20xH-00KhSc; Wed, 02 Oct 2019 10:53:46 +0200 Subject: Re: bug#37563: [PATCH] please review To: Ingo Lohmar , 37563@debbugs.gnu.org References: <87tv8tsk3f.fsf@kenko.localhost.com> <87o8z0ap93.fsf@kenko.localhost.com> From: martin rudalics Message-ID: Date: Wed, 2 Oct 2019 10:53:46 +0200 MIME-Version: 1.0 In-Reply-To: <87o8z0ap93.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:QSTM3dvTI80EvnPDzgBydzjaCxLIVW8oXMr7f3CIJfB2LbR+Q9G HMfv6ZO7b7xgeDKBYvQKJrU37K6w+XDdHbKnD73nhFbgne05lTBi8MxdkXp1lC4UPtLPYRW y4lED1hkrmlA8A6dJe3xplGV0BRWhascreUxNsVKXDYaU/cpbT8CaEMEz0rb+A9c7rSBes4 0rVfVI3q72JcezlQjImpw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Xhvj46r+8YY=:+cDzLhNpoDMCYfCpdgUe4G d38czAO1f5KwOa1TvbUvfuooQ5Be7n2VZSKBiu1DJshK1LulHCtFi/DcDzWRcp41XSe1xouRs E4nwicm5BOMtC5xV8nPx8eQ25d5pT5mi899jTFzW8Di7KVeW9IIniO/eMwFFfxHlwvHYMEW1/ 3mfDLxtHH6R6nCQkh+JfpWJ5cYm5+BNHaiWwZgaaqjcswr7gF5hl1+4xXP4H5DC4iasDsC3xh TRUycUrrVhbht2gPotuSnKdYi4xmZboQOkAhTqVKu6UuHHSSeUblfMhq6q5RwA7jBYVEbpNqg UY9oL+571lBPE3+sTcrvKRgmj6mWptn+fSHdoUOxOWOVUTUprl9UAL0pzY+KmhNrm8Fl39yUu Z7H8RhvSVMYWN61RuD+i3YFWIqMwV7zhfRmLA494TqxfcRDhWmB5IJkEqMCsUm7LWepx+uF+n Qt6wtL69v+eMHfd40Ot0/riw0e1Gu750oupiI+bwd9qtZ9huLbLET3JisVDXUuxL4MgYYsk8T J/bhw92SRSQt6vyAtw6TCxnPcv96rc+16i6qEwYMW0hx7AG94zc+l0KI3lv+5oSh5zZoXF3XY vCEW11gJR218rQeDsoRL/f1uSDF+8TUCiTzAlJVOJlwlep/MPAW0HnsY+MgLScQjlsYnQGlAS feqjON9yjqTp76waEXQou4Sb2SYxwsajm/EtNcZfbPqvDfR9/H/51Bax7B/aqaBqe1Blj99Ra cK+UC1nzQyj0mRgw1cEFXu8zUqeKq5qkO0vH7FMl2c86KTL0rKRDhjAk9IBHcAKTTL/6QqUD1 lt/X6QWV2O7yDWodTp/ku5ksdNwD9wWn3UFya2sj/iM9+aoLLH4KO5yvBpiilDcA2ZeLYfBoJ jw4YEmwpeyOdsbGs36TxtLKm/CPxWzI8nOBjq0uLsoAanB9+OXcQ9GNdDvLL+mpzHorUpnnuP edWOcVuL37UU667K8NyrjlbNTKcbs9VHhTBBcXig9eDiUBmsnGk+VqA5Gbk8auf+jlwXM8+F+ kQYmraD3katicASL6Vv1dCctEZHuiMEuITHTLEeAeOMxPzN57/8Qzh+3ntxmrICGXPwEETSKV yQ3tpq9TCvAV+seTMbut6B99oi2lspGziEVTj4ySgmfadjwrU+fhb1PmBjlvsbMwNEhPE2ljr f46Wn7OvclqDyzZgGl1CwqNEyhAPxcxYOplwpppgqtvEFo3AmrvoF8HP9cgqYy0dqoUWY6sd9 fOUbhnrIc22YAkFQ6uyFVe/MLNqSKoA0IN4Twig== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37563 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > This has an obvious fix after sleeping on it: Just increase the > char-height by the line-spacing. The local var `char-height' is used > once again in the function, but also with the correct meaning. > > Actually it should be renamed to `line-height', should I do that? > Other than that, waiting for some kind of review before I commit.. Received, finally. Would be interesting to know what kept it so long. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 02 04:54:12 2019 Received: (at 37563) by debbugs.gnu.org; 2 Oct 2019 08:54:12 +0000 Received: from localhost ([127.0.0.1]:35330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFaOi-0007GG-4X for submit@debbugs.gnu.org; Wed, 02 Oct 2019 04:54:12 -0400 Received: from mout.gmx.net ([212.227.17.22]:33693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFaOh-0007G3-4D for 37563@debbugs.gnu.org; Wed, 02 Oct 2019 04:54:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570006442; bh=4fnc3ALsgPJezyWSVRwO5/0MnCtwF9UGE4rOcjp4UAw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=bn3titZgdPDmpt+bVobGjnibtVjXpJvKV/Hhvoo3eLTc3TuuR5sO/bWXntZnJpDj1 FkLpZ6TDckzPmJAWgMr6lSkNeXtfNATy0j28JZ7L6cicsstTl2cGld9j/BaL0b+CV3 UJVVcQd06AbflyNwQgs7dkFvmuhh+39vbY5iUUuM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.203]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7i8Y-1i2zSC2p50-014ij8; Wed, 02 Oct 2019 10:54:02 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> From: martin rudalics Message-ID: <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> Date: Wed, 2 Oct 2019 10:54:03 +0200 MIME-Version: 1.0 In-Reply-To: <87d0fgamzj.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:JUcjH/0g9JDZcYngXWpHNkjKSWAXMIvqjSRHUzcp1kVdKoi+YzA PlTWPP61l5aqx45fYXMLbXUpoH1HcdgOSXnoJi4ERTXXeHxcY+IhRz7LBUK1tGNHF8QupjM XOKnfvn2SMoQFrMp7DReDHAU4gyo1asOhlBVpyYL1k8r3shMTD6r+zEr4c8dhjLJ8NSqWX8 eWCcvj6KPjjTlHaDNxyQQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:l9zsel5TgBc=:60Hv917MzyoTPS2OBqH8/E XWwFTLKcUyuQ6f4Y0Ds4sWwSvzLkUxQNC2sSWYnWQ5ZV6+ozShQ23ioP0Hc9o9+18X06lwmuA Ngw9yFkehVB5CXbAXM6fAlQ/jSEOK0Gs5Vc9Sr1ImQScrlKllxz8q353/q9mJxy0ZlDY7oJLm Q4UIFkz8RdrHIyz7LEzAb7lCN6cMJmcfnIlLvXpQV0L3Z3EN7aEiDYghH8R5BHWxgQ21v+FCg SaPES5ExME9myVSrMLsYb1RvzXDW9rPVmMWQClZDYwhnahzq6x7kgqKvDdKrGqU2vsqCYl+Vh lYq5kFzW37PJlYFA55Ra+vjq1fJGSMlwjNUUk+xxyT4EG+TznJvH1uM+0ozGCfN6qhWVpi03x pYR/SW1O8tndr9KjIE8r0RQA9PW855R/8lc4nrLn9mnlwx0M1k6kVWgP+ArX1taHSC2zPS56P N+N9TsHODDqEUiQShFOF6SCqBwb03Z7U1MWUbSt7Gy5/A+t0ZxdPyJelTV0OVUAwboBdNvGw5 /En4ZSW+FeoKdsewu6N3w95HJ3Esc95HR2C5X9AxbG/zWGbAeBOVKfGsnBkaGcTV8g2iWXhx3 UtjalOGmknDcGFkW1yHtEC+QThpA0+ngvyYBYyKjVAyGKCt3gM42m7gX/p+CYjPmt4M3/roue x85zZm7xkZ/pHP9o4pLZ8EpTHYc9YPGvpmDxn7iDJaVf1aSjKtSpbinWFYFQ/rgXevrOntcQL davfiLCGChd+dOODV/vNi5gh+MEXcTIY7hm+jaiG4xo/xzP0XYEcTI+HOBt5bxMMe56khZX3v 137xnP7ijGXbaOYR/+MRnnLwyhJT3q9+a4xy1J5Dl3eDddYYuBvo6NeZFR3uAMtoN8YzmMs+c HYRGf44p0LWWm8qyF8Zh6Qvz2AMNh14un1P9IfqqPk5hFYGy5GPjFEhepHzhFQZzbZj8XJKTV UqX4zvq6kJ5mDTB3Kq8pOCVO1ah75ono7QwUaqnVyPBokFfz+OZzu1zSjkMjEkPfB4Q/6U9J4 CmMSvWoOOu7080eIIJmtzBOfRvbkQn4x18eVpJhg+3N2qpR13BSt64gJASsYvdYExq5KGZNjH 5Rd4BM8tQiDnKgbTWhqD18Viwlbr0lLycV6yv6n//4tPKAYaFb76PaSS66bKK9170QHGQ54Ga osB+lgLkoFhDgnHl1BfBbZRuVVjvp2Kj9DyIeS28OeVqYZiufom4AhhuvPyrX4S6nSWvSb+SD Yn5kK4FwNwoWhQH7LrR6bMaTvUDFkk3BdDtHvRGbFgXO8M8VdeIJ0+VQHPzU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I surely find the complexity of all this code jarring, so I have to > restrict myself to looking at a single issue; and here, it's clearly > fixing a bug, using the char height is simply wrong, IMO. Agreed. But if I change 'fit-frame-to-buffer', then, for consistency, I have to at least change 'fit-window-to-buffer' too. > + (setq height (* (/ (+ height line-height -1) line-height) > + line-height))) [...] > And then char-height can be dropped. Right. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 04:15:27 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 08:15:27 +0000 Received: from localhost ([127.0.0.1]:38727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFwGk-0001sH-PB for submit@debbugs.gnu.org; Thu, 03 Oct 2019 04:15:26 -0400 Received: from mout.gmx.net ([212.227.15.19]:55935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFwGg-0001s1-EY for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 04:15:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570090513; bh=YwV4DaJYfhc0MGCyiGDu8kLX0B9LUtoo6ggbLErWroI=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=ekDVMGVjKp5Bhk12Im/9M92BTKCpmJXMsPKF9rnWmxs/W+/oytetBAWuy3aaO6Aaq +mq74bdROGCUgFU2BXvVbz0qzYzohf36N06fDT4pwmXV7Ew5nsK2Txdd6t5+E2MgRG /mcFukXBugtr6eDT2K9nPNr+DM/0ynW53l/Bq9X4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.249.90]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MG9gE-1iLPO133cK-00GbSR; Thu, 03 Oct 2019 10:15:13 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing From: martin rudalics To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> Message-ID: Date: Thu, 3 Oct 2019 10:15:11 +0200 MIME-Version: 1.0 In-Reply-To: <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:TvzwgTFussNziT3BbddE0qj7S7NS0hN5MZFk6ZR5cCDyxKD2JBr rtzdIQ4Gk4QII9sCpNO/hROc+CD6Yrlh79ysV3Zf3q1Bb+Xw+EMuO2uPVX15AGxprg9JRVE hn7FsREiQVgl0KMNDoss6F8OEcdba7FqIxTTR9k5S98bdz1v0cTAW/s6KLs/J3ijRLlxWhI qqU+Mooxv6p6IEs40Sb4g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:VRl5ns64j7Y=:vo/uhXrN4JgXrWeTIjXZeK O/Yqa5NNt65XiMQ+OwfQZbtd0zHdtQS0bB6AgEhLYLGTu2mT0NBYZoSgCRGCWp1bVxxWNXmrG DcbZfqok3B+1cPIX6uTJauVVCuL+bLU65Zgd5/0MpJHumETR3Lb+Iy0mxpxzpPg8u3Ne0tXh6 0wdHZLvPWsKkgNJYIex44qvSHYtBZqmc66n0E0/o3m0rA/sqfcp9iqT3MEDAWLplEl5IKOu6V yiW7avt1FEyv83v2iFdZe0ONhpklxPI/FUYqM6QwXo5q4DmRtuRDb1vL1Co8OFSWYLoJqSS04 qImP1USwhrudi/y/p+CxS6HtPGZNnf/auS8BR9zW0057Hs4XJnUPpwiv7J0n371k9LzB43W2S 3FhUm0oIm6AVa+0SoeEfSCs2Vh8Qov+YaKY2esGpN6Xw8pSmOqetFqB8zR4I0qwl6wb7NO/vA LSFw6ZkobC+1yYg5zorTmU2dj7qy4/ao9Zea2gpDrTEN9n2nxKA6A3O/zlhtmukzgXugRWVhD p9ZEkZZMmbFGiHf/lX/iPLz9meisxiBWIVwr3kk1pMDFVcwEzESB4PwKEHi6MiFlsSedNaFyS t71nzwmIBr+45UZdeMbmOQF8sNXXvySyrTbd2u8uXKXE30PaxDoz05lfAGMffkqZ9p7sgwNDC H/fhl6pFX7T655owaAZCzdqjfDE3LL/vS1Fj4RFfY8AeZxTV5UJ6CpLmzu4xw9i0GZec+HRov 6Yvg5bI8UurPxhIqNQCLjzG+3teYvS8Q9WegIaCpSA2kn7qjffDBPuhCDsS+0I/gtbbkNBlTr egz/jiJfRKDgSllTRnZWUJL7tf8F1WaOZsAf6NMiXIUSbb7JS+H6ae2IoMqP0bOO76MLpD76s HVCi4pMx1rcbl7BPwtkS7aURow75QQFwsg2Ug5OjnlJ4XMAlc12YxEqRIZD7urzlFS48lCDdt /0KlEmvsoECdWFGFReIIvHeREqzx7J2bT3QmJdT7NbNprNBxyU3bu69h64G6b2ZvJ2rospzyj xXZnNQPini9CdrNh9E21JuWaLZsx9i8nb+otNJwJIeAZDdJP08uCpgFVvPszXNC8tx0B9axJD ZwQn3rbXovH/ZjMe3IYzDN7McXYitGKgo634M6dGgBqDZHwx2isG2gVVnl5Ee6mHvMREEoUjs wvC9izKhA96RZR1VhYSpowSZRK591ooLiFa2nAok3c9MUD8IvgM/FZEEkFRxTs33Wm2AGCRGl LpYuHTbgZtMYNfA0qWpheLvF2LYGSH6J/ltnd2+sC97QptmLXSURKjhsnXUk= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Agreed. But if I change 'fit-frame-to-buffer', then, for consistency, > I have to at least change 'fit-window-to-buffer' too. > > > + (setq height (* (/ (+ height line-height -1) line-height) > > + line-height))) > [...] > > And then char-height can be dropped. > > Right. Hmm... Back to the roots, unfortunately. When we are here, 'height' is the calculated height the window should have in pixels. When we want to communicate this value to the window manager and 'frame-resize-pixelwise' is nil, we have to transform this value (which already includes the pixels needed for line spacing) to a multiple of the canonical character height of the frame and not the line height we calculated earlier. So using 'line-height' here is not the TRT unless I'm missing something. WDYT? martin PS: My 'window-line-height' must be renamed to not clash with the homonymous function in window.c. It will probably become something like 'window-default-line-height' unless I manage to merge it into 'default-line-height' itself. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 04:48:32 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 08:48:32 +0000 Received: from localhost ([127.0.0.1]:38750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFwmm-0002f9-88 for submit@debbugs.gnu.org; Thu, 03 Oct 2019 04:48:32 -0400 Received: from mout02.posteo.de ([185.67.36.66]:60273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFwmi-0002et-CF for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 04:48:29 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id A40832400FD for <37563@debbugs.gnu.org>; Thu, 3 Oct 2019 10:48:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570092501; bh=qqKaEPcYMkcvDdkuc7xipmXSYApmLzS9yaIj6o1ofTU=; h=From:To:Cc:Subject:Date:From; b=BO0fVGW/XUwnMJm9yT6jVQkPWD2+y459nKz5LXyzQwJZXYHsISdze3lFp4PWvCOLM ixCsHKCvC+MIbO1D3UUh7xx4XW68JpyYKgKc5kdFilwHTe0ubWIjFbTBIU859aG0m2 15szS5pAjL/yU+U7T7aFZxePARbnpUnBKhZDfrR9dgn982UK0wQkIz+49TfWzCJ4bf jAtX4Hv+HO2WeSS8rEy3QWxSwwvotBT62Hs6galvN59MSGbmO9JvDpZ+nxeTQemWHn sRlZdetAcHOr5H8QYZIYgdnxCq3HQVVTXrH9zDEpl7up7F4Z+q0GMnE80h4HotpjZL rTQBIJHiFK5JA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46kRVW6lcSz9rxN; Thu, 3 Oct 2019 10:48:19 +0200 (CEST) From: Ingo Lohmar To: martin rudalics Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing In-Reply-To: References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> Date: Thu, 03 Oct 2019 10:48:09 +0200 Message-ID: <87zhiixliu.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Thu, Oct 03 2019 10:15 (+0200), martin rudalics wrote: > > Agreed. But if I change 'fit-frame-to-buffer', then, for consistency, > > I have to at least change 'fit-window-to-buffer' too. > > > > > + (setq height (* (/ (+ height line-height -1) line-height) > > > + line-height))) > > [...] > > > And then char-height can be dropped. > > > > Right. > > Hmm... Back to the roots, unfortunately. > > When we are here, 'height' is the calculated height the window should > have in pixels. When we want to communicate this value to the window > manager and 'frame-resize-pixelwise' is nil, we have to transform this > value (which already includes the pixels needed for line spacing) to a > multiple of the canonical character height of the frame and not the > line height we calculated earlier. So using 'line-height' here is not > the TRT unless I'm missing something. WDYT? Well, I don't really know :) I'm not totally sure about the meaning of `frame-resize-pixelwise'. 1) I think you're right in the sense that rounding to the line height (not the canonical char height) is NOT what the docstring says it does. That's bad and should be fixed either way. 2) With the above code, rounding window height (incl line spacing) to a multiple of the line height (incl line spacing), I do not see any effect of the option value; because it does not change the height value at all in my test cases (small popups). 3) BUT that's not generally true, IMO: If the height is restricted by the screen, or the margin calculation changes it, the rounding will have an effect. 4) *My interpretation* of `frame-resize-pixelwise' is that the default value, nil, has a single intention: To make the frame height an exact multiple of lines (and char width), mainly because of aesthetic reasons. In that case, I suggest we change the doc-string (which has some inaccurate phrasing and is a bit wordy, anyway) to say that it nil will round to a multiple of the default line height (incl line spacing).. Very briefly browsing the C code using the option seems to confirm that interpretation. So I think the code snippet as above is correct (using the line-height). I will try to come up with an updated docstring for `frame-resize-pixelwise', if you don't mind. As for the consistency changes that you mention, that sounds fine with me, you know the relevant much(!) better than I do. Ingo From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 04:56:38 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 08:56:39 +0000 Received: from localhost ([127.0.0.1]:38755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFwuc-0002qM-BO for submit@debbugs.gnu.org; Thu, 03 Oct 2019 04:56:38 -0400 Received: from mout02.posteo.de ([185.67.36.66]:49505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFwua-0002q9-CK for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 04:56:36 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 26B602400FB for <37563@debbugs.gnu.org>; Thu, 3 Oct 2019 10:56:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570092990; bh=y0K6kGFEvQbomQhLhDONQVtSUBKZNudC0vLG959Nq/0=; h=From:To:Cc:Subject:Date:From; b=bGWKHOcvCjEjuyGQ4uUSwdG6VjutVoRZEh0hQsXvTMI5kam0nen5OvAqgolv19YuY 5OD4je4gSIgDzmOMq8jTUguQPkr7pj2kpiP5I3tyxhRAhP+Rv6T6RP3t6FEiTh/+TK jcYqxN03FIckJLSMsOhD+0HYBzrdDIU4KhILKIIWv0kNRST7Z0AOl3KK/5sIn9WJB6 x1uaCXe/AXNRoC/Zp/cPx1uQ8w8yktp1WN+iFn3k7BdW0ECs24qiHcA1JDVVOB9kCz pwXUbiaFAstO1Xes6dP6xMXBBjo0gQ3XUV5wDCzt3k5jj2HFlaxnJ03iiOqSa4O/nk 9jjgpYuRT/GPQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46kRgw56jPz9rxN; Thu, 3 Oct 2019 10:56:28 +0200 (CEST) From: Ingo Lohmar To: martin rudalics Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing In-Reply-To: References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> Date: Thu, 03 Oct 2019 10:56:28 +0200 Message-ID: <87wodmxl4z.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Oh, one more thing. The meaning of "line height" in the C code (and related lisp functions) seems to be "line, without line-spacing", for better or worse. Having line height mean sth different in window.el will make the situation worse, I guess :) Maybe we should go for an ugly, but different name like "line-height-w-space" instead? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 05:12:14 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 09:12:14 +0000 Received: from localhost ([127.0.0.1]:38787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFx9i-0003Fn-5Z for submit@debbugs.gnu.org; Thu, 03 Oct 2019 05:12:14 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:36614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFx9g-0003Fb-Pg for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 05:12:13 -0400 Received: by mail-wr1-f49.google.com with SMTP id y19so2120137wrd.3 for <37563@debbugs.gnu.org>; Thu, 03 Oct 2019 02:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=xl4Hu6o48B3elGFeaP2xBvHL5lprGuaQAA6fNyYY5LE=; b=cWfewQNCyupohc2g4i+A1bto/hG5p8pOsmTscyoz6vpHZxXERYy9l8oT3KYsGMOVCY MYLJA6KYrafXfuhU/J//qizq4af8s1xc1sZKrcvoIxjtJbpbo+e5qrEoTaTmlm3RlaJ0 LhmgBZUBR9T3wgpirQEU/1pNEPOmOsZzyxQ0OhqGzHZORTo3d+Z5vUhS5nLpMe6LddKX 9SKKKQJfgtMYr5QwX5AYBklgqlNMFn0MIvPp54RGwIdYDbcA5GoquZK9V6KK2kvtRoH5 4YsbJDala6bijpZuKEDOxTke4NGUj0eitKEU7mngPKMnRaypyZPSkoGsqRpPi4l0kugz ++vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=xl4Hu6o48B3elGFeaP2xBvHL5lprGuaQAA6fNyYY5LE=; b=dPLtFhC6fUOakWcV7iUEHUZ7ZOca3mGAkj+SWCtLTHdKR88EoXlHXQLTJx3p82U4/v ZlcPixWrsGXI20vDlhXzAnrOu+QTBZ/LvFK0tNLaiQfSs8JgwKo7X4wU+Z0/Cg/YnRns J3B9mUGmi0O+OP510Qi2F2U/izijCLj2VgV+3A1q0CeuEBXCxCwFY4KSyNJy2GYZHUpc mOngXjwCF/avkYh+OauQgEJbRPiM2PMz+C7XR81/m6Xx7LlBtZGaJqSpUhL+4hadFxF3 DIEdtsX1jy/Qlg2582EimwDO3J0c6gWVxuQfCrhC9PCO33sO7hnOfVGbcOpchOKwxHxh j6Tw== X-Gm-Message-State: APjAAAWc7aS+4urr2I+SqgFHOae2N522sHD4gEl9hoHuLHJ9W/ZSYh6Y c2aW5TaceS9H4OVTWoG2vp7e+DTWpao= X-Google-Smtp-Source: APXvYqz+XSmClAJGlo7POPF9/Ig//4CTxPfcfSTnWSoBGX74U9NGEMNck5jTp9z2OkWi1Y5aVBIgKQ== X-Received: by 2002:adf:84c6:: with SMTP id 64mr6752189wrg.287.1570093926412; Thu, 03 Oct 2019 02:12:06 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id e18sm2383508wrv.63.2019.10.03.02.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 02:12:05 -0700 (PDT) From: Robert Pluim To: Ingo Lohmar Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87wodmxl4z.fsf@kenko.localhost.com> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 03 Oct 2019 11:12:04 +0200 In-Reply-To: <87wodmxl4z.fsf@kenko.localhost.com> (Ingo Lohmar's message of "Thu, 03 Oct 2019 10:56:28 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37563 Cc: martin rudalics , 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 03 Oct 2019 10:56:28 +0200, Ingo Lohmar said: Ingo> Oh, one more thing. Ingo> The meaning of "line height" in the C code (and related lisp functions) Ingo> seems to be "line, without line-spacing", for better or worse. Having Ingo> line height mean sth different in window.el will make the situation Ingo> worse, I guess :) Ingo> Maybe we should go for an ugly, but different name like Ingo> "line-height-w-space" instead? 'line-display-height' ? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 12:10:11 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 16:10:12 +0000 Received: from localhost ([127.0.0.1]:40898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG3gB-0006HK-Hi for submit@debbugs.gnu.org; Thu, 03 Oct 2019 12:10:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG3g9-0006H5-KV for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 12:10:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iG3g4-0000gf-8c; Thu, 03 Oct 2019 12:10:04 -0400 Received: from [176.228.60.248] (port=2345 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iG3g3-0003n7-Fw; Thu, 03 Oct 2019 12:10:03 -0400 Date: Thu, 03 Oct 2019 19:09:50 +0300 Message-Id: <83v9t57qup.fsf@gnu.org> From: Eli Zaretskii To: Ingo Lohmar In-reply-to: <87wodmxl4z.fsf@kenko.localhost.com> (message from Ingo Lohmar on Thu, 03 Oct 2019 10:56:28 +0200) Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87wodmxl4z.fsf@kenko.localhost.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 Cc: rudalics@gmx.at, 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ingo Lohmar > Date: Thu, 03 Oct 2019 10:56:28 +0200 > Cc: 37563@debbugs.gnu.org > > Maybe we should go for an ugly, but different name like > "line-height-w-space" instead? line-vertical-space? (I'm lousy with finding good names, FWIW.) From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 14:10:47 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 18:10:47 +0000 Received: from localhost ([127.0.0.1]:41114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5Ys-000722-Nr for submit@debbugs.gnu.org; Thu, 03 Oct 2019 14:10:46 -0400 Received: from mout.gmx.net ([212.227.17.22]:38911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5Yq-00071g-IQ for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 14:10:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570126238; bh=qtjpWlxaipvEqDJ7CARRxA/YvpsGA+YbKfRGuF5mROk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=YXydBGj/BorcjXYqWnxidGJOfE9sz3GYSzz64iBfjdYCdd9ajxDJpXgCvgyUdf0IS 9BrsgTqCvJrwKM0/7TN5MSoeZsAcp86bPZkwT6iqzvSKrI75rjhbCeyC/UMy1vEjIR IKm4Xjoq/Ys/6mWsNEEwus0EWLdntQCUgQGaqzr4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.198]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOzOm-1iUR2f3WKS-00PJQ9; Thu, 03 Oct 2019 20:10:37 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> From: martin rudalics Message-ID: Date: Thu, 3 Oct 2019 20:10:37 +0200 MIME-Version: 1.0 In-Reply-To: <87zhiixliu.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:5oK85DWo4KbWTV5YYVCkgVSPw8Txf7kopNTIN70p16SQmeRLz4X 3vOgbE2L3SDbyEJI12TKKb0icv57HlopNNSoWtjUxKhQZc/UUa2EdPp/DbR5UBPEjSSwXfe fJFesodP2VMtiOr9F3Edfhoy48LufNN4ewLm9jeGjHRuHhmuowbtauiq+9RPG5zNsP42gqi 3ZdjOLVn3pVZt+uj7gY9Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wRg/vZhJDAc=:6HlINuD3r7awNa370zNYlg 2qpoDSxbAwH1I7lmy47Wqrr1yC8n6lJzsBcBl0nimh0wkD/DZ6YufAHH31Saz8hIGS5tYRSeb AfHMwi308blZE+wSgf3INf4ZV/YAXa2D25vy/zdxPtjjm/MYgRgk7Pm3cemtnc3AdAyBEn399 Cj/JwHZ4b1DkzyYlLiUBmcIJVK2b4RLPasNtxDr7anaTRJpc8h5xd4Tq21oF05kEFI8YqmRaL cLbJtRDDs1iXOMrSn3dJLwG4LoZu3pcVCUs2atTsGNHQmlo75mbmT0CCOq6Et65sGK3/oXe+3 k/UH/6pBAeWFK3gnQYZWJa9gRr0bFWMF6h9XXj3gGiQ7XFgysq1s0twYu1oNgOMRmbR6Km6yE +nVR/SBo/bI27+MOIR1MsNAuYNecRVOkTJiPPudqLur0gHhhP1Vlml0pRdax8UkWp4v8gRtwB CA9gkNAsbzqbFFdGRFnlWrFHyKZO62p6CL/LHyuT3/BReer1pkwJr9l0VgCu8T6ZKLakuFguK ZVNg5++MRMREqqQ+SaRobeYivTF+QXwtww0fqpVSrfyMoAgyvQvkS1ro31p0GoCMd1i3KDZ5A jcmDmAkEb6daZWrnAY0QdPeR6lx+hXm+E7LvJMlWt7vThhjNZJ8O0/tDNfGh0vUuxahifLXaQ lp2EsC1th+mFZc7xo7LnENPMcyFcsFj0Kr2GzVgOpqYhhpL7X6UHGrgE1M+yGY9da44obVY6B sb1CJxt2y7pNrPMK37qHpkZiQAte9hpQbwk/gTALDgQm/ziLi82O0s7jSKkuJhkk4vdZi4iNZ kr9HNhTBrCHcNwZutIH3clHsobleli3PmPQxhxOZ7Ln/SGRq6siL0xKg2pZTaV747nEvwj9+R ligUDdW3GgSsQccsZjfXswhnaTSzo85ZVw3912GB8cpAirC4fpuiYTGTb8puCu2o1AOqQyNbq yIsJD0QroAgYpBwKv3K2zRx9TZ4UjkHXnPc0OTPixAfomMKoy4unNmda9ItcoixPcTAhAbhBW gmWoVzI6rAM4raFlGdHxJP7Min6HXAOP2XxrQ+7HDTVMHsAVTKh88GtGa3Bb4YvBQljw1ipjF XBfAj3mXjNu+a5/Adstk7y9Qd7ZE5hIZp94jxcU2CDKRFqdWdYpM1DAVDzI+63KeK+SJwUw3P hxQsCeX0OVMVyLHeGHnVvVOQHEVHItBOO+rGiPQg4OBuGLkSXKMW6V0v7RvJ7asNr23U1+Lpx HRGI0Q2bK6tYzSiLx3/DIsmqKuhIN2PGj/DDmhL0C4P2oJQ9Q6zjNpYPIVz4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > 4) *My interpretation* of `frame-resize-pixelwise' is that the default > value, nil, has a single intention: To make the frame height an exact > multiple of lines (and char width), mainly because of aesthetic reasons. > In that case, I suggest we change the doc-string (which has some > inaccurate phrasing and is a bit wordy, anyway) to say that it nil will > round to a multiple of the default line height (incl line spacing).. We cannot reliably do that. Suppose a frame has two windows with different line heights. Which one would we choose for rounding the frame size? 'frame-char-height' is canonical. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 14:11:03 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 18:11:03 +0000 Received: from localhost ([127.0.0.1]:41118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5Z9-00072h-0t for submit@debbugs.gnu.org; Thu, 03 Oct 2019 14:11:03 -0400 Received: from mout.gmx.net ([212.227.17.21]:34305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5Z5-00072F-AI for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 14:10:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570126252; bh=5QXQ7s6jks0t15KG0oXu/ZHKCSn8Gz454fhSWkrignI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=C/vi4Bj8eFVaCNFyfN7JqN84dksAtwyl3fXv7eWmFPvnrY3mxvZILFwpHx1hBMkEx V00brBFd8j/IxbjBqBqIm1OguY2DzeDgFcfja0D+iedJyTDs22qS0zUBmqv2d+SmlB jgNkYPLpzMDUExO01jEmViomANGOzy3Bxpc+m+x4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.198]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mq2nK-1hkpPa2tBy-00n9I1; Thu, 03 Oct 2019 20:10:52 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87wodmxl4z.fsf@kenko.localhost.com> From: martin rudalics Message-ID: <9ce0917a-5e0e-385b-fd77-9b583dfc51c9@gmx.at> Date: Thu, 3 Oct 2019 20:10:49 +0200 MIME-Version: 1.0 In-Reply-To: <87wodmxl4z.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:K6wurryYqI+42JgbVZsN1Z4umm38m1JLRnfLmQsChX6UiuK44xc kKbE5GwOVQamAsU6gW0Ny8F5ntn3B5Bx5MO8EO4i2jau49h+zq5xPrdpp1uPpCUhvQPeJBq Zx2HnV8Yqt3txinxPybVolUPpSCLr7Ty1Xk7e9TmH2K7169gFj3YuqmhjSooPSXdceT9lPa ctUawqY+EJfZJsUQV6+1w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Q/7+E+hvuhQ=:jnBCo9d/zhOmmxoTi99/E9 eyiLV7GWt1tqm5yFLP/0GFuGSN+waSAmT7wTVBRdQ8XeIKdgtNCeo0SgQaYxo2h/qAzhdOK12 0X73awNaE9UrjH3he9o00xWUyJYNIoLqE6xt/NOjM+ovg7YBvdCF6A3XqNz2xPzDT2tIUzaj4 d3Jn8YyIKXOjj6+s9VoObEDdRjMIVmB3tTlSiSmyWoqPBIPSH9I171PMgFaV5cgH/6lu2Nt+d ckRZD1aE2vJ7ErFtXrgdGoeEp4XFEbAeIISnR7UMHQww+z39inLH5VnpVSyin9Bp/AJJ3ZeyK ONPT0MN82WMlb6zrYRxhQear+81XVZ168821BTezD+dnlFGsDxuXgcWKiXXaON/1xSiQAP58O WSHVurOGe5PVYJBZOHQZ8BfiJq9OvWMWoY1Xti5rC8syiVBUC+CHAbMee854KGHJniz8EqYfP ZiaO+ziNwEyjPYKBx4kZt7re4WSI8ppEgky5MHDr5rEVbgTUPVTrzNJK0aY0eNhgwljIKiBwa WVj/AgEZrBot7BFGFUHwUxGm/3EBG9SSYr4IcIFbZq5jp83LIEBqrXm7Lnjs8qfTkGqS5vbxY d9Yb4jyLoYA5sBTB3jHXme2ziGjrWTEDprdnpM5Nh7vhMG6syhI0jcyc3INEIlerUrYzWPIJ9 u/EbdpgHHFEvz90viwSXr06/043fgzyxQBgeWn5VNyGoZubLn1ZslUtiu+b/86Iotgb75W6VL JXrmXpKRN3/k2BDLnPZL4FXSLnJfAcuH/k4xY1YP8/zA5+a6gtkPTEBdaONPouNhNUS+tOT2Z 70bSodKzwydM2lxji/l1DudvlNtX9u/XO/n7JsaCE4FPUf5v+91lGk6EgSZM9EeFS7kWIdPUo IoNsRXWkNgbQnYMNJRcGxbiKjHMggFiIUylej9Iz0SnHml/4oi536M/wHnvdiSlz97CsSwaEJ BsVLQ06fY1BwPZ9dC3N8cAdmtfw7Nu8c8DwCclEuRTiMxhYkJSV63fv8kOchGvII/N3ZSUBQn nxcpr2GeVTA9YMtMGh/AXtjYj8bFNyweb6kmeJMMb3kJoQ0p/yA9H5oAnGGHFMyvcm3vuihet WBf3x+HGCrWVvgavr2CTpVdYrBNrGmaGjDPonrpi+lhzBb0cp9YwHt5LeM8CPRjS7iHa2f6jy u7fJ91vTOUsq9U/Hy0Y8jvbcYQY6A/XfGwdZb9hH3x729GUqgQglKzyOH1utO42uyA5mXPLIb d1VwSPkuk/pYm9IkJtteXK5yadvCtpFVNN7LnGXtynhUPzzZe/M7SNI5VFBw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The meaning of "line height" in the C code (and related lisp functions) > seems to be "line, without line-spacing", for better or worse. Having > line height mean sth different in window.el will make the situation > worse, I guess :) > > Maybe we should go for an ugly, but different name like > "line-height-w-space" instead? This ship has sailed with the advent of 'default-line-height' in simple.el, more or less. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 14:21:19 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 18:21:19 +0000 Received: from localhost ([127.0.0.1]:41128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5j3-0007Jf-Us for submit@debbugs.gnu.org; Thu, 03 Oct 2019 14:21:18 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5j2-0007JP-Bk for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 14:21:17 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id DBA0D160061 for <37563@debbugs.gnu.org>; Thu, 3 Oct 2019 20:21:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570126868; bh=6FOC5PCHyAqu9nPfSDslnW4qTObfY3IjNeOY9R3fxdU=; h=From:To:Cc:Subject:Date:From; b=cBmsBGXqsHTFGRMVL2xVgSm6lekVgen65HDjRKGvP3p+Tz6QnL7VRa0GYCrYz5UOs ahnpYRWRcoR5II34Z2EaVdYwpB2ls3OrMB1nvsqU0FqeF4bwd1MH8beGL0G+87cVvU jb2md2YbBg+Q+ocwhXzsHqmW+AqwHgs2YNFsSoOzIvOoKHzcMuJ678jbelvgNUehRq j5v23DDafwHlIoO1Oy26sJRm9nZiDA2v6Gk30MG/6CsU2mupyjr17pPR/Z4791i+H2 65uAHsCMb3BChIouOYeBKrFQxRD48nu0JNEixn6rpXVG7dJ2Z3zgW/aTWeRLGsINMW aRrC+oHtzuyQg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46khCJ2Jm2z6tmN; Thu, 3 Oct 2019 20:21:00 +0200 (CEST) From: Ingo Lohmar To: martin rudalics Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing In-Reply-To: References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> Date: Thu, 03 Oct 2019 20:21:00 +0200 Message-ID: <87lfu1zo4z.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Thu, Oct 03 2019 20:10 (+0200), martin rudalics wrote: > > 4) *My interpretation* of `frame-resize-pixelwise' is that the default > > value, nil, has a single intention: To make the frame height an exact > > multiple of lines (and char width), mainly because of aesthetic reasons. > > In that case, I suggest we change the doc-string (which has some > > inaccurate phrasing and is a bit wordy, anyway) to say that it nil will > > round to a multiple of the default line height (incl line spacing).. > > We cannot reliably do that. Suppose a frame has two windows with > different line heights. Which one would we choose for rounding the > frame size? 'frame-char-height' is canonical. > > martin Okay, then I truly don't know how to write that succinctly. I suggest to keep using the char-height (and the `frame-resize-pixelwise' docstring) for the time being, that is, not change the code in the last part of the function. Personally, I will simple set `frame-resize-pixelwise' to t. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 14:22:50 2019 Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 18:22:50 +0000 Received: from localhost ([127.0.0.1]:41133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5kY-0007Lw-Gr for submit@debbugs.gnu.org; Thu, 03 Oct 2019 14:22:50 -0400 Received: from mout01.posteo.de ([185.67.36.65]:39383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5kV-0007Lf-1S for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 14:22:47 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 68C3016005E for <37563@debbugs.gnu.org>; Thu, 3 Oct 2019 20:22:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570126960; bh=W9heFyVj+/vQ+Y97J8JqmLbQcPpytuY/P/T/gcd0V/E=; h=From:To:Cc:Subject:Date:From; b=k+xyou1fcsKkbrWYHZJygFTFJAFOm2vVIjO+fre7TZQ5/DKtVWre8g0jMer+03TzH tcjq7mioxFy6O5t1m72irZAmp5If5RolAmqgZCnYivernIm6Vu5TytzMyd5fYKt7n1 gyg4TXZVixBYQZjS8k0ClxxL6tSjUcqlrFQLnOk/DV2YLEKPHpUSb4ZT/kO0ur0Y0l V2fn38fmsKE6aVr7C/p9rsSzgKBfGvlE8rNIrYMiOXm3n1CKafV3+xfSZOgj7kcBDN 4yr12dJ29E1/ngI5PJVSx8dCTG8Ku0SMD7S/ocNT/M6GJOL4uNbxWYKwXAns87ZWy+ JkC3oCxyvXtBg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46khFC5c9pz6tmH; Thu, 3 Oct 2019 20:22:39 +0200 (CEST) From: Ingo Lohmar To: martin rudalics Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing In-Reply-To: <9ce0917a-5e0e-385b-fd77-9b583dfc51c9@gmx.at> References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87wodmxl4z.fsf@kenko.localhost.com> <9ce0917a-5e0e-385b-fd77-9b583dfc51c9@gmx.at> Date: Thu, 03 Oct 2019 20:22:38 +0200 Message-ID: <87imp5zo29.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Thu, Oct 03 2019 20:10 (+0200), martin rudalics wrote: > > The meaning of "line height" in the C code (and related lisp functions) > > seems to be "line, without line-spacing", for better or worse. Having > > line height mean sth different in window.el will make the situation > > worse, I guess :) > > > > Maybe we should go for an ugly, but different name like > > "line-height-w-space" instead? > > This ship has sailed with the advent of 'default-line-height' in > simple.el, more or less. > > martin Understood. Just goes to show my ignorance of many of these details. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 04:41:19 2019 Received: (at 37563) by debbugs.gnu.org; 5 Oct 2019 08:41:19 +0000 Received: from localhost ([127.0.0.1]:43712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGfct-00055c-Db for submit@debbugs.gnu.org; Sat, 05 Oct 2019 04:41:19 -0400 Received: from mout.gmx.net ([212.227.15.15]:60219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGfcr-00055N-C7 for 37563@debbugs.gnu.org; Sat, 05 Oct 2019 04:41:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570264870; bh=JZRGSRQJZrUafeQN/tEWjThslgeiu20ZEFssERRyIqo=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Io+P7XjUoAE165rKZ0BcqJPlLkkOCYi+YQyofEjgC3X9ML/IqJ+bJixuYN8PZXgl4 u9nZtw3gHqqCgYwzIXszrlLx4PB/Yx5AlN2/M64JqoR3Xj0y/XujzVF/9MsUWDfFR0 BYXAZ4MeXUBofV11CkkE4dxIkGTI2Z8AL4xDOsOI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.156]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4hvR-1i9tMv16il-011kiK; Sat, 05 Oct 2019 10:41:10 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> <87lfu1zo4z.fsf@kenko.localhost.com> From: martin rudalics Message-ID: <6e9ca7b7-4dcd-6038-b4fb-a5ac7d52b049@gmx.at> Date: Sat, 5 Oct 2019 10:41:11 +0200 MIME-Version: 1.0 In-Reply-To: <87lfu1zo4z.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:0bXM/eWlVCe6XZaJzXyBGSl4l2yAADlTJubvu1qR6Ch+/24r0r5 r7z9FOPLb+5vVlyuhAebP/aIFh4M8Z1f9f3sXwCEEFewDLDVZc4ci99CxrIi6OpefIw76xP hsesoUB+Ndecg5+Ck34UvliRFoeYJ69JZRbPns+OXg4Qimt+wXMg9AReBXocJegXb05ED3N pHrGAHU/ZEo/6EuebXziA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Vtn/Mo93Rn8=:VMY5Hda/SuMG4FuWFDFzKD X1eJz/9XOm11ueTRVek1lt4jh9NQFpBfwJ558J+yxZIO4FgzCWrxNZ3DhddYlr9xafxEsSLzm MXqNsVvKOSh3ETwE8//vJPfazP7nCkf51gl4z+0aW4ztg4PdNgLQcNQoJO5RXpKiRHijthlez dGzItO8pJ1KU702net3/4sXsFdLIQNwtfG+azric5rhaPh8Y6Y0vHDjNuFwT81qSOEYt7yxcC XpSufj29EQck1BP4vXuhq9FMOtK0sP9l8yf8TjdS8BrdyfoaFBRvzdxlh9GWa9f5bGSMWoS/r M0PMgYV0baFxe+wRL2GIsZUO9PkI2kaLw+jm2gyreiraFrcDrcSe9Rr88AUHEpe+U88GbylgN y9pKsJIkWSUU4EDna4gX1MPLAk9/uRXLSvIAg2DJN1ugXu4RfuDHMcAG6CIWmM+Rc+07CL8IN LvVtvK39ZS9B+I/HrcppG9yM36yjAGcoPcrZamE+yItIg94+Xk88aBoVQAls6qvkkr6YwXP52 t+yjNSawqVzVzaGIlTom6aYiaolEM67wMk9KKgyKNZ6hJDZ3cRF+5QG7Kn9PnaI0FxPjyZA/m REXJi6APr+oDx9PNh0nrLMRX9UpiYv9q08S+0Ung9OpCkSUWQBYBl3I8Z/jDHxNYxUhL/LFGT 2vDiovLUkwmrmmv8R20dTa651cHICxxj1J9jMRx6oSEBD3V8PbwALxUL/+9tFAIbFXXAtLKia DfqjU9kyAlmaj0r4Y057SCbSuPJyfFHk2OmtgwZuYjDqTmznAaQzWEQ9/V0g7t/7Mvz9Cg9zy z+aH+ArxInUf4PadzrNE0u9TwStCbyT38z3ncSDqjfKoFYImcc7QAgvP1SQTUC16RU7eMarQQ tmfhoNLD0d/FS3yojhaTpFpzVtTdFyAq4HCqLLJ+NTyCaPF6dwpJZV1iomCYbyKLfgcwVvU9r ptFTcC2wAqjGXWe9126k5hZhi4yabEuS7HyylnGu+v222zhd7rJP0T/A/I/jsZqoqt87ahP1K bsONqyP7Rc9Ub+gevJYLWa4mMgiToC5pv0niU2AENZ/feG599wEKFXcntqH6ZmjPxTsSXTNlx 4owfN2UItmytMPsfdZr3KCM9C6q2Wr2TzD67lV1xlCOQKAHhApcYfs2E++Ecvzez5OubYHcXO K+79ArdY+h0VQMJejzldKxdCBDKn+HOSzPBUsqJ5ExaHN1dh8Y4yUVCkP31LHPCNQ26oYfeLI aHjt/ssenfu+HN5kyGfMD5avJdCUw0VvW6MkANVwGf2p5frg87msoXBAb5xc= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Okay, then I truly don't know how to write that succinctly. I suggest > to keep using the char-height (and the `frame-resize-pixelwise' > docstring) for the time being, that is, not change the code in the last > part of the function. If I don't use 'frame-char-height' here, any subsequent resize requests for that frame (including resizing the frame by dragging its boder with the mouse) might use the line height value. In general, this is certainly not TRT, for example, when another buffer gets displayed in that frame's window. That's also why I'm still reluctant to use the line height concept more pervasively. The particular problem could be resolved by adding a 'resize-pixelwise' frame parameter whose value, when set, would override that of 'frame-resize-pixelwise'. Provided your frame is in some sense private to 'company-posframe'. > Personally, I will simple set `frame-resize-pixelwise' to t. I don't think, however, that this problem is grave enough to warrant a general recommendation. Adding all sorts of window and frame decorations to the value returned by 'window-text-pixel-size' will often add some slack whitespace when 'frame-resize-pixelwise' is nil, regardless of whether we round by character or line height. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 05:06:28 2019 Received: (at 37563) by debbugs.gnu.org; 5 Oct 2019 09:06:29 +0000 Received: from localhost ([127.0.0.1]:43747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGg1E-0006M4-MP for submit@debbugs.gnu.org; Sat, 05 Oct 2019 05:06:28 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGg1B-0006Le-8o for 37563@debbugs.gnu.org; Sat, 05 Oct 2019 05:06:26 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C56BF2400FB for <37563@debbugs.gnu.org>; Sat, 5 Oct 2019 11:06:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570266378; bh=ODevXubkTVcKuTh7M2qAZHoxsaqAuuwspJ7gK4Dlw0c=; h=From:To:Cc:Subject:Date:From; b=HamEJfLpFUcmNn89CUPZ5Dr5ag5NFBHUoGLGu/waU+Vd2d/inujzQo8ewEMliz+hj PYwMTo/IxhF0PKovgBt4XK4m5KE03m6q7K7jDh87d+ks2JzQqiHIRx4WVmoK78eeRF Q0INOxC/BPS7xFpJNdrSi+5On9bkeBWnhzzvqgRTviP/cfg0Vgdm/PqrQxDe35dsT/ YVLZ7RcjRXIfAyq7c2KyL4Z1LOtBWAQEjH9HA8K+vud5KQpmcWvG8TQ9eTzT03AQkd yx0SOoi2vULJPT7/lo++fgdSTd+iO5mUWUPhjgIAsOICvzvpBjavNjZqjz+jOeaISP hpqJm9dyfndzg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46lgnB2qCjz9rxp; Sat, 5 Oct 2019 11:05:18 +0200 (CEST) From: Ingo Lohmar To: martin rudalics Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing In-Reply-To: <6e9ca7b7-4dcd-6038-b4fb-a5ac7d52b049@gmx.at> References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> <87lfu1zo4z.fsf@kenko.localhost.com> <6e9ca7b7-4dcd-6038-b4fb-a5ac7d52b049@gmx.at> Date: Sat, 05 Oct 2019 11:05:18 +0200 Message-ID: <87a7af7eb5.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Sat, Oct 05 2019 10:41 (+0200), martin rudalics wrote: > > Okay, then I truly don't know how to write that succinctly. I suggest > > to keep using the char-height (and the `frame-resize-pixelwise' > > docstring) for the time being, that is, not change the code in the last > > part of the function. > > If I don't use 'frame-char-height' here, any subsequent resize > requests for that frame (including resizing the frame by dragging its > boder with the mouse) might use the line height value. In general, > this is certainly not TRT, for example, when another buffer gets > displayed in that frame's window. That's also why I'm still reluctant > to use the line height concept more pervasively. Just to be clear: I do not see any problem with keeping using `char-height' (the result of `frame-char-height') here; I only thought that it is unfortunate that we cannot remove at least some tiny bit of complexity. > The particular problem could be resolved by adding a > 'resize-pixelwise' frame parameter whose value, when set, would > override that of 'frame-resize-pixelwise'. Provided your frame is > in some sense private to 'company-posframe'. > > > Personally, I will simple set `frame-resize-pixelwise' to t. > > I don't think, however, that this problem is grave enough to warrant a > general recommendation. Adding all sorts of window and frame > decorations to the value returned by 'window-text-pixel-size' will > often add some slack whitespace when 'frame-resize-pixelwise' is nil, > regardless of whether we round by character or line height. I think I understand better now, I was hampered by some weird debugging artifacts in my current setup. With the default `frame-resize-pixelwise' of nil, and the otherwise bug-fixed code, nothing is cut off, but there is some slack whitespace, indeed. The frame parameter solution could address that, but adds even more complexity.. >From your explanation I think we should just live with it for the time being. No need for a general recommendation also, it was just a "TIL". From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 05:26:05 2019 Received: (at 37563) by debbugs.gnu.org; 7 Oct 2019 09:26:06 +0000 Received: from localhost ([127.0.0.1]:47370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHPHJ-00013I-Ab for submit@debbugs.gnu.org; Mon, 07 Oct 2019 05:26:05 -0400 Received: from mout.gmx.net ([212.227.15.15]:41475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHPHG-00012m-Av for 37563@debbugs.gnu.org; Mon, 07 Oct 2019 05:26:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570440353; bh=QDUY7eOIOcx3Ph+E2ZUS8XJqa+z/R9bc6zHNVPZql4g=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=aKgxpC8lR2kMIpIKQcQZbtYzOwLRuRD8wD5yyk+C3QeMRT06sruU/cMW4UK22My6e axvlkgBjKLGuLAFf1TXlydPBg/+SGW9Z3gs+fqUbDzZyAFmtmvfb/GYEGGuFuhNlbD RwQThrudOaoDe25YWloiIEpWxSSQh1FJjfw2KGZU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.237]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MVN6j-1iiBM60Y3b-00SMdV; Mon, 07 Oct 2019 11:25:53 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> <87lfu1zo4z.fsf@kenko.localhost.com> <6e9ca7b7-4dcd-6038-b4fb-a5ac7d52b049@gmx.at> <87a7af7eb5.fsf@kenko.localhost.com> From: martin rudalics Message-ID: Date: Mon, 7 Oct 2019 11:25:52 +0200 MIME-Version: 1.0 In-Reply-To: <87a7af7eb5.fsf@kenko.localhost.com> Content-Type: multipart/mixed; boundary="------------A073090F109E8ACB3A75D8C9" Content-Language: de-AT X-Provags-ID: V03:K1:gMjavtH4FWzfrk3hDL9iTypxVBfLTSZcxX7E08aWH1EPSccV+3e YvDF4CGElOQv718GjQuaVrDB2jt0FVVvzC4Y6n827RnlsZFtQxG4dK+1NnbpgtoiZe6OVt+ pH2BkkqFk6UDRbXFZj3DadA7epgsUYOjZvNjHvz8m9lXTkhAC4zazrMM7/8+TL3lIiXJ9Sd q0+V1IYhQXrTdSDvcQImg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:h0kc8xGwrvY=:rrkV6VfUzOSw4vaiC2/Knd JTKp8k5WS2FWfk0eUhLSjOsSKSxGR9mra1b7MdFp+70SqFgar8v2ASsxNSdJSYaOaSdgfVw5F E8I8q1X0yFMQ6g+TPR3m1mxppfp3nOK3Zd6JKEFsbqi2eDwdOQ7hJ5n2boQZcdeHhZ+c6Etko nv57F6dJWqrtcj0nWN687wHGXaFScc8Fy4FOiWQfoA6P8/81dUW01jnHSPo4E8V36zLsjD3Jg vv2PRVnobt8hQVTq7rOpH5jf8tEa/bswkfXMKv4KhYqEGPUiC36w44VO3xq/DgjrSoA3PfwX9 iTpRnS04R+hCc0+kWQqgPnjJ/cNlwHQbeJ7n707OCLmjKLxEsTrviexY0dE6M0pI41moNTKXV IYxC5P4uXMeT+E4RIHEgB0UhvaQqsNSWXaCRbEUOTkHu50hFKUB4RDdCzRskLiTTN0SavSv8Z DmqJXyrTzDDUZzaU7/hXnU30KcXoU0i8rpuBxYLoThcCGjjnZPUmsDN7VSXnZNrDgRrbVNbeJ D9kI9wO2od9mt23CJ1MB5ub1YwwUtUw7FYpoP4+TjfkTTf2iXV8D8FPNQcdWLYhQpX75L+0Bv yd6oNduDgb5WQZwr1x3EntQ42zfbGJM+dYZIIChrLzUcjZj2G95myfXnaeUOyHmVHk4AAqTyF vWMaA2ArDARCSVqwfTg4tYl2+NgjxYDSIn+vexDrvNCcSOi9YhOoqs99V6szixE2NNpEzQ+zF ZsQN4+s7AUWCZdUguvlBgQlOPODnaCOa3aIY28kqVbyJD/k+Kh7XfIV7APfWjMR7sLWAHGVPB 6XX2Ri3JFC0CQNJaddnodm+zgpk22/RgH/BKqElx+CWxJJllP8RQlcw3pmWaWbWDITmoBDc4/ XuSTqnxzRIcxErmtOwDutrgklovk5HqKxlKWBhKbzNEwcKb+Rnq4HqB3KeHSntBGjan5D3amU kVy0MKwUASjE0h3AdTKWGuHVWt3/KclWD/i0kPtPasvMv7zyzF8bSDJY616CkKJ1psvmDlfTG 31pM3OWAoqIdg+ZCmWTmBEXh3VqL8TO7rC/9mXUP5sCyyT9v6oyaq/kjfa7hMCWj2eISfCGyA ZNSqC8urB93IkgD9DeSM935UA8872W6/OMVLt4h43lSnB4MOA8/x5plV3tOEOONEbWCsZwduq 9Un4uQvhYlS0w39++Qmisja0qjjfU9BzjtXMlNMO7H1SM2oxmJIGnS/ZW21rZ7hVimZL8mvkD dbP3HGup6TTgSfazas9AVe9HoRcS3eg2k3+/r+njkbi4Gtn8mW6WKLLMNHqA= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------A073090F109E8ACB3A75D8C9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I now came up with a fix for 'fit-window-to-buffer' too which had some strange misbehavior with different size restricting arguments when the window's text size did not change. See attached diffs and Change Log below. > I think I understand better now, I was hampered by some weird debugging > artifacts in my current setup. With the default > `frame-resize-pixelwise' of nil, and the otherwise bug-fixed code, > nothing is cut off, but there is some slack whitespace, indeed. I suppose that part of that whitespace comes from the fact that with 'line-spacing' greater zero, 'window-text-pixel-size' includes the space below the last line of its text. It would be nice to get rid of that but ISTR that a line's text may now get centered within the space reserved for it. So I cannot just remove the entire line space of one line from the return value but probably only half of the line spacing value. How would I know the right value? martin Fixes for fitting windows and frames to their buffers (Bug#37563) * lisp/window.el (window-default-font-height) (window-default-line-height): New functions. (fit-frame-to-buffer): Interpret values of MAX-HEIGHT and MIN-HEIGHT arguments in terms of WINDOW's default line height (Bug#37563). (fit-window-to-buffer): Obey size restricting arguments even when size of WINDOW's text does not change. Do not temporarily select WINDOW and perform height/width related calculations if and only if WINDOW is accordingly combined. Interpret values of MAX-HEIGHT and MIN-HEIGHT arguments in terms of WINDOW's default line height. --------------A073090F109E8ACB3A75D8C9 Content-Type: text/plain; charset=UTF-8; name="fit-to-buffer.diffs" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fit-to-buffer.diffs" ZGlmZiAtLWdpdCBhL2xpc3Avd2luZG93LmVsIGIvbGlzcC93aW5kb3cuZWwKaW5kZXggZDkz ZWMwYWRkNi4uZmFmYjZmOTBlZCAxMDA2NDQKLS0tIGEvbGlzcC93aW5kb3cuZWwKKysrIGIv bGlzcC93aW5kb3cuZWwKQEAgLTg1MDEsNiArODUwMSw0MSBAQCB3aW5kb3ctYnVmZmVyLWhl aWdodAogCQkJICAgICAoZW9icCkKIAkJCSAgICAgd2luZG93KSkpKQogCisoZGVmdW4gd2lu ZG93LWRlZmF1bHQtZm9udC1oZWlnaHQgKCZvcHRpb25hbCB3aW5kb3cpCisgICJSZXR1cm4g aGVpZ2h0IGluIHBpeGVscyBvZiBXSU5ET1cncyBkZWZhdWx0IGZhY2UgZm9udC4KK1dJTkRP VyBtdXN0IGJlIGEgbGl2ZSB3aW5kb3cgYW5kIGRlZmF1bHRzIHRvIHRoZSBzZWxlY3RlZCBv bmUuCisKK1RoZSByZXR1cm4gdmFsdWUgYWNjb3VudHMgZm9yIGFueSByZW1hcHBpbmcgb2Yg dGhlIGRlZmF1bHQgZmFjZQorZm9udCBvbiBXSU5ET1cncyBmcmFtZS4iCisgIChsZXQqICgo d2luZG93ICh3aW5kb3ctbm9ybWFsaXplLXdpbmRvdyB3aW5kb3cgdCkpCisJIChmcmFtZSAo d2luZG93LWZyYW1lIHdpbmRvdykpCisJIChkZWZhdWx0LWZvbnQgKGZhY2UtZm9udCAnZGVm YXVsdCBmcmFtZSkpKQorICAgIChpZiAoYW5kIChkaXNwbGF5LW11bHRpLWZvbnQtcCAoZnJh bWUtcGFyYW1ldGVyIGZyYW1lICdkaXNwbGF5KSkKKwkgICAgIChub3QgKHN0cmluZy1lcXVh bCAoZnJhbWUtcGFyYW1ldGVyIGZyYW1lICdmb250KSBkZWZhdWx0LWZvbnQpKSkKKyAgICAg ICAgKGFyZWYgKGZvbnQtaW5mbyBkZWZhdWx0LWZvbnQgZnJhbWUpIDMpCisgICAgICAoZnJh bWUtY2hhci1oZWlnaHQgZnJhbWUpKSkpCisKKyhkZWZ1biB3aW5kb3ctZGVmYXVsdC1saW5l LWhlaWdodCAoJm9wdGlvbmFsIHdpbmRvdykKKyAgIlJldHVybiBoZWlnaHQgaW4gcGl4ZWxz IG9mIGEgdGV4dCBsaW5lIGluIFdJTkRPVy4KK1dJTkRPVyBtdXN0IGJlIGEgbGl2ZSB3aW5k b3cgYW5kIGRlZmF1bHRzIHRvIHRoZSBzZWxlY3RlZCBvbmUuCisKK1RoZSByZXR1cm4gdmFs dWUgaW5jbHVkZXMgYW55IGxpbmUgc3BhY2luZyBkZWZpbmVkIGZvciBXSU5ET1cncworYnVm ZmVyIG9yIGZyYW1lIGFuZCBhY2NvdW50cyBmb3IgYW55IHJlbWFwcGluZyBvZiB0aGUgZGVm YXVsdAorZmFjZSBvbiBXSU5ET1cncyBmcmFtZS4iCisgIChsZXQqICgod2luZG93ICh3aW5k b3ctbm9ybWFsaXplLXdpbmRvdyB3aW5kb3cgdCkpCisJIChmb250LWhlaWdodCAod2luZG93 LWRlZmF1bHQtZm9udC1oZWlnaHQgd2luZG93KSkKKwkgKGZyYW1lICh3aW5kb3ctZnJhbWUg d2luZG93KSkKKwkgKGJ1ZmZlciAod2luZG93LWJ1ZmZlciB3aW5kb3cpKQorCSAoc3BhY2Ut aGVpZ2h0CisJICAob3IgKGFuZCAoZGlzcGxheS1ncmFwaGljLXAgZnJhbWUpCisJCSAgIChv ciAoYnVmZmVyLWxvY2FsLXZhbHVlICdsaW5lLXNwYWNpbmcgYnVmZmVyKQorCQkgICAgICAg KGZyYW1lLXBhcmFtZXRlciBmcmFtZSAnbGluZS1zcGFjaW5nKSkpCisJICAgICAgMCkpKQor ICAgICgrIGZvbnQtaGVpZ2h0CisgICAgICAgKGlmIChmbG9hdHAgc3BhY2UtaGVpZ2h0KQor ICAgICAgICAgICAodHJ1bmNhdGUgKCogKGZyYW1lLWNoYXItaGVpZ2h0IGZyYW1lKSBzcGFj ZS1oZWlnaHQpKQorICAgICAgICAgc3BhY2UtaGVpZ2h0KSkpKQorCiA7OzsgUmVzaXppbmcg d2luZG93cyBhbmQgZnJhbWVzIHRvIGZpdCB0aGVpciBjb250ZW50cyBleGFjdGx5LgogKGRl ZmN1c3RvbSBmaXQtd2luZG93LXRvLWJ1ZmZlci1ob3Jpem9udGFsbHkgbmlsCiAgICJOb24t bmlsIG1lYW5zIGBmaXQtd2luZG93LXRvLWJ1ZmZlcicgY2FuIHJlc2l6ZSB3aW5kb3dzIGhv cml6b250YWxseS4KQEAgLTg2NDMsNiArODY3OCw3IEBAIGZpdC1mcmFtZS10by1idWZmZXIK ICAgICAgICAgICAgKGNoYXItaGVpZ2h0IChmcmFtZS1jaGFyLWhlaWdodCBmcmFtZSkpCiAg ICAgICAgICAgIDs7IFdJTkRPVyBpcyBGUkFNRSdzIHJvb3Qgd2luZG93LgogICAgICAgICAg ICAod2luZG93IChmcmFtZS1yb290LXdpbmRvdyBmcmFtZSkpCisgICAgICAgICAgIChsaW5l LWhlaWdodCAod2luZG93LWRlZmF1bHQtbGluZS1oZWlnaHQgd2luZG93KSkKICAgICAgICAg ICAgKHBhcmVudCAoZnJhbWUtcGFyZW50IGZyYW1lKSkKICAgICAgICAgICAgKG1vbml0b3It YXR0cmlidXRlcwogICAgICAgICAgICAgKHVubGVzcyBwYXJlbnQKQEAgLTg3MzksMTYgKzg3 NzUsMTYgQEAgZml0LWZyYW1lLXRvLWJ1ZmZlcgogICAgICAgICAgICAobWF4LWhlaWdodAog ICAgICAgICAgICAgKG1pbgogICAgICAgICAgICAgIChjb25kCi0gICAgICAgICAgICAgICgo bnVtYmVycCBtYXgtaGVpZ2h0KSAoKiBtYXgtaGVpZ2h0IGNoYXItaGVpZ2h0KSkKLSAgICAg ICAgICAgICAgKChudW1iZXJwIChudGggMCBzaXplcykpICgqIChudGggMCBzaXplcykgY2hh ci1oZWlnaHQpKQorICAgICAgICAgICAgICAoKG51bWJlcnAgbWF4LWhlaWdodCkgKCogbWF4 LWhlaWdodCBsaW5lLWhlaWdodCkpCisgICAgICAgICAgICAgICgobnVtYmVycCAobnRoIDAg c2l6ZXMpKSAoKiAobnRoIDAgc2l6ZXMpIGxpbmUtaGVpZ2h0KSkKICAgICAgICAgICAgICAg KHQgcGFyZW50LW9yLWRpc3BsYXktaGVpZ2h0KSkKICAgICAgICAgICAgICA7OyBUaGUgZm9s bG93aW5nIGlzIHRoZSBtYXhpbXVtIGhlaWdodCB0aGF0IGZpdHMgaW50byB0aGUKICAgICAg ICAgICAgICA7OyB0b3AgYW5kIGJvdHRvbSBtYXJnaW5zLgogICAgICAgICAgICAgIChtYXgg KC0gYm90dG9tLW1hcmdpbiB0b3AtbWFyZ2luIG91dGVyLW1pbnVzLWJvZHktaGVpZ2h0KSkp KQogICAgICAgICAgICAobWluLWhlaWdodAogICAgICAgICAgICAgKGNvbmQKLSAgICAgICAg ICAgICAoKG51bWJlcnAgbWluLWhlaWdodCkgKCogbWluLWhlaWdodCBjaGFyLWhlaWdodCkp Ci0gICAgICAgICAgICAgKChudW1iZXJwIChudGggMSBzaXplcykpICgqIChudGggMSBzaXpl cykgY2hhci1oZWlnaHQpKQorICAgICAgICAgICAgICgobnVtYmVycCBtaW4taGVpZ2h0KSAo KiBtaW4taGVpZ2h0IGxpbmUtaGVpZ2h0KSkKKyAgICAgICAgICAgICAoKG51bWJlcnAgKG50 aCAxIHNpemVzKSkgKCogKG50aCAxIHNpemVzKSBsaW5lLWhlaWdodCkpCiAgICAgICAgICAg ICAgKHQgKHdpbmRvdy1taW4tc2l6ZSB3aW5kb3cgbmlsIG5pbCB0KSkpKQogICAgICAgICAg ICAobWF4LXdpZHRoCiAgICAgICAgICAgICAobWluCkBAIC04ODcxLDEyNCArODkwNywxMTgg QEAgZml0LXdpbmRvdy10by1idWZmZXIKIAkgbWF4LWhlaWdodCBtaW4taGVpZ2h0IG1heC13 aWR0aCBtaW4td2lkdGgKIAkgKGFuZCAobWVtcSBmaXQtZnJhbWUtdG8tYnVmZmVyICcodmVy dGljYWxseSBob3Jpem9udGFsbHkpKQogCSAgICAgIGZpdC1mcmFtZS10by1idWZmZXIpKSkK LSAgICAod2l0aC1zZWxlY3RlZC13aW5kb3cgd2luZG93Ci0gICAgICAobGV0KiAoKHBpeGVs d2lzZSB3aW5kb3ctcmVzaXplLXBpeGVsd2lzZSkKLQkgICAgIChjaGFyLWhlaWdodCAoZnJh bWUtY2hhci1oZWlnaHQpKQotCSAgICAgKGNoYXItd2lkdGggKGZyYW1lLWNoYXItd2lkdGgp KQotCSAgICAgKHRvdGFsLWhlaWdodCAod2luZG93LXNpemUgd2luZG93IG5pbCBwaXhlbHdp c2UpKQotCSAgICAgKGJvZHktaGVpZ2h0ICh3aW5kb3ctYm9keS1oZWlnaHQgd2luZG93IHBp eGVsd2lzZSkpCi0JICAgICAoYm9keS13aWR0aCAod2luZG93LWJvZHktd2lkdGggd2luZG93 IHBpeGVsd2lzZSkpCi0JICAgICAobWluLWhlaWdodAotCSAgICAgIDs7IFNhbml0aXplIE1J Ti1IRUlHSFQuCi0JICAgICAgKGlmIChudW1iZXJwIG1pbi1oZWlnaHQpCi0JCSAgOzsgQ2Fu J3QgZ2V0IHNtYWxsZXIgdGhhbiBgd2luZG93LXNhZmUtbWluLWhlaWdodCcuCi0JCSAgKG1h eCAoaWYgcGl4ZWx3aXNlCi0JCQkgICAoKiBjaGFyLWhlaWdodCBtaW4taGVpZ2h0KQotCQkJ IG1pbi1oZWlnaHQpCi0JCSAgICAgICAoaWYgcGl4ZWx3aXNlCi0JCQkgICAod2luZG93LXNh ZmUtbWluLXBpeGVsLWhlaWdodCB3aW5kb3cpCi0JCQkgd2luZG93LXNhZmUtbWluLWhlaWdo dCkpCi0JCTs7IFByZXNlcnZlIGhlYWRlciBhbmQgbW9kZSBsaW5lIGlmIHByZXNlbnQuCi0J CShtYXggKGlmIHBpeGVsd2lzZQotCQkJICgqIGNoYXItaGVpZ2h0IHdpbmRvdy1taW4taGVp Z2h0KQotCQkgICAgICAgd2luZG93LW1pbi1oZWlnaHQpCi0JCSAgICAgKHdpbmRvdy1taW4t c2l6ZSB3aW5kb3cgbmlsIHdpbmRvdyBwaXhlbHdpc2UpKSkpCi0JICAgICAobWF4LWhlaWdo dAotCSAgICAgIDs7IFNhbml0aXplIE1BWC1IRUlHSFQuCi0JICAgICAgKGlmIChudW1iZXJw IG1heC1oZWlnaHQpCi0JCSAgKG1pbgotCQkgICAoKyB0b3RhbC1oZWlnaHQKLQkJICAgICAg KHdpbmRvdy1tYXgtZGVsdGEKLQkJICAgICAgIHdpbmRvdyBuaWwgd2luZG93IG5pbCB0IG5p bCBwaXhlbHdpc2UpKQotCQkgICAoaWYgcGl4ZWx3aXNlCi0JCSAgICAgICAoKiBjaGFyLWhl aWdodCBtYXgtaGVpZ2h0KQotCQkgICAgIG1heC1oZWlnaHQpKQotCQkoKyB0b3RhbC1oZWln aHQgKHdpbmRvdy1tYXgtZGVsdGEKLQkJCQkgd2luZG93IG5pbCB3aW5kb3cgbmlsIHQgbmls IHBpeGVsd2lzZSkpKSkKLQkgICAgIGhlaWdodCkKLQkoY29uZAotCSA7OyBJZiBXSU5ET1cg aXMgdmVydGljYWxseSBjb21iaW5lZCwgdHJ5IHRvIHJlc2l6ZSBpdAotCSA7OyB2ZXJ0aWNh bGx5LgotCSAoKGFuZCAobm90IChlcSBmaXQtd2luZG93LXRvLWJ1ZmZlci1ob3Jpem9udGFs bHkgJ29ubHkpKQotCSAgICAgICAobm90ICh3aW5kb3ctc2l6ZS1maXhlZC1wIHdpbmRvdyAn cHJlc2VydmVkKSkKLQkgICAgICAgKHdpbmRvdy1jb21iaW5lZC1wKSkKKyAgICAobGV0KiAo KHBpeGVsd2lzZSB3aW5kb3ctcmVzaXplLXBpeGVsd2lzZSkKKyAgICAgICAgICAgKGZyYW1l ICh3aW5kb3ctZnJhbWUgd2luZG93KSkKKyAgICAgICAgICAgKGNoYXItaGVpZ2h0IChmcmFt ZS1jaGFyLWhlaWdodCBmcmFtZSkpKQorICAgICAgKGNvbmQKKyAgICAgICA7OyBJZiBXSU5E T1cgaXMgdmVydGljYWxseSBjb21iaW5lZCwgdHJ5IHRvIHJlc2l6ZSBpdAorICAgICAgIDs7 IHZlcnRpY2FsbHkuCisgICAgICAgKChhbmQgKG5vdCAoZXEgZml0LXdpbmRvdy10by1idWZm ZXItaG9yaXpvbnRhbGx5ICdvbmx5KSkKKwkgICAgIChub3QgKHdpbmRvdy1zaXplLWZpeGVk LXAgd2luZG93ICdwcmVzZXJ2ZWQpKQorCSAgICAgKHdpbmRvdy1jb21iaW5lZC1wKSkKKyAg ICAgICAgKGxldCogKChsaW5lLWhlaWdodCAod2luZG93LWRlZmF1bHQtbGluZS1oZWlnaHQg d2luZG93KSkKKwkgICAgICAgKHRvdGFsLWhlaWdodCAod2luZG93LXNpemUgd2luZG93IG5p bCBwaXhlbHdpc2UpKQorICAgICAgICAgICAgICAgKG1pbi1oZWlnaHQKKwkgICAgICAgIDs7 IFNhbml0aXplIE1JTi1IRUlHSFQuCisJICAgICAgICAoaWYgKG51bWJlcnAgbWluLWhlaWdo dCkKKwkgICAgICAgICAgICA7OyBDYW4ndCBnZXQgc21hbGxlciB0aGFuIGB3aW5kb3ctc2Fm ZS1taW4taGVpZ2h0Jy4KKwkgICAgICAgICAgICAobWF4IChpZiBwaXhlbHdpc2UKKwkJCSAg ICAgKCogbGluZS1oZWlnaHQgbWluLWhlaWdodCkKKwkJICAgICAgICAgICBtaW4taGVpZ2h0 KQorCQkgICAgICAgICAoaWYgcGl4ZWx3aXNlCisJCQkgICAgICh3aW5kb3ctc2FmZS1taW4t cGl4ZWwtaGVpZ2h0IHdpbmRvdykKKwkJICAgICAgICAgICB3aW5kb3ctc2FmZS1taW4taGVp Z2h0KSkKKwkgICAgICAgICAgOzsgUHJlc2VydmUgaGVhZGVyIGFuZCBtb2RlIGxpbmUgaWYg cHJlc2VudC4KKwkgICAgICAgICAgKG1heCAoaWYgcGl4ZWx3aXNlCisJCSAgICAgICAgICAg KCogbGluZS1oZWlnaHQgd2luZG93LW1pbi1oZWlnaHQpCisJCSAgICAgICAgIHdpbmRvdy1t aW4taGVpZ2h0KQorCQkgICAgICAgKHdpbmRvdy1taW4tc2l6ZSB3aW5kb3cgbmlsIHdpbmRv dyBwaXhlbHdpc2UpKSkpCisJICAgICAgIChtYXgtaGVpZ2h0CisJICAgICAgICA7OyBTYW5p dGl6ZSBNQVgtSEVJR0hULgorCSAgICAgICAgKGlmIChudW1iZXJwIG1heC1oZWlnaHQpCisJ ICAgICAgICAgICAgKG1pbgorCQkgICAgICgrIHRvdGFsLWhlaWdodAorCQkgICAgICAgICh3 aW5kb3ctbWF4LWRlbHRhCisJCSAgICAgICAgIHdpbmRvdyBuaWwgd2luZG93IG5pbCB0IG5p bCBwaXhlbHdpc2UpKQorCQkgICAgIChpZiBwaXhlbHdpc2UKKwkJICAgICAgICAgKCogbGlu ZS1oZWlnaHQgbWF4LWhlaWdodCkKKwkJICAgICAgICgvICgqIGxpbmUtaGVpZ2h0IG1heC1o ZWlnaHQpIGxpbmUtaGVpZ2h0KSkpCisJICAgICAgICAgICgrIHRvdGFsLWhlaWdodCAod2lu ZG93LW1heC1kZWx0YQorCQkJICAgICAgICAgICB3aW5kb3cgbmlsIHdpbmRvdyBuaWwgdCBu aWwgcGl4ZWx3aXNlKSkpKQorCSAgICAgICAoaGVpZ2h0ICgrIChjZHIgKHdpbmRvdy10ZXh0 LXBpeGVsLXNpemUKKwkJCSAgICAgICAgd2luZG93IG5pbCB0IG5pbCAoZnJhbWUtcGl4ZWwt aGVpZ2h0IGZyYW1lKSB0KSkKKwkJICAgICAgICAgICh3aW5kb3ctc2Nyb2xsLWJhci1oZWln aHQgd2luZG93KQorCQkgICAgICAgICAgKHdpbmRvdy1ib3R0b20tZGl2aWRlci13aWR0aCB3 aW5kb3cpKSkpCiAJICA7OyBWZXJ0aWNhbGx5IHdlIGFsd2F5cyB3YW50IHRvIGZpdCB0aGUg ZW50aXJlIGJ1ZmZlci4KIAkgIDs7IFdJTkRPVydTIGhlaWdodCBjYW4ndCBnZXQgbGFyZ2Vy IHRoYW4gaXRzIGZyYW1lJ3MgcGl4ZWwKIAkgIDs7IGhlaWdodC4gIEl0cyB3aWR0aCByZW1h aW5zIGZpeGVkLgotCSAgKHNldHEgaGVpZ2h0ICgrIChjZHIgKHdpbmRvdy10ZXh0LXBpeGVs LXNpemUKLQkJCQluaWwgbmlsIHQgbmlsIChmcmFtZS1waXhlbC1oZWlnaHQpIHQpKQotCQkJ ICAod2luZG93LXNjcm9sbC1iYXItaGVpZ2h0IHdpbmRvdykKLQkJCSAgKHdpbmRvdy1ib3R0 b20tZGl2aWRlci13aWR0aCkpKQogCSAgOzsgUm91bmQgaGVpZ2h0LgogCSAgKHVubGVzcyBw aXhlbHdpc2UKIAkgICAgKHNldHEgaGVpZ2h0ICgvICgrIGhlaWdodCBjaGFyLWhlaWdodCAt MSkgY2hhci1oZWlnaHQpKSkKKyAgICAgICAgICAoc2V0cSBoZWlnaHQgKG1heCBtaW4taGVp Z2h0IChtaW4gbWF4LWhlaWdodCBoZWlnaHQpKSkKIAkgICh1bmxlc3MgKD0gaGVpZ2h0IHRv dGFsLWhlaWdodCkKIAkgICAgKHdpbmRvdy1wcmVzZXJ2ZS1zaXplIHdpbmRvdykKIAkgICAg KHdpbmRvdy1yZXNpemUtbm8tZXJyb3IKLQkgICAgIHdpbmRvdwotCSAgICAgKC0gKG1heCBt aW4taGVpZ2h0IChtaW4gbWF4LWhlaWdodCBoZWlnaHQpKSB0b3RhbC1oZWlnaHQpCi0JICAg ICBuaWwgd2luZG93IHBpeGVsd2lzZSkKKwkgICAgIHdpbmRvdyAoLSBoZWlnaHQgdG90YWwt aGVpZ2h0KSBuaWwgd2luZG93IHBpeGVsd2lzZSkKIAkgICAgKHdoZW4gcHJlc2VydmUtc2l6 ZQotCSAgICAgICh3aW5kb3ctcHJlc2VydmUtc2l6ZSB3aW5kb3cgbmlsIHQpKSkpCi0JIDs7 IElmIFdJTkRPVyBpcyBob3Jpem9udGFsbHkgY29tYmluZWQsIHRyeSB0byByZXNpemUgaXQK LQkgOzsgaG9yaXpvbnRhbGx5LgotCSAoKGFuZCBmaXQtd2luZG93LXRvLWJ1ZmZlci1ob3Jp em9udGFsbHkKLQkgICAgICAgKG5vdCAod2luZG93LXNpemUtZml4ZWQtcCB3aW5kb3cgdCAn cHJlc2VydmVkKSkKLQkgICAgICAgKHdpbmRvdy1jb21iaW5lZC1wIG5pbCB0KSkKLQkgIChs ZXQqICgodG90YWwtd2lkdGggKHdpbmRvdy1zaXplIHdpbmRvdyB0IHBpeGVsd2lzZSkpCi0J CSAobWluLXdpZHRoCi0JCSAgOzsgU2FuaXRpemUgTUlOLVdJRFRILgotCQkgIChpZiAobnVt YmVycCBtaW4td2lkdGgpCi0JCSAgICAgIDs7IENhbid0IGdldCBzbWFsbGVyIHRoYW4gYHdp bmRvdy1zYWZlLW1pbi13aWR0aCcuCi0JCSAgICAgIChtYXggKGlmIHBpeGVsd2lzZQotCQkJ ICAgICAgICgqIGNoYXItd2lkdGggbWluLXdpZHRoKQotCQkJICAgICBtaW4td2lkdGgpCi0J CQkgICAoaWYgcGl4ZWx3aXNlCi0JCQkgICAgICAgKHdpbmRvdy1zYWZlLW1pbi1waXhlbC13 aWR0aCkKLQkJCSAgICAgd2luZG93LXNhZmUtbWluLXdpZHRoKSkKLQkJICAgIDs7IFByZXNl cnZlIGZyaW5nZXMsIG1hcmdpbnMsIHNjcm9sbGJhcnMgaWYgcHJlc2VudC4KKwkgICAgICAo d2luZG93LXByZXNlcnZlLXNpemUgd2luZG93IG5pbCB0KSkpKSkKKyAgICAgICA7OyBJZiBX SU5ET1cgaXMgaG9yaXpvbnRhbGx5IGNvbWJpbmVkLCB0cnkgdG8gcmVzaXplIGl0CisgICAg ICAgOzsgaG9yaXpvbnRhbGx5LgorICAgICAgICgoYW5kIGZpdC13aW5kb3ctdG8tYnVmZmVy LWhvcml6b250YWxseQorCSAgICAgKG5vdCAod2luZG93LXNpemUtZml4ZWQtcCB3aW5kb3cg dCAncHJlc2VydmVkKSkKKwkgICAgICh3aW5kb3ctY29tYmluZWQtcCB3aW5kb3cgdCkpCisJ KGxldCogKChjaGFyLXdpZHRoIChmcmFtZS1jaGFyLXdpZHRoIGZyYW1lKSkKKyAgICAgICAg ICAgICAgICh0b3RhbC13aWR0aCAod2luZG93LXNpemUgd2luZG93IHQgcGl4ZWx3aXNlKSkK KwkgICAgICAgKG1pbi13aWR0aAorCQk7OyBTYW5pdGl6ZSBNSU4tV0lEVEguCisJCShpZiAo bnVtYmVycCBtaW4td2lkdGgpCisJCSAgICA7OyBDYW4ndCBnZXQgc21hbGxlciB0aGFuIGB3 aW5kb3ctc2FmZS1taW4td2lkdGgnLgogCQkgICAgKG1heCAoaWYgcGl4ZWx3aXNlCi0JCQkg ICAgICgqIGNoYXItd2lkdGggd2luZG93LW1pbi13aWR0aCkKLQkJCSAgIHdpbmRvdy1taW4t d2lkdGgpCi0JCQkgKHdpbmRvdy1taW4tc2l6ZSBuaWwgbmlsIHdpbmRvdyBwaXhlbHdpc2Up KSkpCi0JCSAobWF4LXdpZHRoCi0JCSAgOzsgU2FuaXRpemUgTUFYLVdJRFRILgotCQkgIChp ZiAobnVtYmVycCBtYXgtd2lkdGgpCi0JCSAgICAgIChtaW4gKCsgdG90YWwtd2lkdGgKLQkJ CSAgICAgICh3aW5kb3ctbWF4LWRlbHRhCi0JCQkgICAgICAgd2luZG93IHQgd2luZG93IG5p bCB0IG5pbCBwaXhlbHdpc2UpKQotCQkJICAgKGlmIHBpeGVsd2lzZQotCQkJICAgICAgICgq IGNoYXItd2lkdGggbWF4LXdpZHRoKQotCQkJICAgICBtYXgtd2lkdGgpKQotCQkgICAgKCsg dG90YWwtd2lkdGggKHdpbmRvdy1tYXgtZGVsdGEKLQkJCQkgICAgd2luZG93IHQgd2luZG93 IG5pbCB0IG5pbCBwaXhlbHdpc2UpKSkpCi0JCSA7OyBXaGVuIGZpdHRpbmcgaG9yaXpvbnRh bGx5LCBhc3N1bWUgdGhhdCBXSU5ET1cncwotCQkgOzsgc3RhcnQgcG9zaXRpb24gcmVtYWlu cyB1bmFsdGVyZWQuICBXSU5ET1cgY2FuJ3QgZ2V0Ci0JCSA7OyB3aWRlciB0aGFuIGl0cyBm cmFtZSdzIHBpeGVsIHdpZHRoLCBpdHMgaGVpZ2h0Ci0JCSA7OyByZW1haW5zIHVuYWx0ZXJl ZC4KLQkJICh3aWR0aCAoKyAoY2FyICh3aW5kb3ctdGV4dC1waXhlbC1zaXplCi0JCQkJIG5p bCAod2luZG93LXN0YXJ0KSAocG9pbnQtbWF4KQotCQkJCSAoZnJhbWUtcGl4ZWwtd2lkdGgp Ci0JCQkJIDs7IEFkZCBvbmUgY2hhci1oZWlnaHQgdG8gYXNzdXJlIHRoYXQKLQkJCQkgOzsg d2UncmUgb24gdGhlIHNhZmUgc2lkZS4gIFRoaXMKLQkJCQkgOzsgb3ZlcnNob290cyB3aGVu IHRoZSBmaXJzdCBsaW5lIGJlbG93Ci0JCQkJIDs7IHRoZSBib3R0b20gaXMgd2lkZXIgdGhh biB0aGUgd2luZG93LgotCQkJCSAoKiBib2R5LWhlaWdodAotCQkJCSAgICAoaWYgcGl4ZWx3 aXNlIDEgY2hhci1oZWlnaHQpKSkpCi0JCQkgICAod2luZG93LXJpZ2h0LWRpdmlkZXItd2lk dGgpKSkpCi0JICAgICh1bmxlc3MgcGl4ZWx3aXNlCi0JICAgICAgKHNldHEgd2lkdGggKC8g KCsgd2lkdGggY2hhci13aWR0aCAtMSkgY2hhci13aWR0aCkpKQotCSAgICAodW5sZXNzICg9 IHdpZHRoIGJvZHktd2lkdGgpCi0JICAgICAgKHdpbmRvdy1wcmVzZXJ2ZS1zaXplIHdpbmRv dyB0KQotCSAgICAgICh3aW5kb3ctcmVzaXplLW5vLWVycm9yCi0JICAgICAgIHdpbmRvdwot CSAgICAgICAoLSAobWF4IG1pbi13aWR0aAotCQkgICAgICAgKG1pbiBtYXgtd2lkdGgKLQkJ CSAgICAoKyB0b3RhbC13aWR0aCAoLSB3aWR0aCBib2R5LXdpZHRoKSkpKQotCQkgIHRvdGFs LXdpZHRoKQotCSAgICAgICB0IHdpbmRvdyBwaXhlbHdpc2UpCi0JICAgICAgKHdoZW4gcHJl c2VydmUtc2l6ZQotCQkod2luZG93LXByZXNlcnZlLXNpemUgd2luZG93IHQgdCkpKSkpKSkp KSkKKwkJCSAgICAgKCogY2hhci13aWR0aCBtaW4td2lkdGgpCisJCQkgICBtaW4td2lkdGgp CisJCQkgKGlmIHBpeGVsd2lzZQorCQkJICAgICAod2luZG93LXNhZmUtbWluLXBpeGVsLXdp ZHRoIHdpbmRvdykKKwkJCSAgIHdpbmRvdy1zYWZlLW1pbi13aWR0aCkpCisJCSAgOzsgUHJl c2VydmUgZnJpbmdlcywgbWFyZ2lucywgc2Nyb2xsYmFycyBpZiBwcmVzZW50LgorCQkgICht YXggKGlmIHBpeGVsd2lzZQorCQkJICAgKCogY2hhci13aWR0aCB3aW5kb3ctbWluLXdpZHRo KQorCQkJIHdpbmRvdy1taW4td2lkdGgpCisJCSAgICAgICAod2luZG93LW1pbi1zaXplIHdp bmRvdyBuaWwgd2luZG93IHBpeGVsd2lzZSkpKSkKKwkgICAgICAgKG1heC13aWR0aAorCQk7 OyBTYW5pdGl6ZSBNQVgtV0lEVEguCisJCShpZiAobnVtYmVycCBtYXgtd2lkdGgpCisJCSAg ICAobWluICgrIHRvdGFsLXdpZHRoCisJCQkgICAgKHdpbmRvdy1tYXgtZGVsdGEKKwkJCSAg ICAgd2luZG93IHQgd2luZG93IG5pbCB0IG5pbCBwaXhlbHdpc2UpKQorCQkJIChpZiBwaXhl bHdpc2UKKwkJCSAgICAgKCogY2hhci13aWR0aCBtYXgtd2lkdGgpCisJCQkgICBtYXgtd2lk dGgpKQorCQkgICgrIHRvdGFsLXdpZHRoICh3aW5kb3ctbWF4LWRlbHRhCisJCQkJICB3aW5k b3cgdCB3aW5kb3cgbmlsIHQgbmlsIHBpeGVsd2lzZSkpKSkKKwkgICAgICAgOzsgV2hlbiBm aXR0aW5nIGhvcml6b250YWxseSwgYXNzdW1lIHRoYXQgV0lORE9XJ3MKKwkgICAgICAgOzsg c3RhcnQgcG9zaXRpb24gcmVtYWlucyB1bmFsdGVyZWQuICBXSU5ET1cgY2FuJ3QgZ2V0CisJ ICAgICAgIDs7IHdpZGVyIHRoYW4gaXRzIGZyYW1lJ3MgcGl4ZWwgd2lkdGgsIGl0cyBoZWln aHQKKwkgICAgICAgOzsgcmVtYWlucyB1bmFsdGVyZWQuCisJICAgICAgICh3aWR0aCAoKyAo Y2FyICh3aW5kb3ctdGV4dC1waXhlbC1zaXplCisJCQkgICAgICAgd2luZG93ICh3aW5kb3ct c3RhcnQpIChwb2ludC1tYXgpCisJCQkgICAgICAgKGZyYW1lLXBpeGVsLXdpZHRoKQorCQkJ ICAgICAgIDs7IEFkZCBvbmUgbGluZS1oZWlnaHQgdG8gYXNzdXJlIHRoYXQKKwkJCSAgICAg ICA7OyB3ZSdyZSBvbiB0aGUgc2FmZSBzaWRlLiAgVGhpcworCQkJICAgICAgIDs7IG92ZXJz aG9vdHMgd2hlbiB0aGUgZmlyc3QgbGluZSBiZWxvdworCQkJICAgICAgIDs7IHRoZSBib3R0 b20gaXMgd2lkZXIgdGhhbiB0aGUgd2luZG93LgorCQkJICAgICAgICgqICh3aW5kb3ctYm9k eS1oZWlnaHQgd2luZG93IHBpeGVsd2lzZSkKKwkJCQkgIChpZiBwaXhlbHdpc2UgMSBjaGFy LWhlaWdodCkpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAoLSB0b3RhbC13aWR0aAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICh3aW5kb3ctYm9keS13aWR0aCB3aW5kb3cg cGl4ZWx3aXNlKSkpKSkKKwkgICh1bmxlc3MgcGl4ZWx3aXNlCisJICAgIChzZXRxIHdpZHRo ICgvICgrIHdpZHRoIGNoYXItd2lkdGggLTEpIGNoYXItd2lkdGgpKSkKKyAgICAgICAgICAo c2V0cSB3aWR0aCAobWF4IG1pbi13aWR0aCAobWluIG1heC13aWR0aCB3aWR0aCkpKQorCSAg KHVubGVzcyAoPSB3aWR0aCB0b3RhbC13aWR0aCkKKwkgICAgKHdpbmRvdy1wcmVzZXJ2ZS1z aXplIHdpbmRvdyB0KQorCSAgICAod2luZG93LXJlc2l6ZS1uby1lcnJvcgorICAgICAgICAg ICAgIHdpbmRvdyAoLSB3aWR0aCB0b3RhbC13aWR0aCkgdCB3aW5kb3cgcGl4ZWx3aXNlKQor CSAgICAod2hlbiBwcmVzZXJ2ZS1zaXplCisJICAgICAgKHdpbmRvdy1wcmVzZXJ2ZS1zaXpl IHdpbmRvdyB0IHQpKSkpKSkpKSkKIAogKGRlZnVuIHdpbmRvdy1zYWZlbHktc2hyaW5rYWJs ZS1wICgmb3B0aW9uYWwgd2luZG93KQogICAiUmV0dXJuIHQgaWYgV0lORE9XIGNhbiBiZSBz aHJ1bmsgd2l0aG91dCBzaHJpbmtpbmcgb3RoZXIgd2luZG93cy4KCg== --------------A073090F109E8ACB3A75D8C9-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 13:45:35 2019 Received: (at 37563) by debbugs.gnu.org; 7 Oct 2019 17:45:35 +0000 Received: from localhost ([127.0.0.1]:49068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHX4h-0002kL-I5 for submit@debbugs.gnu.org; Mon, 07 Oct 2019 13:45:35 -0400 Received: from mout01.posteo.de ([185.67.36.65]:47013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHX4e-0002k5-VG for 37563@debbugs.gnu.org; Mon, 07 Oct 2019 13:45:33 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 5E594160062 for <37563@debbugs.gnu.org>; Mon, 7 Oct 2019 19:45:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570470326; bh=6nqy/UMON/P/QjRyrvaUXGhTSTi1QjOHNfO4kygKKVk=; h=From:To:Cc:Subject:Date:From; b=E9uAOmJmhbKASJX+AFuFTrfWeelHmw3qyEA6rVUS+oVljSDY06KmB/1J0+9xVdYJB cwW8D+tJ+dG/yqcMsZuqW7grxlT/WcUAYdf71smqIvAFTq/Zy40+N9lwnBbCO9+gQE 5M1hu8n3LReFbGEjksIebk1ocluSdOEawh6UG8F3FmYJXPyGuF3uoX+YkbVfQ3NFUu 5TUS+LaTyOLKOjPd1XKkWUcaYjqwyy7791I/35RS6GKoKEcnyPnsxfk3mTqEgabx9a FOdbWj6myzkXU/iYztNZPvj7ur/LS5JPJbBdOWwQxg4gQ5TwZcLHk2oHGHDTJf7fMi zdtyrekuzgKMg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46n7DP1rwNz6tm7; Mon, 7 Oct 2019 19:45:25 +0200 (CEST) From: Ingo Lohmar To: martin rudalics Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing In-Reply-To: References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> <87lfu1zo4z.fsf@kenko.localhost.com> <6e9ca7b7-4dcd-6038-b4fb-a5ac7d52b049@gmx.at> <87a7af7eb5.fsf@kenko.localhost.com> Date: Mon, 07 Oct 2019 19:45:24 +0200 Message-ID: <87k19gih57.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Mon, Oct 07 2019 11:25 (+0200), martin rudalics wrote: > I now came up with a fix for 'fit-window-to-buffer' too which had some > strange misbehavior with different size restricting arguments when the > window's text size did not change. See attached diffs and Change Log > below. > > > I think I understand better now, I was hampered by some weird debugging > > artifacts in my current setup. With the default > > `frame-resize-pixelwise' of nil, and the otherwise bug-fixed code, > > nothing is cut off, but there is some slack whitespace, indeed. > > I suppose that part of that whitespace comes from the fact that with > 'line-spacing' greater zero, 'window-text-pixel-size' includes the > space below the last line of its text. It would be nice to get rid of > that but ISTR that a line's text may now get centered within the space > reserved for it. So I cannot just remove the entire line space of one > line from the return value but probably only half of the line spacing > value. How would I know the right value? I think we're talking about different things. I was talking about the (correct) rounding to a char-height multiple at the end of `fit-frame-to-buffer'. This is unaffected by the line-spacing. Example (line-spacing 1, frame-resize-pixelwise nil): I had 8 lines of char-height 14, leading to 8*(14+1) = 120 pixels (from window-text-pixel-size, AFAICS) before the rounding. Rounding to a multiple of 14, but at least as large leads to height 126, and these 6 extra pixels are what I saw. As an aside, the posframe pkg explicitly sets `frame-resize-pixelwise' to t, presumable to avoid the rounding, which is the correct approach for this package, I think. In any case, I am happy that this will be fixed, and, coming from the application side, have probably not much else to contribute :) Ingo From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 04:44:36 2019 Received: (at 37563) by debbugs.gnu.org; 8 Oct 2019 08:44:36 +0000 Received: from localhost ([127.0.0.1]:49470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHl6i-0001cI-2A for submit@debbugs.gnu.org; Tue, 08 Oct 2019 04:44:36 -0400 Received: from mout.gmx.net ([212.227.17.20]:37569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHl6g-0001c4-Gy for 37563@debbugs.gnu.org; Tue, 08 Oct 2019 04:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570524268; bh=EbYr9Hd+Y8JXf0Gxb8wnzksXnBxtGK/icO14RNVjboc=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=JsT8RpxCW3XQhaIuTOUrhr/QLjN+BRqnxDRgFVPwdvu0tHSn3fCedXqxFjYDHgODj 7XwN4jN567TLPDMaFrU1ZaAbEfnXRzxa3x4ne4VMz4zTVEkPoSIjtq745NoeaTyaDR GjROPJBwn1TWIZD+VbCY9vtCrcwt1XpxAcIjF5Ns= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.249.114]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M59C8-1iGedz3wPc-001Bpu; Tue, 08 Oct 2019 10:44:28 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> <87lfu1zo4z.fsf@kenko.localhost.com> <6e9ca7b7-4dcd-6038-b4fb-a5ac7d52b049@gmx.at> <87a7af7eb5.fsf@kenko.localhost.com> <87k19gih57.fsf@kenko.localhost.com> From: martin rudalics Message-ID: <9fb0411c-d053-7a75-2212-5a977b385d79@gmx.at> Date: Tue, 8 Oct 2019 10:44:26 +0200 MIME-Version: 1.0 In-Reply-To: <87k19gih57.fsf@kenko.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:u1f47zhOBOswfWoQirXcdGIOBpHdNYKOZQlPd7Wnj9ruE9Rj9aJ mPuQimeEc5ZmqLkgOYG1Dh2PIfRrIbUf0nNJ4/9sUPTBJGAxBHTaNXwNKO092uOB85kEs+d 8BFRmJ8nBXXlQD0Uj+XXus/v06FeCpTI5hw2fS9pMoURbt5r9Tea2VMRVkg4nqzH6iSxq39 2ELc79nLSBufNsZUP9/2w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ttbIcX9PicI=:TWCn+Q5BaviyfvzTYXanjo YvvK6IQ5IplfiUxEKqQQ2RPR97Phrs1jIjdyJs8zSTtPg6LBSUAhGNc21bsO7ePOhjP1TjBol 8dROjb1J+O63ot81e6twJhOoozKOvS37KNqt7ekn3jDm3QJxPeAcyn9N8nbJ5u3EBpbWcXkZo Nqb6vbym2/PCKm/z+7hxUVDqD85IhYMD0z/L2ebJgJkukrR+N5g1Mmj1MK6T5mCgPiWTsXpem drElq6cAGbXLP11ggxGir61zG/SZ3MHTu7+DY/m6/FZapMSlqk0ifKFnAlMIW2x7ju7lf7doW ObzrPXBZR23nH22S79xtPfFNp+46BZfKeLs0fFAyAMqAyvA1Bjbwgjm1krVLTbIja6DsynTco ltA7dX2kfF1Ea67wxYKcbd5d74Vi/tI4tXY/mqq/ZOWfRPgWpbgmIUnOkcMgJaODB1Ky3Y2kh 3NDTaImF2+lroohCOGNd4Lf0TrSn0B/LOksIGKOQRI/fL5phFL+jhvkieQgp/fVK1p2vU8w31 7DUCRrHCz2v3OT/ScGc6pWbl68PyENTczU1pIPPCCVBVWnUexyJOHBJYk2apqxe8dtIjr/zKt DRD083Yl09CIohFbdQSz1S/Sn6gX5L056CfiGA10AJczE3bzr7ls9LCSM80+xZAiCLuQRLueH T4xDnUIeCVPjqm0zh/57k8tdhVsj/hhHpBXBlh4rGY2bEtuWHbucZVADdvFt8TVKVLDHzi89u SX+tpxMNRd8desZWpOhmts+9Vi4Hf+yHMg2iRaB+dzarUT9aHSYV8hMSVL72q+DyNTHJ7Lw3o T2Vo3bTYzMaRrnX34hprmjMohV7bRdP4pVk200KO+sFQ4iXJx/grSy5royi4rHXsTGzwXDc07 W2uQm1a8114BuJ8B1U5iSi9vJVqR2YQO/gVrfJuumAlPx8cQTzBs1lMM+fxFKmKYOfmYuQoHb iICiPvRppim2CHikkqpvW6uqg51KEsXhTNGBg+vcZxL2pdHtiWJCMk4PnesqCHAxofkQdRDui 7fQNKkKes3KZ2bFcCvUvRYkESJ6mAjghU9IVta904L19/FZvzVXeT86L3f1+7M3lQVmmC9flk oKk4yhcSFeLTbDPIufQx72H0IBPXXiFQaIeT1nYMc3mAhuyzo+f1Wr1U5jU4AmDth4s+ISORX LEOg2TYSBcuQbrpzIE5+oZZVcr9ECPBDQEE69U+JSAof6kTJPFAxF6xNfGBzn+soUwYfe5Go1 svC+Iz59mD7rBCPA3Ul+XxLaweMJJrys3gOMLVHTsRRPDycPIgkOydHWxB0uFtko9Kr/PRpLt 2PVDdla0 X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I think we're talking about different things. Yes. What I'm talking about is the slack space at the bottom of the window provoked by the line space of the very last line displayed in that window regardless of whether 'frame-resize-pixelwise' is o [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [46.125.249.114 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > I think we're talking about different things. Yes. What I'm talking about is the slack space at the bottom of the window provoked by the line space of the very last line displayed in that window regardless of whether 'frame-resize-pixelwise' is o [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [46.125.249.114 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager > I think we're talking about different things. Yes. What I'm talking about is the slack space at the bottom of the window provoked by the line space of the very last line displayed in that window regardless of whether 'frame-resize-pixelwise' is on or not. As mentioned in my previous mail, it should be possible to remove that minor nuisance but it will work only if the display engine draws the line space _after_ drawing the line text. Otherwise, some empty space will appear at the top of the window and the last text line will get truncated which is clearly more of a nuisance. > In any case, I am happy that this will be fixed, and, coming from the > application side, have probably not much else to contribute :) If there are no objections, I'll install the last patch I sent in a couple of days. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 04:16:55 2019 Received: (at 37563) by debbugs.gnu.org; 11 Oct 2019 08:16:55 +0000 Received: from localhost ([127.0.0.1]:57652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIq6Y-0007Zf-Nd for submit@debbugs.gnu.org; Fri, 11 Oct 2019 04:16:55 -0400 Received: from mout.gmx.net ([212.227.17.20]:43299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIq6U-0007ZF-Bw for 37563@debbugs.gnu.org; Fri, 11 Oct 2019 04:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570781801; bh=fN8dYIdZEYhMjwDe1gCyBbJ51UuOozz6aLa3l4De1uw=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=RxBKw4tDhP6J5FpyTD7qImMHDNZPvSJ4WMTtoE1gAcnRhgewO8f5BieGdPr/z3Qu3 f7jDIj0EHTcdD9SdTs347yHulFI4D9UWHEQa9Exnf69igjERBrcUBe/F44FrBQdcex QgFejLtg6d9n2kebTLUexM49a9238vkYgkO2kwAo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([46.125.249.9]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mgeo8-1hrSRJ0I1M-00h7S2; Fri, 11 Oct 2019 10:16:41 +0200 Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing From: martin rudalics To: Ingo Lohmar References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> <87lfu1zo4z.fsf@kenko.localhost.com> <6e9ca7b7-4dcd-6038-b4fb-a5ac7d52b049@gmx.at> <87a7af7eb5.fsf@kenko.localhost.com> <87k19gih57.fsf@kenko.localhost.com> <9fb0411c-d053-7a75-2212-5a977b385d79@gmx.at> Message-ID: Date: Fri, 11 Oct 2019 10:16:40 +0200 MIME-Version: 1.0 In-Reply-To: <9fb0411c-d053-7a75-2212-5a977b385d79@gmx.at> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:4iFWPJrkbJxrn8WYeXFPD5BkLtLVG8Z8tL49Ct90e0iFmNqx3K5 97TgUwGvv3+zgQe/765PoiiyJEpMGZMb6A9lEUeCwt0+WlnJO980sLD+BIdi9pRSAI9ABdf faCypKYxwKq+iLmEECV3ooTfBXqZVQeX9zA+LScKYhQSSISOlnrDZGE+UsIieDwJ+0yHfYr se8NjncW9XYHyXVsAkDLg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:cgiUC7YQCUM=:g79zU9V/jsSr9cb+6tzQ/5 XJrghmh6zi6HxPPi1hsctWaNyBxig6/3Qf6bDPuigBCfWa+aEiSMuzIv51ynvFpXJYb1XeNMP Odzhf3krgH44qlujzej5+eGBYtHHX2nHbGGG34sOw7oWGAKYnq2puKQfg651ijPmwmU1j+jxJ U7lCTQyxK9XkZTPY53R9NSO67mjI6ZmfrF01PN9GA5e23TdjRtrK/mCS7UOhzCZDdS1MmRRd1 ++gQMqiC5IhlWv6pEnChyWeyev7LfPjLMLctdoibKqCAiJLfkZ1WEtD8NIlCKBxlKXSvs5dWV d6XqUiDZgXAlruoDmkqOz8o7Jv0eI6afE777gRcTNtp2UtXVPE+BlMFf+0a7OrRirDiI8sc9K XatzR1WSN3TLguX6q+5Qh0aXjW3M8U5YL7JwOYv6lpmfSmJFEa4g+xw5BjJTtt7/qb2x/yFGY nTEYCS39WuhKuUFETzUg9/rgV2VwcRsLoHWi9K188lVwCHbcGPJaQ6Jf+moEEtqldNhJXCblg baQFlNeurhW848JLHMJAOQnijQdhH9Yvy9k8cvG8P1Jxsgmj6B/sWcD3Hqugt0HS/ls/glhDV tKeMfBlKaWpGwdGQxR1phqUx4uoWO6O5hsz9UErP/LNiQgEATtEaTxHlk1dfPHQm2o+XHKOOe 2tq745CUvWeYHi9qWogr+4bz51MmzVanvX0ZeYxqqddbjHUz+DIr84cV3G7UT7Qel4PEIEst3 6PVGCPX+SKS3cUOGmi4bgpsQ7Chs7icUFnckO01vDbJcTLLpmSkqOEql+RdLvQDGryb5OJh2I unB7B/W3fR/0kJmaF5BtwDF7jJmvtu6wszcMNOslq4x2NA3aZaLj7KWgpDX2pmASYuCgCYv7+ e6RcJmejIBI8G5Z5Z8K8J0w1ohhXi5UZjGRrzP+zJnjRKpY0i5R4X28xSBpv1yNzuFFurvs4C 7udqMcf4Gs192Gq14+EY33jxpycVriHb7IIG6GAv22sFr3BU9tmAQek0NFDN4YMRjBAsIvnCO CcIaQfS7blM7FqJlEqSK5TOlOAvkW83CdLsBWiU07Pusabgxd7VNvK707T/xUoAiMIwPE9Rs8 p6jkKQ8UVhDgUDJa3HAi7qAufNH3VeAKdzwGfmPBWSKwAn3TydlXnDvClsszZS4kshfOPVokZ EBS57YY/P8n0FGeM7RUrsTsSL0Bp3nointPHnnJdSaeSg+mYLCE4GNYb48OTrQdUCpUZ5HQda Cn9MgpDP9CCwl4whvIE5O9bw5jkhDWa9rS1fX5w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > If there are no objections, I'll install the last patch I sent in a > couple of days. Installed. Please close the bug if you do not see further problems. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 13:46:04 2019 Received: (at 37563) by debbugs.gnu.org; 11 Oct 2019 17:46:04 +0000 Received: from localhost ([127.0.0.1]:60281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIyzM-0004or-94 for submit@debbugs.gnu.org; Fri, 11 Oct 2019 13:46:04 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIyzJ-0004ny-Be for 37563@debbugs.gnu.org; Fri, 11 Oct 2019 13:46:03 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7B13816005E for <37563@debbugs.gnu.org>; Fri, 11 Oct 2019 19:45:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570815954; bh=hhxDRqkOV4bMMV0X7UdPwjHhP7J5aAXtpKod8LaM0vI=; h=From:To:Cc:Subject:Date:From; b=A4ER6JNeumiX6Y8otYhYwAfen0EYeGf3BGOZCTALPQ9cGpClXeBV8VIYbUPrEfzc/ U0fP5fQsX8nRjM5yThJkctIelyiRmEKQKW8dIc7mOg+Swjc35yPD8/Y1/rLFXr1ur2 oyo51P4PgK1yn02PMD4tJHHvk9LQNXP4XImu9XttCUxGPeGELvXotm/CM90ZlOmGiH yMxsWg/O2mpFdF6a5r1cvQp6NisoWOYbEG7iCsEsAvKj6WZ0XMdqldfH81dvI5dPe5 Kb/ba6+T9c6Zd/w2g31m4lLM4IXEYwamhjRXpJ6ehrBxguRop4eD6r7i70WZFIr+nD BP6VtUxKZiE8g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46qb352lDpz6tm5; Fri, 11 Oct 2019 19:45:53 +0200 (CEST) From: Ingo Lohmar To: martin rudalics Subject: Re: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing In-Reply-To: References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> <87zhiixliu.fsf@kenko.localhost.com> <87lfu1zo4z.fsf@kenko.localhost.com> <6e9ca7b7-4dcd-6038-b4fb-a5ac7d52b049@gmx.at> <87a7af7eb5.fsf@kenko.localhost.com> <87k19gih57.fsf@kenko.localhost.com> <9fb0411c-d053-7a75-2212-5a977b385d79@gmx.at> Date: Fri, 11 Oct 2019 19:45:53 +0200 Message-ID: <87h84f5g6m.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563 Cc: 37563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Fri, Oct 11 2019 10:16 (+0200), martin rudalics wrote: > > If there are no objections, I'll install the last patch I sent in a > > couple of days. > > Installed. Please close the bug if you do not see further problems. > > Thanks, martin Thanks, that all seems to work fine! For the "user side", unfortunately, I am now becoming aware that `company-posframe' also uses the C code's `set-frame-size', and that suffers from the same problem :) I will post that to emacs-devel first, not sure if this is a bug at all.. Thanks again, Ingo From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 13:50:29 2019 Received: (at 37563-done) by debbugs.gnu.org; 11 Oct 2019 17:50:29 +0000 Received: from localhost ([127.0.0.1]:60286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIz3c-0004z5-Sv for submit@debbugs.gnu.org; Fri, 11 Oct 2019 13:50:29 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIz3b-0004yn-5G for 37563-done@debbugs.gnu.org; Fri, 11 Oct 2019 13:50:28 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 64F4416005D for <37563-done@debbugs.gnu.org>; Fri, 11 Oct 2019 19:50:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1570816221; bh=frcCV1k9oG9oKj3dpUqdJg1PxRT2RSN/XKdLCPjaYaY=; h=From:To:Subject:Date:From; b=AYY0HzCIbUi2vGUvFjZqFUUBHgsGPh3nB3RzTJXr3TGBRmSPaniXPBMGREeCsbbq9 qJULrfeofXZfHxTMtspdXbTotIVm8T0A/J4w2ZmfQLixakY7sAImIdmO2F71GfjLar MsSC0CPZJcsYSN4ITeNHewQ5deJeAyUd+X3Mtp1txGiZ4a5fWX6qpnh3/DZrCdgZ8c YmQJ77YmafbDvlEygkqCdaMk5yQpYiGWZdVtImuzdSMMkmCcCAsjfN0FNWkMwxb6n1 VQP9kyC51qEwBvp/BoGHbXjL/0MUI0ZwtGljf+RO5rxmdji6NFbbIGZ1Yh2Ch9/JEi REcwKW9zL8jjA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46qb8D43HBz6tm9 for <37563-done@debbugs.gnu.org>; Fri, 11 Oct 2019 19:50:20 +0200 (CEST) From: Ingo Lohmar To: 37563-done@debbugs.gnu.org Subject: Re: bug#37563: Acknowledgement (27.0.50; fit-frame-to-buffer does not account for line-spacing) In-Reply-To: References: <87tv8tsk3f.fsf@kenko.localhost.com> Date: Fri, 11 Oct 2019 19:50:20 +0200 Message-ID: <87eezj5fz7.fsf@kenko.localhost.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37563-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From unknown Sun Jun 15 08:33:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Nov 2019 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator