GNU bug report logs - #37544
[PATCH] More doc fixes in package.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37544 in the body.
You can then email your comments to 37544 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] More doc fixes in package.el
Date: Sat, 28 Sep 2019 17:58:15 +0200

[Message part 1 (text/plain, inline)]

Here are some more doc fixes for package.el.  Any comments?

Best regards,
Stefan Kangas

[0001-More-doc-fixes-in-package.el.patch (text/x-patch, attachment)]

Message #8 received at 37544 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 37544 <at> debbugs.gnu.org
Subject: Re: bug#37544: [PATCH] More doc fixes in package.el
Date: Wed, 02 Oct 2019 15:31:31 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> Here are some more doc fixes for package.el.  Any comments?

Just a minor nit in the log entry:

> From 4dbcc65645710c17c567cdb5d6f3b7822387c17e Mon Sep 17 00:00:00 2001
> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun, 22 Sep 2019 02:21:54 +0200
> Subject: [PATCH] More doc fixes in package.el
>
> * lisp/emacs-lisp/package.el (package-menu-hide-low-priority)
> (package-pinned-packages)
> (package-load-descriptor, package-archive-version)
> (package-archive-contents, package--read-archive-file)
> (package-read-archive-contents, package-unsigned-archives)
> (package-read-all-archive-contents)
> (package--download-and-read-archives, package-install)
                                                       ^^
I think the changelog for each file is expected to end in a colon.

> * lisp/subr.el (package--description-file)
                                           ^^
Ditto.

> * test/lisp/emacs-lisp/package-tests.el: Doc fixes.

Otherwise looks fine to me, but I'm not familiar with the relevant code.

Thanks,

-- 
Basil

Message #11 received at 37544 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 37544 <at> debbugs.gnu.org
Subject: Re: bug#37544: [PATCH] More doc fixes in package.el
Date: Wed, 2 Oct 2019 17:16:59 +0200

Basil L. Contovounesios <contovob <at> tcd.ie> writes:

> I think the changelog for each file is expected to end in a colon.

Thanks, I had missed that.

> Otherwise looks fine to me, but I'm not familiar with the relevant code.

Great, thanks for reviewing.

Best regards,
Stefan Kangas

Message #16 received at 37544-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 37544-done <at> debbugs.gnu.org
Subject: Re: bug#37544: [PATCH] More doc fixes in package.el
Date: Fri, 4 Oct 2019 01:22:30 +0200

Basil L. Contovounesios <contovob <at> tcd.ie> writes:

> Otherwise looks fine to me, but I'm not familiar with the relevant code.

No further comments in 6 days.  Pushed as commit 93dd959711.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.