From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 08:30:50 2019 Received: (at submit) by debbugs.gnu.org; 28 Sep 2019 12:30:50 +0000 Received: from localhost ([127.0.0.1]:49448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEBsA-0005P3-A5 for submit@debbugs.gnu.org; Sat, 28 Sep 2019 08:30:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:42958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEBs8-0005Ow-9n for submit@debbugs.gnu.org; Sat, 28 Sep 2019 08:30:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36578) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEBs4-0000by-BG for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 08:30:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEBs2-0001dL-73 for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 08:30:44 -0400 Received: from colin.muc.de ([193.149.48.1]:59798 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1iEBs1-0001XZ-HF for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 08:30:42 -0400 Received: (qmail 83972 invoked by uid 3782); 28 Sep 2019 12:30:35 -0000 Received: from acm.muc.de (p2E5D5A4C.dip0.t-ipconnect.de [46.93.90.76]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 28 Sep 2019 14:30:34 +0200 Received: (qmail 9195 invoked by uid 1000); 28 Sep 2019 12:30:34 -0000 Date: Sat, 28 Sep 2019 12:30:34 +0000 To: bug-gnu-emacs@gnu.org Subject: [PATCH] Wishlist: Allow edebug-specs to signal arbitrary error strings on syntax errors in macros. Message-ID: <20190928123034.GA9181@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Emacs. I think it would be a good idea to allow edebug-specs to signal syntax errors with arbitrary strings, like: ("`" &error "Too deeply nested backquotes") . The motivation is to complete the correction in bug #31090, which fixed edebug's handling of nested backquotes in macros. The problem with that fix is it doesn't handle triply nested backquotes (without , or ,@ between them) at all well. There is a fundamental structure clash between backquote's nesting and Lisp's nesting of parentheses. The pragmatic solution is simply to ban triply nested backquotes (i.e. three `s without ,s or ,@s between them) from edebug instrumentation. However, this really needs a mechanism to output an error message string. There is currently no such mecahanism in edebug. The following patch implements an &error mechanism in edebug.el, and illustrates its use in the case which motivated it. Any objections to committing this patch (together with the needed amendments to documentation and NEWS)? diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index 717026995a..73257f1568 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -1683,6 +1683,7 @@ edebug-match-specs (cl-macrolet-body . edebug-match-cl-macrolet-body) (¬ . edebug-match-¬) (&key . edebug-match-&key) + (&error . edebug-match-&error) (place . edebug-match-place) (gate . edebug-match-gate) ;; (nil . edebug-match-nil) not this one - special case it. @@ -1816,6 +1817,14 @@ edebug-match-&key (car (cdr pair)))) specs)))) +(defun edebug-match-&error (cursor specs) + ;; Signal an error, using the following string in the spec as argument. + (setq edebug-gate t) + (let* ((error-string (car specs))) + (if (stringp error-string) + (edebug-no-match cursor error-string) + (error "String expected after &error in edebug-spec")))) + (defun edebug-match-gate (_cursor) ;; Simply set the gate to prevent backtracking at this level. @@ -2185,6 +2194,8 @@ backquote-form (def-edebug-spec nested-backquote-form (&or + ("`" &error "Triply nested backquotes (without commas \"between\" them) \ +are too difficult to instrument") ;; Allow instrumentation of any , or ,@ contained within the (\, ...) or ;; (\,@ ...) matched on the next line. ([&or "," ",@"] backquote-form) -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 09:43:02 2019 Received: (at 37540) by debbugs.gnu.org; 28 Sep 2019 13:43:03 +0000 Received: from localhost ([127.0.0.1]:49476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iED02-0007AY-Jd for submit@debbugs.gnu.org; Sat, 28 Sep 2019 09:43:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iED00-0007A5-FZ for 37540@debbugs.gnu.org; Sat, 28 Sep 2019 09:43:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iECzu-0005Z3-VC; Sat, 28 Sep 2019 09:42:55 -0400 Received: from [176.228.60.248] (port=4762 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iECzt-0006fS-BK; Sat, 28 Sep 2019 09:42:53 -0400 Date: Sat, 28 Sep 2019 16:42:47 +0300 Message-Id: <83o8z4h6zs.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-reply-to: <20190928123034.GA9181@ACM> (message from Alan Mackenzie on Sat, 28 Sep 2019 12:30:34 +0000) Subject: Re: bug#37540: [PATCH] Wishlist: Allow edebug-specs to signal arbitrary error strings on syntax errors in macros. References: <20190928123034.GA9181@ACM> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37540 Cc: 37540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 28 Sep 2019 12:30:34 +0000 > From: Alan Mackenzie > > The following patch implements an &error mechanism in edebug.el, and > illustrates its use in the case which motivated it. > > Any objections to committing this patch (together with the needed > amendments to documentation and NEWS)? Please wait with such changes until the emacs-27 branch is cut (which should happen soon, I hope). I don't want to risk destabilizing Emacs 27 with potentially risky low-level changes, more than it already is. TIA From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 16:34:22 2019 Received: (at 37540) by debbugs.gnu.org; 28 Sep 2019 20:34:22 +0000 Received: from localhost ([127.0.0.1]:51341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEJQ5-00014R-UJ for submit@debbugs.gnu.org; Sat, 28 Sep 2019 16:34:22 -0400 Received: from colin.muc.de ([193.149.48.1]:64541 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1iEJQ4-00014J-CB for 37540@debbugs.gnu.org; Sat, 28 Sep 2019 16:34:21 -0400 Received: (qmail 92185 invoked by uid 3782); 28 Sep 2019 20:34:19 -0000 Received: from acm.muc.de (p2E5D5A4C.dip0.t-ipconnect.de [46.93.90.76]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 28 Sep 2019 22:34:17 +0200 Received: (qmail 31759 invoked by uid 1000); 28 Sep 2019 20:34:16 -0000 Date: Sat, 28 Sep 2019 20:34:16 +0000 To: Eli Zaretskii Subject: Re: bug#37540: [PATCH] Wishlist: Allow edebug-specs to signal arbitrary error strings on syntax errors in macros. Message-ID: <20190928203416.GB9181@ACM> References: <20190928123034.GA9181@ACM> <83o8z4h6zs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83o8z4h6zs.fsf@gnu.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37540 Cc: 37540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli. On Sat, Sep 28, 2019 at 16:42:47 +0300, Eli Zaretskii wrote: > > Date: Sat, 28 Sep 2019 12:30:34 +0000 > > From: Alan Mackenzie > > The following patch implements an &error mechanism in edebug.el, and > > illustrates its use in the case which motivated it. > > Any objections to committing this patch (together with the needed > > amendments to documentation and NEWS)? > Please wait with such changes until the emacs-27 branch is cut (which > should happen soon, I hope). I don't want to risk destabilizing Emacs > 27 with potentially risky low-level changes, more than it already is. OK. Presumably when the emacs-27 branch comes into existence, the emacs-26 branch will be retired from active service. > TIA -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 29 02:18:57 2019 Received: (at 37540) by debbugs.gnu.org; 29 Sep 2019 06:18:57 +0000 Received: from localhost ([127.0.0.1]:52066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iESXp-0000V7-4o for submit@debbugs.gnu.org; Sun, 29 Sep 2019 02:18:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iESXn-0000Uv-NY for 37540@debbugs.gnu.org; Sun, 29 Sep 2019 02:18:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iESXi-0003rs-7S; Sun, 29 Sep 2019 02:18:50 -0400 Received: from [176.228.60.248] (port=2537 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iESXh-0000sc-HS; Sun, 29 Sep 2019 02:18:50 -0400 Date: Sun, 29 Sep 2019 09:18:44 +0300 Message-Id: <8336gfhbgb.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-reply-to: <20190928203416.GB9181@ACM> (message from Alan Mackenzie on Sat, 28 Sep 2019 20:34:16 +0000) Subject: Re: bug#37540: [PATCH] Wishlist: Allow edebug-specs to signal arbitrary error strings on syntax errors in macros. References: <20190928123034.GA9181@ACM> <83o8z4h6zs.fsf@gnu.org> <20190928203416.GB9181@ACM> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37540 Cc: 37540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 28 Sep 2019 20:34:16 +0000 > Cc: 37540@debbugs.gnu.org > From: Alan Mackenzie > > Presumably when the emacs-27 branch comes into existence, the > emacs-26 branch will be retired from active service. It is actually de-facto retired already. Making changes there that are anything but emergency fixes just means more work for Glenn and others, who do the merging, and has no useful purpose. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 14 15:14:24 2020 Received: (at 37540) by debbugs.gnu.org; 14 Jan 2020 20:14:24 +0000 Received: from localhost ([127.0.0.1]:33542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irSZz-0005HI-TF for submit@debbugs.gnu.org; Tue, 14 Jan 2020 15:14:24 -0500 Received: from colin.muc.de ([193.149.48.1]:39008 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1irSZt-0005H5-EA for 37540@debbugs.gnu.org; Tue, 14 Jan 2020 15:14:21 -0500 Received: (qmail 55323 invoked by uid 3782); 14 Jan 2020 20:14:16 -0000 Received: from acm.muc.de (p4FE15B53.dip0.t-ipconnect.de [79.225.91.83]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 14 Jan 2020 21:14:13 +0100 Received: (qmail 8748 invoked by uid 1000); 14 Jan 2020 20:14:13 -0000 Date: Tue, 14 Jan 2020 20:14:13 +0000 To: 37540@debbugs.gnu.org Subject: Re: Bug 37540: [PATCH] Wishlist: Allow edebug-specs to signal arbitrary error strings on syntax errors in macros. Message-ID: <20200114201413.GA8534@ACM> References: <20190928123034.GA9181@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190928123034.GA9181@ACM> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37540 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Emacs and Eli. On Sat, Sep 28, 2019 at 12:30:34 +0000, Alan Mackenzie wrote: > I think it would be a good idea to allow edebug-specs to signal syntax > errors with arbitrary strings, like: > ("`" &error "Too deeply nested backquotes") > . The motivation is to complete the correction in bug #31090, which > fixed edebug's handling of nested backquotes in macros. > The problem with that fix is it doesn't handle triply nested backquotes > (without , or ,@ between them) at all well. There is a fundamental > structure clash between backquote's nesting and Lisp's nesting of > parentheses. > The pragmatic solution is simply to ban triply nested backquotes (i.e. > three `s without ,s or ,@s between them) from edebug instrumentation. > However, this really needs a mechanism to output an error message > string. There is currently no such mecahanism in edebug. > The following patch implements an &error mechanism in edebug.el, and > illustrates its use in the case which motivated it. > Any objections to committing this patch (together with the needed > amendments to documentation and NEWS)? , to which Eli's response was to request me to wait until the emacs-27 release branch had been cut. That has now happened. So, are there any objections to me now committing this patch (current version below, including a documentation amendment), plus a NEWS item, to the master branch? diff --git a/doc/lispref/edebug.texi b/doc/lispref/edebug.texi index 8be8307c75..cfef5c12d1 100644 --- a/doc/lispref/edebug.texi +++ b/doc/lispref/edebug.texi @@ -1362,6 +1362,11 @@ Specification List is primarily used to generate more specific syntax error messages. See @ref{Backtracking}, for more details. Also see the @code{let} example. +@item &error +@code{&error} should be followed by a string, an error message, in the +edebug-spec; it aborts the instrumentation, displaying the message in +the minibuffer. + @item @var{other-symbol} @cindex indirect specifications Any other symbol in a specification list may be a predicate or an diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index b8d2fb5beb..a57c48f1f9 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -1714,6 +1714,7 @@ edebug-match-specs (cl-macrolet-body . edebug-match-cl-macrolet-body) (¬ . edebug-match-¬) (&key . edebug-match-&key) + (&error . edebug-match-&error) (place . edebug-match-place) (gate . edebug-match-gate) ;; (nil . edebug-match-nil) not this one - special case it. @@ -1847,6 +1848,14 @@ edebug-match-&key (car (cdr pair)))) specs)))) +(defun edebug-match-&error (cursor specs) + ;; Signal an error, using the following string in the spec as argument. + (setq edebug-gate t) + (let* ((error-string (car specs))) + (if (stringp error-string) + (edebug-no-match cursor error-string) + (error "String expected after &error in edebug-spec")))) + (defun edebug-match-gate (_cursor) ;; Simply set the gate to prevent backtracking at this level. @@ -2216,6 +2225,8 @@ backquote-form (def-edebug-spec nested-backquote-form (&or + ("`" &error "Triply nested backquotes (without commas \"between\" them) \ +are too difficult to instrument") ;; Allow instrumentation of any , or ,@ contained within the (\, ...) or ;; (\,@ ...) matched on the next line. ([&or "," ",@"] backquote-form) -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 09:47:59 2020 Received: (at 37540) by debbugs.gnu.org; 16 Jan 2020 14:47:59 +0000 Received: from localhost ([127.0.0.1]:37000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1is6RD-00074a-C9 for submit@debbugs.gnu.org; Thu, 16 Jan 2020 09:47:59 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:51540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1is6R9-00073s-Bj for 37540@debbugs.gnu.org; Thu, 16 Jan 2020 09:47:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KbLqIp3yMYLalFyXNdsddlXpn6Mm9hay4jfagxCZj8E=; b=jFi5PJp9jrBG3zKyQVhaMBvbj7 DLh55bdWJHHNroZ9tHDV5jVrdjfSJJAryppgVip1/qqoNZhSSiufXyg3rykR1MmEpWvyhTsxDzubU Dsnhgj/vyg7FvhwaVUu7JIPKKgzJud10yOKWQtZktE/NtuSM2fwnwRcg94jBiX15oWTlqKYgkRLbM s5djitTaLK7Nm6sLJstyXiCvemQgZ6baSQv+EWF8AkGIcyLWP7m7X/0hCsDcrUjmuIpfIfjrbM/pS 53EvUF9sKGYr53urcHpdQJbbhvzHOginFI6PugT91N3MTMY71klQp6g2tZs3NId075QEwgsoRw+V+ IVTxID5Q==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:52544 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1is6R0-000SSy-Ch; Thu, 16 Jan 2020 09:47:46 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#37540: [PATCH] Wishlist: Allow edebug-specs to signal arbitrary error strings on syntax errors in macros. In-Reply-To: <83o8z4h6zs.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 28 Sep 2019 16:42:47 +0300") References: <20190928123034.GA9181@ACM> <83o8z4h6zs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Thu, 16 Jan 2020 15:47:44 +0100 Message-ID: <87h80vwj8v.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37540 Cc: Alan Mackenzie , 37540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Sat, 28 Sep 2019 12:30:34 +0000 >> From: Alan Mackenzie >> >> The following patch implements an &error mechanism in edebug.el, and >> illustrates its use in the case which motivated it. >> >> Any objections to committing this patch (together with the needed >> amendments to documentation and NEWS)? > > Please wait with such changes until the emacs-27 branch is cut (which > should happen soon, I hope). I don't want to risk destabilizing Emacs > 27 with potentially risky low-level changes, more than it already is. Now that the emacs-27 branch is cut, perhaps it is time to look into this again? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 15:57:15 2020 Received: (at 37540) by debbugs.gnu.org; 16 Jan 2020 20:57:15 +0000 Received: from localhost ([127.0.0.1]:38429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isCCW-00080q-QP for submit@debbugs.gnu.org; Thu, 16 Jan 2020 15:57:15 -0500 Received: from colin.muc.de ([193.149.48.1]:52538 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1isCCR-00080b-Dl for 37540@debbugs.gnu.org; Thu, 16 Jan 2020 15:57:11 -0500 Received: (qmail 95761 invoked by uid 3782); 16 Jan 2020 20:57:05 -0000 Received: from acm.muc.de (p4FE15B48.dip0.t-ipconnect.de [79.225.91.72]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 16 Jan 2020 21:57:03 +0100 Received: (qmail 19816 invoked by uid 1000); 16 Jan 2020 20:57:03 -0000 Date: Thu, 16 Jan 2020 20:57:03 +0000 To: Stefan Kangas Subject: Re: bug#37540: [PATCH] Wishlist: Allow edebug-specs to signal arbitrary error strings on syntax errors in macros. Message-ID: <20200116205703.GA19757@ACM> References: <20190928123034.GA9181@ACM> <83o8z4h6zs.fsf@gnu.org> <87h80vwj8v.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h80vwj8v.fsf@marxist.se> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37540 Cc: Eli Zaretskii , 37540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Stefan. On Thu, Jan 16, 2020 at 15:47:44 +0100, Stefan Kangas wrote: > Eli Zaretskii writes: > >> Date: Sat, 28 Sep 2019 12:30:34 +0000 > >> From: Alan Mackenzie > >> The following patch implements an &error mechanism in edebug.el, and > >> illustrates its use in the case which motivated it. > >> Any objections to committing this patch (together with the needed > >> amendments to documentation and NEWS)? > > Please wait with such changes until the emacs-27 branch is cut (which > > should happen soon, I hope). I don't want to risk destabilizing Emacs > > 27 with potentially risky low-level changes, more than it already is. > Now that the emacs-27 branch is cut, perhaps it is time to look into > this again? Indeed, I posted a post on this bug just on Tuesday. It has not yet attracted much feedback. I suppose it is a particularly arcane topic, but such an &error feature would enable me to tidy up the edebug-spec for backquote properly. > Best regards, > Stefan Kangas -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 17 17:02:00 2020 Received: (at 37540-done) by debbugs.gnu.org; 17 Jan 2020 22:02:00 +0000 Received: from localhost ([127.0.0.1]:40243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isZgh-0001h4-Km for submit@debbugs.gnu.org; Fri, 17 Jan 2020 17:02:00 -0500 Received: from colin.muc.de ([193.149.48.1]:55564 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1isZgZ-0001gq-Ny for 37540-done@debbugs.gnu.org; Fri, 17 Jan 2020 17:01:53 -0500 Received: (qmail 45695 invoked by uid 3782); 17 Jan 2020 22:01:46 -0000 Received: from acm.muc.de (p2E5D565F.dip0.t-ipconnect.de [46.93.86.95]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 17 Jan 2020 23:01:43 +0100 Received: (qmail 9798 invoked by uid 1000); 17 Jan 2020 22:01:43 -0000 Date: Fri, 17 Jan 2020 22:01:43 +0000 To: 37540-done@debbugs.gnu.org Subject: Re: Bug 37540: [PATCH] Wishlist: Allow edebug-specs to signal arbitrary error strings on syntax errors in macros. Message-ID: <20200117220143.GA9769@ACM> References: <20190928123034.GA9181@ACM> <20200114201413.GA8534@ACM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200114201413.GA8534@ACM> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37540-done Cc: Eli Zaretskii , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wishlist item committed to master. -- Alan Mackenzie (Nuremberg, Germany). From unknown Sun Aug 17 22:12:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 15 Feb 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator