GNU bug report logs - #37535
[PATCH] gnu: Add python-flask-cors.

Previous Next

Full log

Message #8 received at 37535 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org>
Cc: 37535 <at> debbugs.gnu.org
Subject: Re: [bug#37535] [PATCH] gnu: Add python-flask-cors.
Date: Sat, 28 Sep 2019 22:40:50 +0200

Hi Hamzeh,

"Hamzeh Nasajpour" <h.nasajpour <at> pantherx.org> skribis:

> * gnu/packages/python-web.scm (python-flask-cors): New variable.

[...]

> +(define-public python-flask-cors
> +  (package
> +  (name "python-flask-cors")
> +    (version "3.0.7")

The indentation is different from what we usually do.  Could you run
./etc/indent-code.el as noted at
<https://guix.gnu.org/manual/en/html_node/Formatting-Code.html>?

> +    (arguments
> +      `(#:tests? #f))

Could you try to run the test suite or, as a last resort, add a comment
explaining why it is disabled?

> +    (home-page "https://github.com/corydolphin/flask-cors")
> +    (synopsis "A Flask extension adding a decorator for CORS support")
> +    (description
> +     "A Flask extension for handling Cross Origin Resource Sharing (CORS), 
> +making cross-origin AJAX possible.")

Please fix the issue reported by ‘guix lint’ for the synopsis and make a
full sentence for the description.  See
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>.

Could you send an updated patch?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.