GNU bug report logs - #37534
[PATCH] gnu: conky: Activate Pulseaudio support.

Previous Next

Full log

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dumitrascu Vasile <va511e <at> yahoo.com>
To: Vasile Dumitrascu via Guix-patches <guix-patches <at> gnu.org>, 
 Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 37534 <at> debbugs.gnu.org
Subject: Re: [bug#37534] [PATCH] gnu: conky: Activate Pulseaudio support.
Date: Sat, 28 Sep 2019 09:02:12 +0000 (UTC)

[Message part 1 (text/plain, inline)]

  Hi Tobias
Thank you for the review and sorry to have missed the sorting.
I have re-attached the original patch as a file to this email, as I guess the encoding issues were caused by git send-mail.
  Thank you again,    Vasile

    On Saturday, September 28, 2019, 12:50:15 AM GMT+2, Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:  
 
 Vasile,

Vasile Dumitrascu via Guix-patches via 写道：
> --- a/gnu/packages/conky.scm
> +++ b/gnu/packages/conky.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa <at> bidin.eu>
>  ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice 
>  <me <at> tobias.gr>
>  ;;; Copyright ?? 2019 Pierre Neidhardt <mail <at> ambrevar.xyz>
> +;;; Copyright ?? 2019 Vasile Dumitrascu <va511e <at> yahoo.com>

Does this show up as corrupted in your mailbox as well?  (‘??’ 
instead of ‘©’.)

> @@ -76,6 +79,7 @@
>        ("libxext" ,libxext)
>        ("libxft" ,libxft)
>        ("libxinerama" ,libxinerama)
> +      ("pulseaudio", pulseaudio)
>        ("lua" ,lua)
>        ("ncurses" ,ncurses)
>        ("curl" ,curl)))

I guess any hope of alphabetical ordering was lost long ago.

The change looks fine to me, but could you try fixing the text 
encoding?

Thanks!

T G-R  

[Message part 2 (text/html, inline)]

[0001-gnu-conky-Activate-Pulseaudio-support.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.