Subject: Re: [bug#37486] [PATCH] gnu: Add goattracker

From: Ludovic Courtès <[email-masked]>
Date: Tue, 19 Nov 2019 10:38:51 +0100

Hi Mikhail,

Did you have a chance to look further into this patch, based on the
comments below?

(See <https://issues.guix.gnu.org/issue/37486>.)

Thanks in advance,
Ludo’.

Ludovic Courtès <[email-masked]> skribis:

> Hi Mikhail,
>
> Mikhail Kirillov <[email-masked]> skribis:
>
>> * gnu/packages/music.scm: Add goattracker
>
> Thanks for the updated patch.
>
> I started looking into it, fixing an issue reported by ‘guix lint’, and
> cleaning up the source, leading to the following patch.
>
> However, goattracker no fails to build because of a missing ‘.bin’ file.
>
> Do you know what these ‘.bin’ (and ‘.dat’) files are, what their license
> is, and what can be done with them?
>
> Thanks in advance,
> Ludo’.
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 7216075c34..84b602ae36 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -4598,7 +4598,14 @@ with error and volume history, and advanced features.")
>                      version "/GoatTracker_" version ".zip"))
>                (sha256
>                 (base32
> -                "1km97nl7qvk6qc5l5j69wncbm76hf86j47sgzgr968423g0bxxlk"))))
> +                "1km97nl7qvk6qc5l5j69wncbm76hf86j47sgzgr968423g0bxxlk"))
> +              (modules '((guix build utils)))
> +              (snippet
> +               '(begin
> +                  ;; Remove binaries from the source tarball.
> +                  (for-each delete-file
> +                            (find-files "." "\\.(o|dll|exe|bin)$"))
> +                  #t))))
>      (arguments
>       `(#:tests? #f
>         #:make-flags '("CC=gcc")
> @@ -4613,7 +4620,7 @@ with error and volume history, and advanced features.")
>           (replace 'install
>             (lambda* (#:key inputs outputs #:allow-other-keys)
>               (chdir "../linux")
> -             (invoke "ln" "-s" "goattrk2" "goattracker")
> +             (symlink "goattrk2" "goattracker")
>               (copy-recursively "./" (string-append
>                                       (assoc-ref %outputs "out")
>                                       "/bin"))
> @@ -4626,5 +4633,5 @@ with error and volume history, and advanced features.")
>      (description "GoatTracker is a cross-platform tracker written by Lasse
>  Öörni, producing SID chiptune music for the Commodore 64, and released with
>  source code under the GPL.")
> -    (home-page "https://goattracker2.sourceforge.io/")
> -    (license license:gpl2)))
> +    (home-page "http://goattracker2.sourceforge.net/")
> +    (license license:gpl2+)))