GNU bug report logs - #37473
27.0.50; antialias setting is not preserved by inheriting

Previous Next

Full log

View this message in rfc822 format

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: David Ponce <da_vid <at> orange.fr>, larsi <at> gnus.org, 37473 <at> debbugs.gnu.org
Subject: bug#37473: 27.0.50; antialias setting is not preserved by, inheriting
Date: Mon, 20 Jun 2022 08:49:19 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>
>> Date: Sun, 19 Jun 2022 18:43:33 +0200
>> From: David Ponce <da_vid <at> orange.fr>
>> 
>> The below related today's commit to xface.c breaks antialiasing:
>> 
>>  From b2d11d69dd49864874f8fe53669b4049e83bfce9 Mon Sep 17 00:00:00 2001
>> From: Po Lu <luangruo <at> yahoo.com>
>> Date: Sun, 19 Jun 2022 21:57:11 +0800
>> Subject: More conservative fix for bug#37473
>> 
>> * src/xfaces.c (realize_gui_face): Add more conservative fix,
>> since the last change makes C-x C-+ lead to weight weirdness on
>> my machine.
>
> FWIW, I understand neither that commit nor the one it attempted to
> fix.

I didn't either.  My goal was to fix C-x C-+ causing a font with an
incorrect weight to be selected, by only preserving :antialias (as
opposed to everything aside from foundry, family, registry and adstyle.)

The fix should definitely be rewritten.

> IOW, do we really understand the reason for bug#37473?  Not the commit
> which introduced it, but the reason why :antialiasing is being reset
> and doesn't appear in attrs[] and in the realized face?  If so, could
> someone please spell that out?

I think the person who wrote the font code is the only person who really
understands it.  Is Kenchi Handa still around?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.