Subject: Re: bug#37470: 26.3; [PATCH] Default value and type of message-make-forward-subject-function

From: Robert Pluim <[email-masked]>
Date: Fri, 20 Sep 2019 12:02:15 +0200

>>>>> On Fri, 20 Sep 2019 11:08:42 +0200, Damien Cassou <[email-masked]> said:

    Damien> Please find attached a patch fixing the default value and type of
    Damien> message-make-forward-subject-function.
    Damien> +  :type '(repeat :tag "List of functions"
    Damien> +                 (radio (function-item message-forward-subject-author-subject)
    Damien> +                        (function-item message-forward-subject-fwd)
    Damien> +                        (function-item message-forward-subject-name-subject)
    Damien> +                        (function))))

I donʼt see how this could work: 'radio allows selecting only one from
the list. How about something like this:

diff --git i/lisp/gnus/message.el w/lisp/gnus/message.el
index 48d79107ea..1a1cb79039 100644
--- i/lisp/gnus/message.el
+++ w/lisp/gnus/message.el
@@ -532,7 +532,7 @@ message-user-organization-file
   :group 'message-headers)
 
 (defcustom message-make-forward-subject-function
-  #'message-forward-subject-name-subject
+  (list #'message-forward-subject-name-subject)
   "List of functions called to generate subject headers for forwarded messages.
 The subject generated by the previous function is passed into each
 successive function.
@@ -547,10 +547,11 @@ message-make-forward-subject-function
       to it."
   :group 'message-forwarding
   :link '(custom-manual "(message)Forwarding")
-  :type '(radio (function-item message-forward-subject-author-subject)
-		(function-item message-forward-subject-fwd)
-		(function-item message-forward-subject-name-subject)
-		(repeat :tag "List of functions" function)))
+  :type '(set :tag "List of functions"
+              (function-item message-forward-subject-author-subject)
+              (function-item message-forward-subject-fwd)
+              (function-item message-forward-subject-name-subject)
+              (repeat :tag "User functions" :inline t (function :tag "Function"))))
 
 (defcustom message-forward-as-mime nil
   "Non-nil means forward messages as an inline/rfc822 MIME section.