From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Dan Nicolaescu , 3746@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 03 Jul 2009 18:20:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12466449095556 (code B ref -1); Fri, 03 Jul 2009 18:20:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Jul 2009 18:15:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n63IF2ja005442 for ; Fri, 3 Jul 2009 11:15:03 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MMioX-0000hr-EJ for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MMioT-0000cb-R7 for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:29 -0400 Received: from [199.232.76.173] (port=40895 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MMioT-0000cY-Lp for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:25 -0400 Received: from sallyv2.ics.uci.edu ([128.195.1.120]:47612) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MMioT-0005wj-93 for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:25 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n63DQfRL027172 for ; Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n63DQfPA027629; Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Date: Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Message-Id: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Lines: 11 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n63DQfRL027172 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) When using the minibuffer for example doing: M-x then C-r will use isearch to search the history. This is nice because it shows the items that are matched. M-r should to the same thing when used in comint, right now it's hard to tell if it matches anything before typing RET From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 04 Jul 2009 00:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124666712010100 (code B ref 3746); Sat, 04 Jul 2009 00:30:04 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 4 Jul 2009 00:25:20 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from smtp-gw1.starman.ee (smtp-out3.starman.ee [85.253.0.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n640PE3k009999 for <3746@emacsbugs.donarmstrong.com>; Fri, 3 Jul 2009 17:25:15 -0700 Received: from mx2.starman.ee (mx2.starman.ee [62.65.192.17]) by smtp-gw1.starman.ee (Postfix) with ESMTP id 8EEE327D39; Sat, 4 Jul 2009 03:25:12 +0300 (EEST) X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.53.243.cable.starman.ee [82.131.53.243]) by mx2.starman.ee (Postfix) with ESMTP id 9AF113F404E; Sat, 4 Jul 2009 03:25:07 +0300 (EEST) From: Juri Linkov To: Dan Nicolaescu Cc: 3746@debbugs.gnu.org Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> Date: Sat, 04 Jul 2009 02:36:36 +0300 In-Reply-To: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 3 Jul 2009 06:26:41 -0700 (PDT)") Message-ID: <87zlblpajc.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > When using the minibuffer for example doing: > > M-x > then > C-r > will use isearch to search the history. This is nice because it shows > the items that are matched. > > M-r should to the same thing when used in comint, right now it's hard > to tell if it matches anything before typing RET Do you mean implementing a bash-like history isearch in comint/shell modes? I think it would be nice. But maybe M-r is not the best key to start a shell history isearch in the comint buffer. In the minibuffer M-r keeps its old functionality, and C-s is used to isearch the minibuffer history. It seems we can't use C-s in the comint buffer to isearch the shell history because searching in the output is useful as well. Maybe we should let C-s to isearch the shell history from the M-r minibuffer instead of the minibuffer history of the previous M-r input? -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Dan Nicolaescu , 3746@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 05 Jul 2009 15:05:10 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.12468062369471 (code B ref 3746); Sun, 05 Jul 2009 15:05:10 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 5 Jul 2009 15:03:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.0 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n65F3qYB009454 for <3746@emacsbugs.donarmstrong.com>; Sun, 5 Jul 2009 08:03:53 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n65F3fbo006307; Sun, 5 Jul 2009 08:03:41 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n65F3fDv003169; Sun, 5 Jul 2009 08:03:41 -0700 (PDT) Date: Sun, 5 Jul 2009 08:03:41 -0700 (PDT) Message-Id: <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Juri Linkov Cc: 3746@debbugs.gnu.org References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> In-Reply-To: <87zlblpajc.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 04 Jul 2009 02:36:36 +0300") Lines: 29 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n65F3fbo006307 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Juri Linkov writes: > > When using the minibuffer for example doing: > > > > M-x > > then > > C-r > > will use isearch to search the history. This is nice because it shows > > the items that are matched. > > > > M-r should to the same thing when used in comint, right now it's hard > > to tell if it matches anything before typing RET > > Do you mean implementing a bash-like history isearch > in comint/shell modes? I think it would be nice. Yep. > But maybe M-r is not the best key to start a shell history > isearch in the comint buffer. In the minibuffer M-r keeps > its old functionality, and C-s is used to isearch the > minibuffer history. The problem with that is that C-s (and C-r) already have bindings in comint modes, and changing them would not be liked by most users. Doing M-r and then C-s/C-r seems a bit cumbersome. IMHO just using M-r for incremental history search will provide no surprises for the user, and it seems like a natural extension of the current behavior. From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 07 Jul 2009 01:15:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124692903728223 (code B ref 3746); Tue, 07 Jul 2009 01:15:04 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 7 Jul 2009 01:10:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n671AUpW028217 for <3746@emacsbugs.donarmstrong.com>; Mon, 6 Jul 2009 18:10:31 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.30.29.cable.starman.ee [82.131.30.29]) by mx2.starman.ee (Postfix) with ESMTP id BD0953F4075; Tue, 7 Jul 2009 04:10:24 +0300 (EEST) From: Juri Linkov To: Dan Nicolaescu Cc: 3746@debbugs.gnu.org Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> Date: Tue, 07 Jul 2009 03:09:45 +0300 In-Reply-To: <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 5 Jul 2009 08:03:41 -0700 (PDT)") Message-ID: <87ab3hxprg.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > The problem with that is that C-s (and C-r) already have bindings in > comint modes, and changing them would not be liked by most users. > Doing M-r and then C-s/C-r seems a bit cumbersome. > IMHO just using M-r for incremental history search will provide no > surprises for the user, and it seems like a natural extension of the > current behavior. Currently M-r typed in the shell buffer activates the minibuffer with the prompt "Previous input matching (regexp): ". I doubt that users will like to see Isearch activated instead of this minibuffer. But maybe we should try using M-s that is less useful in the shell buffer. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Dan Nicolaescu , 3746@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 07 Jul 2009 01:25:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124692972330165 (code B ref 3746); Tue, 07 Jul 2009 01:25:05 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 7 Jul 2009 01:22:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.0 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n671Lxra030154 for <3746@emacsbugs.donarmstrong.com>; Mon, 6 Jul 2009 18:22:00 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n671LmeM005362; Mon, 6 Jul 2009 18:21:48 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n671LmLt029754; Mon, 6 Jul 2009 18:21:48 -0700 (PDT) Date: Mon, 6 Jul 2009 18:21:48 -0700 (PDT) Message-Id: <200907070121.n671LmLt029754@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Juri Linkov Cc: 3746@debbugs.gnu.org References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> In-Reply-To: <87ab3hxprg.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 07 Jul 2009 03:09:45 +0300") Lines: 23 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n671LmeM005362 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Juri Linkov writes: > > The problem with that is that C-s (and C-r) already have bindings in > > comint modes, and changing them would not be liked by most users. > > Doing M-r and then C-s/C-r seems a bit cumbersome. > > IMHO just using M-r for incremental history search will provide no > > surprises for the user, and it seems like a natural extension of the > > current behavior. > > Currently M-r typed in the shell buffer activates the minibuffer with > the prompt "Previous input matching (regexp): ". I doubt that users > will like to see Isearch activated instead of this minibuffer. Why not? It does provide the same functionality and it seems easier to use. Maybe the prompt would need to be adjusted, but, IMHO, it's doubtful the users would be unpleasantly surprised by the behavior... > But maybe we should try using M-s that is less useful in the > shell buffer. > > -- > Juri Linkov > http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 08 Jul 2009 01:35:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.12470165101035 (code B ref 3746); Wed, 08 Jul 2009 01:35:06 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 8 Jul 2009 01:28:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n681SPsn001030 for <3746@emacsbugs.donarmstrong.com>; Tue, 7 Jul 2009 18:28:26 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.53.27.cable.starman.ee [82.131.53.27]) by mx1.starman.ee (Postfix) with ESMTP id 016BA3F411E; Wed, 8 Jul 2009 04:28:18 +0300 (EEST) From: Juri Linkov To: Dan Nicolaescu Cc: 3746@debbugs.gnu.org Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> Date: Wed, 08 Jul 2009 03:45:05 +0300 In-Reply-To: <200907070121.n671LmLt029754@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 6 Jul 2009 18:21:48 -0700 (PDT)") Message-ID: <87skh8ynnm.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > > > The problem with that is that C-s (and C-r) already have bindings in > > > comint modes, and changing them would not be liked by most users. > > > Doing M-r and then C-s/C-r seems a bit cumbersome. > > > IMHO just using M-r for incremental history search will provide no > > > surprises for the user, and it seems like a natural extension of the > > > current behavior. > > > > Currently M-r typed in the shell buffer activates the minibuffer with > > the prompt "Previous input matching (regexp): ". I doubt that users > > will like to see Isearch activated instead of this minibuffer. > > Why not? It does provide the same functionality and it seems easier to > use. Maybe the prompt would need to be adjusted, but, IMHO, it's > doubtful the users would be unpleasantly surprised by the behavior... M-r has a different UI. Its main difference that it is a non-incremental regexp search unlike C-s that is an incremental string search. Both bash and the Emacs minibuffer activate Isearch on C-s, so it would be natural to do the same in shell buffers. We could try the same context-dependent dwim approach used by the option of `dired-isearch-filenames', i.e. "When point is on a file name initially, search file names". So when point is on the shell prompt then run Isearch on the shell history, otherwise run Isearch on the shell buffer. What to do with the prompt is more difficult problem. Bash replaces the shell prompt with the search prompt. Perhaps we should do the same. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: "Drew Adams" , 3746@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 08 Jul 2009 06:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124703241112101 (code B ref 3746); Wed, 08 Jul 2009 06:00:04 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 8 Jul 2009 05:53:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from acsinet11.oracle.com (acsinet11.oracle.com [141.146.126.233]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n685rPSN012082 for <3746@emacsbugs.donarmstrong.com>; Tue, 7 Jul 2009 22:53:26 -0700 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n685sc86006757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Jul 2009 05:54:39 GMT Received: from abhmt004.oracle.com (abhmt004.oracle.com [141.146.116.13]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n685t498010614; Wed, 8 Jul 2009 05:55:04 GMT Received: from dradamslap1 (/141.144.124.151) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 07 Jul 2009 22:53:15 -0700 From: "Drew Adams" To: "'Juri Linkov'" , <3746@debbugs.gnu.org>, "'Dan Nicolaescu'" References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu><87zlblpajc.fsf@mail.jurta.org><200907051503.n65F3fDv003169@godzilla.ics.uci.edu><87ab3hxprg.fsf@mail.jurta.org><200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> Date: Tue, 7 Jul 2009 22:53:29 -0700 Message-ID: <30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87skh8ynnm.fsf@mail.jurta.org> Thread-Index: Acn/bO8d1H7YwRfvS4yQ7kYhvdOgjQAHLGSg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt004.oracle.com [141.146.116.13] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010203.4A54344C.00F8:SCFSTAT5015188,ss=1,fgs=0 > So when point is on the shell prompt then run Isearch on > the shell history, otherwise run Isearch on the shell buffer. Why? I don't really want to get involved in this thread. I will say though that the approach just quoted is a good example of the weakness of DWIM. A better approach, generally, is to give users explicit control, without such a dependence on fine-grained context or mode. IOW, in this case, have the two different kinds of search be initiated by a user differently, using two different commands/keys. That's the typical, simple, straightforward Emacs approach. The DWIM approach, far from always making things easier for users, complicates the mental models they need to use to make sense of their interactions with the program. They need to be aware (not necessarily consciously) of much more contextual state. The behavior is more complex, not less. That's not to say that users can't make use of it or that they need to be consciously thinking about complex contextual issues all the time. Like riding a bike or driving a car, this can soon become unconscious and natural (provided they use it a lot). The general objection is rather Occam's razor: _Why_ add such complexity? What is gained? Occasionally the added convenience of having a single key to use makes a DWIM command worth it. But usually not. If the two behaviors and their triggering contexts are complementary and quite separate, then it can sometimes be worth it. But just combining behaviors on the same key binding whenever there is some degree of context difference is not justified, on its own. Just because Isearch on the history and Isearch on the buffer have no target overlap is not in itself a sufficient reason to combine them on the same key. Put another way, is it really worth it in this case to make the command behavior more complex, just to avoid having two key bindings? What reasons can you give? One can look throughout Emacs and find plenty of commands/keys that _could_ be combined, pushing the decision of which command to apply from the user into the combo-command, according to context. But very few commands merit such combination. I'm sure you could combine some commands/keys in almost any major mode - from Dired to *Buffer List* to view-mode to almost anything. There are commands that make sense only in certain contexts and so could be combined. But _why_ do that? You could make `U' in Dired do something different when no files are marked. You could perhaps combine that with `#' to do something when there are no auto-save files. But why? You get the idea: Combining different commands on the same key, to take advantage of their applicability in different contexts, makes the UI more complex; it forces users to consider the context. All that's gained is a keystroke or two. Generally, it's not worth it. Some argue that having lots of commands and lots of key bindings is also complex. Yes, but then the different features are more separate, explicit, independent. They are not linked by state/mode changes. States and modes are among the most complex UI critters for users to tame, and they are largely invisible/virtual. Each time there is a DWIM proposal like this, I'd like to see a little extra justification - justification for the combination itself: why one complex command instead of two simple commands? If this isn't supported by argument each time, we might well find ourselves soon in a maze of DWIM, with people emulating such tricky combination more and more. Programmers like to be clever, and DWIM is a cute cleverness trap. Like trying to eke out extra functionality from fewer bytes of assembler code, apparent cleverness can have a price in ease of change, ease of use, and ease of understanding. From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 08 Jul 2009 23:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124709575528215 (code B ref 3746); Wed, 08 Jul 2009 23:35:03 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 8 Jul 2009 23:29:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n68NTADw028201 for <3746@emacsbugs.donarmstrong.com>; Wed, 8 Jul 2009 16:29:12 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.68.68.cable.starman.ee [82.131.68.68]) by mx1.starman.ee (Postfix) with ESMTP id 8ECC83F4139; Thu, 9 Jul 2009 02:29:04 +0300 (EEST) From: Juri Linkov To: "Drew Adams" Cc: <3746@debbugs.gnu.org>, "'Dan Nicolaescu'" Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com> Date: Thu, 09 Jul 2009 02:27:45 +0300 In-Reply-To: <30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com> (Drew Adams's message of "Tue, 7 Jul 2009 22:53:29 -0700") Message-ID: <87zlbf1kr0.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > The general objection is rather Occam's razor: _Why_ add such complexity? > What is gained? Occasionally the added convenience of having a single key > to use makes a DWIM command worth it. But usually not. This case is an exception. C-r is the most frequent key I use in bash running in xterm because it is very convenient to search for old commands in the shell history. I suppose the same is true for other users. Using a different key in Emacs for the same functionality will cause too much trouble. Just imagine when you have a habit typing C-r to search on the shell history, typing it in the Emacs shell buffer will not do what you mean. This recalls that Emacs has a different key M-r. Then switching back to xterm and typing M-r: Ahh, that M-r is valid only in Emacs, but in xterm it is C-r. Arrrgh! I think having two different keys for the same functionality (C-r and M-r for Isearch on the history) is worse than having the same key for different contexts (the shell prompt or the rest of the shell buffer). -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Lennart Borgman , 3746@debbugs.gnu.org Resent-From: Lennart Borgman Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 08 Jul 2009 23:50:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124709653630398 (code B ref 3746); Wed, 08 Jul 2009 23:50:05 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 8 Jul 2009 23:42:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n68NgBrs030392 for <3746@emacsbugs.donarmstrong.com>; Wed, 8 Jul 2009 16:42:13 -0700 Received: by bwz9 with SMTP id 9so1535108bwz.18 for <3746@emacsbugs.donarmstrong.com>; Wed, 08 Jul 2009 16:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=u9dRTboMQ5OXsitiYRsSERtT0zJ96cOMmOahdwHzyZU=; b=XNd6EXdYHMpuAkPw32PAEjzKBRrJkJxQeCJL8q08m6yWDVMHFKq6DqAx+Bt0U9qP+Q 5I235iabz737RTEWlFMUbtUFjUGF2ajnPYrDBLUGntpMOYpC8Cl3dGfMn4fPSNbYPkOJ P5dVfP/78u8c1+Jp3TNF2v+P1R+e64+N4cRzY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=RwJqFpBR5FMbowJgrzvHQL+aeyXfOtvDNaa4V1QDM2C1G3rTdw2mgeQzBI0r7g+c39 V7JNu5CoVQVueJlrbMB4PE8u5b5MnYRwxDSaNiye/WIIwGh/1dnJdZ3fG8Z3cmP8k3GO EdsBofff/yOrRDqlYQ6iUK50M/7rFwmcNIrCk= MIME-Version: 1.0 Received: by 10.239.156.65 with SMTP id l1mr9689hbc.34.1247096525636; Wed, 08 Jul 2009 16:42:05 -0700 (PDT) In-Reply-To: <87zlbf1kr0.fsf@mail.jurta.org> References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com> <87zlbf1kr0.fsf@mail.jurta.org> Date: Thu, 9 Jul 2009 01:42:05 +0200 Message-ID: From: Lennart Borgman To: Juri Linkov , 3746@debbugs.gnu.org Cc: Drew Adams , Dan Nicolaescu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Jul 9, 2009 at 1:27 AM, Juri Linkov wrote: >> The general objection is rather Occam's razor: _Why_ add such complexity= ? >> What is gained? Occasionally the added convenience of having a single ke= y >> to use makes a DWIM command worth it. But usually not. > > This case is an exception. > > C-r is the most frequent key I use in bash running in xterm because > it is very convenient to search for old commands in the shell history. > I suppose the same is true for other users. > > Using a different key in Emacs for the same functionality > will cause too much trouble. =C2=A0Just imagine when you have a habit I do not think it is an exception. I think it is a way of thinking we should always consider. From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Dan Nicolaescu , 3746@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 08 Jul 2009 23:55:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124709697931269 (code B ref 3746); Wed, 08 Jul 2009 23:55:06 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 8 Jul 2009 23:49:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.0 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n68NnXsS031242 for <3746@emacsbugs.donarmstrong.com>; Wed, 8 Jul 2009 16:49:34 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n68NnKBF018364; Wed, 8 Jul 2009 16:49:20 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n68NnKRj025444; Wed, 8 Jul 2009 16:49:20 -0700 (PDT) Date: Wed, 8 Jul 2009 16:49:20 -0700 (PDT) Message-Id: <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Juri Linkov Cc: 3746@debbugs.gnu.org References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> In-Reply-To: <87skh8ynnm.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 08 Jul 2009 03:45:05 +0300") Lines: 40 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n68NnKBF018364 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Juri Linkov writes: > > > > The problem with that is that C-s (and C-r) already have bindings in > > > > comint modes, and changing them would not be liked by most users. > > > > Doing M-r and then C-s/C-r seems a bit cumbersome. > > > > IMHO just using M-r for incremental history search will provide no > > > > surprises for the user, and it seems like a natural extension of the > > > > current behavior. > > > > > > Currently M-r typed in the shell buffer activates the minibuffer with > > > the prompt "Previous input matching (regexp): ". I doubt that users > > > will like to see Isearch activated instead of this minibuffer. > > > > Why not? It does provide the same functionality and it seems easier to > > use. Maybe the prompt would need to be adjusted, but, IMHO, it's > > doubtful the users would be unpleasantly surprised by the behavior... > > M-r has a different UI. Its main difference that it is a non-incremental > regexp search unlike C-s that is an incremental string search. Is there any reason not to have an incremental search for M-r too? > Both bash and the Emacs minibuffer activate Isearch on C-s, so it > would be natural to do the same in shell buffers. We could try the > same context-dependent dwim approach used by the option of > `dired-isearch-filenames', i.e. "When point is on a file name > initially, search file names". So when point is on the shell prompt > then run Isearch on the shell history, otherwise run Isearch on the > shell buffer. That sounds fine, but it's not exclusive with M-r being an incremental search too. We are at the beginning of a release cycle, so we can experiment, if the users hate the change, there's enough time to change back. > What to do with the prompt is more difficult problem. Bash replaces the > shell prompt with the search prompt. Perhaps we should do the same. Agreed. From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: "Drew Adams" , 3746@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Jul 2009 15:10:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124715171618569 (code B ref 3746); Thu, 09 Jul 2009 15:10:06 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 9 Jul 2009 15:01:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n69F1poP018562 for <3746@emacsbugs.donarmstrong.com>; Thu, 9 Jul 2009 08:01:52 -0700 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n69F3BKx019164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jul 2009 15:03:13 GMT Received: from abhmt009.oracle.com (abhmt009.oracle.com [141.146.116.18]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n69F3VZ2018328; Thu, 9 Jul 2009 15:03:32 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Jul 2009 08:01:41 -0700 From: "Drew Adams" To: "'Juri Linkov'" Cc: <3746@debbugs.gnu.org>, "'Dan Nicolaescu'" References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu><87zlblpajc.fsf@mail.jurta.org><200907051503.n65F3fDv003169@godzilla.ics.uci.edu><87ab3hxprg.fsf@mail.jurta.org><200907070121.n671LmLt029754@godzilla.ics.uci.edu><87skh8ynnm.fsf@mail.jurta.org><30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com> <87zlbf1kr0.fsf@mail.jurta.org> Date: Thu, 9 Jul 2009 08:01:43 -0700 Message-ID: <84007A40B39D4D1F97E2E01F3B07B59F@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87zlbf1kr0.fsf@mail.jurta.org> Thread-Index: AcoAJAEOj3uQLgqFSCySdrfFKr5P1AAgSLOQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt009.oracle.com [141.146.116.18] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010205.4A560656.00AB:SCFSTAT5015188,ss=1,fgs=0 > > The general objection is rather Occam's razor: _Why_ add > > such complexity? What is gained? Occasionally the added > > convenience of having a single key to use makes a DWIM > > command worth it. But usually not. > > This case is an exception. I leave that to your judgment; I can't speak to that. > C-r is the most frequent key I use in bash running in xterm because > it is very convenient to search for old commands in the shell history. > I suppose the same is true for other users. > > Using a different key in Emacs for the same functionality > will cause too much trouble. Just imagine when you have a habit > typing C-r to search on the shell history, typing it in the Emacs > shell buffer will not do what you mean. This recalls that > Emacs has a different key M-r. Then switching back to xterm > and typing M-r: Ahh, that M-r is valid only in Emacs, > but in xterm it is C-r. Arrrgh! > > I think having two different keys for the same functionality > (C-r and M-r for Isearch on the history) is worse than having > the same key for different contexts (the shell prompt or the > rest of the shell buffer). The alternative is not necessarily to have two completely different keys. The typical, traditional, and simpler approach is to use the same key but still allow two behaviors and keep the behavior distinction under explicit user control: Initiate one of the two behaviors using `C-u'. Depending on context is far more complicated. And depending on context doesn't necessarily mean fewer keystrokes (even though you never need to hit `C-u'): If the cursor is not in the right place for the particular behavior you want, then you must first move it there. I'm not sure that anything significant is gained by the approach you propose, except added complexity. `C-r' for history search and `C-u C-r' for normal search seems reasonable, to me. But it's your call, of course. From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Jul 2009 22:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124717832328250 (code B ref 3746); Thu, 09 Jul 2009 22:30:03 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 9 Jul 2009 22:25:23 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n69MPHnU028241 for <3746@emacsbugs.donarmstrong.com>; Thu, 9 Jul 2009 15:25:19 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.30.18.cable.starman.ee [82.131.30.18]) by mx2.starman.ee (Postfix) with ESMTP id AFF023F40F8; Fri, 10 Jul 2009 01:25:08 +0300 (EEST) From: Juri Linkov To: "Drew Adams" Cc: <3746@debbugs.gnu.org>, "'Dan Nicolaescu'" Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com> <87zlbf1kr0.fsf@mail.jurta.org> <84007A40B39D4D1F97E2E01F3B07B59F@us.oracle.com> Date: Fri, 10 Jul 2009 01:16:20 +0300 In-Reply-To: <84007A40B39D4D1F97E2E01F3B07B59F@us.oracle.com> (Drew Adams's message of "Thu, 9 Jul 2009 08:01:43 -0700") Message-ID: <871voppknf.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > And depending on context doesn't necessarily mean fewer keystrokes > (even though you never need to hit `C-u'): If the cursor is not in the > right place for the particular behavior you want, then you must first > move it there. I'm not sure that anything significant is gained by the > approach you propose, except added complexity. `C-r' for history > search and `C-u C-r' for normal search seems reasonable, to me. Generally, using C-u to modify behavior is a good thing but not for C-r since its C-u argument runs a regular expression search instead. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Jul 2009 22:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124717832328253 (code B ref 3746); Thu, 09 Jul 2009 22:30:05 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 9 Jul 2009 22:25:23 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n69MPHIN028242 for <3746@emacsbugs.donarmstrong.com>; Thu, 9 Jul 2009 15:25:19 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.30.18.cable.starman.ee [82.131.30.18]) by mx2.starman.ee (Postfix) with ESMTP id 39D823F40F9; Fri, 10 Jul 2009 01:25:09 +0300 (EEST) From: Juri Linkov To: Dan Nicolaescu Cc: 3746@debbugs.gnu.org Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> Date: Fri, 10 Jul 2009 01:19:11 +0300 In-Reply-To: <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 8 Jul 2009 16:49:20 -0700 (PDT)") Message-ID: <87ljmxo5pw.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > > Both bash and the Emacs minibuffer activate Isearch on C-s, so it > > would be natural to do the same in shell buffers. We could try the > > same context-dependent dwim approach used by the option of > > `dired-isearch-filenames', i.e. "When point is on a file name > > initially, search file names". So when point is on the shell prompt > > then run Isearch on the shell history, otherwise run Isearch on the > > shell buffer. > > That sounds fine, but it's not exclusive with M-r being an incremental > search too. > > We are at the beginning of a release cycle, so we can experiment, if the > users hate the change, there's enough time to change back. Ok, since all approaches are shaky, let's try all of them. I'll post a patch soon. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: "Drew Adams" , 3746@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Jul 2009 22:40:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.124717875429378 (code B ref 3746); Thu, 09 Jul 2009 22:40:05 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 9 Jul 2009 22:32:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from acsinet12.oracle.com (acsinet12.oracle.com [141.146.126.234]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n69MWUui029372 for <3746@emacsbugs.donarmstrong.com>; Thu, 9 Jul 2009 15:32:31 -0700 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n69MWCrv020433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jul 2009 22:32:13 GMT Received: from abhmt006.oracle.com (abhmt006.oracle.com [141.146.116.15]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n69MWTlO017325; Thu, 9 Jul 2009 22:32:30 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Jul 2009 15:32:21 -0700 From: "Drew Adams" To: "'Juri Linkov'" Cc: <3746@debbugs.gnu.org>, "'Dan Nicolaescu'" References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu><87zlblpajc.fsf@mail.jurta.org><200907051503.n65F3fDv003169@godzilla.ics.uci.edu><87ab3hxprg.fsf@mail.jurta.org><200907070121.n671LmLt029754@godzilla.ics.uci.edu><87skh8ynnm.fsf@mail.jurta.org><30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com><87zlbf1kr0.fsf@mail.jurta.org><84007A40B39D4D1F97E2E01F3B07B59F@us.oracle.com> <871voppknf.fsf@mail.jurta.org> Date: Thu, 9 Jul 2009 15:32:24 -0700 Message-ID: <0EB1F58839DE4C8EACBEF3867C69B80C@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <871voppknf.fsf@mail.jurta.org> Thread-Index: AcoA5D0I5Zh9iLboQaa4HR5CQqyQ3AAABsjg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt006.oracle.com [141.146.116.15] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010203.4A566FF5.018A:SCFSTAT5015188,ss=1,fgs=0 > > And depending on context doesn't necessarily mean fewer keystrokes > > (even though you never need to hit `C-u'): If the cursor is > > not in the right place for the particular behavior you want, > > then you must first move it there. I'm not sure that anything > > significant is gained by the approach you propose, except > > added complexity. `C-r' for history search and `C-u C-r' for > > normal search seems reasonable, to me. > > Generally, using C-u to modify behavior is a good thing but > not for C-r since its C-u argument runs a regular expression > search instead. Hm, I wonder why. ;-) I wonder why they didn't choose to have the search behavior (regexp vs plain) depend intelligently on the context (where the cursor is, what phase the moon is in,...). `C-u' seems so, well, primitive - actually leaving it up to the user to indicate explicitly what s?he means! Surely there is some smart way to second-guess the user in that case also. ;-) From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Jul 2009 23:15:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.12471810083086 (code B ref 3746); Thu, 09 Jul 2009 23:15:04 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 9 Jul 2009 23:10:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n69NA3AD003007 for <3746@emacsbugs.donarmstrong.com>; Thu, 9 Jul 2009 16:10:04 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.30.18.cable.starman.ee [82.131.30.18]) by mx2.starman.ee (Postfix) with ESMTP id CD9D53F40DD; Fri, 10 Jul 2009 02:09:57 +0300 (EEST) From: Juri Linkov To: "Drew Adams" Cc: <3746@debbugs.gnu.org>, "'Dan Nicolaescu'" Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com> <87zlbf1kr0.fsf@mail.jurta.org> <84007A40B39D4D1F97E2E01F3B07B59F@us.oracle.com> <871voppknf.fsf@mail.jurta.org> <0EB1F58839DE4C8EACBEF3867C69B80C@us.oracle.com> Date: Fri, 10 Jul 2009 02:05:16 +0300 In-Reply-To: <0EB1F58839DE4C8EACBEF3867C69B80C@us.oracle.com> (Drew Adams's message of "Thu, 9 Jul 2009 15:32:24 -0700") Message-ID: <878wixmp8z.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Generally, using C-u to modify behavior is a good thing but >> not for C-r since its C-u argument runs a regular expression >> search instead. > > Hm, I wonder why. ;-) > > I wonder why they didn't choose to have the search behavior > (regexp vs plain) depend intelligently on the context > (where the cursor is, what phase the moon is in,...). > `C-u' seems so, well, primitive - actually leaving it up > to the user to indicate explicitly what s?he means! > Surely there is some smart way to second-guess the user > in that case also. ;-) If we are going to go down this road, soon we will have only one command: M-x dwim RET ;-) -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: "Drew Adams" , 3746@debbugs.gnu.org Resent-From: "Drew Adams" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Jul 2009 23:20:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.12471813454119 (code B ref 3746); Thu, 09 Jul 2009 23:20:05 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 9 Jul 2009 23:15:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n69NFgQA004110 for <3746@emacsbugs.donarmstrong.com>; Thu, 9 Jul 2009 16:15:43 -0700 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n69NFELN024132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jul 2009 23:15:15 GMT Received: from abhmt008.oracle.com (abhmt008.oracle.com [141.146.116.17]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n69NHOGX021948; Thu, 9 Jul 2009 23:17:24 GMT Received: from dradamslap1 (/24.5.190.74) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Jul 2009 16:15:33 -0700 From: "Drew Adams" To: "'Juri Linkov'" Cc: <3746@debbugs.gnu.org>, "'Dan Nicolaescu'" References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu><87zlblpajc.fsf@mail.jurta.org><200907051503.n65F3fDv003169@godzilla.ics.uci.edu><87ab3hxprg.fsf@mail.jurta.org><200907070121.n671LmLt029754@godzilla.ics.uci.edu><87skh8ynnm.fsf@mail.jurta.org><30EDDB5AC92A422E87D113B0A49C500E@us.oracle.com><87zlbf1kr0.fsf@mail.jurta.org><84007A40B39D4D1F97E2E01F3B07B59F@us.oracle.com><871voppknf.fsf@mail.jurta.org><0EB1F58839DE4C8EACBEF3867C69B80C@us.oracle.com> <878wixmp8z.fsf@mail.jurta.org> Date: Thu, 9 Jul 2009 16:15:31 -0700 Message-ID: <336E6FF731CC4CEBAC360BF6B6D25B85@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <878wixmp8z.fsf@mail.jurta.org> Thread-Index: AcoA6mwiub+NgnloTgyl96dtA4/lyAAAKDaA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt008.oracle.com [141.146.116.17] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4A567A16.00D8:SCFSTAT5015188,ss=1,fgs=0 And then we'll need only one key: RET > If we are going to go down this road, soon we will have > only one command: M-x dwim RET ;-) From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 19 Nov 2009 17:55:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.125865293823693 (code B ref 3746); Thu, 19 Nov 2009 17:55:07 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 19 Nov 2009 17:48:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out3.starman.ee [85.253.0.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAJHmu9L023689 for <3746@emacsbugs.donarmstrong.com>; Thu, 19 Nov 2009 09:48:57 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.33.165.cable.starman.ee [82.131.33.165]) by mx1.starman.ee (Postfix) with ESMTP id 4D5E03F4133; Thu, 19 Nov 2009 19:48:50 +0200 (EET) From: Juri Linkov To: Dan Nicolaescu Cc: 3746@debbugs.gnu.org Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> <87ljmxo5pw.fsf@mail.jurta.org> Date: Thu, 19 Nov 2009 19:30:43 +0200 In-Reply-To: <87ljmxo5pw.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 10 Jul 2009 01:19:11 +0300") Message-ID: <877htmbj2s.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Please see the attached code that implements isearch in comint mode. It is not posted as a patch because it has one remaining problem: `comint-previous-input' and `comint-next-input' don't signal an error at the beginning/end of the history ring. This is unlike the minibuffer's commands `previous-history-element' and `next-history-element' that signal an error at the beginning/end of the minibuffer history. So Isearch on the minibuffer history can stop and wrap. But in comint mode Isearch with an unmatched string doesn't stop and goes into the loop. Maybe we should change `comint-previous-input' and `comint-next-input' to signal an error at the beginning/end of the history ring? --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline; filename=comint.history.isearch.el Content-Transfer-Encoding: quoted-printable ;; isearch input history (defcustom comint-history-isearch nil "Non-nil to Isearch in input history only, not in comint output. If t, Isearch in comint mode always matches only input history. If `dwim', Isearch matches input history when initial point position is at comint command line. If nil, it searches the whole comint buffer." :type '(choice (const :tag "Don't search in input history" nil) (const :tag "When point is on command line initially, search history" dw= im) (const :tag "Always search in input history" t)) :group 'comint :version "23.2") (defun comint-history-isearch-backward () "Search for a string backward in input history using Isearch." (interactive) (let ((comint-history-isearch t)) (isearch-backward))) ;; FIXME: This should be added to `comint-mode': (add-hook 'comint-mode-hook (lambda () (define-key comint-mode-map "\M-r" 'comint-history-isearch-backward) (add-hook 'isearch-mode-hook 'comint-history-isearch-setup nil t))) (defvar comint-history-isearch-message-overlay) (make-variable-buffer-local 'comint-history-isearch-message-overlay) (defun comint-history-isearch-setup () "Set up a comint for using isearch to search the input history. Intended to be added to `comint-mode-hook'." (when (or (eq comint-history-isearch t) (and (eq comint-history-isearch 'dwim) ;; Point is at command line. (comint-after-pmark-p))) (setq isearch-message-prefix-add "history ") (set (make-local-variable 'isearch-search-fun-function) 'comint-history-isearch-search) (set (make-local-variable 'isearch-message-function) 'comint-history-isearch-message) (set (make-local-variable 'isearch-wrap-function) 'comint-history-isearch-wrap) (set (make-local-variable 'isearch-push-state-function) 'comint-history-isearch-push-state) (add-hook 'isearch-mode-end-hook 'comint-history-isearch-end nil t))) (defun comint-history-isearch-end () "Clean up the comint after terminating isearch in the comint." (if comint-history-isearch-message-overlay (delete-overlay comint-history-isearch-message-overlay)) (setq isearch-message-prefix-add nil) (setq isearch-search-fun-function nil) (setq isearch-message-function nil) (setq isearch-wrap-function nil) (setq isearch-push-state-function nil) (remove-hook 'isearch-mode-end-hook 'comint-history-isearch-end t)) (defun comint-goto-input (pos) "Put input history of the absolute history position POS." ;; Logic from `comint-previous-matching-input'. ;; It should be like `goto-history-element'. (if (null comint-input-ring-index) (setq comint-stored-incomplete-input (funcall comint-get-old-input))) (setq comint-input-ring-index pos) (comint-delete-input) (when pos (insert (ring-ref comint-input-ring pos)))) (defun comint-history-isearch-search () "Return the proper search function, for isearch in input history." (cond (isearch-word (if isearch-forward 'word-search-forward 'word-search-backward)) (t (lambda (string bound noerror) (let ((search-fun ;; Use standard functions to search within comint text (cond (isearch-regexp (if isearch-forward 're-search-forward 're-search-backward)) (t (if isearch-forward 'search-forward 'search-backward)))) found) ;; Avoid lazy-highlighting matches in the comint prompt when ;; searching forward. Lazy-highlight calls this lambda with the ;; bound arg, so skip the comint prompt. (if (and bound isearch-forward (< (point) (comint-line-beginning-position)= )) (goto-char (comint-line-beginning-position))) (or ;; 1. First try searching in the initial comint text (funcall search-fun string (if isearch-forward bound (comint-line-beginning-position)) noerror) ;; 2. If the above search fails, start putting next/prev history ;; elements in the comint successively, and search the string ;; in them. Do this only when bound is nil (i.e. not while ;; lazy-highlighting search strings in the current comint text). (unless bound (condition-case nil (progn (while (not found) (cond (isearch-forward (comint-next-input 1) (goto-char (comint-line-beginning-position))) (t (comint-previous-input 1) (goto-char (point-max)))) (setq isearch-barrier (point) isearch-opoint (point)) ;; After putting the next/prev history element, search ;; the string in them again, until comint-next-input ;; or comint-previous-input raises an error at the ;; beginning/end of history. (setq found (funcall search-fun string (unless isearch-forward ;; For backward search, don't search ;; in the comint prompt (comint-line-beginning-position)) noerror))) ;; Return point of the new search result (point)) ;; Return nil when next(prev)-history-element fails (error nil))))))))) (defun comint-history-isearch-message (&optional c-q-hack ellipsis) "Display the input history search prompt. If there are no search errors, this function displays an overlay with the isearch prompt which replaces the original comint prompt. Otherwise, it displays the standard isearch message returned from `isearch-message'." (if (not (and isearch-success (not isearch-error))) ;; Use standard function `isearch-message' when not in the comint, ;; or search fails, or has an error (like incomplete regexp). ;; This function overwrites comint text with isearch message, ;; so it's possible to see what is wrong in the search string. (isearch-message c-q-hack ellipsis) ;; Otherwise, put the overlay with the standard isearch prompt over ;; the initial comint prompt. (if (overlayp comint-history-isearch-message-overlay) (move-overlay comint-history-isearch-message-overlay (save-excursion (forward-line 0) (point)) (comint-line-beginning-position)) (setq comint-history-isearch-message-overlay (make-overlay (save-excursion (forward-line 0) (point)) (comint-line-beginning-position))) (overlay-put comint-history-isearch-message-overlay 'evaporate t)) (overlay-put comint-history-isearch-message-overlay 'display (isearch-message-prefix c-q-hack ellipsis)) ;; And clear any previous isearch message. (message ""))) (defun comint-history-isearch-wrap () "Wrap the input history search when search fails. Move point to the first history element for a forward search, or to the last history element for a backward search." (unless isearch-word ;; When `comint-history-isearch-search' fails on reaching the ;; beginning/end of the history, wrap the search to the first/last ;; input history element. (if isearch-forward (comint-goto-input (length (symbol-value comint-history-variable))) (comint-goto-input nil)) (setq isearch-success t)) (goto-char (if isearch-forward (comint-line-beginning-position) (point-ma= x)))) (defun comint-history-isearch-push-state () "Save a function restoring the state of input history search. Save `comint-input-ring-index' to the additional state parameter in the search status stack." `(lambda (cmd) (comint-history-isearch-pop-state cmd ,comint-input-ring-index))) (defun comint-history-isearch-pop-state (cmd hist-pos) "Restore the input history search state. Go to the history element by the absolute history position HIST-POS." (comint-goto-input hist-pos)) --=-=-= -- Juri Linkov http://www.jurta.org/emacs/ --=-=-=-- From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Stefan Monnier , 3746@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 19 Nov 2009 21:20:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.125866515514849 (code B ref 3746); Thu, 19 Nov 2009 21:20:06 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 19 Nov 2009 21:12:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAJLCWnj014846 for <3746@emacsbugs.donarmstrong.com>; Thu, 19 Nov 2009 13:12:34 -0800 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nAJLCWrL013701; Thu, 19 Nov 2009 16:12:32 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 0560F3A0FA; Thu, 19 Nov 2009 16:12:32 -0500 (EST) From: Stefan Monnier To: Juri Linkov Cc: 3746@debbugs.gnu.org, Dan Nicolaescu Message-ID: References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> <87ljmxo5pw.fsf@mail.jurta.org> <877htmbj2s.fsf@mail.jurta.org> Date: Thu, 19 Nov 2009 16:12:31 -0500 In-Reply-To: <877htmbj2s.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 19 Nov 2009 19:30:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3410=0 > Please see the attached code that implements isearch in comint mode. What would be the "UI" (e.g. key-binding) for it? Only the comint-history-isearch defcustom? > Maybe we should change `comint-previous-input' and `comint-next-input' > to signal an error at the beginning/end of the history ring? That sounds fine to me, but pleast double check all uses of those functions to make sure it won't introduce other problems. Stefan From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 20 Nov 2009 09:45:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.125870991720104 (code B ref 3746); Fri, 20 Nov 2009 09:45:04 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 20 Nov 2009 09:38:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out3.starman.ee [85.253.0.5]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAK9cZJU020099 for <3746@emacsbugs.donarmstrong.com>; Fri, 20 Nov 2009 01:38:36 -0800 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.34.117.cable.starman.ee [82.131.34.117]) by mx1.starman.ee (Postfix) with ESMTP id 5185C3F4147; Fri, 20 Nov 2009 11:38:26 +0200 (EET) From: Juri Linkov To: Stefan Monnier Cc: 3746@debbugs.gnu.org, Dan Nicolaescu Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> <87ljmxo5pw.fsf@mail.jurta.org> <877htmbj2s.fsf@mail.jurta.org> Date: Fri, 20 Nov 2009 11:28:09 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 19 Nov 2009 16:12:31 -0500") Message-ID: <87vdh51vt2.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Please see the attached code that implements isearch in comint mode. > > What would be the "UI" (e.g. key-binding) for it? > Only the comint-history-isearch defcustom? One way to use this feature is to configure `comint-history-isearch' to a non-nil value. But I think it should be nil by default because after trying to use it with non-nil values I found it counterintuitive since in comint mode on typing `C-r' I expect it to search in the comint output, not in the input history. There is no such problem in bash where C-r searches in the input history, since there is no way to search in the bash output. So we need another key to search in the history. However, this is a controversial issue, so I will defer to others to decide what key to use for that. (In the code I sent, there is a command `comint-history-isearch-backward' that could be bound to any key.) -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#3746: M-r in comint mode should use isearch Reply-To: Juri Linkov , 3746@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 23 Nov 2009 20:55:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.125900931719951 (code B ref 3746); Mon, 23 Nov 2009 20:55:06 +0000 Received: (at 3746) by emacsbugs.donarmstrong.com; 23 Nov 2009 20:48:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nANKmZ1Q019944 for <3746@emacsbugs.donarmstrong.com>; Mon, 23 Nov 2009 12:48:36 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.34.24.cable.starman.ee [82.131.34.24]) by mx2.starman.ee (Postfix) with ESMTP id DE6413F40D9; Mon, 23 Nov 2009 22:48:29 +0200 (EET) From: Juri Linkov To: Stefan Monnier Cc: 3746@debbugs.gnu.org, Dan Nicolaescu Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> <87ljmxo5pw.fsf@mail.jurta.org> <877htmbj2s.fsf@mail.jurta.org> Date: Mon, 23 Nov 2009 22:39:51 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 19 Nov 2009 16:12:31 -0500") Message-ID: <87zl6dxkiw.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Maybe we should change `comint-previous-input' and `comint-next-input' >> to signal an error at the beginning/end of the history ring? > > That sounds fine to me, but pleast double check all uses of those > functions to make sure it won't introduce other problems. To avoid possible problems, I installed a non-intrusive implementation that signals an error inside `comint-history-isearch-search' before calling `comint-next-input' or `comint-previous-input'. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Tue Jun 17 01:43:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Dan Nicolaescu Subject: bug#3746 closed by Juri Linkov (Re: bug#3746: M-r in comint mode should use isearch) Message-ID: References: <87ocmknicw.fsf@mail.jurta.org> <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> X-Emacs-PR-Message: they-closed 3746 X-Emacs-PR-Package: emacs Reply-To: 3746@debbugs.gnu.org Date: Mon, 30 Nov 2009 16:30:12 +0000 Content-Type: multipart/mixed; boundary="----------=_1259598612-32379-1" This is a multi-part message in MIME format... ------------=_1259598612-32379-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #3746: M-r in comint mode should use isearch It has been closed by Juri Linkov . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Juri Linkov by replying to this email. --=20 3746: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D3746 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1259598612-32379-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3746-done) by emacsbugs.donarmstrong.com; 30 Nov 2009 16:22:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGMGpn031750 for <3746-done@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 08:22:18 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx2.starman.ee (Postfix) with ESMTP id D5E5C3F4047; Mon, 30 Nov 2009 18:22:10 +0200 (EET) From: Juri Linkov To: Stefan Monnier Cc: 3746-done@debbugs.gnu.org, Dan Nicolaescu Subject: Re: bug#3746: M-r in comint mode should use isearch Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> <87ljmxo5pw.fsf@mail.jurta.org> <877htmbj2s.fsf@mail.jurta.org> <87vdh51vt2.fsf@mail.jurta.org> Date: Mon, 30 Nov 2009 18:12:45 +0200 In-Reply-To: <87vdh51vt2.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 20 Nov 2009 11:28:09 +0200") Message-ID: <87ocmknicw.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> What would be the "UI" (e.g. key-binding) for it? >> Only the comint-history-isearch defcustom? > > One way to use this feature is to configure `comint-history-isearch' to > a non-nil value. But I think it should be nil by default because after > trying to use it with non-nil values I found it counterintuitive since > in comint mode on typing `C-r' I expect it to search in the comint output, > not in the input history. > > There is no such problem in bash where C-r searches in the input history, > since there is no way to search in the bash output. > > So we need another key to search in the history. However, this is > a controversial issue, so I will defer to others to decide what key > to use for that. (In the code I sent, there is a command > `comint-history-isearch-backward' that could be bound to any key.) To help to select a key binding, below is a table of current key bindings: * Bash: M-p non-incremental-reverse-search-history M-n non-incremental-forward-search-history M-r revert-line C-r reverse-search-history C-s forward-search-history C-p previous-history C-n next-history * Emacs comint mode: M-p comint-previous-input M-n comint-next-input M-r comint-previous-matching-input M-s comint-next-matching-input C-r isearch-backward C-s isearch-forward C-p previous-line C-n next-line So I now agree with the subject of bug#3746 that says "M-r in comint mode should use isearch" I marked bug#3746 as closed with M-r bound to the new command that uses Isearch, added corresponding menu items, removed M-s (that was symmetrical to M-r) to expose the global key binding M-s for comint with removing one problem from the list of problems in FOR-RELEASE that used to say: 3. Shell mode binds `M-s' to `comint-next-matching-input'. This key binding can be changed later when we will implement incremental search through the shell history. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1259598612-32379-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 3 Jul 2009 18:15:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n63IF2ja005442 for ; Fri, 3 Jul 2009 11:15:03 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MMioX-0000hr-EJ for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MMioT-0000cb-R7 for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:29 -0400 Received: from [199.232.76.173] (port=40895 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MMioT-0000cY-Lp for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:25 -0400 Received: from sallyv2.ics.uci.edu ([128.195.1.120]:47612) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MMioT-0005wj-93 for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:25 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n63DQfRL027172 for ; Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n63DQfPA027629; Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Date: Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Message-Id: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: M-r in comint mode should use isearch Lines: 11 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n63DQfRL027172 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) When using the minibuffer for example doing: M-x then C-r will use isearch to search the history. This is nice because it shows the items that are matched. M-r should to the same thing when used in comint, right now it's hard to tell if it matches anything before typing RET ------------=_1259598612-32379-1--