From unknown Mon Jun 16 23:47:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37459 <37459@debbugs.gnu.org> To: bug#37459 <37459@debbugs.gnu.org> Subject: Status: 26.2; sql syntax highlight problem when escaping single quote Reply-To: bug#37459 <37459@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:47:29 +0000 retitle 37459 26.2; sql syntax highlight problem when escaping single quote reassign 37459 emacs submitter 37459 ndame severity 37459 minor tag 37459 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 08:50:17 2019 Received: (at submit) by debbugs.gnu.org; 19 Sep 2019 12:50:17 +0000 Received: from localhost ([127.0.0.1]:55258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAvt2-00058i-T2 for submit@debbugs.gnu.org; Thu, 19 Sep 2019 08:50:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:35765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAvsz-00058Y-Q6 for submit@debbugs.gnu.org; Thu, 19 Sep 2019 08:50:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41468) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAvsw-0006KH-VI for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2019 08:50:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: *** X-Spam-Status: No, score=3.2 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAvjf-0006UA-LR for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2019 08:40:36 -0400 Received: from fmfe24.onbox.hu ([46.107.16.229]:32870 helo=web-out.onbox.hu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iAvjf-0006G7-4O for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2019 08:40:35 -0400 X-fm-smtp-source: yes Received: from localhost (localhost [84.236.92.174]) by web-out.onbox.hu (Postfix) with SMTP id 46YxJn3K1GzGpt for ; Thu, 19 Sep 2019 14:40:25 +0200 (CEST) Date: Thu, 19 Sep 2019 12:39:33 +0000 (GMT) From: ndame Message-ID: Subject: 26.2; sql syntax highlight problem when escaping single quote MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_4166_989323815.1568896773058" To: "bug-gnu-emacs@gnu.org" X-AccountId: 57978162 X-Originating-Ip: 84.236.92.174 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvddtgdehiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdcuhfftgffgofetkffnnecuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhkffugggtvfhisegrtdersgdttdejnecuhfhrohhmpehnuggrmhgvuceovghmrggtshhushgvrhesfhhrvggvmhgrihhlrdhhuheqnecuffhomhgrihhnpehimhhguhhrrdgtohhmnecukfhppeekgedrvdefiedrledvrddujeegnecurfgrrhgrmhephhgvlhhopedpihhnvghtpeekgedrvdefiedrledvrddujeegpdhmrghilhhfrhhomhepvghmrggtshhushgvrhesfhhrvggvmhgrihhlrdhhuhdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/relaxed; t=1568896825; s=20181004; d=freemail.hu; h=Date:From:Message-ID:Subject:MIME-Version:Content-Type:To; l=760; bh=/inyA6sWCzluMixr7cCueHPiSKEadZAseHSAJC91gaE=; b=y+iAtDO7PSxGP6gJXbMxNhHEtNvfqIlRnyyo2yeiPK0B6AwenBvY6Fy7/RiOf7lx 2W1xMVhOsjwYExu6xphiQWwQoUnHbyXVurqalrUG1gOpup5sjGAsoBi64L5Vs/rIA2v gCQsx+4BtpO3NTE8H2qr/C3+WypKFEzFjpaPnyPIFlk7exL0037HlYioo+iUXs2ax6Q SvjsaXtG/0Alh2WeqhzBWSGGZ/YRZsb9O+nNFYppobp1Z4Azogz62HWDgEQ6L7vIgd7 6IRmaxUWRSGyUZOE+/wFV0lZc17LjXMTOEdzwQGxjMZZN27eU7KOAsClUFFO9wPiJdM GXkmkZ8ojQ== X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 46.107.16.229 X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: If you try this simple sql   insert into test (test) values ('test\'test') then the string is not highlighted properly: Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: freemail.hu] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (emacsuser[at]freemail.hu) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 HTML_MESSAGE BODY: HTML included in message 2.4 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) ------=_Part_4166_989323815.1568896773058 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable If you try this simple sql =C2=A0 insert into test (test) values ('test\'test') then the string is not highlighted properly: https://i.imgur.com/DE9TJUP.png I guess it's a bug. =C2=A0 ------=_Part_4166_989323815.1568896773058 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit If you try this simple sql

  insert into test (test) values ('test\'test')

then the string is not highlighted properly:

https://i.imgur.com/DE9TJUP.png

I guess it's a bug.
  ------=_Part_4166_989323815.1568896773058-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 20 09:29:05 2019 Received: (at 37459) by debbugs.gnu.org; 20 Sep 2019 13:29:05 +0000 Received: from localhost ([127.0.0.1]:56983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIy9-0006y6-8t for submit@debbugs.gnu.org; Fri, 20 Sep 2019 09:29:05 -0400 Received: from fmfe09.onbox.hu ([46.107.16.202]:27344 helo=web-out.onbox.hu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBIy6-0006xh-6w for 37459@debbugs.gnu.org; Fri, 20 Sep 2019 09:29:03 -0400 X-fm-smtp-source: yes Received: from localhost (localhost [94.21.250.143]) by web-out.onbox.hu (Postfix) with SMTP id 46ZZLG724rzVpF for <37459@debbugs.gnu.org>; Fri, 20 Sep 2019 15:28:54 +0200 (CEST) From: ndame To: "37459@debbugs.gnu.org" <37459@debbugs.gnu.org> Message-ID: In-Reply-To: References: Subject: Re: bug#37459: 26.2; sql syntax highlight problem when escaping single quote MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_7576_1734759372.1568985933475" X-AccountId: 57978162 X-Originating-Ip: 94.21.250.143 Date: Fri, 20 Sep 2019 15:28:54 +0200 (CEST) X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvddvgdehhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdcuhfftgffgofetkffnnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvkfgjfhfugggtihffsegrtdersgdttddunecuhfhrohhmpehnuggrmhgvuceovghmrggtshhushgvrhesfhhrvggvmhgrihhlrdhhuheqnecuffhomhgrihhnpehmhihsqhhlrdgtohhmnecukfhppeelgedrvddurddvhedtrddugeefnecurfgrrhgrmhephhgvlhhopedpihhnvghtpeelgedrvddurddvhedtrddugeefpdhmrghilhhfrhhomhepvghmrggtshhushgvrhesfhhrvggvmhgrihhlrdhhuhdprhgtphhtthhopeefjeegheelseguvggssghughhsrdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/relaxed; t=1568986135; s=20181004; d=freemail.hu; h=From:To:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Date; l=4483; bh=PGRSO/PA/soHO9xKesKfckT7hQb+JdjkWqVYFzq2NrE=; b=ZJsQZKBr+oEdoUOjeX8i2augf1yfNhQoMYZS2C228LVM++OnyhcZeru+mQz8y/DQ JrfmP4ohpzQphLJ7BuAEa8LfGyl1V/Mnr0hVASlr0PKNaBurBEGONndX7JqYSUgVf3O WmnpfA2HA669iSbonqQKKsFRvruvtfHb6u0ephGPf+U+zAGR0PA/g5uDfRA0WwilCH+ Ul1kZhuA4jMCCa5hhzfp0Fw+ouUZY4lp0ZoA4+QXoS59Kec+iMrEF3SD7REAH+NNwi3 0KlvDo1NLLIWbG/2CN9q+KziZjZO4yBUijCGqXAS/Jev/WjKzdK4QrtDjEApq1A5qOp IpS3lo2Hpg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37459 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------=_Part_7576_1734759372.1568985933475 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I poked around for the problem and found this in sql-mode Help: =C2=A0 Note that SQL doesn't have an escape character unless you specify =C2=A0 one. =C2=A0If you specify backslash as escape character in SQL, you =C2=A0 must tell Emacs. =C2=A0Here's how to do that in your init file: =C2=A0 (add-hook 'sql-mode-hook =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda () =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (modify-syntax-entry ?\\ "= ." sql-mode-syntax-table))) And sure enough, the syntax of \ was punctuation. However, adding the above add hook did nothing. The string highlighting was still wrong. It's because the suggestion is wrong, because it sets slash to punctuation again. Somebody who has access to the repo could simply fix that by changing the syntax string in the example: =C2=A0 (modify-syntax-entry ?\\ "\\" sql-mode-syntax-table) So it worked, but then I realized there are different sql modes and the default is ANSI, so I changed it to Mysql to test it, but that didn't help either. Then I checked the mysql syntax setting and backslash was missing there too, though backslash is an escape character for mysql by default: =C2=A0 https://dev.mysql.com/doc/refman/8.0/en/string-literals.html So I changed the syntax for mysql by adding backslash: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:syntax-alist ((?# . "< b") (?\\ .= "\\")) and this fixed it. There are 3 takeaways: 1. The incorrect example in sql-mode Help should be fixed. 2. Since backslash is an escape character in mysql it may be set as =C2=A0 =C2=A0such by default if the user chooses mysql mode. 3. The user may not realize he is in an incorrect sql mode. Maybe when =C2=A0 =C2=A0the user activates sql mode for the first time emacs should te= ll him =C2=A0 =C2=A0that ansi is the default and ask him if he wants to change it? =C2=A0 =C2=A0 ------=_Part_7576_1734759372.1568985933475 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I poked around for the problem and found this in sql-mode Help:

  Note that SQL doesn't have an escape character unless you specify
  one.  If you specify backslash as escape character in SQL, you
  must tell Emacs.  Here's how to do that in your init file:

  (add-hook 'sql-mode-hook
            (lambda ()
              (modify-syntax-entry ?\\ "." sql-mode-syntax-table)))


And sure enough, the syntax of \ was punctuation.

However, adding the above add hook did nothing. The string
highlighting was still wrong.

It's because the suggestion is wrong, because it sets slash to
punctuation again.

Somebody who has access to the repo could simply fix that by changing
the syntax string in the example:

  (modify-syntax-entry ?\\ "\\" sql-mode-syntax-table)


So it worked, but then I realized there are different sql modes and
the default is ANSI, so I changed it to Mysql to test it, but that
didn't help either.

Then I checked the mysql syntax setting and backslash was missing
there too, though backslash is an escape character for mysql by
default:

  https://dev.mysql.com/doc/refman/8.0/en/string-literals.html

So I changed the syntax for mysql by adding backslash:

           :syntax-alist ((?# . "< b") (?\\ . "\\"))

and this fixed it.


There are 3 takeaways:

1. The incorrect example in sql-mode Help should be fixed.

2. Since backslash is an escape character in mysql it may be set as
   such by default if the user chooses mysql mode.

3. The user may not realize he is in an incorrect sql mode. Maybe when
   the user activates sql mode for the first time emacs should tell him
   that ansi is the default and ask him if he wants to change it?
    ------=_Part_7576_1734759372.1568985933475-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 11:53:54 2019 Received: (at 37459) by debbugs.gnu.org; 26 Oct 2019 15:53:55 +0000 Received: from localhost ([127.0.0.1]:41360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOOO2-0001GW-7H for submit@debbugs.gnu.org; Sat, 26 Oct 2019 11:53:54 -0400 Received: from mail-lj1-f176.google.com ([209.85.208.176]:44459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iONqa-0000NI-8k for 37459@debbugs.gnu.org; Sat, 26 Oct 2019 11:19:21 -0400 Received: by mail-lj1-f176.google.com with SMTP id c4so6508779lja.11 for <37459@debbugs.gnu.org>; Sat, 26 Oct 2019 08:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hole-priv-no.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=HlnBcZNci/wFhhZG12ubDjeCIv84E7PVmD6+nMwyeYE=; b=qlR9itrmjzdSXEnPywzg79Sz63eVMGeUy5Ny0EyiSW+c4Md+tFlBtERLrKO0VcuQZb thjf1jMDqPet1OxtlohJw0G2WbvxD6fVezoCiZuHL9aczBwclX90vKsD+UrC+A/7tdaj kcf8TdT/V+HW/lj7y3Dj8MJia+pvpzsmffdsnK4zdE7eX9mQCggEDFLdMgpPAZ1rUOPQ QtydzH6w0JXAvyBe//pNxDHXNvlvCHNErQCDHOsc26dyNCruoOuJj2Zp5G10BNd7pXcr VuhrfMyVhZzik4KTkRZ2O+KpawM1gPnwe1P4WuNbLDqNDYkOPB1OkoQbmw8n9lZdffbk S7Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=HlnBcZNci/wFhhZG12ubDjeCIv84E7PVmD6+nMwyeYE=; b=SnPr8K3nY2sNUCTktIZARjDzxYrIZu80TlgjIFUEIJypoDkGHE/f/RiOOv+m7o8TTD 1esrWAsszQ7o5IiD6xt3pzGIVArDozRvhtZTQU9VuSZvPGDQALU8qpch8iY+cIxcdyA9 cRnYMG/w8/6WljUBiGC48aWd3a5eaHfQ2fQrhMzyRVsq8PFTMXi2gVrjz3e5zllTo9CL H0UdWCOtrTHFoZeL5H2kidsdGaL+mPV+FjzAUX5KnFXxS4hxE64JMF/QTCq7TurQ4bJE m9TL8XGb0r/eaI73Zv/z6BHV7vrl9UDB7ci2r7yNu8XacCB818VDYyMhhmfd1/wQzBJk jN8g== X-Gm-Message-State: APjAAAXSa6TupP892PQR4M/Eatt+yWcBXDAbYgOknnZGLYR+wrWBWC4r PyAvdpAWbrmJxTNoAyowbj9AlTTkipc5L2W0QauPSFn74Hk= X-Google-Smtp-Source: APXvYqwgGBzn2FBlgZFkTGXk76k2rc3c8Lyqg1FMYwVIGhYcARUfcPCverGLqYJqdMzsNOvMHhjbDmi+Xgb/bZM4YVQ= X-Received: by 2002:a2e:5d1:: with SMTP id 200mr2788147ljf.50.1572103153938; Sat, 26 Oct 2019 08:19:13 -0700 (PDT) MIME-Version: 1.0 From: Kristian Hole Date: Sat, 26 Oct 2019 17:19:00 +0200 Message-ID: Subject: Re: bug#37459: Corrects sql-mode help about escape character syntax To: 37459@debbugs.gnu.org Content-Type: multipart/mixed; boundary="0000000000000a99230595d1cacd" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37459 X-Mailman-Approved-At: Sat, 26 Oct 2019 11:53:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000a99230595d1cacd Content-Type: multipart/alternative; boundary="0000000000000a99200595d1cacb" --0000000000000a99200595d1cacb Content-Type: text/plain; charset="UTF-8" --0000000000000a99200595d1cacb Content-Type: text/html; charset="UTF-8"
--0000000000000a99200595d1cacb-- --0000000000000a99230595d1cacd Content-Type: application/octet-stream; name="0001-Corrects-sql-mode-help-about-escape-character-syntax.patch" Content-Disposition: attachment; filename="0001-Corrects-sql-mode-help-about-escape-character-syntax.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k27plon10 RnJvbSA0OWEwYWYwMDVkNzcwY2VkYzU0YTk1NGE4MTFjOTAzYjhkZmU5YTkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBrYWhvbGUgPGtyaXN0aWFuQGhvbGUucHJpdi5ubz4KRGF0ZTog U2F0LCAyNiBPY3QgMjAxOSAxNzowNzoyNyArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBDb3Jy ZWN0cyBzcWwtbW9kZSBoZWxwIGFib3V0IGVzY2FwZSBjaGFyYWN0ZXIgc3ludGF4CgpDaGFuZ2Vz IHRoZSBleGFtcGxlIGZyb20gdGhlIGluY29ycmVjdCB1c2Ugb2YKcHVuY3R1YXRpb24gcnVsZSwg dG8gdGhlIGVzY2FwZSBjaGFyYWN0ZXIgcnVsZSAoQnVnIzM3NDU5KS4KLS0tCiBsaXNwL3Byb2dt b2Rlcy9zcWwuZWwgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9zcWwuZWwgYi9saXNwL3Byb2dt b2Rlcy9zcWwuZWwKaW5kZXggYjE3MzY0YjA4Zi4uZjk4NTE1NzIwMiAxMDA2NDQKLS0tIGEvbGlz cC9wcm9nbW9kZXMvc3FsLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3NxbC5lbApAQCAtNDI0NCw3 ICs0MjQ0LDcgQEAgc3FsLW1vZGUKIAogXChhZGQtaG9vayBcXD0nc3FsLW1vZGUtaG9vawogICAg ICAgICAgIChsYW1iZGEgKCkKLQkgICAgKG1vZGlmeS1zeW50YXgtZW50cnkgP1xcXFwgXCIuXCIg c3FsLW1vZGUtc3ludGF4LXRhYmxlKSkpIgorCSAgICAobW9kaWZ5LXN5bnRheC1lbnRyeSA/XFxc XCBcIlxcXFxcIiBzcWwtbW9kZS1zeW50YXgtdGFibGUpKSkiCiAgIDpncm91cCAnU1FMCiAgIDph YmJyZXYtdGFibGUgc3FsLW1vZGUtYWJicmV2LXRhYmxlCiAKLS0gCjIuMTguMAoK --0000000000000a99230595d1cacd-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 26 11:53:55 2019 Received: (at 37459) by debbugs.gnu.org; 26 Oct 2019 15:53:55 +0000 Received: from localhost ([127.0.0.1]:41362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOOO2-0001GY-UL for submit@debbugs.gnu.org; Sat, 26 Oct 2019 11:53:55 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:46880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iONx3-0000Ye-Ra for 37459@debbugs.gnu.org; Sat, 26 Oct 2019 11:26:02 -0400 Received: by mail-lj1-f171.google.com with SMTP id w8so2037059lji.13 for <37459@debbugs.gnu.org>; Sat, 26 Oct 2019 08:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hole-priv-no.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=IcmKBFvaepmTE3vNlQysCMAX8c9D9p190uvhx9GwLHc=; b=E+QAHO9EdvoGw2SQtruhsINuJOuK2pztwQ6LtUvN94AJ2FGNzORWzMbMA+HA9P/oeM 6uQhBlRfQkCSz8c6Pb/ZF6nz6pLiBq+Odw3zrQZiq+FTPnMnTtfezW08gvBPV0wkl6WD QenDoKZxZyaitLELUYdbe/+mku6oTj6xhTHx9GPOPVrwKCQBiyqok1gRd4rC93cr0AV0 tkwySkGkr1vw66nVv5/LtN1N3t5NjVmQabx+/lfRlWI5YSIbIGcXL9icDvXGSob/Je8E t7c52/CIdARwvAxJEdGq9vaPPO1M5tmSUPNkUe8jbJfTXzmISaSyzFM93Qr3EIbYb79m 3lkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IcmKBFvaepmTE3vNlQysCMAX8c9D9p190uvhx9GwLHc=; b=aUQsPIL0RFWVd8pl8B5FNCEUL6j/u+bCE94W/0jHH0BJkcXbGZBT2kqhOV1fa34N7m J2AOtF3am8K08H4GhPBfgDrGnzhGmjkGyQS6+X3uX5WJCXqsHwm4LiiRWRDSdDZ0YCBR MUPuDL0dYKtLAd4DyGpy+NHLA432wStjEKM7ZP5V5BqQkht520nDNx0b63pLK/Ibtexx Q34iM4+dgD1bu/9Bfb5AaNdaJc5QioEyQwJv9PqWXlltj8ngMtCpp1owQ4GLADri24MA 3cSi1ETdvZb+Zv4yGyRfM6PabJHV7J+adiVhP3LPU1PlhIsXu4ntYiB3B7++FozW3ncO zCrg== X-Gm-Message-State: APjAAAWABcohfhy1crgjBr4xKgx0CJ2u52Cz+GiaiT1KtSJd9GGt7bnV T9KYMA1Qt21I0Rvs8yQzX7iy1TOXp8/hxBBHipfQrYV/SPJxtA== X-Google-Smtp-Source: APXvYqzZZkz6NMK6/lVWtUWzYEb2LSi0FHMYXhLUemOeAJ/6aMh4hGZV84OxMAFXAR/vze+vPPFPkt/rfKikKd9N7JQ= X-Received: by 2002:a2e:7c13:: with SMTP id x19mr6434199ljc.0.1572103555419; Sat, 26 Oct 2019 08:25:55 -0700 (PDT) MIME-Version: 1.0 From: Kristian Hole Date: Sat, 26 Oct 2019 17:25:42 +0200 Message-ID: Subject: Re: bug#37459: Adds backslash as escape character to mysql syntax-alist To: 37459@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000f8b8bc0595d1e188" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37459 X-Mailman-Approved-At: Sat, 26 Oct 2019 11:53:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f8b8bc0595d1e188 Content-Type: multipart/alternative; boundary="000000000000f8b8b90595d1e186" --000000000000f8b8b90595d1e186 Content-Type: text/plain; charset="UTF-8" I've generated patches for takeaways (1) and (2) Patch attached to previous message: Corrects sql-mode help about escape character syntax Changes the example from the incorrect use of punctuation rule, to the escape character rule (Bug#37459). This patch: Adds backslash as escape character to mysql syntax-alist In MySQL syntax backslash denotes an escape sequence. This change adds backslash to the syntax-alist of MySQL in sql-mode as per (Bug#37459). --000000000000f8b8b90595d1e186 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I've generated patches for takeaways (1) and (2)= =C2=A0

Patch attached to previous message:
=C2=A0 Corrects sql-= mode help about escape character syntax

=C2=A0 Changes the exam= ple from the incorrect use of
=C2=A0 punctuation rule, to the escape cha= racter rule (Bug#37459).

This patch:
=C2=A0 Adds = backslash as escape character to mysql syntax-alist

=C2= =A0 In MySQL syntax backslash denotes an escape sequence.
=C2=A0 This ch= ange adds backslash to the syntax-alist of
=C2=A0 MySQL in sql-mode as p= er (Bug#37459).
--000000000000f8b8b90595d1e186-- --000000000000f8b8bc0595d1e188 Content-Type: application/octet-stream; name="0002-Adds-backslash-as-escape-character-to-mysql-syntax-a.patch" Content-Disposition: attachment; filename="0002-Adds-backslash-as-escape-character-to-mysql-syntax-a.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k27pura00 RnJvbSA0OTUzZDdiYjI0OTUwMmZkOGQ4NzI5NWI4MWJkMzgxZTcwMTM0ZmMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBrYWhvbGUgPGtyaXN0aWFuQGhvbGUucHJpdi5ubz4KRGF0ZTog U2F0LCAyNiBPY3QgMjAxOSAxNzowODoxNyArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBBZGRz IGJhY2tzbGFzaCBhcyBlc2NhcGUgY2hhcmFjdGVyIHRvIG15c3FsIHN5bnRheC1hbGlzdAoKSW4g TXlTUUwgc3ludGF4IGJhY2tzbGFzaCBkZW5vdGVzIGFuIGVzY2FwZSBzZXF1ZW5jZS4KVGhpcyBj aGFuZ2UgYWRkcyBiYWNrc2xhc2ggdG8gdGhlIHN5bnRheC1hbGlzdCBvZgpNeVNRTCBpbiBzcWwt bW9kZSBhcyBwZXIgKEJ1ZyMzNzQ1OSkuCi0tLQogbGlzcC9wcm9nbW9kZXMvc3FsLmVsIHwgMiAr LQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvbGlzcC9wcm9nbW9kZXMvc3FsLmVsIGIvbGlzcC9wcm9nbW9kZXMvc3FsLmVsCmluZGV4 IGY5ODUxNTcyMDIuLjgxZTBkOGNmODkgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3NxbC5l bAorKysgYi9saXNwL3Byb2dtb2Rlcy9zcWwuZWwKQEAgLTQ2MSw3ICs0NjEsNyBAQCBzcWwtcHJv ZHVjdC1hbGlzdAogICAgICA6cHJvbXB0LXJlZ2V4cCAiXm15c3FsPiAiCiAgICAgIDpwcm9tcHQt bGVuZ3RoIDYKICAgICAgOnByb21wdC1jb250LXJlZ2V4cCAiXiAgICAtPiAiCi0gICAgIDpzeW50 YXgtYWxpc3QgKCg/IyAuICI8IGIiKSkKKyAgICAgOnN5bnRheC1hbGlzdCAoKD8jIC4gIjwgYiIp ICg/XFwgLiAiXFwiKSkKICAgICAgOmlucHV0LWZpbHRlciBzcWwtcmVtb3ZlLXRhYnMtZmlsdGVy KQogCiAgICAgKG9yYWNsZQotLSAKMi4xOC4wCgo= --000000000000f8b8bc0595d1e188-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 08:05:11 2019 Received: (at control) by debbugs.gnu.org; 28 Oct 2019 12:05:11 +0000 Received: from localhost ([127.0.0.1]:43967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP3ln-000165-3z for submit@debbugs.gnu.org; Mon, 28 Oct 2019 08:05:11 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:34327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP3lk-00015X-9u for control@debbugs.gnu.org; Mon, 28 Oct 2019 08:05:09 -0400 Received: by mail-lf1-f47.google.com with SMTP id f5so7609734lfp.1 for ; Mon, 28 Oct 2019 05:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hole-priv-no.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=NZAqezhb+Kjovg0PFfXNsi8fJCKyLUi7HJdtaIl39AE=; b=CoiIeN7SVhhdT4MRfa91aY75TegmdNWS+rI86BnCkkRfgd0XEIEjeysFd7uma5w5W8 dnN2xEvnNGSfO5qZQsmBQfES7GNQ0Z4qHiiJcumMzK1JhfRd7n9fDW/39k8n+AjyujWA tDdW3byUSspUn72NvXKTCn+JVPVKlgeZ73WkTJx3ped4trpuE+nC8c5ZPWIntPNlWb9L zd3GcdSwEtp5hEMvKfgFK9HAIJZYUSJeneVp2foaBL3/E8Qw0YdgYpcwLtP+F8nj+lCA l88mHLo401qiy/i0B8xD/W3wxh2MpP4h2ovXwOqqRMhblvbjMkqvoSzweoG8UtLw3fT/ NY2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NZAqezhb+Kjovg0PFfXNsi8fJCKyLUi7HJdtaIl39AE=; b=iMCnjGx87xQgK+D6XLAqN+wulPmbdAp6sxECFg3dMgUkPhYUSe1SjC+9eEfwh4Fdeu r1O8ITGJP/E4POMHNgTQnT1EvWdoO/ptmnLHe8IflvuFwoQh8fM2zsCxOzAgc2St3+5k DNRwD/i5ivN8UzJkoGxRJ32xLXYZKP44ufMRWDYJyrA6y2eHpoQfgBG5rz+GAUz/Wo3Y 5vyGd+bsLWDJug4eBOrAAhUj1OrJwl90JnjqNcLZgdv2jzKAEx/IT/caCz7fJL6/kkXN 8eq8x9pf4MqFxZhnUEdf+mqxWTvkiNZZ4o/tLUji7J2WBniBdyaiSZGSEOS807uXMAMT 9qdA== X-Gm-Message-State: APjAAAUvo5D69gUZjatkIaLMLldn/uL1lwD1487OFAiUdHyePyG8/cJm QZoKLSLd5QX454TaaZZNLzjeYP9zkirKkojwbtuekdAjZgz7tw== X-Google-Smtp-Source: APXvYqxD3LVGzb9Bmol3BZf0FjPxIAVaIoBsmMpEqHB4fSBr2DV5tLH3qh9lzdCRY6kPcXFXIwitUiJmjROoKFCz+EY= X-Received: by 2002:a19:4318:: with SMTP id q24mr11034995lfa.12.1572264301630; Mon, 28 Oct 2019 05:05:01 -0700 (PDT) MIME-Version: 1.0 From: Kristian Hole Date: Mon, 28 Oct 2019 13:04:27 +0100 Message-ID: Subject: Re: bug#37459: Adds backslash as escape character to mysql To: control@debbugs.gnu.org Content-Type: multipart/alternative; boundary="0000000000003128740595f74fcd" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003128740595f74fcd Content-Type: text/plain; charset="UTF-8" tags 37459 + patch --0000000000003128740595f74fcd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tags=C2=A037459=C2= =A0+ patch
--0000000000003128740595f74fcd-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 09:44:50 2019 Received: (at 37459) by debbugs.gnu.org; 22 Nov 2019 14:44:50 +0000 Received: from localhost ([127.0.0.1]:54043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYAAz-0000wR-MH for submit@debbugs.gnu.org; Fri, 22 Nov 2019 09:44:49 -0500 Received: from fmfe26.onbox.hu ([46.107.16.231]:28895 helo=web-out.onbox.hu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYAAx-0000wC-Jg for 37459@debbugs.gnu.org; Fri, 22 Nov 2019 09:44:48 -0500 X-fm-smtp-source: yes Received: from localhost (localhost [84.236.30.241]) by web-out.onbox.hu (Postfix) with SMTP id 47KK2c2wf1zNr6 for <37459@debbugs.gnu.org>; Fri, 22 Nov 2019 15:44:37 +0100 (CET) From: ndame To: "37459@debbugs.gnu.org" <37459@debbugs.gnu.org> Message-ID: In-Reply-To: References: Subject: Re: bug#37459: Acknowledgement (26.2; sql syntax highlight problem when escaping single quote) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_1542_1164885660.1574433525529" X-AccountId: 57978162 X-Originating-Ip: 84.236.30.241 Date: Fri, 22 Nov 2019 15:44:37 +0100 (CET) X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudehgedgieejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpucfhtffggffotefknfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffkjghfufggtghiffesrgdtregstddtjeenucfhrhhomhepnhgurghmvgcuoegvmhgrtghsuhhsvghrsehfrhgvvghmrghilhdrhhhuqeenucfkphepkeegrddvfeeirdeftddrvdegudenucfrrghrrghmpehhvghloheppdhinhgvthepkeegrddvfeeirdeftddrvdeguddpmhgrihhlfhhrohhmpegvmhgrtghsuhhsvghrsehfrhgvvghmrghilhdrhhhupdhrtghpthhtohepfeejgeehleesuggvsggsuhhgshdrghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/relaxed; t=1574433880; s=20181004; d=freemail.hu; h=From:To:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Date; l=4339; bh=IsfKEhy5y/BlW6v9dbSCyfgvIXlIjnOEKPEb1mMYhmU=; b=P0ADuatRIISO9Iv+r3+BwyT19JV+K/A8LT0rcRqivQfq9KAmO6Xk6zRoqqCsz8mi IFanrOM6GgHl+QHkRn4D6QMz4pAsv0VV/vs5WZBDvp2IDHbDKpFcvtvx8kW6caQrkZZ ssHR1SusrmTBodMdqDBoizyerjseRBvKnmHv1l9818JB13lq4SgckbqS9M3bHSqWubK Xg4FYJ2RTnxy/da4OWGGwiVaWZTaJyUuAgCoEYOuUby4CDhZ/fUmtLcHKAV2mO7aG/s vPn7aaH1nma43zEswehagXy+9Q+wNTtz0Eufl/UjdkUqs3xOjUu5SWv3u3FEds1PwFo Av6A5A7FUw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37459 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------=_Part_1542_1164885660.1574433525529 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Browsing sql.el I found this code: =C2=A0 ;; MariaDB is a drop-in replacement for MySQL, so just make the ;; MariaDB variables aliases of the MySQL ones. =C2=A0 (defvaralias 'sql-mariadb-program 'sql-mysql-program) (defvaralias 'sql-mariadb-options 'sql-mysql-options) (defvaralias 'sql-mariadb-login-params 'sql-mysql-login-params) =C2=A0 =C2=A0 If mariadb is a drop in mysql replacement then all mysql-related fixes should apply to it too, though later in the code mariadb sets up syntax independetly, so the same bug affects it which the patch here fixes. The correct solution could be setting up a mariadb syntax variable and alias it to the mysql syntax variable to avoid duplicating the same cod= e: =C2=A0 (mariadb :name "MariaDB" :free-software t :font-lock sql-mode-mariadb-font-lock-keywords :sqli-program sql-mariadb-program :sqli-options sql-mariadb-options :sqli-login sql-mariadb-login-params :sqli-comint-func sql-comint-mariadb :list-all "SHOW TABLES;" :list-table "DESCRIBE %s;" :prompt-regexp "^MariaDB \\[.*]> " :prompt-cont-regexp "^ [\"'`-]> " :syntax-alist ((?# . "< b")) :input-filter sql-remove-tabs-filter) =C2=A0 ------=_Part_1542_1164885660.1574433525529 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Browsing sql.el I found this code:
 
;; MariaDB is a drop-in replacement for MySQL, so just make the
;; MariaDB variables aliases of the MySQL ones.
 
(defvaralias 'sql-mariadb-program 'sql-mysql-program)
(defvaralias 'sql-mariadb-options 'sql-mysql-options)
(defvaralias 'sql-mariadb-login-params 'sql-mysql-login-params)
 
 

If mariadb is a drop in mysql replacement then all mysql-related fixes
should apply to it too, though later in the code mariadb sets up syntax
independetly, so the same bug affects it which the patch here fixes.
The correct solution could be setting up a mariadb syntax variable
and alias it to the mysql syntax variable to avoid duplicating the same code:

 
(mariadb
:name "MariaDB"
:free-software t
:font-lock sql-mode-mariadb-font-lock-keywords
:sqli-program sql-mariadb-program
:sqli-options sql-mariadb-options
:sqli-login sql-mariadb-login-params
:sqli-comint-func sql-comint-mariadb
:list-all "SHOW TABLES;"
:list-table "DESCRIBE %s;"
:prompt-regexp "^MariaDB \\[.*]> "
:prompt-cont-regexp "^ [\"'`-]> "
:syntax-alist ((?# . "< b"))
:input-filter sql-remove-tabs-filter)



  ------=_Part_1542_1164885660.1574433525529-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 14:38:15 2020 Received: (at 37459) by debbugs.gnu.org; 20 Jan 2020 19:38:16 +0000 Received: from localhost ([127.0.0.1]:46092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itcsG-0007kM-6i for submit@debbugs.gnu.org; Mon, 20 Jan 2020 14:38:15 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:39808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itcsA-0007jb-P8 for 37459@debbugs.gnu.org; Mon, 20 Jan 2020 14:38:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N7gF1qgCEewCFc72kD9ANoUs8QHyV2VVox2TkK+8ccY=; b=irx8euUFKFle01ERGEMYI1HVo1 szJAEcEZwzVJyPnnVQzLj3tklHoIEnLHdnKlYp7h0X7SbcTr+Nn9hURYLQ/udYuzns0TnT9M3yo7g jOASvvjKjgsnJ+3SQMeN89ZwFIRQDREHJX3kjlzjINMupgzX7CbjyFnlpSKi7Rwo+Jr19IyXFWgrR 493XyjtsdCR9L4o5xprhlK286JaHcJKZxi8BAKCSFn+X8fUF7iLhwcdR1NWHVVg7BaHntzULjJuAW ylHccuMZUpJLViIwp6VqwxNzYeVhvVhni0h9rUeZPzE7wrZgMAv/Ffo1cMj46Q8vKuOVytG7sTYuv kLdm4IVQ==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:59940 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1itcs3-0002dj-Us; Mon, 20 Jan 2020 14:38:00 -0500 From: Stefan Kangas To: Michael Mauger Subject: Re: bug#37459: Adds backslash as escape character to mysql syntax-alist In-Reply-To: (Kristian Hole's message of "Sat, 26 Oct 2019 17:25:42 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Mon, 20 Jan 2020 20:37:58 +0100 Message-ID: <87blqxsyuh.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37459 Cc: Kristian Hole , 37459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Michael, Kristian Hole writes: > I've generated patches for takeaways (1) and (2) > > Patch attached to previous message: > Corrects sql-mode help about escape character syntax > > Changes the example from the incorrect use of > punctuation rule, to the escape character rule (Bug#37459). > > This patch: > Adds backslash as escape character to mysql syntax-alist > > In MySQL syntax backslash denotes an escape sequence. > This change adds backslash to the syntax-alist of > MySQL in sql-mode as per (Bug#37459). Could you please take a look at the below patch? TIA. Best regards, Stefan Kangas > > From 4953d7bb249502fd8d87295b81bd381e70134fc0 Mon Sep 17 00:00:00 2001 > From: kahole > Date: Sat, 26 Oct 2019 17:08:17 +0200 > Subject: [PATCH 2/2] Adds backslash as escape character to mysql syntax-alist > > In MySQL syntax backslash denotes an escape sequence. > This change adds backslash to the syntax-alist of > MySQL in sql-mode as per (Bug#37459). > --- > lisp/progmodes/sql.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el > index f985157202..81e0d8cf89 100644 > --- a/lisp/progmodes/sql.el > +++ b/lisp/progmodes/sql.el > @@ -461,7 +461,7 @@ sql-product-alist > :prompt-regexp "^mysql> " > :prompt-length 6 > :prompt-cont-regexp "^ -> " > - :syntax-alist ((?# . "< b")) > + :syntax-alist ((?# . "< b") (?\\ . "\\")) > :input-filter sql-remove-tabs-filter) > > (oracle From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 14:57:42 2020 Received: (at 37459) by debbugs.gnu.org; 9 Aug 2020 18:57:42 +0000 Received: from localhost ([127.0.0.1]:33435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4qVq-0000aA-9X for submit@debbugs.gnu.org; Sun, 09 Aug 2020 14:57:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4qVo-0000Zp-E9 for 37459@debbugs.gnu.org; Sun, 09 Aug 2020 14:57:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c9E/shhThxJYT4xDPiSpJOlXNcfER1LjRry9jAwSHJM=; b=NsAm8TkmFc/UH/QKZ3nxcsccy/ Co2dN+uUa+zcVAXArnRQ2npH1yNOF5S8jqdU3m3a2SJd6DhiaopHp0Y7/wQ6c4hNDZ5bz7rBz8vSF 68b3HgEDo5xUX/WA6w5FCEeoMBFei7zKMHm8dYGGN70XGmFUrxn7ph4z28YlcIdo0c28=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4qVe-0002UF-Bb; Sun, 09 Aug 2020 20:57:33 +0200 From: Lars Ingebrigtsen To: Kristian Hole Subject: Re: bug#37459: Adds backslash as escape character to mysql syntax-alist References: Date: Sun, 09 Aug 2020 20:57:28 +0200 In-Reply-To: (Kristian Hole's message of "Sat, 26 Oct 2019 17:25:42 +0200") Message-ID: <874kpbd4vb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kristian Hole writes: > I've generated patches for takeaways (1) and (2) > > Patch attached to previous message: > Corrects sql-mode help about escape character syntax > > Changes the example from the incorrect use of > pu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37459 Cc: Michael Mauger , 37459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kristian Hole writes: > I've generated patches for takeaways (1) and (2) > > Patch attached to previous message: > Corrects sql-mode help about escape character syntax > > Changes the example from the incorrect use of > punctuation rule, to the escape character rule (Bug#37459). > > This patch: > Adds backslash as escape character to mysql syntax-alist > > In MySQL syntax backslash denotes an escape sequence. > This change adds backslash to the syntax-alist of > MySQL in sql-mode as per (Bug#37459). [...] > - :syntax-alist ((?# . "< b")) > + :syntax-alist ((?# . "< b") (?\\ . "\\")) > :input-filter sql-remove-tabs-filter) I don't use mysql in sql mode, but this looks "obviously" correct, so I've applied it to Emacs 28 (along with the doc fix). Perhaps Michael can chime in... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 14:57:48 2020 Received: (at control) by debbugs.gnu.org; 9 Aug 2020 18:57:48 +0000 Received: from localhost ([127.0.0.1]:33438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4qVw-0000aR-H0 for submit@debbugs.gnu.org; Sun, 09 Aug 2020 14:57:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4qVv-0000a8-1r for control@debbugs.gnu.org; Sun, 09 Aug 2020 14:57:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GE+tELbBlNOZqEvaDkEkiGlIl+rbnt8v38FWQYVX7j4=; b=LzoKTkBKN+spBb/TePm5VxEgAU 2ToUoBl71GCDOpVFK+Wbdk3KEYK6Dse8vquQwVROf/s61CrGBV8ENEn8akcxBJ6HJ0Ud3vLxihXeO bNm4eXlp97BYnF2JooOeQkNmHj2QesVSJiy5JJaY/K6YSgRWVoGAC0ZqOu6qjvu4bjSc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4qVn-0002US-89 for control@debbugs.gnu.org; Sun, 09 Aug 2020 20:57:41 +0200 Date: Sun, 09 Aug 2020 20:57:38 +0200 Message-Id: <87364vd4v1.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #37459 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 37459 fixed close 37459 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 37459 fixed close 37459 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 15:02:34 2020 Received: (at 37459) by debbugs.gnu.org; 9 Aug 2020 19:02:34 +0000 Received: from localhost ([127.0.0.1]:33449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4qaY-0002mA-Da for submit@debbugs.gnu.org; Sun, 09 Aug 2020 15:02:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4qaW-0002hQ-Td for 37459@debbugs.gnu.org; Sun, 09 Aug 2020 15:02:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oE1tt9rui205vqMe00MCj/TCtnK96l/RNeJCzG6gj00=; b=qhDJReNmEBKZTl0qFLBKHlYxqi wiGaXLHo9ExmzdC5tQ08K/fZeu4+819pqpstrk3oq9xyP/OOR0W+NdKwVQIiFyFgxi/MxEh3jWvff MCLQmx5sl2q3n5SGWX5OxE7aFI+b7wWyczDYY/MUEmvai53N5cBvdcmAw8okW9uxBwFQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4qaO-0002WB-4n; Sun, 09 Aug 2020 21:02:26 +0200 From: Lars Ingebrigtsen To: Kristian Hole Subject: Re: bug#37459: Adds backslash as escape character to mysql syntax-alist References: <874kpbd4vb.fsf@gnus.org> Date: Sun, 09 Aug 2020 21:02:22 +0200 In-Reply-To: <874kpbd4vb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 09 Aug 2020 20:57:28 +0200") Message-ID: <87tuxbbq2p.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I don't use mysql in sql mode, but this looks "obviously" correct, so > I've applied it to Emacs 28 (along with the doc fix). Perhaps Michael > can chime in... Content analysis details: (1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 2.0 SPOOF_COM2COM URI: URI contains ".com" in middle and end 2.7 SPOOF_COM2OTH URI: URI contains ".com" in middle -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37459 Cc: Michael Mauger , 37459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I don't use mysql in sql mode, but this looks "obviously" correct, so > I've applied it to Emacs 28 (along with the doc fix). Perhaps Michael > can chime in... Or not? Somebody has manually blacklisted my MTA, which only sends out emails from me? Well I have never! michael@mauger.com host mx.netidentity.com.cust.hostedemail.com [216.40.42.4] SMTP error from remote mail server after initial connection: 554 5.7.1 Service unavailable; Client host [95.216.78.240] blocked using urbl.hostedemail.com; Your IP has been manually blacklisted -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Jun 16 23:47:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 Sep 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator