Subject: bug#37434: closed (Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 25 Sep 2019 02:21:02 +0000

Your bug report

#37434: [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
37434: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37434
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
From: Eric Bavier <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked], Timothy Sample <[email-masked]>, [email-masked]
Date: Tue, 24 Sep 2019 22:20:28 -0400 (EDT)
List-Id: <debbugs-submit.debbugs.gnu.org>

----- On Sep 24, 2019, at 12:08 PM, Ludovic Courtès [email-masked] wrote:

> Hi Eric,
> 
> Eric Bavier <[email-masked]> skribis:
> 
>> From 832529b71c2c5c7e6aa6e88a206c0db65e8a0c2e Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <[email-masked]>
>> Date: Mon, 16 Sep 2019 22:20:23 -0500
>> Subject: [PATCH] gnu: idris: Update to 1.3.2.
>>
>> * gnu/packages/idris.scm (ghc-network-2.8, ghc-megaparsec-7): New variables.
>> (idris): Update to 1.3.2.
>> [source]: Remove patch.
>> [inputs]: Use ghc-network-2.8 and ghc-megaparsec-7.
>> * gnu/packages/patches/idris-test-no-node.patch: Delete.
>> * gnu/local.mk (dist_patch_DATA): Remove it.
> 
> [...]
>> +;;; Until we update our default GHC to >=8.6 we cannot update our ghc-network
>> +;;; package, since the 'cabal-install' package that supports the current
>> +;;; 'Cabal' module requires 'network==2.6.*'.  Providing a local ghc-network
>> +;;; works in this case since we use it only for a standalone program.
>> +(define ghc-network-2.8
>> +  (package
>> +    (inherit ghc-network)
> 
> You should only inherit from packages defined in the same module,
> otherwise we risk hitting the dreaded circular dependency mess (actually
> this particular case is fine because idris.scm is a “leaf”, but still,
> let’s not take this risk.)
> 
> So I recommend moving these two ghc-* packages next to their friends.

Makes sense.  Done.

> With this change the patch LGTM.

Pushed with that change and other small adjustments for latest master in commit 4780db2c93.

-- 
`~Eric

Subject: [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
From: [email-masked]
To: [email-masked]
Cc: Eric Bavier <[email-masked]>
Date: Mon, 16 Sep 2019 22:37:29 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

From: Eric Bavier <[email-masked]>

* gnu/packages/haskell.scm (ghc-megaparsec): Update to 7.0.5
[arguments]: Remove field.
---
 gnu/packages/haskell.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 8787f10789..960068ab23 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -4050,7 +4050,7 @@ combinators.")
 (define-public ghc-megaparsec
   (package
     (name "ghc-megaparsec")
-    (version "6.5.0")
+    (version "7.0.5")
     (source
      (origin
        (method url-fetch)
@@ -4059,11 +4059,8 @@ combinators.")
                            version ".tar.gz"))
        (sha256
         (base32
-         "12iggy7qpf8x93jm64zf0g215xwy779bqyfyjk2bhmxqqr1yzgdy"))))
+         "0bqx1icbmk8s7wmbcdzsgnlh607c7kzg8l80cp02dxr5valjxp7j"))))
     (build-system haskell-build-system)
-    (arguments
-     `(#:cabal-revision
-       ("4" "0ij3asi5vwlhbgwsy6nhli9a0qb7926mg809fsgyl1rnhs9fvpx1")))
     (inputs
      `(("ghc-case-insensitive" ,ghc-case-insensitive)
        ("ghc-parser-combinators" ,ghc-parser-combinators)
-- 
2.23.0