GNU bug report logs - #37421
node fails to build during update

Previous Next

Full log

View this message in rfc822 format

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 37421 <at> debbugs.gnu.org
Subject: bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl <at> 1.1.1d.
Date: Mon, 16 Sep 2019 15:52:28 +0200

Work around <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37386>.

* gnu/packages/node.scm (node)[arguments]: Disable failing tests.
---

Jelle, Guix,

So here's the obvious non-solution, ignoring test failures being the lesser evil compared to 4 potential CVEs anywhere in a Web browser's closure.

It seems to ‘work’ in a short VM Chromium test.  As in, nothing broke.  Don't know how to test Node.  Thoughts?

Kind regards,

T G-R

 gnu/packages/node.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index fc43fcb04c..f467be7665 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -91,6 +91,11 @@
          (add-before 'configure 'patch-files
            (lambda* (#:key inputs #:allow-other-keys)
 
+             ;; FIXME: These tests fail with openssl <at> 1.1.1d.
+             (for-each delete-file
+                       '("test/parallel/test-crypto-binary-default.js"
+                         "test/parallel/test-crypto-dh.js"))
+
              ;; Fix hardcoded /bin/sh references.
              (substitute* '("lib/child_process.js"
                             "lib/internal/v8_prof_polyfill.js"
-- 
2.23.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.