GNU bug report logs - #37412
[PATCH 0/2] Add package and service for the Guix Data Service.

Previous Next

Full log

Message #41 received at 37412 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37412 <at> debbugs.gnu.org
Subject: Re: [bug#37412] [PATCH 2/2] services: Add the Guix Data Service.
Date: Sun, 22 Sep 2019 13:15:42 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> +(define (guix-data-service-shepherd-services config)
>> +  (match config
>> +    (($ <guix-data-service-configuration> package user group
>> +                                          port host)
>
> Perhaps use ‘match-record’ here and elsewhere, to avoid mistakes when
> the record type changes.

Yeah, I've switched a couple of the match statements across to
match-record, but I've left one, as it has a couple of clauses.

>> +(define %test-guix-data-service
>> +  (system-test
>> +   (name "guix-data-service")
>> +   (description "Connect to a running Guix Data Service.")
>> +   (value (run-guix-data-service-test))))
>
> Nice.
>
> Could you add a bit to guix.texi, maybe under “Continuous Integration”?
> You don’t have to go into too much detail if you think some of the
> configuration elements are subject to change.

I forgot you mentioned the "Continuous Integration" section, so I
actually added something under a new "Guix" section, but regardless,
I've now sent some new patches, which includes some documentation.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.