GNU bug report logs - #37409
[PATCH] gnu: guile-email: Add phase to patch the module directory.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37409: closed ([PATCH] gnu: guile-email: Add phase to patch
 the module directory.)
Date: Sat, 21 Sep 2019 16:38:05 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Sep 2019 17:37:07 +0100
with message-id <87muex1u8c.fsf <at> cbaines.net>
and subject line Re: [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the module directory.
has caused the debbugs.gnu.org bug report #37409,
regarding [PATCH] gnu: guile-email: Add phase to patch the module directory.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37409: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37409
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: guile-email: Add phase to patch the module directory.
Date: Sun, 15 Sep 2019 13:33:31 +0100

Otherwise the .go files appear within share, and Guile doesn't find them. With
this patch they appear in lib within the output. One thing this means is that
stack traces include the filenames.

* gnu/packages/guile-xyz.scm (guile-email)[arguments]: Add 'patch-module-dir
phase.
---
 gnu/packages/guile-xyz.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index b765ef36e1..4fa2759205 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -927,7 +927,16 @@ tracker's SOAP service, such as @url{https://bugs.gnu.org}.")
     (inputs
      `(("guile" ,guile-2.2)))
     (arguments
-     '(#:make-flags '("GUILE_AUTO_COMPILE=0"))) ; to prevent guild warnings
+     '(#:make-flags '("GUILE_AUTO_COMPILE=0") ; to prevent guild warnings
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'patch-module-dir
+           (lambda _
+             (substitute* "Makefile.in"
+               (("^godir = ([[:graph:]]+)")
+                "godir = \
+$(libdir)/guile/@GUILE_EFFECTIVE_VERSION@/site-ccache\n"))
+             #t)))))
     (home-page "https://guile-email.systemreboot.net")
     (synopsis "Guile email parser")
     (description "guile-email is a collection of email utilities implemented
-- 
2.23.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 37409-done <at> debbugs.gnu.org
Subject: Re: [bug#37409] [PATCH] gnu: guile-email: Add phase to patch the
 module directory.
Date: Sat, 21 Sep 2019 17:37:07 +0100

[Message part 4 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Otherwise the .go files appear within share, and Guile doesn't find them. With
>> this patch they appear in lib within the output. One thing this means is that
>> stack traces include the filenames.
>>
>> * gnu/packages/guile-xyz.scm (guile-email)[arguments]: Add 'patch-module-dir
>> phase.
>
> LGTM!

Great, I've pushed this now (as
c219104c7803cd31ab1cf4bef142a8fbf8ed5b7a).

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.