GNU bug report logs - #37394
[PATCH] gnu: Add tigervnc

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37394: closed ([PATCH] gnu: Add tigervnc)
Date: Tue, 01 Oct 2019 23:29:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 2 Oct 2019 01:28:37 +0200
with message-id <20191002012837.19d4ac0f <at> scratchpost.org>
and subject line Re: [bug#37394] [PATCH] gnu: Add tigervnc
has caused the debbugs.gnu.org bug report #37394,
regarding [PATCH] gnu: Add tigervnc
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37394: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37394
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Todor Kondić <tk.code <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add tigervnc
Date: Thu, 12 Sep 2019 19:33:45 +0000

[Message part 3 (text/plain, inline)]

Hi,

I needed a decent VNC server, so I wrapped up TigerVNC into two guix packages. One is for the client, and another for the server. Since the build procedure is non-standard (a combination of cmake for the viewer and some parts, but  then patch-and-compile  Xorg server for the VNC server) , I could not follow the ([understandably] scarcely documented) package definition procedures in Guix docs and, instead, mixed and matched things I gleaned from other Guix packages. The result works as far as I can tell and was tested in a VM, however, some parts of the package definition could probably be expressed more elegantly.

Also, it would be nice if the folks who created xorg-server package definition could check the various configure options in the server part, since the tigervnc-server inherits from xorg-server. For example, was it really necessary to disable Xephyr? I do not even know what is it for.

The vncserver script surprisingly works, but could probably customised a bit for the Guix distro. In addition, most distros have a systemd service to start the server. I do not  see this as a very important addition, given the Guix orientation towards user managed configs, but if someone wants to help me define one, I am open to it. One nice application for a service would be to implement the multi-user vnc server as described here https://developer.ibm.com/tutorials/os-multiuserloginsvnc/

Finally, the packages were linted, and indented using the script. The lint complains about certain minor things that I feel are better left the way they are.

Hopefully someone will find this useful.

Cheers,

Todor

[Message part 4 (text/html, inline)]

[0001-Add-tigervnc-client.patch (text/x-patch, attachment)]

[0002-Add-tigervnc-server.patch (text/x-patch, attachment)]

[Message part 7 (message/rfc822, inline)]

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Todor Kondić via Guix-patches via <guix-patches <at> gnu.org>
Cc: 37394-done <at> debbugs.gnu.org
Subject: Re: [bug#37394] [PATCH] gnu: Add tigervnc
Date: Wed, 2 Oct 2019 01:28:37 +0200

[Message part 8 (text/plain, inline)]

Hi,

thanks for the patches!

On Thu, 12 Sep 2019 19:33:45 +0000
Todor Kondić via Guix-patches via <guix-patches <at> gnu.org> wrote:

> Also, it would be nice if the folks who created xorg-server package definition could check the various configure options in the server part, since the tigervnc-server inherits from xorg-server. For example, was it really necessary to disable Xephyr? I do not even know what is it for.

Xephyr is an X server whose output is a window instead of the entire screen.  That doesn't sound like one needs that in a VNC server (which does not render to a screen anyway).

[Message part 9 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.