GNU bug report logs - #37392
[PATCH] gnu: Add r-assertr

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 37392 in the body.
You can then email your comments to 37392 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wiktor Żelazny <wz <at> freeshell.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add r-assertr
Date: Thu, 12 Sep 2019 18:44:57 +0200

From: Wiktor Żelazny <wzelazny <at> vurv.cz>

* gnu/packages/cran.scm (r-assertr): New variable
---
 gnu/packages/cran.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 6ef2066429..ddaffb6b6d 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2018 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2018, 2019 Brett Gilio <brettg <at> posteo.net>
 ;;; Copyright © 2019 Nicolò Balzarotti <anothersms <at> gmail.com>
+;;; Copyright © 2019 Wiktor Żelazny <wzelazny <at> vurv.cz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -15365,3 +15366,29 @@ common graph algorithms.")
 removing cell free mRNA contamination (the \"soup\") from droplet based single
 cell RNA-seq experiments.")
       (license license:gpl2))))
+
+(define-public r-assertr
+  (package
+    (name "r-assertr")
+    (version "2.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "assertr" version))
+       (sha256
+        (base32
+         "0g4ii6vhp0155a29ljhs64a09x0nzy5ybvwwchhk4mkcgsvnvfkj"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-dplyr" ,r-dplyr)
+       ("r-knitr" ,r-knitr)             ; needed for vignette
+       ("r-mass" ,r-mass)
+       ("r-rlang" ,r-rlang)))
+    (home-page "https://github.com/ropensci/assertr")
+    (synopsis "Assertive Programming for R Analysis Pipelines")
+    (description
+     "Provides functionality to assert conditions that have to be met so that
+errors in data used in analysis pipelines can fail quickly.  Similar to
+@code{stopifnot()} but more powerful, friendly, and easier for use in
+pipelines.")
+    (license (license:fsf-free "https://cran.r-project.org/web/licenses/MIT"))))
-- 
2.22.0

Message #10 received at 37392-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Wiktor Żelazny <wz <at> freeshell.de>
Cc: 37392-done <at> debbugs.gnu.org
Subject: Re: [bug#37392] [PATCH] gnu: Add r-assertr
Date: Fri, 13 Sep 2019 01:09:43 +0200

Hi Wiktor,

> * gnu/packages/cran.scm (r-assertr): New variable

Thank you for your patch!

I made a couple of minor changes before pushing it to the repository’s
master branch.

> +(define-public r-assertr
> +  (package
> +    (name "r-assertr")
> +    (version "2.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "assertr" version))
> +       (sha256
> +        (base32
> +         "0g4ii6vhp0155a29ljhs64a09x0nzy5ybvwwchhk4mkcgsvnvfkj"))))
> +    (build-system r-build-system)
> +    (propagated-inputs
> +     `(("r-dplyr" ,r-dplyr)
> +       ("r-knitr" ,r-knitr)             ; needed for vignette

I moved this to native-inputs, because it is not needed at runtime.

> +    (synopsis "Assertive Programming for R Analysis Pipelines")

I changed this to use lower case.

> +    (description
> +     "Provides functionality to assert conditions that have to be met so that
> +errors in data used in analysis pipelines can fail quickly.  Similar to
> +@code{stopifnot()} but more powerful, friendly, and easier for use in
> +pipelines.")

I used full sentences here.

> +    (license (license:fsf-free "https://cran.r-project.org/web/licenses/MIT"))))

This is the Expat license, so I changed it to license:expat.

I also added punctuation to the commit message.

Thank you for your contribution and welcome to Guix!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.