From unknown Sun Jun 15 08:15:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#37384 <37384@debbugs.gnu.org> To: bug#37384 <37384@debbugs.gnu.org> Subject: Status: Daemon does not honor =?UTF-8?Q?=E2=80=9CuseSubstitutes=E2=80=9D?= on armhf Reply-To: bug#37384 <37384@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:15:25 +0000 retitle 37384 Daemon does not honor =E2=80=9CuseSubstitutes=E2=80=9D on arm= hf reassign 37384 guix submitter 37384 Timothy Sample severity 37384 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 14:51:17 2019 Received: (at submit) by debbugs.gnu.org; 11 Sep 2019 18:51:17 +0000 Received: from localhost ([127.0.0.1]:42772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i87i1-0007l0-8Q for submit@debbugs.gnu.org; Wed, 11 Sep 2019 14:51:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:32895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i87hy-0007kn-Kn for submit@debbugs.gnu.org; Wed, 11 Sep 2019 14:51:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50798) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i87hx-0006Z1-CD for bug-guix@gnu.org; Wed, 11 Sep 2019 14:51:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i87hw-0005lh-8r for bug-guix@gnu.org; Wed, 11 Sep 2019 14:51:13 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:48991) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i87hv-0005kk-VZ for bug-guix@gnu.org; Wed, 11 Sep 2019 14:51:12 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2C5E1557 for ; Wed, 11 Sep 2019 14:51:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 11 Sep 2019 14:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=tTw5ES tiYE32DRVCO+iwe2eGTk80dp37f6ET+D2mOAA=; b=VnxnObbCWhsD1gzfk7Heko QeY2fG2mvoH7AlvVQ/NX/vm5gJuu4pwnENtr2vjQifbnd7Mt2vNkObIO0BufUQwC NNVIX/06RTmJUr251TtEgUgGjCguLoxLNPLlKmiY+vYGuxnDOJQE8jQFxGu3uOmK 1b5r+oi0bCyxlYzVo0I+eXZHkv1pjTwc6iUqhGYWzHwU4M1dEYb+mSRRPWByzTPz q6/OALYKF7pcAWxjncMCFcWtIt5jj08iy80SvhAk/TGS5dIqYw98BCGsr9XsS/J7 3riMvLM9Ui3eDSyRLR1r4TFUjspVZBfuKMAb+KTpO2wFkC2TQCotO2s5A6xjsCYQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtdefgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkfgggtgfgsehtqhertd dtreejnecuhfhrohhmpefvihhmohhthhihucfurghmphhlvgcuoehsrghmphhlvghtsehn ghihrhhordgtohhmqeenucffohhmrghinhepghhnuhdrohhrghenucfkphepjeegrdduud eirddukeeirdeggeenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhg hihrohdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 61EF7D60067 for ; Wed, 11 Sep 2019 14:51:08 -0400 (EDT) From: Timothy Sample To: bug-guix@gnu.org Subject: Daemon does not honor =?utf-8?Q?=E2=80=9CuseSubstitutes=E2=80=9D?= on armhf Date: Wed, 11 Sep 2019 14:51:07 -0400 Message-ID: <87woeevf8k.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.147.123.25 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Currently, the =E2=80=9Cguix=E2=80=9D package cannot build on armhf due to = test failures: . (I can confirm this on my local machine, too.) It looks like there is some confusion about the layout of the =E2=80=9CSett= ings=E2=80=9D struct. At least, if I add some print statements in the code to print the address of the =E2=80=9CuseSubstitutes=E2=80=9D flag: printMsg(lvlError, format("XXX: %1%") % &settings.useSubstitutes); it gives me different addresses depending on whether I=E2=80=99m printing f= rom the main daemon loop or from the =E2=80=9CquerySubstitutablePathInfos=E2=80= =9D method. The addresses suspiciously differ by eight. I can confirm that the addresses are the same on x86_64. My guess is that this bug was revealed by the changes made in commit f6919ebdc6b0ce0286814cc6ab0564b1a4c67f5f (making the daemon assume a single substituter). Before this commit, it looks like the daemon would give up because there were no substituters. Now it relies on checking =E2=80=9CuseSubstitutes=E2=80=9D, which is not in fact reliable. I=E2=80= =99ve tested everything from before this commit, and the addresses are still different. Weirdly, in GDB, I can be right before the following line: if (!settings.useSubstitutes) return; run =E2=80=9Cp settings.useSubstitutes=E2=80=9D and see =E2=80=9Cfalse=E2= =80=9D, and then continue running through the method without hitting that =E2=80=9Creturn=E2=80=9D. = It seems GDB is not confused about the flag, just the actual code. Looking at the disassembly was no use to me, since I don=E2=80=99t know much about ARM, and it was not simple enough for me to guess what it was doing. -- Tim From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 16:28:33 2019 Received: (at 37384) by debbugs.gnu.org; 11 Sep 2019 20:28:33 +0000 Received: from localhost ([127.0.0.1]:42795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i89E9-0001oS-I4 for submit@debbugs.gnu.org; Wed, 11 Sep 2019 16:28:33 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:57545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i89E7-0001o6-3S for 37384@debbugs.gnu.org; Wed, 11 Sep 2019 16:28:31 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7EEEF570 for <37384@debbugs.gnu.org>; Wed, 11 Sep 2019 16:28:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 11 Sep 2019 16:28:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=dk7Fnk2Li90IwZZxHUxIZTD2QVXPiS6ZLwK3SKvU9 FM=; b=BLsOJuV7ooCyXEjVIAdka2v82Ff8QYqbWqrmcJal6Dr/Y7LDOjuMEgy/m mjScREkgxyT6R/Hc9b+lS8QnQqKb8zuXuX/PLs/PJf1dTx05ff59ZuXExJRTyh+x c1MWafuHEVgRHan648Q6RSpPFAjpvWz57HYKFAJnbuLbNCLN5+3b+tFGwgXoNecb P35SdMoQ6W/+pO2dzGD3ntUBF24/l3rFRQw846pOZobRLhM0WlT52F2pUKOvA0Dx hwlViEpgtxyJybLBo4qhCzVzchayXmMy4BmXJ1r9NY6noGPMbIxkD5rVUAVRPIUp 8Z9tgznU8i1rbuA86pqmT3+n6wZxQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtdefgdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufhffjgfkfgggtgfgsehtqh ertddtreejnecuhfhrohhmpefvihhmohhthhihucfurghmphhlvgcuoehsrghmphhlvght sehnghihrhhordgtohhmqeenucfkphepjeegrdduudeirddukeeirdeggeenucfrrghrrg hmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtghomhenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id A026580066 for <37384@debbugs.gnu.org>; Wed, 11 Sep 2019 16:28:23 -0400 (EDT) From: Timothy Sample To: 37384@debbugs.gnu.org Subject: Re: bug#37384: Daemon does not honor =?utf-8?Q?=E2=80=9CuseSubsti?= =?utf-8?Q?tutes=E2=80=9D?= on armhf References: <87woeevf8k.fsf@ngyro.com> Date: Wed, 11 Sep 2019 16:28:22 -0400 In-Reply-To: <87woeevf8k.fsf@ngyro.com> (Timothy Sample's message of "Wed, 11 Sep 2019 14:51:07 -0400") Message-ID: <87sgp2vaqh.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37384 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Timothy Sample writes: > it gives me different addresses depending on whether I=E2=80=99m printing= from > the main daemon loop or from the =E2=80=9CquerySubstitutablePathInfos=E2= =80=9D method. > The addresses suspiciously differ by eight. The problem goes away if I move =E2=80=9CuseSubstitutes=E2=80=9D above =E2= =80=9CreservedSize=E2=80=9D, which has type =E2=80=9Coff_t=E2=80=9D. I=E2=80=99m guessing this is becau= se of something fishy with =E2=80=9C_FILE_OFFSET_BITS=E2=80=9D, but I=E2=80=99m not sure what jus= t yet. -- Tim From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 01:48:01 2019 Received: (at 37384) by debbugs.gnu.org; 12 Sep 2019 05:48:01 +0000 Received: from localhost ([127.0.0.1]:42961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8HxY-00017t-Uk for submit@debbugs.gnu.org; Thu, 12 Sep 2019 01:48:01 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:55511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8HxW-00017f-LY for 37384@debbugs.gnu.org; Thu, 12 Sep 2019 01:47:59 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B461C538 for <37384@debbugs.gnu.org>; Thu, 12 Sep 2019 01:47:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 12 Sep 2019 01:47:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=A6cRFO OpKFt2k89jaT/xd3Xi6eR43CvzqAnYDQGmRsc=; b=MkoKw85ypGiG5HVLU/SVN9 4eaS91C6tp+w5pXKl9dy93Jkz7YR2DJLdX6Vz9dZElfdw9UyORPQbbfgYwamtT3x Zdof6D4LRWSHZK9kkdIBRE2hiGfnFXelFvIPvNiBaRJ+pI/VdaEGOM2TrzDtX1Mw xCUsEaR+Qc2cR58t5K8biEZzq3OoRyhDhIxA7cFUn/WG3qRqhDyd5w6joZu19NUV vfQHNK4zBCmeRaNh7zvchuKYx8my6EZfVjhrePRQs0y2g45s+CQqmZWavkP2xHVo Q7V+VtzaYCNJUA6dtuGnn3a2H9gmcla3GLLkGH+T1H5uQft8qAEdbyDZlgZsfcdQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtdeggddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesmhdtre ertderjeenucfhrhhomhepvfhimhhothhhhicuufgrmhhplhgvuceoshgrmhhplhgvthes nhhghihrohdrtghomheqnecukfhppeejgedrudduiedrudekiedrgeegnecurfgrrhgrmh epmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgtohhmnecuvehluhhsthgv rhfuihiivgeptd X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id E32A1D60062 for <37384@debbugs.gnu.org>; Thu, 12 Sep 2019 01:47:51 -0400 (EDT) From: Timothy Sample To: 37384@debbugs.gnu.org Subject: Re: bug#37384: Daemon does not honor =?utf-8?Q?=E2=80=9CuseSubsti?= =?utf-8?Q?tutes=E2=80=9D?= on armhf In-Reply-To: <87sgp2vaqh.fsf@ngyro.com> (Timothy Sample's message of "Wed, 11 Sep 2019 16:28:22 -0400") References: <87woeevf8k.fsf@ngyro.com> <87sgp2vaqh.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Thu, 12 Sep 2019 01:47:51 -0400 Message-ID: <87ftl25am0.fsf@ngyro.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37384 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Timothy Sample writes: > The problem goes away if I move =E2=80=9CuseSubstitutes=E2=80=9D above = =E2=80=9CreservedSize=E2=80=9D, > which has type =E2=80=9Coff_t=E2=80=9D. I=E2=80=99m guessing this is bec= ause of something fishy > with =E2=80=9C_FILE_OFFSET_BITS=E2=80=9D, but I=E2=80=99m not sure what j= ust yet. Here=E2=80=99s my best guess as to what is going on. In =E2=80=9Cnix-daemo= n.cc=E2=80=9D the order of includes causes =E2=80=9Coff_t=E2=80=9D to be defined before =E2=80=9C_FILE_OFFSET_BITS=E2=80=9D, which results in it being something li= ke a 32-bit signed integer. In =E2=80=9Clocal-store.cc=E2=80=9D, =E2=80=9C_FILE_OFFSET= _BITS=E2=80=9D gets set first, yielding a 64-bit =E2=80=9Coff_t=E2=80=9D. This causes all of the a= ddresses in the =E2=80=9CSettings=E2=80=9D struct to be mismatched after =E2=80=9Creser= vedSize=E2=80=9D. I plugged in =E2=80=9Csizeof(off_t)=E2=80=9D into the =E2=80=9CprintMsg=E2=80=9D call= s from before, and (lo and behold) I saw 4 from =E2=80=9Cnix-daemon.cc=E2=80=9D and 8 from =E2=80=9Clo= cal-store.cc=E2=80=9D. The following patch fixes the problem: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-daemon-Include-config.h-in-nix-daemon.cc.patch >From 3c3eafac82e0a6e8a37363d6eb46f128e585705a Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Thu, 12 Sep 2019 00:50:54 -0400 Subject: [PATCH] daemon: Include 'config.h' in 'nix-daemon.cc'. * nix/nix-daemon/nix-daemon.cc: Include 'config.h'. --- nix/nix-daemon/nix-daemon.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/nix/nix-daemon/nix-daemon.cc b/nix/nix-daemon/nix-daemon.cc index ffac6cde34..1163a249d1 100644 --- a/nix/nix-daemon/nix-daemon.cc +++ b/nix/nix-daemon/nix-daemon.cc @@ -1,3 +1,4 @@ +#include "config.h" #include "shared.hh" #include "local-store.hh" #include "util.hh" -- 2.23.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Is this okay to push? It seems kind of conspicuous that it=E2=80=99s missi= ng in the first place. Is it missing for a good reason? -- Tim --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 11:53:09 2019 Received: (at 37384) by debbugs.gnu.org; 16 Sep 2019 15:53:09 +0000 Received: from localhost ([127.0.0.1]:50870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9tJM-0003AY-S5 for submit@debbugs.gnu.org; Mon, 16 Sep 2019 11:53:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9tJK-0003AK-VA for 37384@debbugs.gnu.org; Mon, 16 Sep 2019 11:53:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i9tJF-0002u1-Pm; Mon, 16 Sep 2019 11:53:01 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=49510 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i9tJF-0006HM-8U; Mon, 16 Sep 2019 11:53:01 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: bug#37384: Daemon does not honor =?utf-8?Q?=E2=80=9CuseSubsti?= =?utf-8?Q?tutes=E2=80=9D?= on armhf References: <87woeevf8k.fsf@ngyro.com> <87sgp2vaqh.fsf@ngyro.com> <87ftl25am0.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Fructidor an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 16 Sep 2019 17:52:59 +0200 In-Reply-To: <87ftl25am0.fsf@ngyro.com> (Timothy Sample's message of "Thu, 12 Sep 2019 01:47:51 -0400") Message-ID: <877e686xwk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37384 Cc: 37384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Timothy, Timothy Sample skribis: > The following patch fixes the problem: > > From 3c3eafac82e0a6e8a37363d6eb46f128e585705a Mon Sep 17 00:00:00 2001 > From: Timothy Sample > Date: Thu, 12 Sep 2019 00:50:54 -0400 > Subject: [PATCH] daemon: Include 'config.h' in 'nix-daemon.cc'. > > * nix/nix-daemon/nix-daemon.cc: Include 'config.h'. > --- > nix/nix-daemon/nix-daemon.cc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/nix/nix-daemon/nix-daemon.cc b/nix/nix-daemon/nix-daemon.cc > index ffac6cde34..1163a249d1 100644 > --- a/nix/nix-daemon/nix-daemon.cc > +++ b/nix/nix-daemon/nix-daemon.cc > @@ -1,3 +1,4 @@ > +#include "config.h" > #include "shared.hh" > #include "local-store.hh" > #include "util.hh" LGTM. Thanks for the debugging effort that led to this fix! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 16 17:06:31 2019 Received: (at 37384) by debbugs.gnu.org; 16 Sep 2019 21:06:32 +0000 Received: from localhost ([127.0.0.1]:51194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9yCd-0003P8-F8 for submit@debbugs.gnu.org; Mon, 16 Sep 2019 17:06:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9yCb-0003Ok-BS; Mon, 16 Sep 2019 17:06:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i9yCU-0004qu-8F; Mon, 16 Sep 2019 17:06:23 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60008 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i9yCN-0005Qt-J5; Mon, 16 Sep 2019 17:06:19 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mikhail Kryshen Subject: Re: bug#37426: guix-1.0.1-5.cc98b00 fails tests on i686-linux References: <87ef0gfm1a.fsf@e6230.localdomain> Date: Mon, 16 Sep 2019 23:06:14 +0200 In-Reply-To: <87ef0gfm1a.fsf@e6230.localdomain> (Mikhail Kryshen's message of "Mon, 16 Sep 2019 15:44:33 +0300") Message-ID: <871rwg2bp5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37384 Cc: 37426@debbugs.gnu.org, 37384@debbugs.gnu.org, Timothy Sample X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Mikhail, Mikhail Kryshen skribis: > http://ci.guix.gnu.org/log/jkgrd9sv605jj3l819wp1jba99axfl0g-guix-1.0.1-5.= cc98b00 > > This breaks system configuration on i686 with current Guix. Thanks for the heads-up. The test failures are: --8<---------------cut here---------------start------------->8--- test-name: substitutable-path-info when substitutes are turned off location: /tmp/guix-build-guix-1.0.1-5.cc98b00.drv-0/source/tests/store.scm= :310 source: + (test-equal + "substitutable-path-info when substitutes are turned off" + '() + (with-store + s + (set-build-options s #:use-substitutes? #f) + (let* ((b (add-to-store + s + "bash" + #t + "sha256" + (search-bootstrap-binary + "bash" + (%current-system)))) + (d (derivation + s + "the-thing" + b + '("--version") + #:inputs + `((,b)))) + (o (derivation->output-path d))) + (with-derivation-narinfo + d + (substitutable-path-info s (list o)))))) expected-value: () actual-value: (#< path: "/tmp/guix-tests/store/k8yr3vwh9lry8= r5x53p1fcpk1d78v4y3-the-thing" deriver: "/tmp/guix-tests/store/1kklp6bxdl34= k0qxg4q4wxab7viyl00n-the-thing.drv" refs: () dl-size: 0 nar-size: 1234>) result: FAIL test-name: substitutable-paths when substitutes are turned off location: /tmp/guix-build-guix-1.0.1-5.cc98b00.drv-0/source/tests/store.scm= :323 source: + (test-equal + "substitutable-paths when substitutes are turned off" + '() + (with-store + s + (set-build-options s #:use-substitutes? #f) + (let* ((b (add-to-store + s + "bash" + #t + "sha256" + (search-bootstrap-binary + "bash" + (%current-system)))) + (d (derivation + s + "the-thing" + b + '("--version") + #:inputs + `((,b)))) + warning: in 'the-thing': deprecated 'derivation' calling conve= ntion used warning: in 'the-thing': deprecated 'derivation' calling convention used substitute: warning: authentication and authorization of substitutes disabl= ed! substitute: guix substitute: warning: ACL for archive imports seems to be u= ninitialized, substitutes may be unavailable warning: in 'the-thing': deprecated 'derivation' calling convention used warning: in 'the-thing': deprecated 'derivation' calling convention used warning: in 'the-thing': deprecated 'derivation' calling convention used warning: in 'the-thing': deprecated 'derivation' calling convention used substitute: warning: authentication and authorization of substitutes disabl= ed! substitute: guix substitute: warning: ACL for archive imports seems to be u= ninitialized, substitutes may be unavailable @ build-started /tmp/guix-tests/store/fh0yssxmiv089bpylfl4v5z4qqq89p56-the-= thing.drv - i686-linux /tmp/guix-tests/var/log/guix/drvs/fh//0yssxmiv089bpy= lfl4v5z4qqq89p56-the-thing.drv.bz2 31208 @ build-succeeded /tmp/guix-tests/store/fh0yssxmiv089bpylfl4v5z4qqq89p56-th= e-thing.drv - (o (derivation->output-path d))) + (with-derivation-narinfo + d + (substitutable-paths s (list o)))))) expected-value: () actual-value: ("/tmp/guix-tests/store/k8yr3vwh9lry8r5x53p1fcpk1d78v4y3-the-= thing") result: FAIL --8<---------------cut here---------------end--------------->8--- This may well be due to . When Timothy pushes the fix, I=E2=80=99ll update the =E2=80=98guix=E2=80=99= package and check whether it builds on i686-linux. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 17 00:14:50 2019 Received: (at 37384-done) by debbugs.gnu.org; 17 Sep 2019 04:14:50 +0000 Received: from localhost ([127.0.0.1]:51461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iA4t7-0001aD-QJ for submit@debbugs.gnu.org; Tue, 17 Sep 2019 00:14:50 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iA4t6-0001a1-Nm for 37384-done@debbugs.gnu.org; Tue, 17 Sep 2019 00:14:49 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A41E421D25; Tue, 17 Sep 2019 00:14:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 17 Sep 2019 00:14:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=l/wyx8qrRktiVPUBapeE1hQECTiJLYZ5bDb5142Ms /0=; b=oPLvF1yqw37CQcIenYRqLQDZjb709f+DZFzeemrxcvdWd+QVRLxW7UYnh nwJL4A65f5WQTNKtB0HoH3aJzHGz3Ve37CFco0NKKj/sw9SZomXw9XV3jbxv56mI KJBs2tBdRqz9/7PGad9bE0qhMBs+LOyDT6tRvgj3Mui2nb9qOMBtzF2IBcQGaPMQ XcCgXA1I0BDZa3l1l4H3E+1NpsogRkLbXO/EdBFA0ax5x3Nk1CXUDTibGFaJVjI0 8l1C6JsH6fgmJEUxjsNGr2o+pV2TD3fwWm/RsVKYVX/VLKt6nRwBSXqkFuzoCmTi 1XRn7ZjD5tWZnRtsK9+waqTk4/Tbg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeggdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucfkphepje egrdduudeirddukeeirdeggeenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgv thesnhhghihrohdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 2479680062; Tue, 17 Sep 2019 00:14:43 -0400 (EDT) From: Timothy Sample To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#37384: Daemon does not honor =?utf-8?Q?=E2=80=9CuseSubsti?= =?utf-8?Q?tutes=E2=80=9D?= on armhf References: <87woeevf8k.fsf@ngyro.com> <87sgp2vaqh.fsf@ngyro.com> <87ftl25am0.fsf@ngyro.com> <877e686xwk.fsf@gnu.org> Date: Tue, 17 Sep 2019 00:14:42 -0400 In-Reply-To: <877e686xwk.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 16 Sep 2019 17:52:59 +0200") Message-ID: <877e675zkd.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37384-done Cc: 37384-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Ludovic Court=C3=A8s writes: > LGTM. Great! I just pushed it. Thanks for the review. -- Tim From unknown Sun Jun 15 08:15:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Oct 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator