Subject: Re: Getting network-manager-openconnect to work

From: "pelzflorian (Florian Pelz)" <[email-masked]>
Date: Mon, 16 Sep 2019 18:06:35 +0200

On Mon, Sep 16, 2019 at 05:57:51PM +0200, Ludovic Courtès wrote:
> So I guess we first need someone to tell us whether the patch “works”,
> as you wrote, right?  :-)
> 
> Ludo’.

Currently I have built the attached patch, but NetworkManager
segfaults when connecting, and I try to debug why.

Regards,
Florian
>From 1efadd4619f397429d5fae024b46cd8100870c42 Mon Sep 17 00:00:00 2001
From: Florian Pelz <[email-masked]>
Date: Mon, 16 Sep 2019 15:27:01 +0200
Subject: [PATCH] gnu: network-manager: Enable openconnect helper.

* gnu/packages/gnome.scm (network-manager): Add openconnect input.
Patch source to use it instead of searching /usr/bin.
---
 gnu/packages/gnome.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 5dc18b3bb5..a8ba00965d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5374,6 +5374,13 @@ users.")
                (("src/devices/tests/test-lldp") " ")
                (("src/tests/test-route-manager-linux") " "))
              #t))
+         (add-after 'unpack 'patch-source
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((openconnect (assoc-ref inputs "openconnect")))
+               (substitute* "clients/common/nm-vpn-helpers.c"
+                 (("\\\"/usr/sbin/openconnect\\\"")
+                  (string-append "\"" openconnect "/sbin/openconnect\"")))
+               #t)))
          (add-after 'unpack 'delete-failing-tests
            (lambda _
              ;; FIXME: These four tests fail for unknown reasons.
@@ -5436,6 +5443,7 @@ users.")
        ("libsoup" ,libsoup)
        ("modem-manager" ,modem-manager)
        ("newt" ,newt)                       ;for the 'nmtui' console interface
+       ("openconnect" ,openconnect)
        ("polkit" ,polkit)
        ("ppp" ,ppp)
        ("readline" ,readline)
-- 
2.23.0