GNU bug report logs - #37344
rcirc: nil gets interpreted as a nickname

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Liu <sdl.web <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#37344: closed (rcirc: nil gets interpreted as a nickname)
Date: Mon, 07 Oct 2019 11:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 07 Oct 2019 19:01:29 +0800
with message-id <m17e5g4y5y.fsf <at> gmail.com>
and subject line Re: bug#37344: rcirc: nil gets interpreted as a nickname
has caused the debbugs.gnu.org bug report #37344,
regarding rcirc: nil gets interpreted as a nickname
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
37344: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=37344
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Naïm Favier <n.emacs <at> monade.li>
To: bug-gnu-emacs <at> gnu.org
Subject: rcirc: nil gets interpreted as a nickname
Date: Sun, 8 Sep 2019 20:58:59 +0200

Severity: normal

Ever since I changed my nickname to "nil" on Freenode, I've been
getting occasional private messages from unknown users consisting of a
single empty CTCP ACTION. After a bit of investigating, it turned out
they all used rcirc. The situation was clear at that point: somewhere
in rcirc's source code, a nil value is being implicitly converted to a
string and used as the target of a PRIVMSG command.

The bug seems to be reproducible by issuing "/me" (without arguments)
inside a server buffer: the "nil" user on that server gets sent an
empty ACTION.

Suggested fix: in rcirc-send-privmsg, fail if target is nil. It might
be useful to check other places where the "%s" format is used, to
discover similar bugs.

[Message part 3 (message/rfc822, inline)]

From: Leo Liu <sdl.web <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Naïm Favier <n.emacs <at> monade.li>,
 37344-done <at> debbugs.gnu.org
Subject: Re: bug#37344: rcirc: nil gets interpreted as a nickname
Date: Mon, 07 Oct 2019 19:01:29 +0800

Version: 26.4

On 2019-10-07 06:55 +0200, Lars Ingebrigtsen wrote:
> I have no objections; please go ahead.

I have committed the change to emacs-26. Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.