GNU bug report logs - #37344
rcirc: nil gets interpreted as a nickname

Previous Next

Package: emacs;

Reported by: Naïm Favier <n.emacs <at> monade.li>

Date: Sun, 8 Sep 2019 19:06:01 UTC

Severity: normal

Tags: patch

Fixed in version 26.4

Done: Leo Liu <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #16 received at 37344 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: Naïm Favier <n.emacs <at> monade.li>, 37344 <at> debbugs.gnu.org
Subject: Re: bug#37344: rcirc: nil gets interpreted as a nickname
Date: Fri, 20 Sep 2019 20:33:18 +0200

Leo Liu <sdl.web <at> gmail.com> writes:

> Thanks. Does the following patch fix the issue?

It was confirmed that it does, so I guess you should just apply the
patch, but:


[...]

> -(defun rcirc-cmd-me (args &optional process target)
> -  (rcirc-send-ctcp process target "ACTION" args))
> +(defun rcirc-cmd-me (args process target)
> +  (when target (rcirc-send-ctcp process target "ACTION" args)))

Perhaps you should keep the &optional there to avoid changing the call
signature?  Somebody else may have code that calls the function with
that calling convention.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 5 years and 223 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.