Subject: Re: bug#37344: rcirc: nil gets interpreted as a nickname

From: Lars Ingebrigtsen <[email-masked]>
Date: Fri, 20 Sep 2019 20:33:18 +0200

Leo Liu <[email-masked]> writes:

> Thanks. Does the following patch fix the issue?

It was confirmed that it does, so I guess you should just apply the
patch, but:

[...]

> -(defun rcirc-cmd-me (args &optional process target)
> -  (rcirc-send-ctcp process target "ACTION" args))
> +(defun rcirc-cmd-me (args process target)
> +  (when target (rcirc-send-ctcp process target "ACTION" args)))

Perhaps you should keep the &optional there to avoid changing the call
signature?  Somebody else may have code that calls the function with
that calling convention.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no