From unknown Fri Jun 13 10:41:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37344: rcirc: nil gets interpreted as a nickname Resent-From: =?UTF-8?Q?Na=C3=AFm?= Favier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2019 19:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 37344@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.156796955328747 (code B ref -1); Sun, 08 Sep 2019 19:06:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Sep 2019 19:05:53 +0000 Received: from localhost ([127.0.0.1]:39130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i72VV-0007Ta-Cs for submit@debbugs.gnu.org; Sun, 08 Sep 2019 15:05:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:51485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i72P4-0007F1-1q for submit@debbugs.gnu.org; Sun, 08 Sep 2019 14:59:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51125) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i72P3-0000wS-0o for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,FROM_EXCESS_BASE64, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i72P2-0007Jd-34 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:12 -0400 Received: from mail-io1-f46.google.com ([209.85.166.46]:43699) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i72P1-0007JO-Uz for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:12 -0400 Received: by mail-io1-f46.google.com with SMTP id u185so23808680iod.10 for ; Sun, 08 Sep 2019 11:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=F05w9t7g+4MBe2mRdjrqrA6qwaarQEyt+yYRzUCZR68=; b=giXN1m7xJhzSdh/EQ0YmR76toNqBLjB7VljXOTvEa0akOq6CSSSqR+vgHCCNOuyeQw 8fktHDfqFnyiVFolT/cciNp8Cal7PF24EOJX6+iwE+8sXjwJMmIFW1JmmhF5EMXYEqxY UqAr570saNOpzZbLYV7Vv3OsnwyiqszxKwQdzHHN42WhulC80MYRO96axXJUdKoZ5xhc zHXLjpv8Pz1QwhJ8bvglR9RrmHZQ/uVDHDAtwoGRhwxj80QAwPntXyItvIA7N0vQT+vQ BV/12CHW4o5nYOdGHiaZiWzeuPh3dfkObLzH9l1xWiHxmMLBysuWfT5qjULxw1CB1t4N BOrg== X-Gm-Message-State: APjAAAWXAMn1oYF93hXuWh2Tn18ggVZ6xNZ5sTFGegHa3AiW//tNUMVR sl9YYk3uZ1cfJMmFmu0bRV2zZpNeCEI= X-Google-Smtp-Source: APXvYqw9RoHJBGaPzhsI0XCrGsxhkbPXMqBWb2zeVrCWquIkKwkCZc/FpFnNiGBsHVqkLRBX3JPAvw== X-Received: by 2002:a6b:8d06:: with SMTP id p6mr9883508iod.219.1567969150846; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com. [209.85.166.49]) by smtp.gmail.com with ESMTPSA id l186sm30052679ioa.54.2019.09.08.11.59.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Sep 2019 11:59:10 -0700 (PDT) Received: by mail-io1-f49.google.com with SMTP id d17so1989232ios.13 for ; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) X-Received: by 2002:a6b:e90d:: with SMTP id u13mr21019282iof.64.1567969150206; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Na=C3=AFm?= Favier Date: Sun, 8 Sep 2019 20:58:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.166.46 X-Spam-Score: 0.7 (/) X-Mailman-Approved-At: Sun, 08 Sep 2019 15:05:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Severity: normal Ever since I changed my nickname to "nil" on Freenode, I've been getting occasional private messages from unknown users consisting of a single empty CTCP ACTION. After a bit of investigating, it turned out they all used rcirc. The situation was clear at that point: somewhere in rcirc's source code, a nil value is being implicitly converted to a string and used as the target of a PRIVMSG command. The bug seems to be reproducible by issuing "/me" (without arguments) inside a server buffer: the "nil" user on that server gets sent an empty ACTION. Suggested fix: in rcirc-send-privmsg, fail if target is nil. It might be useful to check other places where the "%s" format is used, to discover similar bugs. From unknown Fri Jun 13 10:41:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37344: rcirc: nil gets interpreted as a nickname Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Sep 2019 01:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Na=C3=AFm?= Favier Cc: 37344@debbugs.gnu.org Received: via spool by 37344-submit@debbugs.gnu.org id=B37344.156799228023189 (code B ref 37344); Mon, 09 Sep 2019 01:25:02 +0000 Received: (at 37344) by debbugs.gnu.org; 9 Sep 2019 01:24:40 +0000 Received: from localhost ([127.0.0.1]:39361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i78Q4-00061v-6j for submit@debbugs.gnu.org; Sun, 08 Sep 2019 21:24:40 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i78Q1-00061d-LN for 37344@debbugs.gnu.org; Sun, 08 Sep 2019 21:24:38 -0400 Received: by mail-pg1-f196.google.com with SMTP id x15so6814811pgg.8 for <37344@debbugs.gnu.org>; Sun, 08 Sep 2019 18:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=PieM5zr0OTnkbzEhL8Uj0m5uy767ub5D2Hf4npRQf8c=; b=RlIJBgQfBbmFODOY63iob7Pau2ja2yANR3PvJOlqaBIsPwj4D/hEJNRZ+93Y8b3MuP OXKuuW9tynC8F7HbvYEbz0zTzfCmh0XEEnaJ0umCRLEgMLFPC4PCbJ1jkNQH2Kt+EG+R 78A2cdgXOANDJ+bSjorISVXCZn2OZtbyikTkcN6e+iYDdRNnMmagnLxw2C9jBKk14e7t WR06P90Ik5Iuxx8GxV2H6wOWQyVWn+7O4vZl1C+9U79AsNE/b1pMGF5Z2Ly6j6iWzFAY 2oCY3Z117/yEcOzCBNTHJMkSULFf185t9qi8tknHOukbljPMfkPeT/vSI2ZzPAuROyrZ B/tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=PieM5zr0OTnkbzEhL8Uj0m5uy767ub5D2Hf4npRQf8c=; b=sR/8gp42OV++IXX228pY3SHv/uvSZhMoWECJc22CcWJ3B3kevkmbjgklypk9ebEFpW 8F+3trBM+QvEd41PHeHkeJjhHTr1U3f5cl41l/OmD+f8m5UTADi/+nQffWPaw/dt3zgx 6IFIzRo5nHTL6KOVhu+GvJKfI1HvgSSNv7YyXmCkxM92MfWHCp9UyjfxEtzl7k/pT+0j lIcikR0DNxYTnsdC7+UrSSLgKJ8DElyEebNHZIdN61LsJiktbYcfrpWWMY+jPvA1Qpy9 CsbQsNTh/kAUE1Plh/uEn1W03jP5XIj8EQfdtCcbOhUnW57hYapF1XTBFO8i2hiWtysL RycA== X-Gm-Message-State: APjAAAXq+e0YkSn2vhDjy00a2EhwgQzqCF1upZrLMFloISKkBBuK9UUL qaxobGKHdQ7vOE1CmYFQXCd9dTNq X-Google-Smtp-Source: APXvYqzbsbbBt6u/pf3xGM+n2MYWp7jlZhVIMSLUzW2DSSonfBfKj+U9PLBCX5irYUxQgB1Vu1gYLA== X-Received: by 2002:a17:90a:2e08:: with SMTP id q8mr23195566pjd.43.1567992271389; Sun, 08 Sep 2019 18:24:31 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.225.37]) by smtp.gmail.com with ESMTPSA id v8sm10037055pgs.82.2019.09.08.18.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2019 18:24:30 -0700 (PDT) From: Leo Liu References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Mon, 09 Sep 2019 09:24:26 +0800 In-Reply-To: ("=?UTF-8?Q?Na=C3=AFm?= Favier"'s message of "Sun, 8 Sep 2019 20:58:59 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (macOS 10.14.6) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2019-09-08 20:58 +0200, Na=EFm Favier wrote: > Severity: normal > > Ever since I changed my nickname to "nil" on Freenode, I've been > getting occasional private messages from unknown users consisting of a > single empty CTCP ACTION. After a bit of investigating, it turned out > they all used rcirc. The situation was clear at that point: somewhere > in rcirc's source code, a nil value is being implicitly converted to a > string and used as the target of a PRIVMSG command. > > The bug seems to be reproducible by issuing "/me" (without arguments) > inside a server buffer: the "nil" user on that server gets sent an > empty ACTION. > > Suggested fix: in rcirc-send-privmsg, fail if target is nil. It might > be useful to check other places where the "%s" format is used, to > discover similar bugs. Thanks. Does the following patch fix the issue? diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index de524d9e..d95db26c 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -825,6 +825,7 @@ Function is called with PROCESS, COMMAND, SENDER, ARGS = and LINE.") (process-send-string process string))) =20 (defun rcirc-send-privmsg (process target string) + (cl-check-type target string) (rcirc-send-string process (format "PRIVMSG %s :%s" target string))) =20 (defun rcirc-send-ctcp (process target request &optional args) @@ -2337,8 +2338,8 @@ With a prefix arg, prompt for new topic." (let ((timestamp (format-time-string "%s"))) (rcirc-send-ctcp process target "PING" timestamp))) =20 -(defun rcirc-cmd-me (args &optional process target) - (rcirc-send-ctcp process target "ACTION" args)) +(defun rcirc-cmd-me (args process target) + (when target (rcirc-send-ctcp process target "ACTION" args))) =20 (defun rcirc-add-or-remove (set &rest elements) (dolist (elt elements) From unknown Fri Jun 13 10:41:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37344: rcirc: nil gets interpreted as a nickname Resent-From: =?UTF-8?Q?Na=C3=AFm?= Favier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Sep 2019 14:38:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Liu Cc: 37344@debbugs.gnu.org Received: via spool by 37344-submit@debbugs.gnu.org id=B37344.156803985030737 (code B ref 37344); Mon, 09 Sep 2019 14:38:03 +0000 Received: (at 37344) by debbugs.gnu.org; 9 Sep 2019 14:37:30 +0000 Received: from localhost ([127.0.0.1]:40401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i7KnJ-0007zh-Qi for submit@debbugs.gnu.org; Mon, 09 Sep 2019 10:37:30 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:38460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i7GQ4-00071Q-QC for 37344@debbugs.gnu.org; Mon, 09 Sep 2019 05:57:13 -0400 Received: by mail-io1-f65.google.com with SMTP id k5so1926719iol.5 for <37344@debbugs.gnu.org>; Mon, 09 Sep 2019 02:57:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wuOcRSbvMUm20OwizjX0v02QFDAC0LDKpeqc6YBCOyU=; b=TtF9B/tD0k65JkLNIDBUrlkF88kbCP78dlgeiWJqpEgf0Ur4Icnyrbra7KFJU5A5TO +K0qlKkx5f26yEoINLgvqr27A/UlboeNxaeUcIR1izAVWdvHxfGCKnfgpqqfxaQdREwd 9LwvRSITxw2vHKDEEf5shEyb44aFBSNnLKPAXG/31eYVmZVZ0qW9D0eeoDqxWqP1VfmO Cerax9zJPaA+Nd3gl/RMagNe7CA0j0Ssyk8emr444NHVOJikL/xJA0Ebdz9fRA5Rid9s mjSqOSM4sTyIaSCVMUbCLMuLj1tcmwqdvW3Wk0nNywFI0HclohE0RkZtswqhwAvzO9Oc O29Q== X-Gm-Message-State: APjAAAXu0pzlEcr9RBE1S4dm4MKQftbBBbFSRQb1c5V2zei1BRDHDfpM 0XJgRQ5J491osDGmO0v8infMDKWvRCw= X-Google-Smtp-Source: APXvYqwVkyPo89JF5FrU08P+WBCpyern2nGvDREJTl707wPK6FRGZxohnHZ03pBkodnZ9N5zr/BCxg== X-Received: by 2002:a6b:5b07:: with SMTP id v7mr3755980ioh.76.1568023026894; Mon, 09 Sep 2019 02:57:06 -0700 (PDT) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com. [209.85.166.43]) by smtp.gmail.com with ESMTPSA id i14sm11596018ioi.47.2019.09.09.02.57.06 for <37344@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2019 02:57:06 -0700 (PDT) Received: by mail-io1-f43.google.com with SMTP id r8so2303522iol.10 for <37344@debbugs.gnu.org>; Mon, 09 Sep 2019 02:57:06 -0700 (PDT) X-Received: by 2002:a5e:aa1a:: with SMTP id s26mr4456014ioe.96.1568023026361; Mon, 09 Sep 2019 02:57:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Na=C3=AFm?= Favier Date: Mon, 9 Sep 2019 11:56:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Mailman-Approved-At: Mon, 09 Sep 2019 10:37:29 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Yes, it does. On Mon, 9 Sep 2019 at 03:24, Leo Liu wrote: > > On 2019-09-08 20:58 +0200, Na=C3=AFm Favier wrote: > > Severity: normal > > > > Ever since I changed my nickname to "nil" on Freenode, I've been > > getting occasional private messages from unknown users consisting of a > > single empty CTCP ACTION. After a bit of investigating, it turned out > > they all used rcirc. The situation was clear at that point: somewhere > > in rcirc's source code, a nil value is being implicitly converted to a > > string and used as the target of a PRIVMSG command. > > > > The bug seems to be reproducible by issuing "/me" (without arguments) > > inside a server buffer: the "nil" user on that server gets sent an > > empty ACTION. > > > > Suggested fix: in rcirc-send-privmsg, fail if target is nil. It might > > be useful to check other places where the "%s" format is used, to > > discover similar bugs. > > Thanks. Does the following patch fix the issue? > > diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el > index de524d9e..d95db26c 100644 > --- a/lisp/net/rcirc.el > +++ b/lisp/net/rcirc.el > @@ -825,6 +825,7 @@ Function is called with PROCESS, COMMAND, SENDER, ARG= S and LINE.") > (process-send-string process string))) > > (defun rcirc-send-privmsg (process target string) > + (cl-check-type target string) > (rcirc-send-string process (format "PRIVMSG %s :%s" target string))) > > (defun rcirc-send-ctcp (process target request &optional args) > @@ -2337,8 +2338,8 @@ With a prefix arg, prompt for new topic." > (let ((timestamp (format-time-string "%s"))) > (rcirc-send-ctcp process target "PING" timestamp))) > > -(defun rcirc-cmd-me (args &optional process target) > - (rcirc-send-ctcp process target "ACTION" args)) > +(defun rcirc-cmd-me (args process target) > + (when target (rcirc-send-ctcp process target "ACTION" args))) > > (defun rcirc-add-or-remove (set &rest elements) > (dolist (elt elements) From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 13:55:59 2019 Received: (at control) by debbugs.gnu.org; 11 Sep 2019 17:55:59 +0000 Received: from localhost ([127.0.0.1]:42721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i86qV-00046s-7c for submit@debbugs.gnu.org; Wed, 11 Sep 2019 13:55:59 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:38875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i864R-0002rx-1K for control@debbugs.gnu.org; Wed, 11 Sep 2019 13:06:19 -0400 Received: by mail-io1-f53.google.com with SMTP id k5so22249805iol.5 for ; Wed, 11 Sep 2019 10:06:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ed2LQC8FywgRPvDvMDhQW9EKYaBO2+h5myBGQPOeCms=; b=cvUMghEk1eSjuadIGaWQP7rUPWCM0U+F4DbKXCyoBsriyzPhkgMWl3TqHO2PEdDPGO CCzwLtiUnVn+3Sr2WOLb2FsvixMmc+A9NHdcTSuIQ09Q+KRu9m/ezAsClKV+ASo5Wdlg zi6W9VBq3Ca4gm5y9mSGydnkJCWdrK3utKGAaTKfDhxLRTMgxK3RsAmyZB03gtVxOvfP S4rTLUH7gnJtU4Puk6qHwAaVWD02xqooHlAbjYe1nJO6uhj23S+cAcpOoZtej2Zl4Q8+ 56CUNtEs954pNA+3fbQm7e6AviLoj8O7tJuYCoNY+cWsq1gTHUCBSL6Gj5wNizPibsEK aRNw== X-Gm-Message-State: APjAAAUrMx1hCCS1f1McjwD+CES1Jy5VXeFcx9+5kwmDpvHhcMDrStID r8nlPod6yE+eYHXQCIy7ue33caZvovU= X-Google-Smtp-Source: APXvYqzt9hkOzCkJ7CxME+dUckQ8Nxbspxi6jxNr8MGuM8gybHi+nd6YNz1ll61uZMKIES+3+kpbhQ== X-Received: by 2002:a6b:1682:: with SMTP id 124mr17190295iow.99.1568221568385; Wed, 11 Sep 2019 10:06:08 -0700 (PDT) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com. [209.85.166.53]) by smtp.gmail.com with ESMTPSA id 80sm43528643iou.13.2019.09.11.10.06.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2019 10:06:08 -0700 (PDT) Received: by mail-io1-f53.google.com with SMTP id k13so32330812ioj.1 for ; Wed, 11 Sep 2019 10:06:08 -0700 (PDT) X-Received: by 2002:a6b:3b4a:: with SMTP id i71mr16481036ioa.258.1568221567643; Wed, 11 Sep 2019 10:06:07 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?B?TmHDr20gRmF2aWVy?= Date: Wed, 11 Sep 2019 19:05:56 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: 37344 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-Mailman-Approved-At: Wed, 11 Sep 2019 13:55:57 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 37344 + patch From unknown Fri Jun 13 10:41:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37344: rcirc: nil gets interpreted as a nickname Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2019 18:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Leo Liu Cc: =?UTF-8?Q?Na=C3=AFm?= Favier , 37344@debbugs.gnu.org Received: via spool by 37344-submit@debbugs.gnu.org id=B37344.156900440317218 (code B ref 37344); Fri, 20 Sep 2019 18:34:01 +0000 Received: (at 37344) by debbugs.gnu.org; 20 Sep 2019 18:33:23 +0000 Received: from localhost ([127.0.0.1]:58485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBNid-0004Te-4y for submit@debbugs.gnu.org; Fri, 20 Sep 2019 14:33:23 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBNic-0004TX-Bl for 37344@debbugs.gnu.org; Fri, 20 Sep 2019 14:33:22 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBNiY-0004aG-UI; Fri, 20 Sep 2019 20:33:21 +0200 From: Lars Ingebrigtsen References: Date: Fri, 20 Sep 2019 20:33:18 +0200 In-Reply-To: (Leo Liu's message of "Mon, 09 Sep 2019 09:24:26 +0800") Message-ID: <87impm95sh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Leo Liu writes: > Thanks. Does the following patch fix the issue? It was confirmed that it does, so I guess you should just apply the patch, but: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Leo Liu writes: > Thanks. Does the following patch fix the issue? It was confirmed that it does, so I guess you should just apply the patch, but: [...] > -(defun rcirc-cmd-me (args &optional process target) > - (rcirc-send-ctcp process target "ACTION" args)) > +(defun rcirc-cmd-me (args process target) > + (when target (rcirc-send-ctcp process target "ACTION" args))) Perhaps you should keep the &optional there to avoid changing the call signature? Somebody else may have code that calls the function with that calling convention. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Jun 13 10:41:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37344: rcirc: nil gets interpreted as a nickname Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2019 05:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: =?UTF-8?Q?Na=C3=AFm?= Favier , 37344@debbugs.gnu.org Received: via spool by 37344-submit@debbugs.gnu.org id=B37344.15690432794314 (code B ref 37344); Sat, 21 Sep 2019 05:22:01 +0000 Received: (at 37344) by debbugs.gnu.org; 21 Sep 2019 05:21:19 +0000 Received: from localhost ([127.0.0.1]:58948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBXpf-00017V-4M for submit@debbugs.gnu.org; Sat, 21 Sep 2019 01:21:19 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBXpa-00017E-VX for 37344@debbugs.gnu.org; Sat, 21 Sep 2019 01:21:17 -0400 Received: by mail-pf1-f196.google.com with SMTP id a2so5917180pfo.10 for <37344@debbugs.gnu.org>; Fri, 20 Sep 2019 22:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=GgpVexSn05mCb8rid7O9WPRjrSkNHPNHrYA4yowsIvM=; b=Kp4LeUQjlaNbSLHqM+RAaPGlJtrxYwEkeVDgTCk3ks4GSMhIlwmP7gGM8VlPXdswOi eL5glFyX202dtm1T9EBQpYFeTznG1PiJMSyWlQUqK8rsJQT4M8dsGhCfmvof4olJ7OC9 M5u/93W7HXdYsGBnBl9k5lkY56MOWWjH/w6EpVgVULGA9dV70/31yKyWy1TZcNnWOVeI yYz1B7JR0S07vnrUGzWxrmRpGUYH8/armKAINFpq1o5nEzp8bUomqnd8Bh6fZyfCj43K NAr5uL8YcmmoCx0eviwZGq7pFfv6aZzGZeJF9nDx7VbQAqlzuHlSRqJTjaId1yKx62Zp F/ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=GgpVexSn05mCb8rid7O9WPRjrSkNHPNHrYA4yowsIvM=; b=fY723TYuAvrqVjPFElVCvxDZjitSA7XBu+zS4IoIwFgfaqt7WrHAVYzWWmy+Jdw6GG yj+8aRdru6npuYTb8tvi+PNWLvfrH+ftaGIAsBfapuet81V8RXR0NiMrmLaDhU0f2mz/ Hg8VPuVCj7vJxAL3/Boa/JjTQXFKrSvBSeIRRWxiHgq1cdaLiNcCG5FxPCX3oScwBd1Y 4F+tuORwiV/Dg/9nKddKuT+qJkkCMsbj7PrscHsulhhK3feDC/MXzC7nGfY5A3MQyn4O KozD16P9P8HG+HG5zR5INm4pJNvlWGw3Wuqmrx7EzMsuQi52XytNDvxZBDWUyeg3yQwL JN6Q== X-Gm-Message-State: APjAAAXnozfLObSB6bnmKHeIiKOVPlMll4uTru6TXseaAYZWipqPkard GR83nZ/7NZ6uRJL+iVh0wjKIeUFyVdo= X-Google-Smtp-Source: APXvYqwnihT27eeoV5JrkE9ydXGK4jYqbBHT0k7vxiCSN2YxxHxaYKiUgf0dczDWZzPtNMA0AOHPtQ== X-Received: by 2002:a65:6890:: with SMTP id e16mr2678533pgt.264.1569043268653; Fri, 20 Sep 2019 22:21:08 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.225.37]) by smtp.gmail.com with ESMTPSA id j126sm5931842pfb.186.2019.09.20.22.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 22:21:07 -0700 (PDT) From: Leo Liu References: <87impm95sh.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Sat, 21 Sep 2019 13:21:04 +0800 In-Reply-To: <87impm95sh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 20 Sep 2019 20:33:18 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (macOS 10.14.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2019-09-20 20:33 +0200, Lars Ingebrigtsen wrote: >> Thanks. Does the following patch fix the issue? > > It was confirmed that it does, so I guess you should just apply the > patch, but: Will do. >> -(defun rcirc-cmd-me (args &optional process target) >> - (rcirc-send-ctcp process target "ACTION" args)) >> +(defun rcirc-cmd-me (args process target) >> + (when target (rcirc-send-ctcp process target "ACTION" args))) > > Perhaps you should keep the &optional there to avoid changing the call > signature? Somebody else may have code that calls the function with > that calling convention. The signature is wrong from the start. Directly call them without providing these optional (mandatory-in-disguise) arguments throws an error, unlike commands defined by defun-rcirc-command which correctly handle &optional arguments. I'll commit the patch as is if no objections. Thanks for raising the issue. Leo From unknown Fri Jun 13 10:41:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#37344: rcirc: nil gets interpreted as a nickname Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Oct 2019 04:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Leo Liu Cc: =?UTF-8?Q?Na=C3=AFm?= Favier , 37344@debbugs.gnu.org Received: via spool by 37344-submit@debbugs.gnu.org id=B37344.157042412311675 (code B ref 37344); Mon, 07 Oct 2019 04:56:02 +0000 Received: (at 37344) by debbugs.gnu.org; 7 Oct 2019 04:55:23 +0000 Received: from localhost ([127.0.0.1]:47213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHL3L-00032E-1q for submit@debbugs.gnu.org; Mon, 07 Oct 2019 00:55:23 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHL3I-000323-TG for 37344@debbugs.gnu.org; Mon, 07 Oct 2019 00:55:21 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHL3F-0005x4-Jm; Mon, 07 Oct 2019 06:55:20 +0200 From: Lars Ingebrigtsen References: <87impm95sh.fsf@gnus.org> Date: Mon, 07 Oct 2019 06:55:17 +0200 In-Reply-To: (Leo Liu's message of "Sat, 21 Sep 2019 13:21:04 +0800") Message-ID: <87tv8l8896.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Leo Liu writes: > The signature is wrong from the start. Directly call them without > providing these optional (mandatory-in-disguise) arguments throws an > error, unlike commands defined by defun-rcirc-command which [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Leo Liu writes: > The signature is wrong from the start. Directly call them without > providing these optional (mandatory-in-disguise) arguments throws an > error, unlike commands defined by defun-rcirc-command which correctly > handle &optional arguments. I'll commit the patch as is if no > objections. Thanks for raising the issue. I have no objections; please go ahead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Jun 13 10:41:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Na=C3=AFm?= Favier Subject: bug#37344: closed (Re: bug#37344: rcirc: nil gets interpreted as a nickname) Message-ID: References: X-Gnu-PR-Message: they-closed 37344 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 37344@debbugs.gnu.org Date: Mon, 07 Oct 2019 11:02:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1570446123-13015-1" This is a multi-part message in MIME format... ------------=_1570446123-13015-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #37344: rcirc: nil gets interpreted as a nickname which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 37344@debbugs.gnu.org. --=20 37344: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37344 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1570446123-13015-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 37344-done) by debbugs.gnu.org; 7 Oct 2019 11:01:42 +0000 Received: from localhost ([127.0.0.1]:47403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHQlq-0003NJ-H3 for submit@debbugs.gnu.org; Mon, 07 Oct 2019 07:01:42 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:37885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHQlo-0003N5-3H for 37344-done@debbugs.gnu.org; Mon, 07 Oct 2019 07:01:40 -0400 Received: by mail-pl1-f179.google.com with SMTP id u20so6683964plq.4 for <37344-done@debbugs.gnu.org>; Mon, 07 Oct 2019 04:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=EV4CSOxt66czp2v14NIDlRgGXarJqvJVgYHYd++bsh4=; b=a+t0tNS5dyOlWp0Yf42bmFojs/iaDEQN0DlWa6/ELJHtVGtdshNsGrbDnq+E4GyMys LZQBX3U8OAIE2AgAlEVojH0ep2nNT4NwXZLtXqsFMDhsh2mYEEv8lO5ZhrW2UWg/ykzx Vxv31EUf7WbaG8xbk+7I4NhUs6NnjrWeG5YTm+N9Z2CDsUTveEyjvtdnWkoUyLq42SeK JbG+JObE+hvFYVQgGJrGmh32FCyD60mh3Ox9xd4g1tklv+8BHsDh5Y7rgqk70K5eeHba 0WlyQBVvyNP+wY1NQqVF4nUnlrSiRGLKxThfLfHQmKkUiX40Ezzeey6ekbIVCehTRy+R bkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=EV4CSOxt66czp2v14NIDlRgGXarJqvJVgYHYd++bsh4=; b=IGXj1vERJmYWSMyOm7BRCWURhr9QVFGgVjKmzpVL3Za5xhJeeG6up1L++eCQoxgveV dETNOT//nNbaZiblWPvRtMohpQKlkJpTHVQQpcBwLjlw680UC72KhXKmaOQxYXVoWakW soqv8SOiA9WIgEBjjHwi8QCVaLXkByYRV5lvCN8TMJ+J7wO9GCSOA4SPMSTbyc1/FUbz 8ziROmeN2vU8+F8MJot48VsBtNwEv+qvqKQaIzN9EHsUN7M1CWQAfUCH/h+bWEl/D3vf 2uTQ3Yp26tfBkr9ejw1LLd4jmzjjcBmgVO6VFlmjtKeo5+v4G8VXB2Ae08hQxB6/wAyX rbng== X-Gm-Message-State: APjAAAULLCtEZXbGZW+VoukiSbzUFwo4hKPYa+P+q7o7OCXJ34vo1Q22 G3QLc/5QjYckdTtY1eOaSMALzIvo X-Google-Smtp-Source: APXvYqyTB/hx0XLb5xkpGL0Cb4aWcLqS72Le3eWHDmPUN5awN3fDaYGD1auetcY8rU5nmLeu4xp1Lw== X-Received: by 2002:a17:902:6bcc:: with SMTP id m12mr332856plt.280.1570446093871; Mon, 07 Oct 2019 04:01:33 -0700 (PDT) Received: from Zeuss-MacBook-Air.local ([112.208.225.37]) by smtp.gmail.com with ESMTPSA id e14sm13885132pjt.8.2019.10.07.04.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 04:01:32 -0700 (PDT) From: Leo Liu To: Lars Ingebrigtsen Subject: Re: bug#37344: rcirc: nil gets interpreted as a nickname References: <87impm95sh.fsf@gnus.org> <87tv8l8896.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Mon, 07 Oct 2019 19:01:29 +0800 In-Reply-To: <87tv8l8896.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 07 Oct 2019 06:55:17 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (macOS 10.14.6) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 37344-done Cc: =?iso-8859-1?Q?Na=EFm?= Favier , 37344-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 26.4 On 2019-10-07 06:55 +0200, Lars Ingebrigtsen wrote: > I have no objections; please go ahead. I have committed the change to emacs-26. Thanks. ------------=_1570446123-13015-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Sep 2019 19:05:53 +0000 Received: from localhost ([127.0.0.1]:39130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i72VV-0007Ta-Cs for submit@debbugs.gnu.org; Sun, 08 Sep 2019 15:05:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:51485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i72P4-0007F1-1q for submit@debbugs.gnu.org; Sun, 08 Sep 2019 14:59:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51125) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i72P3-0000wS-0o for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,FROM_EXCESS_BASE64, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i72P2-0007Jd-34 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:12 -0400 Received: from mail-io1-f46.google.com ([209.85.166.46]:43699) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i72P1-0007JO-Uz for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2019 14:59:12 -0400 Received: by mail-io1-f46.google.com with SMTP id u185so23808680iod.10 for ; Sun, 08 Sep 2019 11:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=F05w9t7g+4MBe2mRdjrqrA6qwaarQEyt+yYRzUCZR68=; b=giXN1m7xJhzSdh/EQ0YmR76toNqBLjB7VljXOTvEa0akOq6CSSSqR+vgHCCNOuyeQw 8fktHDfqFnyiVFolT/cciNp8Cal7PF24EOJX6+iwE+8sXjwJMmIFW1JmmhF5EMXYEqxY UqAr570saNOpzZbLYV7Vv3OsnwyiqszxKwQdzHHN42WhulC80MYRO96axXJUdKoZ5xhc zHXLjpv8Pz1QwhJ8bvglR9RrmHZQ/uVDHDAtwoGRhwxj80QAwPntXyItvIA7N0vQT+vQ BV/12CHW4o5nYOdGHiaZiWzeuPh3dfkObLzH9l1xWiHxmMLBysuWfT5qjULxw1CB1t4N BOrg== X-Gm-Message-State: APjAAAWXAMn1oYF93hXuWh2Tn18ggVZ6xNZ5sTFGegHa3AiW//tNUMVR sl9YYk3uZ1cfJMmFmu0bRV2zZpNeCEI= X-Google-Smtp-Source: APXvYqw9RoHJBGaPzhsI0XCrGsxhkbPXMqBWb2zeVrCWquIkKwkCZc/FpFnNiGBsHVqkLRBX3JPAvw== X-Received: by 2002:a6b:8d06:: with SMTP id p6mr9883508iod.219.1567969150846; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com. [209.85.166.49]) by smtp.gmail.com with ESMTPSA id l186sm30052679ioa.54.2019.09.08.11.59.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Sep 2019 11:59:10 -0700 (PDT) Received: by mail-io1-f49.google.com with SMTP id d17so1989232ios.13 for ; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) X-Received: by 2002:a6b:e90d:: with SMTP id u13mr21019282iof.64.1567969150206; Sun, 08 Sep 2019 11:59:10 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?B?TmHDr20gRmF2aWVy?= Date: Sun, 8 Sep 2019 20:58:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: rcirc: nil gets interpreted as a nickname To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.166.46 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 08 Sep 2019 15:05:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Severity: normal Ever since I changed my nickname to "nil" on Freenode, I've been getting occasional private messages from unknown users consisting of a single empty CTCP ACTION. After a bit of investigating, it turned out they all used rcirc. The situation was clear at that point: somewhere in rcirc's source code, a nil value is being implicitly converted to a string and used as the target of a PRIVMSG command. The bug seems to be reproducible by issuing "/me" (without arguments) inside a server buffer: the "nil" user on that server gets sent an empty ACTION. Suggested fix: in rcirc-send-privmsg, fail if target is nil. It might be useful to check other places where the "%s" format is used, to discover similar bugs. ------------=_1570446123-13015-1--