GNU bug report logs - #37337
2019-08-31; Error when `TeX-fold-hide-item' acts on evaporated overlays

Previous Next

Full log

Message #25 received at 37337-done <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Florent Rougon <f.rougon <at> free.fr>
Cc: 37337-done <at> debbugs.gnu.org
Subject: Re: bug#37337: [PATCH] Fix bug in `TeX-fold-hide-item' when acting
 on evaporated overlays
Date: Sat, 26 Oct 2019 13:00:04 +0200

Hi Florent,

Florent Rougon <f.rougon <at> free.fr> writes:

> Arash Esbati <arash <at> gnu.org> wrote:
>
>> Many thanks for tracking this down.  I can confirm the bug you describe,
>> and have a question reg. your patch: If it's only about checking if
>> `overlay-start' and `overlay-end' are non-nil, wouldn't it be easier to
>> do:
>>
>>     (when (and ov-start ov-end) ...)
>>
>> instead of
>>
>>     (unless (equal ov-start ov-end) ...)
>
> I don't program in ELisp every day (far from it)

Same here, so no worries :-)

> but AFAIK, the two tests are logically equivalent in this context,
> since the overlay has the 'evaporate' property. But I guess you
> already realized that, just wanted to be clear. So, unless I am
> mistaken, this is only a matter of style. I'm quite fine with your
> test, it puts the emphasis on necessary conditions for the following
> code to behave well, I have no problem with that. :-)

Thanks for your response.  I've installed a modified patch and used most
parts of your ChangeLog entry[1].  Again, thanks for tracking this
down.  I'm closing this report.

Best, Arash

Footnotes:
[1]  http://git.savannah.gnu.org/cgit/auctex.git/commit/?id=342fa714ae53c6e4ffd248310bb201bb97e2a9c0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.