GNU bug report logs - #37305
[PATCH] Allow booting from a Btrfs subvolume.

Previous Next

Full log

Message #38 received at 37305 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 37305 <at> debbugs.gnu.org
Subject: Re: [bug#37305] Allow booting from a Btrfs subvolume [review part 2]
Date: Thu, 20 Feb 2020 10:55:05 +0100

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

>>> +              (error "The store is on a Btrfs subvolume, but the \
>>> +subvolume name is unknown.
>>> +Hint: Define the \"btrfs-subvolume-path\" file system property or
>>> +use the \"subvol\" Btrfs file system option."))))
>
>> Rather use ‘raise’ with ‘&message’ and ‘&fix-hint’ conditions.
>
> I tried this, but importing (guix utils) to acces &fix-hint caused the init
> RAM disk to fail mysteriously:

Oh, my bad.  We should move ‘&fix-hint’ to (guix diagnostics)
eventually.

In the meantime, I’d say just raise a ‘&message’ and leave the hint as a
comment (it’s not supposed to be a user-facing interface).  Or maybe you
could define a specific error condition type for this?

Thanks,
Ludo’.

PS: I’ll comment on the other bits ASAP!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.